)]}'
{"manifests/profile/pacemaker/ovn_dbs_bundle.pp":[{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"199da8dfd027ee5e4acfd149a81477d0d077cb24","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        bundle          \u003d\u003e \u0027ovn-dbs-bundle\u0027,"},{"line_number":212,"context_line":"      }"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"      # This code tells us if ovn_dbs is using a separate ip or is using a the per-network VIP"},{"line_number":215,"context_line":"      $ovn_dbs_network \u003d hiera(\u0027ovn_dbs_network\u0027, undef)"},{"line_number":216,"context_line":"      $net_vip_map \u003d hiera(\u0027network_virtual_ips\u0027, undef)"},{"line_number":217,"context_line":"      if $ovn_dbs_network !\u003d undef and $net_vip_map !\u003d undef and $ovn_dbs_network in $net_vip_map {"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"3fa7e38b_171a8d7c","line":214,"updated":"2019-09-19 08:01:07.000000000","message":"nit: typo","commit_id":"6b05849ab9db9efab011bea6d17b374eddf0c0ed"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"199da8dfd027ee5e4acfd149a81477d0d077cb24","unresolved":false,"context_lines":[{"line_number":215,"context_line":"      $ovn_dbs_network \u003d hiera(\u0027ovn_dbs_network\u0027, undef)"},{"line_number":216,"context_line":"      $net_vip_map \u003d hiera(\u0027network_virtual_ips\u0027, undef)"},{"line_number":217,"context_line":"      if $ovn_dbs_network !\u003d undef and $net_vip_map !\u003d undef and $ovn_dbs_network in $net_vip_map {"},{"line_number":218,"context_line":"        $old_vip \u003d $net_vip_map[$ovn_dbs_network][\u0027ip_address\u0027]"},{"line_number":219,"context_line":"        if $old_vip !\u003d $ovn_dbs_vip {"},{"line_number":220,"context_line":"          $ovn_separate_vip \u003d true"},{"line_number":221,"context_line":"        } else {"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"3fa7e38b_1a3714b3","line":218,"updated":"2019-09-19 08:01:07.000000000","message":"Not sure I get that correctly: for this to work, once we push a stack update with the separate VIP, the old information would need to stay forever in $net_vip_map[$ovn_dbs_network] ?\n\nIf so, could you maybe add some info about the name of the key that holds network info the new ovn_dbs_vip?\n\n(unless I totally misunderstood it)","commit_id":"6b05849ab9db9efab011bea6d17b374eddf0c0ed"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"4990d9bf04ae0b95c08d2c1aa1fb8b6988cd7ff2","unresolved":false,"context_lines":[{"line_number":215,"context_line":"      $ovn_dbs_network \u003d hiera(\u0027ovn_dbs_network\u0027, undef)"},{"line_number":216,"context_line":"      $net_vip_map \u003d hiera(\u0027network_virtual_ips\u0027, undef)"},{"line_number":217,"context_line":"      if $ovn_dbs_network !\u003d undef and $net_vip_map !\u003d undef and $ovn_dbs_network in $net_vip_map {"},{"line_number":218,"context_line":"        $old_vip \u003d $net_vip_map[$ovn_dbs_network][\u0027ip_address\u0027]"},{"line_number":219,"context_line":"        if $old_vip !\u003d $ovn_dbs_vip {"},{"line_number":220,"context_line":"          $ovn_separate_vip \u003d true"},{"line_number":221,"context_line":"        } else {"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"3fa7e38b_3ee0affa","line":218,"in_reply_to":"3fa7e38b_1a3714b3","updated":"2019-09-20 07:24:24.000000000","message":"ovn_dbs_vip is not new, it is what it is being used today and today it gets set to the per network vip (aka net_vip_map[$ovn_dbs_network][\u0027ip_address\u0027]). Once in THT we separate the OVN VIP ovn_dbs_vip will be a new IP address and the following will start to be true: ovn_dbs_vip !\u003d net_vip_map[$ovn_dbs_network][\u0027ip_address\u0027]","commit_id":"6b05849ab9db9efab011bea6d17b374eddf0c0ed"},{"author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"change_message_id":"5581b8c44f16b544bbb6fb10a815b9ef78e84690","unresolved":false,"context_lines":[{"line_number":215,"context_line":"      $ovn_dbs_network \u003d hiera(\u0027ovn_dbs_network\u0027, undef)"},{"line_number":216,"context_line":"      $net_vip_map \u003d hiera(\u0027network_virtual_ips\u0027, undef)"},{"line_number":217,"context_line":"      if $ovn_dbs_network !\u003d undef and $net_vip_map !\u003d undef and $ovn_dbs_network in $net_vip_map {"},{"line_number":218,"context_line":"        $old_vip \u003d $net_vip_map[$ovn_dbs_network][\u0027ip_address\u0027]"},{"line_number":219,"context_line":"        if $old_vip !\u003d $ovn_dbs_vip {"},{"line_number":220,"context_line":"          $ovn_separate_vip \u003d true"},{"line_number":221,"context_line":"        } else {"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"3fa7e38b_fe39b73e","line":218,"in_reply_to":"3fa7e38b_3ee0affa","updated":"2019-09-20 07:46:29.000000000","message":"Ok i think it\u0027s clear now. we only need to do that in case the VIP changed. And then the regular haproxy.pp will handle the vip creation on stack deploy.\nThanks","commit_id":"6b05849ab9db9efab011bea6d17b374eddf0c0ed"}]}