)]}'
{"manifests/certmonger/ceph_grafana.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"77d485f11bb6ee63803e3f9013f363f10cd40800","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  $service_certificate,"},{"line_number":51,"context_line":"  $service_key,"},{"line_number":52,"context_line":"  $certmonger_ca \u003d hiera(\u0027certmonger_ca\u0027, \u0027local\u0027),"},{"line_number":53,"context_line":"  $dnsnames      \u003d $hostname,"},{"line_number":54,"context_line":"  $postsave_cmd  \u003d undef,"},{"line_number":55,"context_line":"  $principal     \u003d undef,"},{"line_number":56,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7faddb67_7539b2a1","line":53,"updated":"2019-08-07 10:56:28.000000000","message":"don\u0027t think we need dnsnames and postsave_cmd","commit_id":"9a3d41a573ed0fd76c1bfbf2bdc0259cf5685e8a"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"276e7a6fa52aaf0b759cc1f2c647cced97f64927","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  $service_certificate,"},{"line_number":51,"context_line":"  $service_key,"},{"line_number":52,"context_line":"  $certmonger_ca \u003d hiera(\u0027certmonger_ca\u0027, \u0027local\u0027),"},{"line_number":53,"context_line":"  $dnsnames      \u003d $hostname,"},{"line_number":54,"context_line":"  $postsave_cmd  \u003d undef,"},{"line_number":55,"context_line":"  $principal     \u003d undef,"},{"line_number":56,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7faddb67_95a9ce7d","line":53,"in_reply_to":"7faddb67_7539b2a1","updated":"2019-08-07 11:13:15.000000000","message":"dnsnames is needed. It should point to the FQDN relevant to the network (e.g. controller-0.internalapi.tripleodomain.com)\n\nYou\u0027ll be able to get this via hiera (and just call it via t-h-t).\n\nthe postsave_cmd is generally used to execute a command (or a script) after the certificate has been acquired. One normally wants to issue a \"reload\" or a \"restart\" for the service; but other services might need something else (such as reformatting the certificate if PEM isn\u0027t appropriate). So, it all depends on the requirements for this service.","commit_id":"9a3d41a573ed0fd76c1bfbf2bdc0259cf5685e8a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"77d485f11bb6ee63803e3f9013f363f10cd40800","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  $postsave_cmd  \u003d undef,"},{"line_number":55,"context_line":"  $principal     \u003d undef,"},{"line_number":56,"context_line":") {"},{"line_number":57,"context_line":"  include ::certmonger"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  certmonger_certificate { \u0027ceph_grafana\u0027 :"},{"line_number":60,"context_line":"    ensure       \u003d\u003e \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7faddb67_b5e08a28","line":57,"updated":"2019-08-07 10:56:28.000000000","message":"we shouldn\u0027t need this","commit_id":"9a3d41a573ed0fd76c1bfbf2bdc0259cf5685e8a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"77d485f11bb6ee63803e3f9013f363f10cd40800","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    certfile     \u003d\u003e $service_certificate,"},{"line_number":62,"context_line":"    keyfile      \u003d\u003e $service_key,"},{"line_number":63,"context_line":"    hostname     \u003d\u003e $hostname,"},{"line_number":64,"context_line":"    dnsname      \u003d\u003e $dnsnames,"},{"line_number":65,"context_line":"    principal    \u003d\u003e $principal,"},{"line_number":66,"context_line":"    postsave_cmd \u003d\u003e $postsave_cmd,"},{"line_number":67,"context_line":"    ca           \u003d\u003e $certmonger_ca,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7faddb67_153e3e8b","line":64,"updated":"2019-08-07 10:56:28.000000000","message":"this can be set to $hostname","commit_id":"9a3d41a573ed0fd76c1bfbf2bdc0259cf5685e8a"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"276e7a6fa52aaf0b759cc1f2c647cced97f64927","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    certfile     \u003d\u003e $service_certificate,"},{"line_number":62,"context_line":"    keyfile      \u003d\u003e $service_key,"},{"line_number":63,"context_line":"    hostname     \u003d\u003e $hostname,"},{"line_number":64,"context_line":"    dnsname      \u003d\u003e $dnsnames,"},{"line_number":65,"context_line":"    principal    \u003d\u003e $principal,"},{"line_number":66,"context_line":"    postsave_cmd \u003d\u003e $postsave_cmd,"},{"line_number":67,"context_line":"    ca           \u003d\u003e $certmonger_ca,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7faddb67_55b596cf","line":64,"in_reply_to":"7faddb67_153e3e8b","updated":"2019-08-07 11:13:15.000000000","message":"this is fine","commit_id":"9a3d41a573ed0fd76c1bfbf2bdc0259cf5685e8a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"77d485f11bb6ee63803e3f9013f363f10cd40800","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    hostname     \u003d\u003e $hostname,"},{"line_number":64,"context_line":"    dnsname      \u003d\u003e $dnsnames,"},{"line_number":65,"context_line":"    principal    \u003d\u003e $principal,"},{"line_number":66,"context_line":"    postsave_cmd \u003d\u003e $postsave_cmd,"},{"line_number":67,"context_line":"    ca           \u003d\u003e $certmonger_ca,"},{"line_number":68,"context_line":"    wait         \u003d\u003e true,"},{"line_number":69,"context_line":"    require      \u003d\u003e Class[\u0027::certmonger\u0027],"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7faddb67_756212b0","line":66,"updated":"2019-08-07 10:56:28.000000000","message":"can be removed","commit_id":"9a3d41a573ed0fd76c1bfbf2bdc0259cf5685e8a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"aae89a613e5367b0f9e623a3540a266c3c98344e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  file { $service_certificate :"},{"line_number":73,"context_line":"    require \u003d\u003e Certmonger_certificate[\u0027ceph_grafana\u0027],"},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":"  file { $service_key :"},{"line_number":76,"context_line":"    require \u003d\u003e Certmonger_certificate[\u0027ceph_grafana\u0027],"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7faddb67_75d5321b","line":73,"updated":"2019-08-07 10:59:59.000000000","message":"I think we also want:\n\n    owner   \u003d\u003e 472\n    group   \u003d\u003e 472\n\nbecause so it is set by default in ceph-ansible [1]\n\n1. https://github.com/ceph/ceph-ansible/blob/master/roles/ceph-defaults/defaults/main.yml#L723","commit_id":"9a3d41a573ed0fd76c1bfbf2bdc0259cf5685e8a"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"276e7a6fa52aaf0b759cc1f2c647cced97f64927","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  file { $service_certificate :"},{"line_number":73,"context_line":"    require \u003d\u003e Certmonger_certificate[\u0027ceph_grafana\u0027],"},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":"  file { $service_key :"},{"line_number":76,"context_line":"    require \u003d\u003e Certmonger_certificate[\u0027ceph_grafana\u0027],"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7faddb67_75ba12c1","line":73,"in_reply_to":"7faddb67_75d5321b","updated":"2019-08-07 11:13:15.000000000","message":"Does ceph_graphana run in a container or on baremetal? If it\u0027s on a container lets remove these dependencies. If it\u0027s on baremetal, then they\u0027re fine and we should actually change the owner/group as Giulio is suggesting.","commit_id":"9a3d41a573ed0fd76c1bfbf2bdc0259cf5685e8a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"aae89a613e5367b0f9e623a3540a266c3c98344e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    require \u003d\u003e Certmonger_certificate[\u0027ceph_grafana\u0027],"},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":"  file { $service_key :"},{"line_number":76,"context_line":"    require \u003d\u003e Certmonger_certificate[\u0027ceph_grafana\u0027],"},{"line_number":77,"context_line":"  }"},{"line_number":78,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7faddb67_15dabe4a","line":76,"updated":"2019-08-07 10:59:59.000000000","message":"owner   \u003d\u003e 472\n    group   \u003d\u003e 472","commit_id":"9a3d41a573ed0fd76c1bfbf2bdc0259cf5685e8a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"d08fcc853a95e717c3b9feb2945c1c6286fb800b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  $service_certificate,"},{"line_number":51,"context_line":"  $service_key,"},{"line_number":52,"context_line":"  $certmonger_ca \u003d hiera(\u0027certmonger_ca\u0027, \u0027local\u0027),"},{"line_number":53,"context_line":"  $dnsnames      \u003d $hostname,"},{"line_number":54,"context_line":"  $principal     \u003d undef,"},{"line_number":55,"context_line":") {"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7faddb67_3b724baf","line":53,"updated":"2019-08-07 12:35:54.000000000","message":"it doesn\u0027t hurt, but it\u0027s set to $hostname and we don\u0027t cusomize it, what I meant is we can remove it from the list of class params and just pass it to certmonger_certificate","commit_id":"1383b221296d23767dc063849d6061800e181450"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"ab37f580bdeeaeb5ac81a6b5748c2b373b341a8c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  $service_certificate,"},{"line_number":51,"context_line":"  $service_key,"},{"line_number":52,"context_line":"  $certmonger_ca \u003d hiera(\u0027certmonger_ca\u0027, \u0027local\u0027),"},{"line_number":53,"context_line":"  $dnsnames      \u003d $hostname,"},{"line_number":54,"context_line":"  $principal     \u003d undef,"},{"line_number":55,"context_line":") {"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7faddb67_dbabf7d4","line":53,"in_reply_to":"7faddb67_3b724baf","updated":"2019-08-07 12:37:49.000000000","message":"ah ok sure, it makes sense","commit_id":"1383b221296d23767dc063849d6061800e181450"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"6a465883f3b4472e2edff9857792209b0d5253f0","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    require      \u003d\u003e Class[\u0027::certmonger\u0027],"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  file { $service_certificate :"},{"line_number":70,"context_line":"    require \u003d\u003e Certmonger_certificate[\u0027ceph_grafana\u0027],"},{"line_number":71,"context_line":"    owner \u003d\u003e 472"},{"line_number":72,"context_line":"    group \u003d\u003e 472"},{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":"  file { $service_key :"},{"line_number":75,"context_line":"    require \u003d\u003e Certmonger_certificate[\u0027ceph_grafana\u0027],"},{"line_number":76,"context_line":"    owner \u003d\u003e 472"},{"line_number":77,"context_line":"    group \u003d\u003e 472"},{"line_number":78,"context_line":"  }"},{"line_number":79,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7faddb67_406f12fc","line":78,"range":{"start_line":69,"start_character":1,"end_line":78,"end_character":3},"updated":"2019-08-07 12:25:08.000000000","message":"Since grafana is a container we can avoid these blocks in theory, but we also need to pass to ceph-ansible the grafana_crt and grafana_key, so I\u0027m not sure if actually we can remove this","commit_id":"1383b221296d23767dc063849d6061800e181450"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b90eee160b70848d437239caf47a73565276d0c9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"7faddb67_7c606836","line":1,"updated":"2019-08-12 22:14:57.000000000","message":"nit: 2019","commit_id":"dcf2263522440580508031c600ca1a15bb49ac2f"}],"manifests/profile/base/certmonger_user.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"77d485f11bb6ee63803e3f9013f363f10cd40800","unresolved":false,"context_lines":[{"line_number":102,"context_line":"#   it will create."},{"line_number":103,"context_line":"#   Defaults to hiera(\u0027redis_certificate_specs\u0027, {})."},{"line_number":104,"context_line":"#"},{"line_number":105,"context_line":"# [*ceph_grafana_certificate_specs*]"},{"line_number":106,"context_line":"#   (Optional) The specifications to give to certmonger for the certificate(s)"},{"line_number":107,"context_line":"#   it will create."},{"line_number":108,"context_line":"#   Defaults to hiera(\u0027ceph_grafana_certificate_specs\u0027, {})."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7faddb67_150cfeea","line":105,"updated":"2019-08-07 10:56:28.000000000","message":"needs to be ceph_grafana-server_certificate_specs","commit_id":"9a3d41a573ed0fd76c1bfbf2bdc0259cf5685e8a"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"276e7a6fa52aaf0b759cc1f2c647cced97f64927","unresolved":false,"context_lines":[{"line_number":102,"context_line":"#   it will create."},{"line_number":103,"context_line":"#   Defaults to hiera(\u0027redis_certificate_specs\u0027, {})."},{"line_number":104,"context_line":"#"},{"line_number":105,"context_line":"# [*ceph_grafana_certificate_specs*]"},{"line_number":106,"context_line":"#   (Optional) The specifications to give to certmonger for the certificate(s)"},{"line_number":107,"context_line":"#   it will create."},{"line_number":108,"context_line":"#   Defaults to hiera(\u0027ceph_grafana_certificate_specs\u0027, {})."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7faddb67_f5c5a23e","line":105,"in_reply_to":"7faddb67_150cfeea","updated":"2019-08-07 11:13:15.000000000","message":"This can be anything really; the this will be referenced from t-h-t at some point.","commit_id":"9a3d41a573ed0fd76c1bfbf2bdc0259cf5685e8a"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"c32e6142318569ccb060e05d8a0fb5179c26406a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"#   it will create."},{"line_number":103,"context_line":"#   Defaults to hiera(\u0027redis_certificate_specs\u0027, {})."},{"line_number":104,"context_line":"#"},{"line_number":105,"context_line":"# [*ceph_grafana_certificate_specs*]"},{"line_number":106,"context_line":"#   (Optional) The specifications to give to certmonger for the certificate(s)"},{"line_number":107,"context_line":"#   it will create."},{"line_number":108,"context_line":"#   Defaults to hiera(\u0027ceph_grafana_certificate_specs\u0027, {})."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7faddb67_80918a49","line":105,"in_reply_to":"7faddb67_d5698626","updated":"2019-08-07 12:05:56.000000000","message":"So we can leave this name here since in tht we\u0027re going to  reference it with \"ceph_grafana_certificate_specs\" name","commit_id":"9a3d41a573ed0fd76c1bfbf2bdc0259cf5685e8a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5aa4f160de8aa8079cb87df384049f5ebd2268b9","unresolved":false,"context_lines":[{"line_number":102,"context_line":"#   it will create."},{"line_number":103,"context_line":"#   Defaults to hiera(\u0027redis_certificate_specs\u0027, {})."},{"line_number":104,"context_line":"#"},{"line_number":105,"context_line":"# [*ceph_grafana_certificate_specs*]"},{"line_number":106,"context_line":"#   (Optional) The specifications to give to certmonger for the certificate(s)"},{"line_number":107,"context_line":"#   it will create."},{"line_number":108,"context_line":"#   Defaults to hiera(\u0027ceph_grafana_certificate_specs\u0027, {})."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7faddb67_d5698626","line":105,"in_reply_to":"7faddb67_f5c5a23e","updated":"2019-08-07 11:22:23.000000000","message":"ack, the matching tht submission currently uses that name [1]\n\n1. https://review.opendev.org/#/c/674556/5/deployment/ceph-ansible/ceph-grafana.yaml","commit_id":"9a3d41a573ed0fd76c1bfbf2bdc0259cf5685e8a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"77d485f11bb6ee63803e3f9013f363f10cd40800","unresolved":false,"context_lines":[{"line_number":105,"context_line":"# [*ceph_grafana_certificate_specs*]"},{"line_number":106,"context_line":"#   (Optional) The specifications to give to certmonger for the certificate(s)"},{"line_number":107,"context_line":"#   it will create."},{"line_number":108,"context_line":"#   Defaults to hiera(\u0027ceph_grafana_certificate_specs\u0027, {})."},{"line_number":109,"context_line":"#"},{"line_number":110,"context_line":"# [*etcd_certificate_specs*]"},{"line_number":111,"context_line":"#   (Optional) The specifications to give to certmonger for the certificate(s)"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7faddb67_3511fa05","line":108,"updated":"2019-08-07 10:56:28.000000000","message":"ceph_grafana-server_certificate_specs","commit_id":"9a3d41a573ed0fd76c1bfbf2bdc0259cf5685e8a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"77d485f11bb6ee63803e3f9013f363f10cd40800","unresolved":false,"context_lines":[{"line_number":169,"context_line":"  $ovs_certificate_specs      \u003d hiera(\u0027tripleo::profile::base::neutron::plugins::ovs::opendaylight::certificate_specs\u0027, {}),"},{"line_number":170,"context_line":"  $neutron_certificate_specs  \u003d hiera(\u0027tripleo::profile::base::neutron::certificate_specs\u0027, {}),"},{"line_number":171,"context_line":"  $novnc_proxy_certificates_specs \u003d hiera(\u0027novnc_proxy_certificates_specs\u0027,{}),"},{"line_number":172,"context_line":"  $ceph_grafana_certificate_specs \u003d hiera(\u0027ceph_grafana_certificate_specs\u0027, {}),"},{"line_number":173,"context_line":"  $novnc_proxy_postsave_cmd   \u003d undef,"},{"line_number":174,"context_line":"  # Deprecated"},{"line_number":175,"context_line":"  $haproxy_postsave_cmd       \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7faddb67_d5f506ce","line":172,"updated":"2019-08-07 10:56:28.000000000","message":"ceph_grafana-server_certificate_specs","commit_id":"9a3d41a573ed0fd76c1bfbf2bdc0259cf5685e8a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"77d485f11bb6ee63803e3f9013f363f10cd40800","unresolved":false,"context_lines":[{"line_number":257,"context_line":"      ensure_resource(\u0027class\u0027, \u0027tripleo::certmonger::novnc_proxy\u0027, $novnc_proxy_certificates_specs,"},{"line_number":258,"context_line":"                        {\u0027postsave_cmd\u0027 \u003d\u003e $novnc_proxy_postsave_cmd})"},{"line_number":259,"context_line":"    }"},{"line_number":260,"context_line":"    unless empty($ceph_grafana_certificate_specs) {"},{"line_number":261,"context_line":"      ensure_resource(\u0027class\u0027, \u0027tripleo::certmonger::ceph_grafana-server\u0027, $ceph_grafana_certificate_specs)"},{"line_number":262,"context_line":"    }"},{"line_number":263,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7faddb67_f5f282e3","line":260,"updated":"2019-08-07 10:56:28.000000000","message":"ceph_grafana-server_certificate_specs","commit_id":"9a3d41a573ed0fd76c1bfbf2bdc0259cf5685e8a"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"77d485f11bb6ee63803e3f9013f363f10cd40800","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                        {\u0027postsave_cmd\u0027 \u003d\u003e $novnc_proxy_postsave_cmd})"},{"line_number":259,"context_line":"    }"},{"line_number":260,"context_line":"    unless empty($ceph_grafana_certificate_specs) {"},{"line_number":261,"context_line":"      ensure_resource(\u0027class\u0027, \u0027tripleo::certmonger::ceph_grafana-server\u0027, $ceph_grafana_certificate_specs)"},{"line_number":262,"context_line":"    }"},{"line_number":263,"context_line":"  }"},{"line_number":264,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7faddb67_95ff8eaa","line":261,"updated":"2019-08-07 10:56:28.000000000","message":"tripleo::certmonger::ceph_grafana\n\nand\n\nceph_grafana-server_certificate_specs","commit_id":"9a3d41a573ed0fd76c1bfbf2bdc0259cf5685e8a"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"c32e6142318569ccb060e05d8a0fb5179c26406a","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                        {\u0027postsave_cmd\u0027 \u003d\u003e $novnc_proxy_postsave_cmd})"},{"line_number":259,"context_line":"    }"},{"line_number":260,"context_line":"    unless empty($ceph_grafana_certificate_specs) {"},{"line_number":261,"context_line":"      ensure_resource(\u0027class\u0027, \u0027tripleo::certmonger::ceph_grafana-server\u0027, $ceph_grafana_certificate_specs)"},{"line_number":262,"context_line":"    }"},{"line_number":263,"context_line":"  }"},{"line_number":264,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7faddb67_40b4f2d1","line":261,"in_reply_to":"7faddb67_95ff8eaa","updated":"2019-08-07 12:05:56.000000000","message":"+1 for tripleo::certmonger::ceph_grafana","commit_id":"9a3d41a573ed0fd76c1bfbf2bdc0259cf5685e8a"}]}