)]}'
{"manifests/profile/base/docker.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5bed163be3b4c15c30c332b844ff9dec0d54cf82","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            \"HOST\u003d${host}\","},{"line_number":304,"context_line":"          ],"},{"line_number":305,"context_line":"          require     \u003d\u003e Service[\u0027docker\u0027],"},{"line_number":306,"context_line":"        }"},{"line_number":307,"context_line":"      }"},{"line_number":308,"context_line":"    }"},{"line_number":309,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7faddb67_ed915655","line":306,"updated":"2019-08-07 13:44:00.000000000","message":"I think we should add a logoutput to false, so if registration fails we don\u0027t leak the credentials in the logs.","commit_id":"e3fae2b04a3e42cba88396e7abebb37f9978d81f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a08623061497250ce814020fa2ca8c8cdf44edb4","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            \"HOST\u003d${host}\","},{"line_number":304,"context_line":"          ],"},{"line_number":305,"context_line":"          require     \u003d\u003e Service[\u0027docker\u0027],"},{"line_number":306,"context_line":"        }"},{"line_number":307,"context_line":"      }"},{"line_number":308,"context_line":"    }"},{"line_number":309,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7faddb67_a61e1bb9","line":306,"in_reply_to":"7faddb67_ed52b668","updated":"2019-08-07 16:11:10.000000000","message":"If command fails, the output is displayed by default:\n\n exec { \"Login to localhost as emilien\":\n   path        \u003d\u003e [\u0027/bin\u0027, \u0027/usr/bin\u0027],\n   command     \u003d\u003e \u0027echo docker login $USER $PASS $HOST \u0026\u0026 false\u0027,\n   environment \u003d\u003e [\n     \"USER\u003demilien\",\n     \"PASS\u003dsecrete\",\n     \"HOST\u003dlocalhost\",\n   ],\n }\n\n Error: \u0027echo docker login $USER $PASS $HOST \u0026\u0026 false\u0027 returned 1 instead of one of [0]\n Error: /Stage[main]/Main/Exec[Login to localhost as emilien]/returns: change from \u0027notrun\u0027 to [\u00270\u0027] failed: \u0027echo docker login $USER $PASS $HOST \u0026\u0026 false\u0027 returned 1 instead of one of [0]","commit_id":"e3fae2b04a3e42cba88396e7abebb37f9978d81f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"97a4ca73f3c9a2d20e758e537557909d377f785f","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            \"HOST\u003d${host}\","},{"line_number":304,"context_line":"          ],"},{"line_number":305,"context_line":"          require     \u003d\u003e Service[\u0027docker\u0027],"},{"line_number":306,"context_line":"        }"},{"line_number":307,"context_line":"      }"},{"line_number":308,"context_line":"    }"},{"line_number":309,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7faddb67_ed52b668","line":306,"in_reply_to":"7faddb67_ed915655","updated":"2019-08-07 13:56:50.000000000","message":"Because we\u0027re using environment vars, it doesn\u0027t show credentials.","commit_id":"e3fae2b04a3e42cba88396e7abebb37f9978d81f"}]}