)]}'
{"manifests/profile/base/octavia/api.pp":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"70b19fc44e16bfa3464fc6eb34f7f3ef8b0436e5","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    if \u0027ovn\u0027 in $neutron_driver and !defined(provider_drivers) {"},{"line_number":105,"context_line":"      $providers \u003d \u0027amphora: The Octavia Amphora driver.,octavia: Deprecated alias of the Octavia Amphora driver.,ovn: Octavia OVN driver.\u0027"},{"line_number":106,"context_line":"    } else {"},{"line_number":107,"context_line":"      $providers \u003d $provider_drivers"},{"line_number":108,"context_line":"    }"},{"line_number":109,"context_line":"    if \u0027ovn\u0027 in $providers {"},{"line_number":110,"context_line":"      class { \u0027::octavia::api\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7faddb67_20f75d8f","line":107,"updated":"2019-08-08 14:12:36.000000000","message":"shouldn\u0027t we use any2array here?","commit_id":"af1c5c4b8c89b49624e919d4668573f17e753544"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"b0edbcf71d110546a77a1654a45695ce2a2491e6","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    if \u0027ovn\u0027 in $neutron_driver and !defined(provider_drivers) {"},{"line_number":105,"context_line":"      $providers \u003d \u0027amphora: The Octavia Amphora driver.,octavia: Deprecated alias of the Octavia Amphora driver.,ovn: Octavia OVN driver.\u0027"},{"line_number":106,"context_line":"    } else {"},{"line_number":107,"context_line":"      $providers \u003d $provider_drivers"},{"line_number":108,"context_line":"    }"},{"line_number":109,"context_line":"    if \u0027ovn\u0027 in $providers {"},{"line_number":110,"context_line":"      class { \u0027::octavia::api\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7faddb67_c09769eb","line":107,"in_reply_to":"7faddb67_20f75d8f","updated":"2019-08-08 14:23:04.000000000","message":"This is expected as a comma delimited string.\nActually it\u0027s terrible logic to be tbh done as a hack to what was existing in a hurry. If we\u0027re making scenrio10 job non-voting we can do it properly.","commit_id":"af1c5c4b8c89b49624e919d4668573f17e753544"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"839ad54b479d3eb285f9fc08b0e7692d5db69f0b","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    } else {"},{"line_number":107,"context_line":"      $providers \u003d $provider_drivers"},{"line_number":108,"context_line":"    }"},{"line_number":109,"context_line":"    if \u0027ovn\u0027 in $providers {"},{"line_number":110,"context_line":"      class { \u0027::octavia::api\u0027:"},{"line_number":111,"context_line":"        sync_db           \u003d\u003e $sync_db,"},{"line_number":112,"context_line":"        provider_drivers  \u003d\u003e $providers,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7faddb67_203c3d2f","line":109,"updated":"2019-08-08 14:13:24.000000000","message":"or here","commit_id":"af1c5c4b8c89b49624e919d4668573f17e753544"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"cc4ccc09fcd187ec1882e89d78d94efad0a0835e","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    }"},{"line_number":109,"context_line":"    class { \u0027::octavia::api\u0027:"},{"line_number":110,"context_line":"      sync_db           \u003d\u003e $sync_db,"},{"line_number":111,"context_line":"      provider_drivers  \u003d\u003e $provider_drivers,"},{"line_number":112,"context_line":"      ovn_nb_connection \u003d\u003e $ovn_nb_connection,"},{"line_number":113,"context_line":"    }"},{"line_number":114,"context_line":"    include ::tripleo::profile::base::apache"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7faddb67_e19db657","line":111,"updated":"2019-08-09 11:37:01.000000000","message":"why do you need to do this here? If that\u0027s set in hiera won\u0027t it be picked up anyway?","commit_id":"68b00eba3bb91ed2a8a04808ac48f77b7573f4e2"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"632587befd64d2531ea594690b7d6ecab9b07320","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    }"},{"line_number":109,"context_line":"    class { \u0027::octavia::api\u0027:"},{"line_number":110,"context_line":"      sync_db           \u003d\u003e $sync_db,"},{"line_number":111,"context_line":"      provider_drivers  \u003d\u003e $provider_drivers,"},{"line_number":112,"context_line":"      ovn_nb_connection \u003d\u003e $ovn_nb_connection,"},{"line_number":113,"context_line":"    }"},{"line_number":114,"context_line":"    include ::tripleo::profile::base::apache"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7faddb67_6cee9dee","line":111,"in_reply_to":"7faddb67_e19db657","updated":"2019-08-09 12:31:37.000000000","message":"It won\u0027t harm right? I was thinking we can set either with tripleo::profile::base::octavia::api::provider_drivers or octavia::api::provider_drivers in composable services as we probably do in certain cases. May be better remove it.","commit_id":"68b00eba3bb91ed2a8a04808ac48f77b7573f4e2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"45d126852f6ce921891cce584e823439519b2134","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    if $ovn_db_host and $ovn_nb_port {"},{"line_number":102,"context_line":"      $ovn_nb_connection \u003d join([\u0027tcp\u0027, normalize_ip_for_uri($ovn_db_host), \"${ovn_nb_port}\"], \u0027:\u0027)"},{"line_number":103,"context_line":"    }"},{"line_number":104,"context_line":"    class { \u0027::octavia::api\u0027:"},{"line_number":105,"context_line":"      sync_db           \u003d\u003e $sync_db,"},{"line_number":106,"context_line":"      ovn_nb_connection \u003d\u003e $ovn_nb_connection,"},{"line_number":107,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7faddb67_3f967096","line":104,"range":{"start_line":104,"start_character":5,"end_line":104,"end_character":16},"updated":"2019-08-12 11:37:19.000000000","message":"shouldn\u0027t this class be inside the if statement?","commit_id":"517eea74811fa5e61ea6010a620ffb50d207844b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5572a5b4120c6eff642cdd0113489d60c9d2e033","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    if $ovn_db_host and $ovn_nb_port {"},{"line_number":102,"context_line":"      $ovn_nb_connection \u003d join([\u0027tcp\u0027, normalize_ip_for_uri($ovn_db_host), \"${ovn_nb_port}\"], \u0027:\u0027)"},{"line_number":103,"context_line":"    }"},{"line_number":104,"context_line":"    class { \u0027::octavia::api\u0027:"},{"line_number":105,"context_line":"      sync_db           \u003d\u003e $sync_db,"},{"line_number":106,"context_line":"      ovn_nb_connection \u003d\u003e $ovn_nb_connection,"},{"line_number":107,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7faddb67_bfd02055","line":104,"range":{"start_line":104,"start_character":5,"end_line":104,"end_character":16},"in_reply_to":"7faddb67_1f8b7468","updated":"2019-08-12 11:41:44.000000000","message":"ok... but it was previously inside the if ovn in neutron driver right? or am i seeing things?","commit_id":"517eea74811fa5e61ea6010a620ffb50d207844b"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"8ffb9a4cd839e324f68183ba89f295af72cade6e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    if $ovn_db_host and $ovn_nb_port {"},{"line_number":102,"context_line":"      $ovn_nb_connection \u003d join([\u0027tcp\u0027, normalize_ip_for_uri($ovn_db_host), \"${ovn_nb_port}\"], \u0027:\u0027)"},{"line_number":103,"context_line":"    }"},{"line_number":104,"context_line":"    class { \u0027::octavia::api\u0027:"},{"line_number":105,"context_line":"      sync_db           \u003d\u003e $sync_db,"},{"line_number":106,"context_line":"      ovn_nb_connection \u003d\u003e $ovn_nb_connection,"},{"line_number":107,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7faddb67_1f8b7468","line":104,"range":{"start_line":104,"start_character":5,"end_line":104,"end_character":16},"in_reply_to":"7faddb67_3f967096","updated":"2019-08-12 11:40:10.000000000","message":"Nope...it\u0027s called for all cases..","commit_id":"517eea74811fa5e61ea6010a620ffb50d207844b"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"dbb0edccfaa903d32c72cc10801c67b75b5cf428","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    if $ovn_db_host and $ovn_nb_port {"},{"line_number":102,"context_line":"      $ovn_nb_connection \u003d join([\u0027tcp\u0027, normalize_ip_for_uri($ovn_db_host), \"${ovn_nb_port}\"], \u0027:\u0027)"},{"line_number":103,"context_line":"    }"},{"line_number":104,"context_line":"    class { \u0027::octavia::api\u0027:"},{"line_number":105,"context_line":"      sync_db           \u003d\u003e $sync_db,"},{"line_number":106,"context_line":"      ovn_nb_connection \u003d\u003e $ovn_nb_connection,"},{"line_number":107,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7faddb67_3ff750d7","line":104,"range":{"start_line":104,"start_character":5,"end_line":104,"end_character":16},"in_reply_to":"7faddb67_bfd02055","updated":"2019-08-12 11:48:37.000000000","message":"It was..but we don\u0027t check for ovn driver in puppet now.. \n\nAssumption is if ovn is enabled (which means we\u0027ve ovn_db_host/ovn_db_port), ovn_nb_connection would be set to the required url, else it would be the service default.\n\nWithout the provider, that url has no impact.","commit_id":"517eea74811fa5e61ea6010a620ffb50d207844b"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3e1b03f3e94e2807fb828a1df41ce77ee41d562c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    if $ovn_db_host and $ovn_nb_port {"},{"line_number":102,"context_line":"      $ovn_nb_connection \u003d join([\u0027tcp\u0027, normalize_ip_for_uri($ovn_db_host), \"${ovn_nb_port}\"], \u0027:\u0027)"},{"line_number":103,"context_line":"    }"},{"line_number":104,"context_line":"    class { \u0027::octavia::api\u0027:"},{"line_number":105,"context_line":"      sync_db           \u003d\u003e $sync_db,"},{"line_number":106,"context_line":"      ovn_nb_connection \u003d\u003e $ovn_nb_connection,"},{"line_number":107,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7faddb67_ffbd3802","line":104,"range":{"start_line":104,"start_character":5,"end_line":104,"end_character":16},"in_reply_to":"7faddb67_bfd02055","updated":"2019-08-12 11:42:53.000000000","message":"ah i see. thats what brent asked below. so it previously had a else without the nb connection thing. but it seems it doesn\u0027t matter if we pass it or not in the non ovn case.","commit_id":"517eea74811fa5e61ea6010a620ffb50d207844b"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"e5f1991dd54de4c56eb6c870e922a8538e7474ff","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    }"},{"line_number":104,"context_line":"    class { \u0027::octavia::api\u0027:"},{"line_number":105,"context_line":"      sync_db           \u003d\u003e $sync_db,"},{"line_number":106,"context_line":"      ovn_nb_connection \u003d\u003e $ovn_nb_connection,"},{"line_number":107,"context_line":"    }"},{"line_number":108,"context_line":"    include ::tripleo::profile::base::apache"},{"line_number":109,"context_line":"    class { \u0027::octavia::wsgi::apache\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7faddb67_2c93c502","line":106,"updated":"2019-08-09 12:43:06.000000000","message":"While we could get pedantic and set something to avoid configuring this if the ovn provider isn\u0027t configured but I\u0027m going to take it on faith that Octavia isn\u0027t going to do something silly with this just because it is there.","commit_id":"517eea74811fa5e61ea6010a620ffb50d207844b"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"eace382db0ebc018c1d897e7b79c72b74baa3a46","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    }"},{"line_number":104,"context_line":"    class { \u0027::octavia::api\u0027:"},{"line_number":105,"context_line":"      sync_db           \u003d\u003e $sync_db,"},{"line_number":106,"context_line":"      ovn_nb_connection \u003d\u003e $ovn_nb_connection,"},{"line_number":107,"context_line":"    }"},{"line_number":108,"context_line":"    include ::tripleo::profile::base::apache"},{"line_number":109,"context_line":"    class { \u0027::octavia::wsgi::apache\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7faddb67_ac7495d1","line":106,"in_reply_to":"7faddb67_2c93c502","updated":"2019-08-09 12:47:27.000000000","message":"No it does not. I have seen with my testing that this setting has no effect without the ovn provider driver being set.","commit_id":"517eea74811fa5e61ea6010a620ffb50d207844b"}]}