)]}'
{"id":"openstack%2Fpuppet-tripleo~675352","triplet_id":"openstack%2Fpuppet-tripleo~master~Idec0875a2d3ea1f7a0f9bfc91d4cba3812315a37","project":"openstack/puppet-tripleo","branch":"master","topic":"bug/1839436","hashtags":[],"change_id":"Idec0875a2d3ea1f7a0f9bfc91d4cba3812315a37","subject":"Don\u0027t configure OVN octavia provider by default when OVN","status":"ABANDONED","created":"2019-08-08 14:30:44.000000000","updated":"2019-08-09 11:38:12.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1a705e3340c16ba0e3f1b3c27b6684dc58d72d57","_number":675352,"virtual_id_number":675352,"owner":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},{"value":-1,"date":"2019-08-09 00:01:55.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2019-08-08 21:31:31.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"all":[{"value":-1,"date":"2019-08-09 06:38:50.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"all":[{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},{"value":-1,"date":"2019-08-09 11:38:09.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-08 14:30:58.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-08-08 14:31:08.000000000","updated_by":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"reviewer":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"state":"REVIEWER"},{"updated":"2019-08-08 15:49:54.000000000","updated_by":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"reviewer":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"state":"REVIEWER"},{"updated":"2019-08-08 21:31:31.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-09 00:01:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-09 06:38:50.000000000","updated_by":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"reviewer":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"state":"REVIEWER"}],"messages":[{"id":"56c6acb494bf395027b6fd5f6d36a4fefeb1d658","author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"date":"2019-08-08 14:30:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b9e881e07cb495f6430f8e0389c6c54940422636","author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"date":"2019-08-08 14:35:17.000000000","message":"Patch Set 1:\n\nAs mentioned in the other patch, I don\u0027t think this is the correct approach. The key things from the user point of view are nutron_driver and/or octavia provider_driver.","accounts_in_message":[],"_revision_number":1},{"id":"fe67bff075afb655b32becb6031ace1a13c36a63","author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"date":"2019-08-08 16:13:47.000000000","message":"Patch Set 1:\n\n\u003e As mentioned in the other patch, I don\u0027t think this is the correct\n \u003e approach. The key things from the user point of view are\n \u003e nutron_driver and/or octavia provider_driver.\n\nI\u0027m not sure octavia_provider_driver is one things that are really valid to control from the user view. Until we open the door to supporting other provider drivers than OVN and amphora, asking the user to configure it is unnecessary and just opens the door to broken configurations. When it comes time to, we intend to enable some control over it but direct unprocessed access to the octavia provider configuration wasn\u0027t a given.","accounts_in_message":[],"_revision_number":1},{"id":"fc2b5a86affb7fc4ee2b4a1455eb50b2aeb2ed3a","author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"date":"2019-08-08 16:27:01.000000000","message":"Patch Set 1:\n\n\u003e I\u0027m not sure octavia_provider_driver is one things that are really valid to control from the user view\n\nI would probably diasgree. We can have validations not to allow anything other than amphora and ovn, but AFAICT, it\u0027s the interface from octavia point of view and the service should be configured accordingly.\n\nAll these puppet logic is hacky and won\u0027t help when we move to ansible. We should have a parameter for drivers to be configured with octavia like we do it for ton of other services like neutron, cinder etc.","accounts_in_message":[],"_revision_number":1},{"id":"9811e304d57d0f619c0c0a465ae58b12db8b2ced","author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"date":"2019-08-08 16:48:11.000000000","message":"Patch Set 1:\n\n\u003e \u003e I\u0027m not sure octavia_provider_driver is one things that are\n \u003e really valid to control from the user view\n \u003e \n \u003e I would probably diasgree. We can have validations not to allow\n \u003e anything other than amphora and ovn, but AFAICT, it\u0027s the interface\n \u003e from octavia point of view and the service should be configured\n \u003e accordingly.\n \u003e \n \u003e All these puppet logic is hacky and won\u0027t help when we move to\n \u003e ansible. We should have a parameter for drivers to be configured\n \u003e with octavia like we do it for ton of other services like neutron,\n \u003e cinder etc.\n\nOk, so let\u0027s just remove the logic and either have the template for the driver agent or the environment file do something.","accounts_in_message":[],"_revision_number":1},{"id":"abedd25e692ec008c636e0a61bfaa2d7a77b7ef2","author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"date":"2019-08-08 17:00:36.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1429c11790064ba746bd3ad43af7b9019341d984","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-08-08 21:31:31.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/52/675352/2/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/6b8af88/ : TIMED_OUT in 4h 30m 06s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035 http://logs.rdoproject.org/52/675352/2/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035/2e0f864/ : FAILURE in 2h 44m 15s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039 http://logs.rdoproject.org/52/675352/2/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039/7676a70/ : TIMED_OUT in 4h 09m 50s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"c82d303694c11cf935e41165dd3217e6ea9e8d25","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 00:01:55.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- puppet-openstack-lint-ubuntu-bionic https://logs.opendev.org/52/675352/2/check/puppet-openstack-lint-ubuntu-bionic/b1b44da/ : SUCCESS in 5m 10s\n- puppet-openstack-syntax-5-ubuntu-bionic https://logs.opendev.org/52/675352/2/check/puppet-openstack-syntax-5-ubuntu-bionic/c4295a1/ : SUCCESS in 6m 13s\n- puppet-openstack-syntax-6-ubuntu-bionic https://logs.opendev.org/52/675352/2/check/puppet-openstack-syntax-6-ubuntu-bionic/2c62b37/ : SUCCESS in 3m 59s\n- puppet-openstack-unit-5.5-centos-7 https://logs.opendev.org/52/675352/2/check/puppet-openstack-unit-5.5-centos-7/bbf3f97/ : FAILURE in 31m 53s\n- puppet-openstack-unit-6.0-ubuntu-bionic https://logs.opendev.org/52/675352/2/check/puppet-openstack-unit-6.0-ubuntu-bionic/be0d643/ : FAILURE in 16m 02s\n- puppet-openstack-unit-latest-ubuntu-bionic https://logs.opendev.org/52/675352/2/check/puppet-openstack-unit-latest-ubuntu-bionic/1ce81a9/ : FAILURE in 20m 11s (non-voting)\n- tripleo-ci-centos-7-undercloud-containers https://logs.opendev.org/52/675352/2/check/tripleo-ci-centos-7-undercloud-containers/09eb415/ : SUCCESS in 1h 42m 15s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades https://logs.opendev.org/52/675352/2/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/207a164/ : FAILURE in 2h 13m 02s (non-voting)\n- tripleo-ci-centos-7-containers-multinode https://logs.opendev.org/52/675352/2/check/tripleo-ci-centos-7-containers-multinode/3c61689/ : SUCCESS in 2h 22m 06s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://logs.opendev.org/52/675352/2/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/b2e547d/ : SUCCESS in 2h 21m 26s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://logs.opendev.org/52/675352/2/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/fb1fb48/ : SUCCESS in 2h 27m 35s (non-voting)\n- tripleo-ci-centos-7-standalone https://logs.opendev.org/52/675352/2/check/tripleo-ci-centos-7-standalone/3800392/ : SUCCESS in 1h 43m 42s\n- tripleo-ci-fedora-28-standalone https://logs.opendev.org/52/675352/2/check/tripleo-ci-fedora-28-standalone/76f36f6/ : SUCCESS in 1h 48m 26s (non-voting)\n- tripleo-ci-centos-7-standalone-upgrade https://logs.opendev.org/52/675352/2/check/tripleo-ci-centos-7-standalone-upgrade/9257e9c/ : SUCCESS in 1h 54m 43s (non-voting)\n- tripleo-ci-centos-7-scenario010-standalone https://logs.opendev.org/52/675352/2/check/tripleo-ci-centos-7-scenario010-standalone/6e75e4a/ : SUCCESS in 1h 12m 05s\n- tripleo-ci-centos-7-scenario010-multinode-oooq-container https://logs.opendev.org/52/675352/2/check/tripleo-ci-centos-7-scenario010-multinode-oooq-container/59e3efa/ : FAILURE in 1h 54m 34s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"f23120e4e0b17386b460f870c4c4f8fba3610d7c","author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"date":"2019-08-09 06:38:50.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9db3c9b00cbc66c9158a51e18b69eb1f3fab10fa","author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"date":"2019-08-09 11:38:09.000000000","message":"Patch Set 2: Workflow-1\n\n\u003e (1 comment)\n\nprovider drivers should be set and picked up by hiera shouldn\u0027t it? in any case, let\u0027s iterate on your patch","accounts_in_message":[],"_revision_number":2},{"id":"74b77ca2300afb3b5bf25c142522617cdcf39abc","author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"date":"2019-08-09 11:38:12.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d457acecbfcc9dbe7105a90305591eaafd152bef","revisions":{"efe49bed5c94ce8725b3038f82b2f35b693146e7":{"kind":"REWORK","_number":1,"created":"2019-08-08 14:30:44.000000000","uploader":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"ref":"refs/changes/52/675352/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/52/675352/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/52/675352/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/52/675352/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/52/675352/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/52/675352/1"}}},"commit":{"parents":[{"commit":"8e4de1b75ce67a253d5c872d3de18128cc17f2a9","subject":"Merge \"Enable service token in nova and cinder\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/8e4de1b75ce67a253d5c872d3de18128cc17f2a9"}]}],"author":{"name":"Brent Eagles","email":"beagles@redhat.com","date":"2019-08-08 14:28:38.000000000","tz":-150},"committer":{"name":"Brent Eagles","email":"beagles@redhat.com","date":"2019-08-08 14:30:37.000000000","tz":-150},"subject":"Disable OVN provider driver when the driver agent is not configured","message":"Disable OVN provider driver when the driver agent is not configured\n\nOctavia doesn\u0027t work well with the OVN provider enabled but there are no\nagents.\n\nChange-Id: Idec0875a2d3ea1f7a0f9bfc91d4cba3812315a37\nCloses-Bug: #1839436\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/efe49bed5c94ce8725b3038f82b2f35b693146e7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/efe49bed5c94ce8725b3038f82b2f35b693146e7"}]},"branch":"refs/heads/master"},"d457acecbfcc9dbe7105a90305591eaafd152bef":{"kind":"REWORK","_number":2,"created":"2019-08-08 17:00:36.000000000","uploader":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"ref":"refs/changes/52/675352/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/52/675352/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/52/675352/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/52/675352/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/52/675352/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/52/675352/2"}}},"commit":{"parents":[{"commit":"8e4de1b75ce67a253d5c872d3de18128cc17f2a9","subject":"Merge \"Enable service token in nova and cinder\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/8e4de1b75ce67a253d5c872d3de18128cc17f2a9"}]}],"author":{"name":"Brent Eagles","email":"beagles@redhat.com","date":"2019-08-08 14:28:38.000000000","tz":-150},"committer":{"name":"Brent Eagles","email":"beagles@redhat.com","date":"2019-08-08 16:57:35.000000000","tz":-150},"subject":"Don\u0027t configure OVN octavia provider by default when OVN","message":"Don\u0027t configure OVN octavia provider by default when OVN\n\nOctavia doesn\u0027t work well with the OVN provider enabled but there are no\nagents. This patch makes this a bit more explicit by adding a flag to\nbe set by the driver agent template that it is being deployed and also\nleaves the provider driver configuration to be set via hiera and the\ntemplates.\n\nChange-Id: Idec0875a2d3ea1f7a0f9bfc91d4cba3812315a37\nCloses-Bug: #1839436\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/d457acecbfcc9dbe7105a90305591eaafd152bef"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/d457acecbfcc9dbe7105a90305591eaafd152bef"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}