)]}'
{"id":"openstack%2Fpuppet-tripleo~677406","triplet_id":"openstack%2Fpuppet-tripleo~stable%2Fqueens~I29f779145a39cd16374a91626f7fae1581a18224","project":"openstack/puppet-tripleo","branch":"stable/queens","topic":"rabbitmq_ready-stable/stein-stable/rocky-stable/queens","hashtags":[],"change_id":"I29f779145a39cd16374a91626f7fae1581a18224","subject":"Make the rabbitmq-ready exec more stringent","status":"MERGED","created":"2019-08-20 06:53:04.000000000","updated":"2019-08-22 15:00:28.000000000","submitted":"2019-08-22 15:00:28.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"677406-1566486028015-3b288848","meta_rev_id":"a3e0137e3ae85d703031426a0810127b5db899f2","_number":677406,"virtual_id_number":677406,"owner":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":2,"date":"2019-08-22 15:00:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2019-08-20 10:17:08.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":2,"date":"2019-08-21 14:04:08.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"all":[{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":1,"date":"2019-08-22 12:38:21.000000000","_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-20 10:17:08.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-21 14:04:08.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-08-22 15:00:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3c2b40ebfa04452ac99662ac9932dcad25440e95","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2019-08-20 06:53:04.000000000","message":"Patch Set 1: Cherry Picked from branch stable/rocky.","accounts_in_message":[],"_revision_number":1},{"id":"524553d38c82bd1fd5fe54b27c5476eb21a108ad","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2019-08-20 06:53:14.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"36607ecd75b6f626f905d8e3ce989ca53ddbcb4a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-20 09:15:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-undercloud-oooq https://zuul.opendev.org/t/openstack/build/0283f17b09e54673b6b2738738ef572a : SUCCESS in 1h 20m 02s\n- tripleo-ci-centos-7-undercloud-upgrades https://zuul.opendev.org/t/openstack/build/b7c94f8c9ad142a0a76998ea2918038a : SUCCESS in 1h 23m 56s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/594e0d8fea9f4f88bdbaab0179c263ea : SUCCESS in 2h 18m 46s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/f8ab05636fdf4991a357ccaf859540f6 : FAILURE in 1h 59m 55s (non-voting)\n- puppet-openstack-lint https://zuul.opendev.org/t/openstack/build/dfb8022427a04e418fac2e75cefe701b : SUCCESS in 6m 02s\n- puppet-openstack-syntax-4 https://zuul.opendev.org/t/openstack/build/edfd60cb278943e2869927e189333117 : SUCCESS in 4m 31s\n- puppet-openstack-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/41a6c27b72fa4c4bb32662676e2b0db6 : SUCCESS in 40m 20s","accounts_in_message":[],"_revision_number":1},{"id":"29e13d31dcb836d76e3102ff336cb257805dec22","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-08-20 10:17:08.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 finger://ze07.softwarefactory-project.io:7979/65f0595636864aeb847c10e5a0a2563c : POST_FAILURE in 3h 22m 28s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035 finger://ze06.softwarefactory-project.io:7979/3323f9f5946e4b0e9238de0d16c61e8b : POST_FAILURE in 3h 21m 28s","accounts_in_message":[],"_revision_number":1},{"id":"04f2b42d99999ae04e6e8fe8e3f09c89cd75222b","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-08-21 14:04:08.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"5f55a8a3853cee9b85efa05b3dd10e765eac4bf8","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2019-08-22 12:38:06.000000000","message":"Patch Set 1: -Workflow","accounts_in_message":[],"_revision_number":1},{"id":"c4a9aebeeb3f7a1a176208ed9ada9ab8306f248d","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2019-08-22 12:38:21.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"9c16d2e59245a0cb04076993a8e20d0ecb93b7c1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-22 12:38:34.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"d0af2bda6d53bb84b740ad8abf62b7a911c7f1b7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-22 15:00:27.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tripleo-ci-centos-7-undercloud-oooq https://zuul.opendev.org/t/openstack/build/0c7ab4fa0d294574af395959476e7494 : SUCCESS in 1h 14m 42s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/f01f0b2e0bfa42f5a0e2bf3b3e6a8c04 : SUCCESS in 2h 16m 23s\n- puppet-openstack-lint https://zuul.opendev.org/t/openstack/build/8b2c3b72851146099376f6d1ad7fb30e : SUCCESS in 5m 13s\n- puppet-openstack-syntax-4 https://zuul.opendev.org/t/openstack/build/f6e8df18cce44000894c0eb571893e69 : SUCCESS in 5m 17s\n- puppet-openstack-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/7b3e6e6ddd374d78928fd172afc9faf0 : SUCCESS in 35m 42s","accounts_in_message":[],"_revision_number":1},{"id":"76d241c3ebb01597a3235d47ca9891e949250830","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-22 15:00:28.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"051e05a91dc89021de45644a8a34ffb93c2ddce7","revisions":{"051e05a91dc89021de45644a8a34ffb93c2ddce7":{"kind":"REWORK","_number":1,"created":"2019-08-20 06:53:04.000000000","uploader":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"ref":"refs/changes/06/677406/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/06/677406/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/06/677406/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/06/677406/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/06/677406/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/06/677406/1"}}},"commit":{"parents":[{"commit":"b123931159167769379ed15f486789f5d7240352","subject":"Merge \"[queens only] Add registry login support\" into stable/queens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/b123931159167769379ed15f486789f5d7240352"}]}],"author":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2019-08-14 14:40:46.000000000","tz":120},"committer":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2019-08-20 06:53:04.000000000","tz":0},"subject":"Make the rabbitmq-ready exec more stringent","message":"Make the rabbitmq-ready exec more stringent\n\nCurrently we use the following command to determine if rabbit is\nup and running *and* ready to service requests:\nrabbitmqctl eval \"rabbit_mnesia:is_clustered().\" | grep -q true\n\nNow we have occasionally observed that rabbitmqctl policies commands\nwhich are executed after said exec[\u0027rabbitmq-ready\u0027] will fail.\n\nOne potential reason is that is_clustered() can return true *before*\nthe rabbit app is actually running. In fact we can see it does\nreturn true even though the app is stopped:\n()[root@controller-1 /]$ rabbitmqctl stop_app\nStopping rabbit application on node rabbit@controller-1 ...\n()[root@controller-1 /]$ rabbitmqctl eval \u0027rabbit_mnesia:is_clustered().\u0027\ntrue\n\nLet\u0027s switch to a combination of commands that check for the cluster to\nbe up *and* the rabbitmq app to be running:\n()[root@controller-1 /]$ rabbitmqctl stop_app\nStopping rabbit application on node rabbit@controller-1 ...\n()[root@controller-1 /]$ rabbitmqctl eval \u0027rabbit_nodes:is_running(node(), rabbit).\u0027\nfalse\n\nSuggested-By: Bogdan Dobrelya \u003cbdobreli@redhat.com\u003e\nCloses-Bug: #1835615\n\nChange-Id: I29f779145a39cd16374a91626f7fae1581a18224\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/051e05a91dc89021de45644a8a34ffb93c2ddce7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/051e05a91dc89021de45644a8a34ffb93c2ddce7"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}