)]}'
{"id":"openstack%2Fpuppet-tripleo~678935","triplet_id":"openstack%2Fpuppet-tripleo~stable%2Fqueens~I6d5d0a37abeb54600bb70e22fabde9479320ab81","project":"openstack/puppet-tripleo","branch":"stable/queens","hashtags":[],"change_id":"I6d5d0a37abeb54600bb70e22fabde9479320ab81","subject":"Ensure Barbican required roles are created by Keystone","status":"MERGED","created":"2019-08-27 18:19:03.000000000","updated":"2019-08-28 01:45:35.000000000","submitted":"2019-08-28 01:45:35.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"678935-1566956735012-2a78a105","meta_rev_id":"8290c321d692b56a63d911d7b99168851698373f","_number":678935,"virtual_id_number":678935,"owner":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},{"value":2,"date":"2019-08-28 01:45:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2019-08-27 22:37:48.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":2,"date":"2019-08-27 22:57:06.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"date":"2019-08-27 18:19:37.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"date":"2019-08-27 18:19:25.000000000","_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"value":1,"date":"2019-08-27 22:57:06.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"date":"2019-08-27 18:19:19.000000000","_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-27 18:19:19.000000000","updated_by":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"reviewer":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"state":"REVIEWER"},{"updated":"2019-08-27 18:19:25.000000000","updated_by":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"reviewer":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"state":"REVIEWER"},{"updated":"2019-08-27 18:19:37.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-08-27 22:37:48.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-27 22:57:06.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-08-28 01:45:34.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"43d8fbbeb621a059ae0410527d17813939964539","author":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"date":"2019-08-27 18:19:03.000000000","message":"Patch Set 1: Cherry Picked from branch stable/rocky.","accounts_in_message":[],"_revision_number":1},{"id":"30a53547a053daae0dd6dfdb5ae2c6bf67b9ddd3","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-08-27 22:37:48.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/35/678935/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/92a5a59/ : FAILURE in 3h 21m 06s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035 http://logs.rdoproject.org/35/678935/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035/9c7348a/ : SUCCESS in 2h 25m 26s","accounts_in_message":[],"_revision_number":1},{"id":"736a8bd324604422adf3397567f262a297a7e301","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-27 22:52:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-undercloud-oooq https://zuul.opendev.org/t/openstack/build/6ba89627945e414ab528632bb62e23c2 : SUCCESS in 1h 10m 46s\n- tripleo-ci-centos-7-undercloud-upgrades https://zuul.opendev.org/t/openstack/build/771c9fe9bd7e45bba7aacca770752f81 : SUCCESS in 1h 17m 34s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/17617ff47f1f4d35b6bbc976a5b7640f : SUCCESS in 2h 21m 14s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/6833f61d2a814e32a9f44a1a198b9d2c : SUCCESS in 2h 41m 35s (non-voting)\n- puppet-openstack-lint https://zuul.opendev.org/t/openstack/build/dad257f2533b4f48aec19ae9aa586a6f : SUCCESS in 5m 30s\n- puppet-openstack-syntax-4 https://zuul.opendev.org/t/openstack/build/5ea7b6a798a545558270bfca62274235 : SUCCESS in 5m 37s\n- puppet-openstack-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/f94012c12be0436bb40b73b715dc802c : SUCCESS in 34m 14s","accounts_in_message":[],"_revision_number":1},{"id":"cbb361287bfc6eecf32728a128cc31ee45346043","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-08-27 22:57:06.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"8ff744b9827245ee760040d4dc2732a61219e61e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-27 22:57:36.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"45761a6270c1c0b61e3547599f32bac3bc985bf6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-28 01:45:34.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tripleo-ci-centos-7-undercloud-oooq https://zuul.opendev.org/t/openstack/build/edb998de1de6433ca386252d54b4e463 : SUCCESS in 1h 36m 19s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/48ccd468d0bd434e8e4c5b72b9d54b7f : SUCCESS in 2h 41m 57s\n- puppet-openstack-lint https://zuul.opendev.org/t/openstack/build/46f9de5462374935aa5367af4988cc93 : SUCCESS in 7m 12s\n- puppet-openstack-syntax-4 https://zuul.opendev.org/t/openstack/build/cddea37ab6974a44b28ece08252a1ac0 : SUCCESS in 6m 17s\n- puppet-openstack-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/218a96ee58584b739cd02c211cb16ed9 : SUCCESS in 33m 35s","accounts_in_message":[],"_revision_number":1},{"id":"8290c321d692b56a63d911d7b99168851698373f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-28 01:45:35.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"cd526608cdad090bed8cfc7a6bb65ca8aa6ae0e6","revisions":{"cd526608cdad090bed8cfc7a6bb65ca8aa6ae0e6":{"kind":"REWORK","_number":1,"created":"2019-08-27 18:19:03.000000000","uploader":{"_account_id":11589,"name":"Harry Rybacki","email":"hrybacki@redhat.com","username":"hrybacki"},"ref":"refs/changes/35/678935/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/35/678935/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/35/678935/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/35/678935/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/35/678935/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/35/678935/1"}}},"commit":{"parents":[{"commit":"81bc798ae00415826e121ed6c6419806eccbf16c","subject":"Add ability to install kernel related packages","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/81bc798ae00415826e121ed6c6419806eccbf16c"}]}],"author":{"name":"Harry Rybacki","email":"hrybacki@redhat.com","date":"2019-08-07 14:45:07.000000000","tz":-240},"committer":{"name":"Harry Rybacki","email":"hrybacki@redhat.com","date":"2019-08-27 18:19:03.000000000","tz":0},"subject":"Ensure Barbican required roles are created by Keystone","message":"Ensure Barbican required roles are created by Keystone\n\nPresently there are several roles: audit, observer, and key-manger:\nservice-admin that are used in Barbican policy but not generated\nby Keystone during a TripleO Deployment.\n\nThis change updates Keystone\u0027s manifest to include creation of these\nmissing roles then the Barbican API is included as part of a depl-\noyment.\n\nChange-Id: I6d5d0a37abeb54600bb70e22fabde9479320ab81\n(cherry picked from commit 970462b56257bccc7671dfc770b3301eaf3acb58)\n(cherry picked from commit 555498ba8c8edebc523b57b766738229abc8d16a)\n(cherry picked from commit d391ddf6a82341eb40fbfce21f1782ee68ef0e17)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/cd526608cdad090bed8cfc7a6bb65ca8aa6ae0e6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/cd526608cdad090bed8cfc7a6bb65ca8aa6ae0e6"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}