)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"198ac997dcc5c97a9ca3a8285d8859aebdeb0dc9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Networking-ansible-ml2 now has a dependency on tooz in order to prevent"},{"line_number":10,"context_line":"parallel updates on switches that do not support them. This patch"},{"line_number":11,"context_line":"adds in the components required for the rediz backend used by"},{"line_number":12,"context_line":"tooz to coordinate distributed locks"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ifdcc3004e4c3baa0bf6e75f0c0f045e1101d800a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5faad753_2a038575","line":12,"updated":"2019-09-10 18:51:41.000000000","message":"Please depends-on on the neutron patch for this functionality","commit_id":"b3fe991e6b1af666fed8a9eba679df8386bd548e"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"e8566170a910b97d12c405ed32a5a131c1d46f20","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Networking-ansible-ml2 now has a dependency on tooz in order to prevent"},{"line_number":10,"context_line":"parallel updates on switches that do not support them. This patch"},{"line_number":11,"context_line":"adds in the components required for the rediz backend used by"},{"line_number":12,"context_line":"tooz to coordinate distributed locks"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ifdcc3004e4c3baa0bf6e75f0c0f045e1101d800a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5faad753_573540f6","line":12,"in_reply_to":"5faad753_2a038575","updated":"2019-09-11 09:12:59.000000000","message":"The net-ansible patch isn\u0027t quite ready yet, and because the release is coming up I was hoping to get the config into tripleo so we have it for 16. net-ansible isn\u0027t on the standard release schedule so we can delay our release until it\u0027s ready.\n\nSo I was avoiding putting a depends on in there because I don\u0027t know if I\u0027ll have it done in time. If that\u0027s not an option let me know.","commit_id":"b3fe991e6b1af666fed8a9eba679df8386bd548e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"cee77c58392798320a0452562cffb908a0732a4b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Networking-ansible-ml2 now has a dependency on tooz in order to prevent"},{"line_number":10,"context_line":"parallel updates on switches that do not support them. This patch"},{"line_number":11,"context_line":"adds in the components required for the rediz backend used by"},{"line_number":12,"context_line":"tooz to coordinate distributed locks"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ifdcc3004e4c3baa0bf6e75f0c0f045e1101d800a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5faad753_9d4bd229","line":12,"in_reply_to":"5faad753_573540f6","updated":"2019-09-11 13:36:40.000000000","message":"The problem here is that because you\u0027re adding a new param and not using hieradata, it\u0027s abreaking change if the puppet-neutron code isn\u0027t in place for this. We can\u0027t land this without puppet-neutron","commit_id":"b3fe991e6b1af666fed8a9eba679df8386bd548e"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"85021b44484866b6b67039c5e965d878f0dcd71e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Networking-ansible-ml2 now has a dependency on tooz in order to prevent"},{"line_number":10,"context_line":"parallel updates on switches that do not support them. This patch"},{"line_number":11,"context_line":"adds in the components required for the rediz backend used by"},{"line_number":12,"context_line":"tooz to coordinate distributed locks"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ifdcc3004e4c3baa0bf6e75f0c0f045e1101d800a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5faad753_dd14ea50","line":12,"in_reply_to":"5faad753_9d4bd229","updated":"2019-09-11 13:59:59.000000000","message":"I can add a dep on the puppet-neutron patch, I thought you meant the patch that\u0027s using the coordination_uri so there can be an end to end test in CI or something.","commit_id":"b3fe991e6b1af666fed8a9eba679df8386bd548e"}],"manifests/profile/base/neutron/plugins/ml2/networking_ansible.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"12f9e5fbac6f5da18d707301f83d49159b01e2f1","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":55,"context_line":"    class { \u0027::neutron::plugins::ml2::networking_ansible\u0027:"},{"line_number":56,"context_line":"      coordination_url \u003d\u003e join([\u0027redis://:\u0027, $neutron_redis_password, \u0027@\u0027, normalize_ip_for_uri($redis_vip), \u0027:6379/\u0027, $tls_query_param])"},{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5faad753_1cf7add5","line":56,"updated":"2019-09-13 14:34:25.000000000","message":"is this port configurable or rather should it be?","commit_id":"a77d632492913b843d448d37cfc08d92d9871486"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"5ef2cbd117d44bd0ddcc0f6f3278fb7609a193dc","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":55,"context_line":"    class { \u0027::neutron::plugins::ml2::networking_ansible\u0027:"},{"line_number":56,"context_line":"      coordination_url \u003d\u003e join([\u0027redis://:\u0027, $neutron_redis_password, \u0027@\u0027, normalize_ip_for_uri($redis_vip), \u0027:6379/\u0027, $tls_query_param])"},{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"5faad753_d39b4070","line":56,"in_reply_to":"5faad753_1cf7add5","updated":"2019-09-13 18:07:39.000000000","message":"It\u0027s not configurable in aodh, gnocchi, ceilometer or zaqar so probably not","commit_id":"a77d632492913b843d448d37cfc08d92d9871486"}]}