)]}'
{"manifests/profile/base/pacemaker/instance_ha.pp":[{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"be2c70dd2c707805377b83a9e22592b2c5912ab9","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  $project_domain        \u003d hiera(\u0027nova::keystone::authtoken::project_domain_name\u0027, \u0027Default\u0027),"},{"line_number":76,"context_line":"  $region_name           \u003d hiera(\u0027nova::keystone::authtoken::region_name\u0027, \u0027regionOne\u0027),"},{"line_number":77,"context_line":"  $no_shared_storage     \u003d hiera(\u0027tripleo::instanceha::no_shared_storage\u0027, true),"},{"line_number":78,"context_line":"  $evacuate_delay\t \u003d hiera(\u0027tripleo::instanceha::evacuate_delay\u0027, 0),"},{"line_number":79,"context_line":") {"},{"line_number":80,"context_line":"  if $step \u003e\u003d 2 {"},{"line_number":81,"context_line":"    class { \u0027::pacemaker::resource_defaults\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3fa7e38b_64ce3483","line":78,"range":{"start_line":78,"start_character":16,"end_line":78,"end_character":19},"updated":"2019-09-26 06:20:20.000000000","message":"YOU FILTHY TAB-USING DIRTMONGER!","commit_id":"0bb47d06990ad86dd5ce7a5637775ef68459918c"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"be2c70dd2c707805377b83a9e22592b2c5912ab9","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    pacemaker::resource::ocf { \u0027nova-evacuate\u0027:"},{"line_number":126,"context_line":"      ocf_agent_name  \u003d\u003e \u0027openstack:NovaEvacuate\u0027,"},{"line_number":127,"context_line":"      # lint:ignore:140chars"},{"line_number":128,"context_line":"      resource_params \u003d\u003e \"auth_url\u003d${keystone_endpoint_url} username\u003d${keystone_admin} password\u003d${keystone_password} user_domain\u003d${user_domain} project_domain\u003d${project_domain} tenant_name\u003d${keystone_admin} region_name\u003d${region_name} ${iha_no_shared_storage} evacuate_delay\u003d${evacuate_delay}\","},{"line_number":129,"context_line":"      # lint:endignore"},{"line_number":130,"context_line":"      tries           \u003d\u003e $pcs_tries,"},{"line_number":131,"context_line":"      location_rule   \u003d\u003e {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3fa7e38b_84b3300a","line":128,"range":{"start_line":128,"start_character":6,"end_line":128,"end_character":293},"updated":"2019-09-26 06:20:20.000000000","message":"I think that by always passing evacuate_delay you *have* to have an updated resource-agents on the host/container when running puppet. This puts a bit of a burden on us to land everything in a specific order. I suggest doing:\nif $evacuate_delay \u003e 0 {\n  $evacuate_param \u003d \" evacuate_delay\u003d${evacuate_delay}\"\n} else {\n  $evacuate_param \u003d \"\"\n}\n\nAnd then:\n      resource_params \u003d\u003e \"auth_url\u003d${keystone_endpoint_url} username\u003d${keystone_admin} password\u003d${keystone_password} user_domain\u003d${user_domain} project_domain\u003d${project_domain} tenant_name\u003d${keystone_admin} region_name\u003d${region_name} ${iha_no_shared_storage}${evacuate_param}\",\n\nTha way we can merge this patch whenever. And after the resource agent rpm is updated, an operator can set the hiera key and his delay.","commit_id":"0bb47d06990ad86dd5ce7a5637775ef68459918c"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"1bdef9c8a87853a29b160611f09f9cc09415f800","unresolved":false,"context_lines":[{"line_number":123,"context_line":"      $iha_no_shared_storage \u003d \u0027no_shared_storage\u003dfalse\u0027"},{"line_number":124,"context_line":"    }"},{"line_number":125,"context_line":"    if $evacuate_delay \u003e 0 {"},{"line_number":126,"context_line":"      $evacuate_param \u003d \"evacuate_delay\u003d${evacuate_delay}\""},{"line_number":127,"context_line":"    } else {"},{"line_number":128,"context_line":"      $evacuate_param \u003d \"\""},{"line_number":129,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3fa7e38b_c464c824","line":126,"range":{"start_line":126,"start_character":24,"end_line":126,"end_character":28},"updated":"2019-09-26 06:49:30.000000000","message":"add a space here","commit_id":"448bfa6c21525cb026e4036dfebe992f085e0667"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"1bdef9c8a87853a29b160611f09f9cc09415f800","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    pacemaker::resource::ocf { \u0027nova-evacuate\u0027:"},{"line_number":131,"context_line":"      ocf_agent_name  \u003d\u003e \u0027openstack:NovaEvacuate\u0027,"},{"line_number":132,"context_line":"      # lint:ignore:140chars"},{"line_number":133,"context_line":"      resource_params \u003d\u003e \"auth_url\u003d${keystone_endpoint_url} username\u003d${keystone_admin} password\u003d${keystone_password} user_domain\u003d${user_domain} project_domain\u003d${project_domain} tenant_name\u003d${keystone_admin} region_name\u003d${region_name} ${iha_no_shared_storage} ${evacuate_delay}\","},{"line_number":134,"context_line":"      # lint:endignore"},{"line_number":135,"context_line":"      tries           \u003d\u003e $pcs_tries,"},{"line_number":136,"context_line":"      location_rule   \u003d\u003e {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3fa7e38b_645e3445","line":133,"range":{"start_line":133,"start_character":258,"end_line":133,"end_character":262},"updated":"2019-09-26 06:49:30.000000000","message":"and remove it here.\n\nThis way unless you specify a value \u003e 0 the resource definition does certainly not change and you will not get spurious useless restarts (note:it\u0027s unlikely that pcs is so dumb to not filter the extra space, but best to be safe :)","commit_id":"448bfa6c21525cb026e4036dfebe992f085e0667"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"63d5b1790c669b0a176c558b82fb8f45ad09d731","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    pacemaker::resource::ocf { \u0027nova-evacuate\u0027:"},{"line_number":131,"context_line":"      ocf_agent_name  \u003d\u003e \u0027openstack:NovaEvacuate\u0027,"},{"line_number":132,"context_line":"      # lint:ignore:140chars"},{"line_number":133,"context_line":"      resource_params \u003d\u003e \"auth_url\u003d${keystone_endpoint_url} username\u003d${keystone_admin} password\u003d${keystone_password} user_domain\u003d${user_domain} project_domain\u003d${project_domain} tenant_name\u003d${keystone_admin} region_name\u003d${region_name} ${iha_no_shared_storage}${evacuate_delay}\","},{"line_number":134,"context_line":"      # lint:endignore"},{"line_number":135,"context_line":"      tries           \u003d\u003e $pcs_tries,"},{"line_number":136,"context_line":"      location_rule   \u003d\u003e {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3fa7e38b_3c52893c","line":133,"range":{"start_line":133,"start_character":260,"end_line":133,"end_character":274},"updated":"2019-09-26 14:22:04.000000000","message":"this prolly needs to be evacuate_param","commit_id":"e079c69297415ecdd7cfe36f9118ac17b6ef70af"}]}