)]}'
{"id":"openstack%2Fpuppet-tripleo~687375","triplet_id":"openstack%2Fpuppet-tripleo~master~I570b996fd8eca8b653c57b43155a6549ba6e5fae","project":"openstack/puppet-tripleo","branch":"master","hashtags":[],"change_id":"I570b996fd8eca8b653c57b43155a6549ba6e5fae","subject":"Load kernel modules before configuring sysctl settings.","status":"ABANDONED","created":"2019-10-08 18:15:43.000000000","updated":"2019-10-11 18:13:24.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0b7cc0ef595e509d7168aae2d49f4fa5cbd744e5","_number":687375,"virtual_id_number":687375,"owner":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"all":[{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"date":"2019-10-10 16:56:22.000000000","_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"tag":"autogenerated:zuul:check","value":1,"date":"2019-10-09 16:22:47.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-10-10 21:00:05.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"disliked":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":1,"date":"2019-10-11 14:00:38.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},{"value":-1,"date":"2019-10-11 13:59:44.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-09 16:22:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-10-10 21:00:05.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-10-11 13:59:44.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-10-11 14:00:38.000000000","updated_by":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"reviewer":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"state":"REVIEWER"}],"messages":[{"id":"e64139d1df57fa59eff0920e0686c974abef3fb2","author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"date":"2019-10-08 18:15:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0708694131a7f503609ababc6259a4c56f990c44","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-10-08 21:33:40.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/75/687375/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/85d6679/ : FAILURE in 1h 57m 00s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039 http://logs.rdoproject.org/75/687375/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039/1746d98/ : FAILURE in 3h 16m 27s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9bfd20dee3388528fcd9c4093a45ab44ff1859ab","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-08 21:53:58.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e875041fc2c14087ba10303236b4822a : SUCCESS in 4m 22s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/8a93b763ac74426491bc9d0b175dbbfa : SUCCESS in 3m 47s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/5019e63c68ed42319edebd1558b72aed : SUCCESS in 3m 48s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/afb91f0ad7184ebab9604f86a75f71cb : SUCCESS in 51m 09s\n- puppet-openstack-unit-6.0-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/0e05ff6cc53d410daa6b23a6c2e31470 : SUCCESS in 18m 56s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/ef5e3e327734470fa0f0dfa4295fd8a8 : SUCCESS in 22m 19s (non-voting)\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/e32e5823497e422ba5b4a163c20db0cf : SUCCESS in 2h 21m 07s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades https://zuul.opendev.org/t/openstack/build/e41d53748aa24ce4b61b71833d0106d1 : FAILURE in 2h 12m 00s (non-voting)\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/0e7b9388b56041b4a59bf180e873f2c6 : TIMED_OUT in 3h 27m 26s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/cb6a13d120624ba29a6d803eb46c41e6 : SUCCESS in 2h 26m 36s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/5bca6f7914eb47a4a31dadee14cb2e95 : SUCCESS in 2h 54m 24s (non-voting)\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/3625d1fe19944e3e84911d3ecccf85b1 : SUCCESS in 3h 15m 04s\n- tripleo-ci-centos-7-standalone-upgrade https://zuul.opendev.org/t/openstack/build/77177ff1cf454a788af61795c37f73a0 : FAILURE in 2h 03m 40s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"32d0ebf5ab45399b080d816d3ab8ae14a85a4d22","author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"date":"2019-10-09 13:25:08.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"d3df86b86d60b1f312f03fba103c88aa65f03990","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-09 16:22:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/15b5e88b818a4ccc9b429e70437fcc75 : SUCCESS in 5m 06s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/edf1794da43440f1b17cdb48cd451e24 : SUCCESS in 4m 38s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/8dd294d2ae5648c383ce75e3dbabedd7 : SUCCESS in 3m 56s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/f7a6158243f14fb8a74b1ab746447b69 : SUCCESS in 45m 34s\n- puppet-openstack-unit-6.0-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/99fe811c237d4a2594d8f12c08ef30b5 : SUCCESS in 21m 33s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9e454eb4e4b4422dae554ba891c6ada7 : SUCCESS in 17m 56s (non-voting)\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/8f01a6a233474290b444f34862995f42 : SUCCESS in 2h 16m 49s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades https://zuul.opendev.org/t/openstack/build/5003a1d58ba5401aadc478bf1c8be323 : FAILURE in 1h 48m 02s (non-voting)\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/9afe5be46e344e8c8f33fc50622b20e1 : SUCCESS in 2h 45m 00s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/8b5071bc0474424ebbd458e2bf7699da : SUCCESS in 2h 26m 15s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/b2bc2497889341429aeae7d75013178f : SUCCESS in 2h 51m 23s (non-voting)\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/53854afbe6cb4a0bbb63d5b965aba6f3 : SUCCESS in 2h 18m 58s\n- tripleo-ci-centos-7-standalone-upgrade https://zuul.opendev.org/t/openstack/build/307a5c478d004629a422e04c20d76e12 : FAILURE in 1h 59m 22s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"82961a1854aa62234933344b656e192fb48b7db3","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-10-09 16:49:11.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/75/687375/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/4c82c20/ : FAILURE in 1h 51m 11s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039 http://logs.rdoproject.org/75/687375/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039/3a22dba/ : FAILURE in 3h 22m 45s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8ac684fdb538f558d13e4be3cd42eaf867bc4a9b","author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"date":"2019-10-09 19:32:32.000000000","message":"Patch Set 1:\n\nThe one voting failure appears to be a false-positive. See http://logs.rdoproject.org/75/687375/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/4c82c20/logs/undercloud/home/zuul/overcloud_deploy.log.txt.gz and http://paste.openstack.org/show/782463/","accounts_in_message":[],"_revision_number":1},{"id":"ae13fdad4b25906c8ad3807b8416dcaf2585c3cb","author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"date":"2019-10-10 16:56:22.000000000","message":"Patch Set 1:\n\ncheck-rdo","accounts_in_message":[],"_revision_number":1},{"id":"e67f9ab6704b0538fa6784d7c1b303879e4c1541","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-10-10 21:00:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/75/687375/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/6af5c7e/ : SUCCESS in 3h 05m 14s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039 http://logs.rdoproject.org/75/687375/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039/bffe7f0/ : FAILURE in 1h 28m 32s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"81931a9cee980e047f9e4e353df2ff36b85d7506","author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"date":"2019-10-11 13:39:14.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"79f7495bbe194345c05d423a773351537cc87784","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-10-11 13:59:44.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f45fc761d3f74b6c8d2895aa01c22b1dae65209e","author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"date":"2019-10-11 14:00:38.000000000","message":"Patch Set 1: Code-Review+1\n\n16:58 \u003c@mwhahaha\u003e that should do nothing?\n16:59 \u003c marios|rover\u003e mwhahaha: it moves the exec load above the create_resources (i.e. reload before configure?)\n16:59 \u003c marios|rover\u003e mwhahaha: or we don\u0027t need that one?\n16:59 \u003c@mwhahaha\u003e shouldn\u0027t change anything","accounts_in_message":[],"_revision_number":1},{"id":"0b7cc0ef595e509d7168aae2d49f4fa5cbd744e5","author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"date":"2019-10-11 18:13:24.000000000","message":"Abandoned\n\nAs Alex has explained, the existing functionality actually works as we want it to. Kernel modules are loaded before configuring sysctl.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"bcbedabeb323fbd41c16008c1e831008bd7bd896","revisions":{"bcbedabeb323fbd41c16008c1e831008bd7bd896":{"kind":"REWORK","_number":1,"created":"2019-10-08 18:15:43.000000000","uploader":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"ref":"refs/changes/75/687375/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/75/687375/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/75/687375/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/75/687375/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/75/687375/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/75/687375/1"}}},"commit":{"parents":[{"commit":"4dee772a2b62534608dbd8c49ed17a2d399b5b3d","subject":"Merge \"Add support to configure token caching in keystone\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/4dee772a2b62534608dbd8c49ed17a2d399b5b3d"}]}],"author":{"name":"ekultails","email":"ekultails@gmail.com","date":"2019-10-08 18:14:57.000000000","tz":-240},"committer":{"name":"ekultails","email":"ekultails@gmail.com","date":"2019-10-08 18:14:57.000000000","tz":-240},"subject":"Load kernel modules before configuring sysctl settings.","message":"Load kernel modules before configuring sysctl settings.\n\nChange-Id: I570b996fd8eca8b653c57b43155a6549ba6e5fae\nRelated-Bug: #1843259\nSigned-off-by: ekultails \u003cekultails@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/bcbedabeb323fbd41c16008c1e831008bd7bd896"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/bcbedabeb323fbd41c16008c1e831008bd7bd896"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}