)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"df2b31d8eedbbc8e4f7ee64523d53bb21b41880c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the source affinity to access the grafana instance"},{"line_number":11,"context_line":"through the haproxy vip."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3c6e8dd2d4a48f5c63311d9c37181c2f26b595ea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_690afa79","line":13,"updated":"2019-12-02 15:56:35.000000000","message":"Closes-Bug: 1854337","commit_id":"17228680cf0f0869cfb24930c855ea2eb89416dc"}],"manifests/haproxy.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"e656c959bc4039717a922fd6fec2ad04f98b253e","unresolved":false,"context_lines":[{"line_number":1027,"context_line":"      public_ssl_port \u003d\u003e $ports[ceph_grafana_ssl_port],"},{"line_number":1028,"context_line":"      listen_options  \u003d\u003e merge($default_listen_options, {"},{"line_number":1029,"context_line":"        \u0027balance\u0027 \u003d\u003e \u0027source\u0027,"},{"line_number":1030,"context_line":"        \u0027timeout\u0027 \u003d\u003e [ \u0027tunnel 1h\u0027 ],"},{"line_number":1031,"context_line":"      }),"},{"line_number":1032,"context_line":"      service_network \u003d\u003e $ceph_grafana_network,"},{"line_number":1033,"context_line":"      member_options  \u003d\u003e union($haproxy_member_options, $internal_tls_member_options),"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3fa7e38b_d0a742a8","line":1030,"updated":"2019-11-27 11:55:16.000000000","message":"I am not sure if we customize this setting in grafana but it seems that by default it supposedly keeps sessions for 24h\n\nhttps://grafana.com/docs/installation/configuration/#session-life-time","commit_id":"3e2ca01e3b041300e4cc13db330790f7f9428947"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"d7bf08bb4c455624566a6007aab8a83a078a4a26","unresolved":false,"context_lines":[{"line_number":1027,"context_line":"      public_ssl_port \u003d\u003e $ports[ceph_grafana_ssl_port],"},{"line_number":1028,"context_line":"      listen_options  \u003d\u003e merge($default_listen_options, {"},{"line_number":1029,"context_line":"        \u0027balance\u0027 \u003d\u003e \u0027source\u0027,"},{"line_number":1030,"context_line":"        \u0027timeout\u0027 \u003d\u003e [ \u0027tunnel 24h\u0027 ],"},{"line_number":1031,"context_line":"      }),"},{"line_number":1032,"context_line":"      service_network \u003d\u003e $ceph_grafana_network,"},{"line_number":1033,"context_line":"      member_options  \u003d\u003e union($haproxy_member_options, $internal_tls_member_options),"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3fa7e38b_2b650b4a","line":1030,"range":{"start_line":1030,"start_character":31,"end_line":1030,"end_character":34},"updated":"2019-11-27 13:15:25.000000000","message":"Not totally sure about keeping this to 24h, it seems to be on removed options [1]\n@Giulio wdyt\n\nhttps://grafana.com/docs/installation/configuration/#removed-options","commit_id":"2bd25a88f0c69cc2a1167e7783a5cfbca8f75be0"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"57fc15d956f47b61555c76afb8e5cf3f4be0715d","unresolved":false,"context_lines":[{"line_number":1027,"context_line":"      public_ssl_port \u003d\u003e $ports[ceph_grafana_ssl_port],"},{"line_number":1028,"context_line":"      listen_options  \u003d\u003e merge($default_listen_options, {"},{"line_number":1029,"context_line":"        \u0027balance\u0027 \u003d\u003e \u0027source\u0027,"},{"line_number":1030,"context_line":"        \u0027timeout\u0027 \u003d\u003e [ \u0027tunnel 24h\u0027 ],"},{"line_number":1031,"context_line":"      }),"},{"line_number":1032,"context_line":"      service_network \u003d\u003e $ceph_grafana_network,"},{"line_number":1033,"context_line":"      member_options  \u003d\u003e union($haproxy_member_options, $internal_tls_member_options),"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3fa7e38b_5dd5aa46","line":1030,"range":{"start_line":1030,"start_character":31,"end_line":1030,"end_character":34},"in_reply_to":"3fa7e38b_2b650b4a","updated":"2019-11-27 13:48:08.000000000","message":"yeah but at the same time it looks like this has been increased even further, to something like 7 days\n\nconsidering we don\u0027t have strong reasons to go with a specific value, maybe we should remove it and stick with the default?\n\n1. https://github.com/grafana/grafana/blob/master/conf/defaults.ini#L276","commit_id":"2bd25a88f0c69cc2a1167e7783a5cfbca8f75be0"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"e83c8a502ddc303903718612e09b22f85ff0d86a","unresolved":false,"context_lines":[{"line_number":1027,"context_line":"      public_ssl_port \u003d\u003e $ports[ceph_grafana_ssl_port],"},{"line_number":1028,"context_line":"      listen_options  \u003d\u003e merge($default_listen_options, {"},{"line_number":1029,"context_line":"        \u0027balance\u0027 \u003d\u003e \u0027source\u0027,"},{"line_number":1030,"context_line":"        \u0027timeout\u0027 \u003d\u003e [ \u0027tunnel 24h\u0027 ],"},{"line_number":1031,"context_line":"      }),"},{"line_number":1032,"context_line":"      service_network \u003d\u003e $ceph_grafana_network,"},{"line_number":1033,"context_line":"      member_options  \u003d\u003e union($haproxy_member_options, $internal_tls_member_options),"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3fa7e38b_1db8920f","line":1030,"range":{"start_line":1030,"start_character":31,"end_line":1030,"end_character":34},"in_reply_to":"3fa7e38b_5dd5aa46","updated":"2019-11-27 13:51:20.000000000","message":"+1, thanks for checking that.\nI agree w/ you, we can  just remove this value right now and re-introduce it if any timeout issue will occur","commit_id":"2bd25a88f0c69cc2a1167e7783a5cfbca8f75be0"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"99669c309015f4349acfd8c25b1994922444f793","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"      server_names    \u003d\u003e hiera(\u0027ceph_grafana_node_names\u0027, $controller_hosts_names_real),"},{"line_number":1026,"context_line":"      mode            \u003d\u003e \u0027http\u0027,"},{"line_number":1027,"context_line":"      public_ssl_port \u003d\u003e $ports[ceph_grafana_ssl_port],"},{"line_number":1028,"context_line":"      listen_options  \u003d\u003e merge($default_listen_options, { \u0027option\u0027 \u003d\u003e [ \u0027httpchk HEAD /\u0027 ] }),"},{"line_number":1029,"context_line":"      service_network \u003d\u003e $ceph_grafana_network,"},{"line_number":1030,"context_line":"      member_options  \u003d\u003e union($haproxy_member_options, $internal_tls_member_options),"},{"line_number":1031,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3fa7e38b_d661493a","side":"PARENT","line":1028,"range":{"start_line":1028,"start_character":58,"end_line":1028,"end_character":90},"updated":"2019-12-02 15:18:29.000000000","message":"please clarify the need for removal of httpchk?","commit_id":"4d623490c244c989d26b1c9844f0c2e209c04710"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"7932e21cbafc172bdca37d4e2cf52f14c918ef51","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"      server_names    \u003d\u003e hiera(\u0027ceph_grafana_node_names\u0027, $controller_hosts_names_real),"},{"line_number":1026,"context_line":"      mode            \u003d\u003e \u0027http\u0027,"},{"line_number":1027,"context_line":"      public_ssl_port \u003d\u003e $ports[ceph_grafana_ssl_port],"},{"line_number":1028,"context_line":"      listen_options  \u003d\u003e merge($default_listen_options, { \u0027option\u0027 \u003d\u003e [ \u0027httpchk HEAD /\u0027 ] }),"},{"line_number":1029,"context_line":"      service_network \u003d\u003e $ceph_grafana_network,"},{"line_number":1030,"context_line":"      member_options  \u003d\u003e union($haproxy_member_options, $internal_tls_member_options),"},{"line_number":1031,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3fa7e38b_c9752e99","side":"PARENT","line":1028,"range":{"start_line":1028,"start_character":58,"end_line":1028,"end_character":90},"in_reply_to":"3fa7e38b_d661493a","updated":"2019-12-02 15:32:43.000000000","message":"I agree this is unrelated but httpchk is enabled by default on line 859\n\nThe different is we\u0027ll be doing OPTIONS instead of HEAD but I am not sure there was a reason to do HEAD here so I am fine with the default choice","commit_id":"4d623490c244c989d26b1c9844f0c2e209c04710"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"e98101cfa1c105661f8505ffa640b5a5abdc4001","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"      server_names    \u003d\u003e hiera(\u0027ceph_grafana_node_names\u0027, $controller_hosts_names_real),"},{"line_number":1026,"context_line":"      mode            \u003d\u003e \u0027http\u0027,"},{"line_number":1027,"context_line":"      public_ssl_port \u003d\u003e $ports[ceph_grafana_ssl_port],"},{"line_number":1028,"context_line":"      listen_options  \u003d\u003e merge($default_listen_options, { \u0027option\u0027 \u003d\u003e [ \u0027httpchk HEAD /\u0027 ] }),"},{"line_number":1029,"context_line":"      service_network \u003d\u003e $ceph_grafana_network,"},{"line_number":1030,"context_line":"      member_options  \u003d\u003e union($haproxy_member_options, $internal_tls_member_options),"},{"line_number":1031,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3fa7e38b_a9e55240","side":"PARENT","line":1028,"range":{"start_line":1028,"start_character":58,"end_line":1028,"end_character":90},"in_reply_to":"3fa7e38b_d661493a","updated":"2019-12-02 15:34:57.000000000","message":"not sure httpchk (with HEAD) ensure the grafana application is alive, but at least it doesn\u0027t hurt.","commit_id":"4d623490c244c989d26b1c9844f0c2e209c04710"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"bd1dee1c7833088afbc47c4900bb79fe37585fa0","unresolved":false,"context_lines":[{"line_number":1026,"context_line":"      mode            \u003d\u003e \u0027http\u0027,"},{"line_number":1027,"context_line":"      public_ssl_port \u003d\u003e $ports[ceph_grafana_ssl_port],"},{"line_number":1028,"context_line":"      listen_options  \u003d\u003e merge($default_listen_options, {"},{"line_number":1029,"context_line":"        \u0027option\u0027 \u003d\u003e [ \u0027httpchk HEAD /\u0027 ],"},{"line_number":1030,"context_line":"        \u0027balance\u0027 \u003d\u003e \u0027source\u0027,"},{"line_number":1031,"context_line":"      }),"},{"line_number":1032,"context_line":"      service_network \u003d\u003e $ceph_grafana_network,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3fa7e38b_89409608","line":1029,"range":{"start_line":1029,"start_character":8,"end_line":1029,"end_character":41},"updated":"2019-12-02 15:37:22.000000000","message":"@bogdando thanks for reviewing the last PS; do you think we have a better way to build this check?","commit_id":"17228680cf0f0869cfb24930c855ea2eb89416dc"}]}