)]}'
{"id":"openstack%2Fpuppet-tripleo~696633","triplet_id":"openstack%2Fpuppet-tripleo~master~I5c397d31650b248660a39e028c98c779871d07ba","project":"openstack/puppet-tripleo","branch":"master","topic":"bug/1854399","hashtags":[],"change_id":"I5c397d31650b248660a39e028c98c779871d07ba","subject":"Remove haproxy ironic-inspector http-check workaround","status":"MERGED","created":"2019-11-29 01:12:21.000000000","updated":"2019-12-02 22:14:58.000000000","submitted":"2019-12-02 22:14:58.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"696633-1575324898258-c826a830","meta_rev_id":"1ffd7024f1e419966f4ef63c2dde50b55cab3c78","_number":696633,"virtual_id_number":696633,"owner":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-12-02 22:14:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-11-29 04:10:31.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"date":"2019-12-01 21:22:54.000000000","_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":2,"date":"2019-12-02 01:48:18.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":2,"date":"2019-12-02 15:56:54.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"date":"2019-12-01 21:23:15.000000000","_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":1,"date":"2019-12-02 15:56:54.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-11-29 04:10:31.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-12-01 21:23:15.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2019-12-02 01:48:18.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-12-02 15:56:54.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-12-02 22:14:58.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f2ce9fb84e9fc5313c459e13c04afa9e3ac2ba15","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2019-11-29 01:12:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"619a5840df74710abb90e96b83d311fc64346001","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-11-29 03:42:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/765bd2d8848f4e008ad6359a5eee5f45 : SUCCESS in 3m 56s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/1cdd331995ca4566a5f4e97465f35650 : SUCCESS in 3m 32s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/483904c429c0470b9bcc82e752f45f9f : SUCCESS in 5m 50s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/75030ec18e6e46edb28be370e80adf81 : SUCCESS in 42m 42s\n- puppet-openstack-unit-6.0-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9837759af6ca40bd89f22848c020518a : SUCCESS in 18m 58s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f483bccb1ea042b18fa9941c2732c187 : SUCCESS in 20m 08s (non-voting)\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/eb1e330c1eb84e899650495de51ba6d8 : SUCCESS in 1h 45m 35s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades https://zuul.opendev.org/t/openstack/build/32f82c1787e54cc0982ca7a8d2b48fb8 : FAILURE in 2h 08m 51s (non-voting)\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/c5fc221656374300805848639e0ee664 : SUCCESS in 2h 25m 27s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/6f3b5cb883bb4f5b9b11cc6d3b5021ac : SUCCESS in 2h 11m 46s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/7727eedd6e77431c8540bb738ded1592 : SUCCESS in 2h 10m 45s (non-voting)\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/1f3373e256d04d0ab37f20d79ad1e7e5 : SUCCESS in 2h 11m 06s\n- tripleo-ci-centos-7-standalone-upgrade https://zuul.opendev.org/t/openstack/build/c4cdba7281cc47c59ebb3f3167b2b057 : SUCCESS in 2h 24m 11s (non-voting)\n- tripleo-ci-centos-7-scenario001-standalone https://zuul.opendev.org/t/openstack/build/1ef072856d0f4a5f92a57058150a7658 : SUCCESS in 2h 01m 01s\n- tripleo-ci-centos-7-scenario003-standalone https://zuul.opendev.org/t/openstack/build/5d4da355b546409bac85732ad7c1f22d : SUCCESS in 1h 25m 20s\n- tripleo-ci-centos-7-scenario004-standalone https://zuul.opendev.org/t/openstack/build/1f4912384dbe4c9a86b848d18a5bec1f : SUCCESS in 2h 06m 24s\n- tripleo-ci-centos-7-scenario012-standalone https://zuul.opendev.org/t/openstack/build/7f34d97c2ec144a3a7a155cbc59c5e83 : FAILURE in 1h 27m 54s (non-voting)\n- tripleo-ci-centos-7-scenario007-standalone https://zuul.opendev.org/t/openstack/build/bee1545a9c914c81ba7038210ae05d78 : SUCCESS in 1h 13m 30s","accounts_in_message":[],"_revision_number":1},{"id":"6a4504dc8fb7b9792c8bf1657cd68b202c76a7a7","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-11-29 04:10:31.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/33/696633/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/08cb5e0/ : SUCCESS in 2h 36m 45s\n- tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039 http://logs.rdoproject.org/33/696633/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp_1supp-featureset039/ea66557/ : SUCCESS in 2h 56m 32s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f19d77e4ae5f0f919c4b68c76271ad7c59eb0e94","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2019-12-01 21:22:54.000000000","message":"Patch Set 1:\n\nHere is a clean ironic-inspector log:\nhttp://logs.rdoproject.org/33/696633/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/08cb5e0/logs/undercloud/var/log/containers/ironic-inspector/ironic-inspector.log.txt.gz\n\nAnd an haproxy log which logs GET /v1/introspection calls:\nhttp://logs.rdoproject.org/33/696633/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/08cb5e0/logs/undercloud/var/log/containers/haproxy/haproxy.log.txt.gz","accounts_in_message":[],"_revision_number":1},{"id":"ef3b206234fd38ac78170b1ef2af36b92829203d","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-12-02 01:48:18.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"0294cea1331305d8e78968ad8ca0e1da50f90525","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-12-02 15:56:54.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"10602580aa6fdced8ef3e4c4e3b42b99c1b92a25","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-02 15:58:58.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"e9668b2aa49f8b126825722e50b6d00f79ac6dc5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-02 22:14:58.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/8b994acd2dd84d8aa6a5d2aefe244cd0 : SUCCESS in 5m 19s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/35c59baa53de4ee7b5584e4d66417493 : SUCCESS in 4m 45s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/3bc61a4a2bdd4edda3986b344e8612de : SUCCESS in 6m 09s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/b6a7ab6485e548179904e329ecb7f6bd : SUCCESS in 45m 28s\n- puppet-openstack-unit-6.0-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/98f68fa671d741fc9a20e962f9aeaefa : SUCCESS in 20m 14s\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/4021cb8acecd4c81a0b699be6e3e73af : SUCCESS in 2h 42m 04s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/2902f59c45ef4e708a967229225875c7 : SUCCESS in 2h 31m 34s\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/23e43cce68e1412ea7baee0ba1c9d1d0 : SUCCESS in 2h 07m 21s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/fd2ea62b9c6e4b17a9094803c19ebd55 : SUCCESS in 2h 22m 47s\n- tripleo-ci-centos-7-scenario001-standalone https://zuul.opendev.org/t/openstack/build/255bc5e070f84cfeae3632f9b0f04483 : SUCCESS in 1h 56m 43s\n- tripleo-ci-centos-7-scenario003-standalone https://zuul.opendev.org/t/openstack/build/5e752c7ffe834661980c4a6bb99080f8 : SUCCESS in 1h 27m 32s\n- tripleo-ci-centos-7-scenario004-standalone https://zuul.opendev.org/t/openstack/build/8d6c120de9cd479a84525bcab9a8b8c5 : SUCCESS in 2h 05m 33s\n- tripleo-ci-centos-7-scenario007-standalone https://zuul.opendev.org/t/openstack/build/b3fcd95ce38e4fe4a6c5aee22babad20 : SUCCESS in 1h 31m 52s","accounts_in_message":[],"_revision_number":1},{"id":"8094994c5263e1b22297015a3d503f6b12df07b3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-02 22:14:58.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"71abeb12c4d8106693f0ade7e1252a00cee0ed56","revisions":{"71abeb12c4d8106693f0ade7e1252a00cee0ed56":{"kind":"REWORK","_number":1,"created":"2019-11-29 01:12:21.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/33/696633/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/33/696633/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/33/696633/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/33/696633/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/33/696633/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/33/696633/1"}}},"commit":{"parents":[{"commit":"3991edcae0b6c80c9e3a05ea51ea7c2708233931","subject":"Explicitly convert stonith_level fact to int","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/3991edcae0b6c80c9e3a05ea51ea7c2708233931"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2019-11-29 01:01:41.000000000","tz":0},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2019-11-29 01:12:15.000000000","tz":0},"subject":"Remove haproxy ironic-inspector http-check workaround","message":"Remove haproxy ironic-inspector http-check workaround\n\nWhen werkzeug was used as the WSGI service for ironic-inspector, it\nwrote stack traces to the logs whenever haproxy did a http check; this\nlisten_options line was the workaround for that. Reverting that change\nis done for the following reasons:\n\n- since ironic-inspector now uses oslo-service, the log stack traces\n  are no longer written\n- setting listen_options overrides the default \u0027option httplog\u0027, which is\n  making diagnosing bug #1854399 harder\n- this http-check override may well be the root cause of bug #1854399\n  (any non-200 response will result in other connections to\n  ironic-inspector being disconnected?)\n\nChange-Id: I5c397d31650b248660a39e028c98c779871d07ba\nPartial-Bug: #1854399\nRelated-Bug: #1691971\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/71abeb12c4d8106693f0ade7e1252a00cee0ed56"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/71abeb12c4d8106693f0ade7e1252a00cee0ed56"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}