)]}'
{"id":"openstack%2Fpuppet-tripleo~720656","triplet_id":"openstack%2Fpuppet-tripleo~stable%2Ftrain~I985d0d192ef3accf7fdd31503348de80713fded4","project":"openstack/puppet-tripleo","branch":"stable/train","topic":"ha-container_logging_train","hashtags":[],"change_id":"I985d0d192ef3accf7fdd31503348de80713fded4","subject":"Make the bundle user configurable via hiera","status":"MERGED","created":"2020-04-17 08:10:21.000000000","updated":"2020-04-18 04:48:12.000000000","submitted":"2020-04-18 04:48:11.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"720656-1587185292017-d9ca7e03","meta_rev_id":"423ba5262e4d55c516b8f9e9710b1bdd5d6a4d5f","_number":720656,"virtual_id_number":720656,"owner":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-04-18 04:48:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-04-17 11:02:16.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2020-04-17 12:25:08.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2020-04-17 12:25:08.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-04-17 11:02:16.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-04-17 12:25:08.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2020-04-18 04:48:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"14df292951e995cb090a135a87c2bea2ba7735f1","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2020-04-17 08:10:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d919a836232c36e06f80078b441b70efa535e45a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-17 10:54:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/8e643e8936c44811abcf93543e567d11 : SUCCESS in 5m 11s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/62100e79693745bb86ba486759bdf3b3 : SUCCESS in 5m 51s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/070ab602c2e64b92adf58333341f1b80 : SUCCESS in 6m 00s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/96ed61c2552e4630bc2eb1b757b0c4c1 : SUCCESS in 38m 42s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/6702811215ca4b649dc099833029b91f : SUCCESS in 28m 12s (non-voting)\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/4f4890d32f44412c9e56de3da314e1bf : SUCCESS in 1h 50m 55s\n- tripleo-ci-centos-7-containers-undercloud-minion https://zuul.opendev.org/t/openstack/build/9ac9fbc422784bcf9dab96d1233bbc69 : SUCCESS in 1h 42m 15s\n- tripleo-ci-centos-7-containerized-undercloud-upgrades https://zuul.opendev.org/t/openstack/build/0768096f541a42bb897dacc68b9a04df : SUCCESS in 2h 40m 52s (non-voting)\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/698eed963aea48e690bdcef36e746c01 : SUCCESS in 2h 28m 13s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/38dc5738b484446d8a8aaa1a420ae023 : SUCCESS in 1h 50m 12s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/76c3529973cb4030ac22a0a8dc22849c : SUCCESS in 1h 59m 11s (non-voting)\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/b0f891cc03824e09a70f04a20d9ab6e0 : SUCCESS in 2h 05m 45s\n- tripleo-ci-centos-7-standalone-upgrade-train https://zuul.opendev.org/t/openstack/build/d75a5e712ed74ca8b4ffa01f92b0e009 : SUCCESS in 2h 33m 43s (non-voting)\n- tripleo-ci-centos-7-scenario001-standalone https://zuul.opendev.org/t/openstack/build/467d27376c98489a8582eb89793f47d2 : SUCCESS in 1h 45m 45s\n- tripleo-ci-centos-7-scenario002-standalone https://zuul.opendev.org/t/openstack/build/3831f04cb36f46f0888c2d99f04bf850 : SUCCESS in 2h 13m 23s\n- tripleo-ci-centos-7-scenario004-standalone https://zuul.opendev.org/t/openstack/build/142f4e480e224a5e8dc68a16e30d8677 : SUCCESS in 2h 30m 43s\n- tripleo-ci-centos-7-scenario007-multinode-oooq-container https://zuul.opendev.org/t/openstack/build/f98d487c39ab49eca92d447e714fe6e6 : SUCCESS in 2h 29m 39s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"44a326e5f5003bc7c819f9ce39bfc9a6042620f9","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2020-04-17 11:02:16.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/71d71df6b44046139ce5a4d5510d3905 : SUCCESS in 2h 49m 44s","accounts_in_message":[],"_revision_number":1},{"id":"117ac1e76dbfcc78dec40df3337989cb36eb19da","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2020-04-17 12:25:08.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"443fd3a28297287fdec5a369d03142f53ea58ba7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-17 13:48:18.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"520683a5ee1546187ab75996cf0dd3841d0aa09b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-18 04:48:11.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/6e9c8c4aee0c4eb1bca2af729ebe27c6 : SUCCESS in 5m 28s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/23b21b667bf6471ea1b72931386a6226 : SUCCESS in 6m 34s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/a640d4d05965441ba0542bff1efc066d : SUCCESS in 4m 36s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/bb5f02dc36b346108f3f70fdf04150d1 : SUCCESS in 41m 39s\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/db15d9e19de54f198fa9cf92cc1fffec : SUCCESS in 1h 50m 28s\n- tripleo-ci-centos-7-containers-undercloud-minion https://zuul.opendev.org/t/openstack/build/a30e77cc3ae44e9d9c5f81402b622487 : SUCCESS in 1h 27m 06s\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/49fb9437b61c43b9a596df82430550e1 : SUCCESS in 2h 57m 41s\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/2e2b4e10519b496a81a056ad26c9d630 : SUCCESS in 1h 28m 41s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/c66804a7af07495985ed32ef02af514f : SUCCESS in 2h 03m 24s\n- tripleo-ci-centos-7-standalone-upgrade-train https://zuul.opendev.org/t/openstack/build/7f9bfeb381794b20b13356c2c8efb8e9 : FAILURE in 1h 30m 07s (non-voting)\n- tripleo-ci-centos-7-scenario001-standalone https://zuul.opendev.org/t/openstack/build/b735e410cb43449fa4ba38b3908344b7 : SUCCESS in 1h 49m 35s\n- tripleo-ci-centos-7-scenario002-standalone https://zuul.opendev.org/t/openstack/build/db839c3eea1e4464827d815da420d74c : SUCCESS in 1h 31m 48s\n- tripleo-ci-centos-7-scenario004-standalone https://zuul.opendev.org/t/openstack/build/8b3edf4651884a67a301a058cc2ee762 : SUCCESS in 1h 43m 05s","accounts_in_message":[],"_revision_number":1},{"id":"27fb4c5f6f1057f409a8b40375b99b41b643ab41","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-18 04:48:12.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1d09aa68faec603463faab62011154354d66a142","revisions":{"1d09aa68faec603463faab62011154354d66a142":{"kind":"REWORK","_number":1,"created":"2020-04-17 08:10:21.000000000","uploader":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"ref":"refs/changes/56/720656/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/56/720656/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/56/720656/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/56/720656/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/56/720656/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/56/720656/1"}}},"commit":{"parents":[{"commit":"67e9708b2060500ddfdf3705e9e406c66d2c27fd","subject":"Enable deployment with external loadbalancers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/67e9708b2060500ddfdf3705e9e406c66d2c27fd"}]}],"author":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2019-12-19 07:48:23.000000000","tz":60},"committer":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2020-04-17 08:06:40.000000000","tz":120},"subject":"Make the bundle user configurable via hiera","message":"Make the bundle user configurable via hiera\n\nAllow all bundles --user option to be overridden as some of them might\nprefer switching to a non-root user when possible.\nThe ovn-dbs bundle is a bit special because it never specified any user.\nHence we default that user to undef and do not set anything.\n\nTested as follows:\n1. deployed an overcloud\n2. patched it with this change\n3. redeployed and and then observed that no HA container has restarted at all\n4. verified cinder-volume runs with root by default:\nUSER  PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND\nroot    1  0.0  0.0   4204   716 ?        Ss   09:01   0:00 dumb-init --single-child -- /bin/bash /usr/local/bin/kolla_start\nroot    7  0.7  0.7 912976 145760 ?       S    09:01   1:04 /usr/bin/python3 /usr/bin/cinder-volume --config-file /usr/share/cinder/cinder-dist.conf --config-file /etc/cinder/cinder.conf\nroot   71  0.1  0.6 925800 124640 ?       S    09:01   0:14 /usr/bin/python3 /usr/bin/cinder-volume --config-file /usr/share/cinder/cinder-dist.conf --config-file /etc/cinder/cinder.conf\n5. added \u0027tripleo::profile::pacemaker::cinder::volume_bundle::bundle_user: cinder\u0027 to\n   the templates and redeployed\n6. Observed that cinder-volume got restarted and now runs with cinder\n   user:\nUSER   PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND\ncinder   1  0.0  0.0   4204   804 ?        Ss   12:23   0:00 dumb-init --single-child -- /bin/bash /usr/local/bin/kolla_start\ncinder   7  2.1  0.7 912976 145432 ?       S    12:23   0:04 /usr/bin/python3 /usr/bin/cinder-volume --config-file /usr/share/cinder/cinder-dist.conf --config-file /etc/cinder/cinder.conf\ncinder  64  0.3  0.5 919908 118452 ?       S    12:23   0:00 /usr/bin/python3 /usr/bin/cinder-volume --config-file /usr/share/cinder/cinder-dist.conf --config-file /etc/cinder/cinder.conf\n\nChange-Id: I985d0d192ef3accf7fdd31503348de80713fded4\n(cherry picked from commit d766eb81a3eb1864aa9c6d4b3b4d5fb978282219)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/1d09aa68faec603463faab62011154354d66a142"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/1d09aa68faec603463faab62011154354d66a142"}]},"parents_data":[{"branch_name":"refs/heads/stable/train","commit_id":"67e9708b2060500ddfdf3705e9e406c66d2c27fd","is_merged_in_target_branch":false,"change_id":"I4833418c68f866a216d837e624199159ace7f696","change_number":720655,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}