)]}'
{"manifests/profile/base/swift/proxy.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ec56c25506b2ba76766d0817ba8b8d5eceb7026a","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    include swift::keymaster"},{"line_number":185,"context_line":"    include swift::proxy::s3api"},{"line_number":186,"context_line":"    include swift::proxy::s3token"},{"line_number":187,"context_line":"    include tripleo::profile::base::swift"},{"line_number":188,"context_line":"  }"},{"line_number":189,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9f560f44_cba7500b","line":187,"updated":"2020-08-17 15:28:42.000000000","message":"same comment as I did for storage class.","commit_id":"c3c72953375abafab16b281aaa3e73d90ac89708"}],"manifests/profile/base/swift/storage.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0e3e2767c0b40e129176d589939d524c325bc2e0","unresolved":false,"context_lines":[{"line_number":73,"context_line":"          require \u003d\u003e Package[\u0027swift\u0027],"},{"line_number":74,"context_line":"        })"},{"line_number":75,"context_line":"      }"},{"line_number":76,"context_line":"      class { \u0027::swift::objectexpirer\u0027:"},{"line_number":77,"context_line":"        pipeline         \u003d\u003e [\u0027catch_errors\u0027, \u0027cache\u0027, \u0027proxy-server\u0027],"},{"line_number":78,"context_line":"        memcache_servers \u003d\u003e $swift_memcache_servers"},{"line_number":79,"context_line":"      }"},{"line_number":80,"context_line":"    }"},{"line_number":81,"context_line":"  }"},{"line_number":82,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9f560f44_29e522a9","line":79,"range":{"start_line":76,"start_character":0,"end_line":79,"end_character":7},"updated":"2020-07-30 16:51:05.000000000","message":"since the class is already defined in the proxy manifest, it\u0027ll fail on a deployment where both services are collocated.\n\nYou should move it to base swift.pp for common bits.","commit_id":"b5e85369ea32d6d6d83566dc6618af37b5bc4b08"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@redhat.com","username":"cschwede"},"change_message_id":"8d8e98ef7511f9208b9be620cf75c269944c70b3","unresolved":false,"context_lines":[{"line_number":73,"context_line":"          require \u003d\u003e Package[\u0027swift\u0027],"},{"line_number":74,"context_line":"        })"},{"line_number":75,"context_line":"      }"},{"line_number":76,"context_line":"      class { \u0027::swift::objectexpirer\u0027:"},{"line_number":77,"context_line":"        pipeline         \u003d\u003e [\u0027catch_errors\u0027, \u0027cache\u0027, \u0027proxy-server\u0027],"},{"line_number":78,"context_line":"        memcache_servers \u003d\u003e $swift_memcache_servers"},{"line_number":79,"context_line":"      }"},{"line_number":80,"context_line":"    }"},{"line_number":81,"context_line":"  }"},{"line_number":82,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9f560f44_db1c2714","line":79,"range":{"start_line":76,"start_character":0,"end_line":79,"end_character":7},"in_reply_to":"9f560f44_29e522a9","updated":"2020-07-30 19:05:18.000000000","message":"Thx Emilien for the quick review! I just fixed that.","commit_id":"b5e85369ea32d6d6d83566dc6618af37b5bc4b08"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ec56c25506b2ba76766d0817ba8b8d5eceb7026a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"          require \u003d\u003e Package[\u0027swift\u0027],"},{"line_number":69,"context_line":"        })"},{"line_number":70,"context_line":"      }"},{"line_number":71,"context_line":"      include tripleo::profile::base::swift"},{"line_number":72,"context_line":"    }"},{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9f560f44_2baecce6","line":71,"updated":"2020-08-17 15:28:42.000000000","message":"nit: since this class is calling the swift module at the right steps already, we don\u0027t need to put it in this step block.\nIf one day someone reduces the step requirements in the swift base class, it will require a change in that file; which could be avoided if that line was moved before L45.","commit_id":"c3c72953375abafab16b281aaa3e73d90ac89708"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"1628fe5946a0a5a26dbe3c30b185992cafcebbb1","unresolved":false,"context_lines":[{"line_number":68,"context_line":"          require \u003d\u003e Package[\u0027swift\u0027],"},{"line_number":69,"context_line":"        })"},{"line_number":70,"context_line":"      }"},{"line_number":71,"context_line":"      include tripleo::profile::base::swift"},{"line_number":72,"context_line":"    }"},{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9f560f44_8b8c3836","line":71,"in_reply_to":"9f560f44_2baecce6","updated":"2020-08-17 15:40:58.000000000","message":"By all means. I left it where Christian put it, after you asked him to separate this into a class. Honestly I have no clue what I\u0027m doing here.","commit_id":"c3c72953375abafab16b281aaa3e73d90ac89708"}]}