)]}'
{"manifests/profile/base/metrics/collectd.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"484a9d6e219780a70a98410b3307231b76c57898","unresolved":false,"context_lines":[{"line_number":218,"context_line":"#  (Optional) Boolean. Set to true if the collectd libpodstats plugin should be"},{"line_number":219,"context_line":"#  loaded"},{"line_number":220,"context_line":"#  Defaults to false."},{"line_number":221,"context_line":"#  "},{"line_number":222,"context_line":"class tripleo::profile::base::metrics::collectd ("},{"line_number":223,"context_line":"  $step \u003d Integer(hiera(\u0027step\u0027)),"},{"line_number":224,"context_line":"  $enable_file_logging \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9f560f44_c15bb183","line":221,"updated":"2020-10-02 14:16:17.000000000","message":"please clean up the trailing space","commit_id":"fe4c89179bbdbbb2c43dbb8013f6064e45e04739"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"484a9d6e219780a70a98410b3307231b76c57898","unresolved":false,"context_lines":[{"line_number":268,"context_line":") {"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":271,"context_line":"    case $enable_libpodstats {"},{"line_number":272,"context_line":"      true: {"},{"line_number":273,"context_line":"        $db \u003d \u0027/usr/share/collectd/types.db.libpodstats\u0027"},{"line_number":274,"context_line":"        include tripleo::profile::base::metrics::collectd::libpodstats"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9f560f44_21526d69","line":271,"updated":"2020-10-02 14:16:17.000000000","message":"Why a case and not just an if statement?","commit_id":"fe4c89179bbdbbb2c43dbb8013f6064e45e04739"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5f4f2c1f90f067a7856c79373c0f96587db81f22","unresolved":false,"context_lines":[{"line_number":268,"context_line":") {"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":271,"context_line":"    case $enable_libpodstats {"},{"line_number":272,"context_line":"      true: {"},{"line_number":273,"context_line":"        $db \u003d \u0027/usr/share/collectd/types.db.libpodstats\u0027"},{"line_number":274,"context_line":"        include tripleo::profile::base::metrics::collectd::libpodstats"},{"line_number":275,"context_line":"      }"},{"line_number":276,"context_line":"      default: {"},{"line_number":277,"context_line":"        $db \u003d \u0027\u0027"},{"line_number":278,"context_line":"      }"},{"line_number":279,"context_line":"    }"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    class {\u0027collectd\u0027:"},{"line_number":282,"context_line":"      manage_repo \u003d\u003e $collectd_manage_repo,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9f560f44_52d2cdfe","line":279,"range":{"start_line":271,"start_character":0,"end_line":279,"end_character":5},"updated":"2020-10-02 16:34:39.000000000","message":"I get the whole not duplicating vars, but this is the same as\n\nif $enable_libpodstats {\n  $db \u003d \u0027foo\u0027\n  include stuff\n} else {\n  $db \u003d \u0027\u0027\n}\n\nI don\u0027t get the usage of case vs if/else","commit_id":"3469501dcfa838267ff7d6c7d3f164c8fb5fa10d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5fd4866def73b3db81c3a7cced308308c1815cc0","unresolved":false,"context_lines":[{"line_number":268,"context_line":") {"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"  if $step \u003e\u003d 3 {"},{"line_number":271,"context_line":"    case $enable_libpodstats {"},{"line_number":272,"context_line":"      true: {"},{"line_number":273,"context_line":"        $db \u003d \u0027/usr/share/collectd/types.db.libpodstats\u0027"},{"line_number":274,"context_line":"        include tripleo::profile::base::metrics::collectd::libpodstats"},{"line_number":275,"context_line":"      }"},{"line_number":276,"context_line":"      default: {"},{"line_number":277,"context_line":"        $db \u003d \u0027\u0027"},{"line_number":278,"context_line":"      }"},{"line_number":279,"context_line":"    }"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    class {\u0027collectd\u0027:"},{"line_number":282,"context_line":"      manage_repo \u003d\u003e $collectd_manage_repo,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9f560f44_2d66dcef","line":279,"range":{"start_line":271,"start_character":0,"end_line":279,"end_character":5},"in_reply_to":"9f560f44_52d2cdfe","updated":"2020-10-02 17:03:06.000000000","message":"Also you should probably set\n\nif\n $typesdb \u003d [\u0027/usr/share/collectd/types.db\u0027, \u0027/usr/share...\u0027]\nelse \n $typesdb \u003d [\u0027/usr/share/collectd/types.db\u0027]\n\nAnd then use $typesdb down in the class call, rather than having an empty string in the list","commit_id":"3469501dcfa838267ff7d6c7d3f164c8fb5fa10d"}]}