)]}'
{"manifests/haproxy.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5e95e18e5c2acdf8accb5f1a4e7097bc1ced96bb","unresolved":true,"context_lines":[{"line_number":1370,"context_line":"      public_ssl_port   \u003d\u003e $ports[ironic_inspector_ssl_port],"},{"line_number":1371,"context_line":"      service_network   \u003d\u003e $ironic_inspector_network,"},{"line_number":1372,"context_line":"      mode              \u003d\u003e \u0027http\u0027,"},{"line_number":1373,"context_line":"      listen_options    \u003d\u003e { \u0027http-check\u0027 \u003d\u003e [\u0027expect rstring .*200.*\u0027], },"},{"line_number":1374,"context_line":"    }"},{"line_number":1375,"context_line":"  }"},{"line_number":1376,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"24e9161d_42fadfeb","line":1373,"range":{"start_line":1373,"start_character":29,"end_line":1373,"end_character":71},"updated":"2020-12-30 02:33:33.000000000","message":"Current problem is caused by this broken option. This never works because ironic inspector never includes status code in its response body.\nThis was initially introduced to avoid traceback in ironic inspector[1], but the patch made haproxy to use tcpchk instead of httpchk, and this option has been ineffective.\n [1] https://review.opendev.org/c/openstack/puppet-tripleo/+/496954\n\nThis option was later removed by [2], and I think this is still valid for stable/train because ironic-inspector no longer uses werkzeug in train. \n [2] https://review.opendev.org/c/openstack/puppet-tripleo/+/696633\n\nSo I think we can revert this train only change and backport [2] to stable/train, which seems to be more straight-forward and proper way, IMO.","commit_id":"69eed9e32654c4529f486a22c09df10da45df79b"}]}