)]}'
{"manifests/profile/base/iscsid.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1c226c4343139816ab2fef502f246cc0179a5bdd","unresolved":true,"context_lines":[{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"class tripleo::profile::base::iscsid ("},{"line_number":30,"context_line":"  $step               \u003d Integer(hiera(\u0027step\u0027)),"},{"line_number":31,"context_line":"  $chap_algs          \u003d undef,"},{"line_number":32,"context_line":") {"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if $step \u003e\u003d 2 {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"129e7d89_06c5c295","line":31,"updated":"2021-03-10 22:11:59.000000000","message":"nit? The convention is $step is the last argument, so yours should precede L30.","commit_id":"a431db8279b8c0517b1f74d6f672a099a1bee8ea"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1c226c4343139816ab2fef502f246cc0179a5bdd","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    file { \u0027/etc/iscsi/.initiator_reset\u0027:"},{"line_number":46,"context_line":"      ensure \u003d\u003e present,"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"    if $chap_algs and $chap_algs !\u003d \u0027\u0027 {"},{"line_number":49,"context_line":"      augeas {\u0027chap_algs in /etc/iscsi/iscsid.conf\u0027:"},{"line_number":50,"context_line":"        context \u003d\u003e \u0027/files/etc/iscsi/iscsid.conf\u0027,"},{"line_number":51,"context_line":"        changes \u003d\u003e [\"set node.session.auth.chap_algs ${chap_algs}\"],"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"df0e4416_0c4a8a00","line":48,"updated":"2021-03-10 22:11:59.000000000","message":"Here\u0027s an alternative expression to consider:\n\n  unless empty($chap_algs) {\n  }","commit_id":"a431db8279b8c0517b1f74d6f672a099a1bee8ea"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c04d0747209fda1e4d0f27b59208822529964142","unresolved":true,"context_lines":[{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"# [*chap_algs*]"},{"line_number":22,"context_line":"#   (Optional) Comma separated list of algorithms to use in CHAP protocol"},{"line_number":23,"context_line":"#   Defaults to undef"},{"line_number":24,"context_line":"# [*step*]"},{"line_number":25,"context_line":"#   (Optional) The current step in deployment. See tripleo-heat-templates"},{"line_number":26,"context_line":"#   for more details."}],"source_content_type":"text/x-puppet","patch_set":7,"id":"d0ace369_74bf056f","line":23,"updated":"2021-03-11 00:13:39.000000000","message":"nit: could use an extra \u0027#\u0027 blank comment line before L24","commit_id":"5dc74cb353e778931d0edaeed95eb9021e4a8b80"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f0239a17487ae9f1c5d4c0d1af2a553fdfcaf2ea","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    file { \u0027/etc/iscsi/.initiator_reset\u0027:"},{"line_number":46,"context_line":"      ensure \u003d\u003e present,"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"    unless empty($chap_algs) {"},{"line_number":49,"context_line":"      augeas {\u0027chap_algs in /etc/iscsi/iscsid.conf\u0027:"},{"line_number":50,"context_line":"        context \u003d\u003e \u0027/files/etc/iscsi/iscsid.conf\u0027,"},{"line_number":51,"context_line":"        changes \u003d\u003e [\"set node.session.auth.chap_algs ${chap_algs}\"],"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"b148dcd3_d7123cb7","line":48,"updated":"2021-03-11 14:48:55.000000000","message":"If this is empty should we ensure the setting is removed?","commit_id":"5dc74cb353e778931d0edaeed95eb9021e4a8b80"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c0c6bdd3394d08bcad8a278fdd1e6da6450dbb7f","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    file { \u0027/etc/iscsi/.initiator_reset\u0027:"},{"line_number":46,"context_line":"      ensure \u003d\u003e present,"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":"    unless empty($chap_algs) {"},{"line_number":49,"context_line":"      augeas {\u0027chap_algs in /etc/iscsi/iscsid.conf\u0027:"},{"line_number":50,"context_line":"        context \u003d\u003e \u0027/files/etc/iscsi/iscsid.conf\u0027,"},{"line_number":51,"context_line":"        changes \u003d\u003e [\"set node.session.auth.chap_algs ${chap_algs}\"],"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"f7be1004_5cf97384","line":48,"in_reply_to":"b148dcd3_d7123cb7","updated":"2021-03-11 14:57:08.000000000","message":"Ooh, right!","commit_id":"5dc74cb353e778931d0edaeed95eb9021e4a8b80"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"475e65ba863ba60e93902320fb2312257fb65604","unresolved":true,"context_lines":[{"line_number":43,"context_line":"    # once, and only once."},{"line_number":44,"context_line":"    exec { \u0027sync-iqn-from-host\u0027:"},{"line_number":45,"context_line":"      command \u003d\u003e \u0027/bin/cp /tmp/iscsi.host/.initiator_reset /tmp/iscsi.host/initiatorname.iscsi /etc/iscsi/\u0027,"},{"line_number":46,"context_line":"      onlyif  \u003d\u003e \u0027/usr/bin/test -f /tmp/iscsi.host/.initiator_reset\u0027,"},{"line_number":47,"context_line":"      before  \u003d\u003e Exec[\u0027reset-iscsi-initiator-name\u0027],"},{"line_number":48,"context_line":"      tag     \u003d\u003e \u0027iscsid_config\u0027"},{"line_number":49,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"0c6898c0_c0b86860","line":46,"range":{"start_line":46,"start_character":35,"end_line":46,"end_character":51},"updated":"2021-03-18 03:50:03.000000000","message":"This is an agreement between THT and puppet-tripleo, it would have been better if it has been taken as parameter rather than hardcoding between 2 components.","commit_id":"56fe343397ba57a8b583cd7b4cfa9c03af3e0b41"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"763cad9a4f5ca21c43b27b3b743526f019c02c3c","unresolved":true,"context_lines":[{"line_number":43,"context_line":"    # once, and only once."},{"line_number":44,"context_line":"    exec { \u0027sync-iqn-from-host\u0027:"},{"line_number":45,"context_line":"      command \u003d\u003e \u0027/bin/cp /tmp/iscsi.host/.initiator_reset /tmp/iscsi.host/initiatorname.iscsi /etc/iscsi/\u0027,"},{"line_number":46,"context_line":"      onlyif  \u003d\u003e \u0027/usr/bin/test -f /tmp/iscsi.host/.initiator_reset\u0027,"},{"line_number":47,"context_line":"      before  \u003d\u003e Exec[\u0027reset-iscsi-initiator-name\u0027],"},{"line_number":48,"context_line":"      tag     \u003d\u003e \u0027iscsid_config\u0027"},{"line_number":49,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"a3b67b27_25ecd671","line":46,"range":{"start_line":46,"start_character":35,"end_line":46,"end_character":51},"in_reply_to":"0c6898c0_c0b86860","updated":"2021-03-20 20:55:46.000000000","message":"I take your point, but the value doesn\u0027t need to be configurable (there\u0027s no reason for THT to specify a different value), and the default value would still appear in both components.","commit_id":"56fe343397ba57a8b583cd7b4cfa9c03af3e0b41"}],"spec/classes/tripleo_profile_base_iscsid_spec.rb":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1c226c4343139816ab2fef502f246cc0179a5bdd","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    end"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    context \u0027with chap params set\u0027 do"},{"line_number":32,"context_line":"      let(:params) { { :step \u003d\u003e 2, :chap_algs \u003d\u003e \"SHA3-256,SHA256,SHA1\"} }"},{"line_number":33,"context_line":"      it \u0027should configure chap_algs\u0027 do"},{"line_number":34,"context_line":"        is_expected.to contain_augeas(\u0027chap_algs in /etc/iscsi/iscsid.conf\u0027)"},{"line_number":35,"context_line":"          .with_changes("}],"source_content_type":"text/x-ruby","patch_set":6,"id":"32b9fe14_0ca1ddcb","line":32,"updated":"2021-03-10 22:11:59.000000000","message":"nit? The merged values should be split so each is on its own line. There are many examples, some can be seen in [1]\n\n[1] https://opendev.org/openstack/puppet-tripleo/src/branch/master/spec/classes/tripleo_profile_base_heat_spec.rb","commit_id":"a431db8279b8c0517b1f74d6f672a099a1bee8ea"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c04d0747209fda1e4d0f27b59208822529964142","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    context \u0027with chap params set\u0027 do"},{"line_number":32,"context_line":"      let(:params) { {"},{"line_number":33,"context_line":"        :step      \u003d\u003e 2,"},{"line_number":34,"context_line":"        :chap_algs \u003d\u003e \"SHA3-256,SHA256,SHA1\""},{"line_number":35,"context_line":"      } }"},{"line_number":36,"context_line":"      it \u0027should configure chap_algs\u0027 do"},{"line_number":37,"context_line":"        is_expected.to contain_augeas(\u0027chap_algs in /etc/iscsi/iscsid.conf\u0027)"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"bc6d3de6_12ea7844","line":34,"updated":"2021-03-11 00:13:39.000000000","message":"nit: could use a trailing \u0027,\u0027","commit_id":"5dc74cb353e778931d0edaeed95eb9021e4a8b80"}]}