)]}'
{"manifests/profile/base/nova/virtlogd_wrapper.pp":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"b4dae7f2e096508ffbb5eb7eb385c964431798e3","unresolved":true,"context_lines":[{"line_number":40,"context_line":"  $enable_wrapper           \u003d false,"},{"line_number":41,"context_line":"  $virtlogd_process_wrapper \u003d undef,"},{"line_number":42,"context_line":"  $virtlogd_image           \u003d undef,"},{"line_number":43,"context_line":"  Boolean $debug            \u003d false,"},{"line_number":44,"context_line":") {"},{"line_number":45,"context_line":"  if $enable_wrapper {"},{"line_number":46,"context_line":"    unless $virtlogd_image and $virtlogd_process_wrapper{"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"cda7e80d_1989ea09","line":43,"range":{"start_line":43,"start_character":2,"end_line":43,"end_character":9},"updated":"2021-05-04 09:30:52.000000000","message":"nit: why specify a Boolean data type for $debug but not for $enable_wrapper?","commit_id":"f09aa48d95bc0fada01b1a011bc00e8c9b1e87b0"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"fe68f1d742e4c1b7b5f320037ff7c54897148359","unresolved":true,"context_lines":[{"line_number":40,"context_line":"  $enable_wrapper           \u003d false,"},{"line_number":41,"context_line":"  $virtlogd_process_wrapper \u003d undef,"},{"line_number":42,"context_line":"  $virtlogd_image           \u003d undef,"},{"line_number":43,"context_line":"  Boolean $debug            \u003d false,"},{"line_number":44,"context_line":") {"},{"line_number":45,"context_line":"  if $enable_wrapper {"},{"line_number":46,"context_line":"    unless $virtlogd_image and $virtlogd_process_wrapper{"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"fc8cb7b6_0a39943b","line":43,"range":{"start_line":43,"start_character":2,"end_line":43,"end_character":9},"in_reply_to":"cda7e80d_1989ea09","updated":"2021-05-04 09:40:24.000000000","message":"TBH, I just kept it in sync with the other wrapper classes we already have for neutron, like\nhttps://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/base/neutron/dhcp_agent_wrappers.pp","commit_id":"f09aa48d95bc0fada01b1a011bc00e8c9b1e87b0"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"3a74a5eabdf39d1ee1de05995faf53cdfc883c09","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  $enable_wrapper           \u003d false,"},{"line_number":41,"context_line":"  $virtlogd_process_wrapper \u003d undef,"},{"line_number":42,"context_line":"  $virtlogd_image           \u003d undef,"},{"line_number":43,"context_line":"  Boolean $debug            \u003d false,"},{"line_number":44,"context_line":") {"},{"line_number":45,"context_line":"  if $enable_wrapper {"},{"line_number":46,"context_line":"    unless $virtlogd_image and $virtlogd_process_wrapper{"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3f46a329_4cffe31d","line":43,"range":{"start_line":43,"start_character":2,"end_line":43,"end_character":9},"in_reply_to":"fc8cb7b6_0a39943b","updated":"2021-05-04 11:18:08.000000000","message":"Ack","commit_id":"f09aa48d95bc0fada01b1a011bc00e8c9b1e87b0"}],"releasenotes/notes/nova_virtlogd_wrapper-43c6c319db2a36ef.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"b4dae7f2e096508ffbb5eb7eb385c964431798e3","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    by doing an RPM update."},{"line_number":12,"context_line":"    To reduce the likelihood in a containerized environment virtlogd should"},{"line_number":13,"context_line":"    only be restarted on manual request, or on compute node reboot. It should"},{"line_number":14,"context_line":"    not be restarted on a minor update without migration off instances."},{"line_number":15,"context_line":"    This introduces a nova_virtlogd_wrapper container and virtlogd wrapper"},{"line_number":16,"context_line":"    script, to only restart virtlogd on either manual or compute node restart."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1ed8eede_28e36a84","line":14,"range":{"start_line":14,"start_character":39,"end_line":14,"end_character":71},"updated":"2021-05-04 09:30:52.000000000","message":"Is that necessary?","commit_id":"f09aa48d95bc0fada01b1a011bc00e8c9b1e87b0"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"3a74a5eabdf39d1ee1de05995faf53cdfc883c09","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    by doing an RPM update."},{"line_number":12,"context_line":"    To reduce the likelihood in a containerized environment virtlogd should"},{"line_number":13,"context_line":"    only be restarted on manual request, or on compute node reboot. It should"},{"line_number":14,"context_line":"    not be restarted on a minor update without migration off instances."},{"line_number":15,"context_line":"    This introduces a nova_virtlogd_wrapper container and virtlogd wrapper"},{"line_number":16,"context_line":"    script, to only restart virtlogd on either manual or compute node restart."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"308bcd09_a7658446","line":14,"range":{"start_line":14,"start_character":39,"end_line":14,"end_character":71},"in_reply_to":"0c3deff4_8afb1ed4","updated":"2021-05-04 11:18:08.000000000","message":"It\u0027s the text I\u0027m asking about. IIRC for minor upgrade migration is recommended as the node needs to be rebooted but it\u0027s not mandatory.\n\nOr is this just referring to the case of manually restarting virtlogd?","commit_id":"f09aa48d95bc0fada01b1a011bc00e8c9b1e87b0"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"fe68f1d742e4c1b7b5f320037ff7c54897148359","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    by doing an RPM update."},{"line_number":12,"context_line":"    To reduce the likelihood in a containerized environment virtlogd should"},{"line_number":13,"context_line":"    only be restarted on manual request, or on compute node reboot. It should"},{"line_number":14,"context_line":"    not be restarted on a minor update without migration off instances."},{"line_number":15,"context_line":"    This introduces a nova_virtlogd_wrapper container and virtlogd wrapper"},{"line_number":16,"context_line":"    script, to only restart virtlogd on either manual or compute node restart."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"0c3deff4_8afb1ed4","line":14,"range":{"start_line":14,"start_character":39,"end_line":14,"end_character":71},"in_reply_to":"1ed8eede_28e36a84","updated":"2021-05-04 09:40:24.000000000","message":"The issue is when you have instances on a compute node and restart virtlogd, the console.log files get closed and not re-opened again. As a result you need to either migrate off the instances and restart virtlogd, or when virtlogd got restarted, also restart the instances or migrate them to another host to get the console.log open again. or you mean we could just remove \u0027without migration off instances.\u0027 from the text?","commit_id":"f09aa48d95bc0fada01b1a011bc00e8c9b1e87b0"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"ab9b3adb110225e82a2ac3de7cdba49649488ee9","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    by doing an RPM update."},{"line_number":12,"context_line":"    To reduce the likelihood in a containerized environment virtlogd should"},{"line_number":13,"context_line":"    only be restarted on manual request, or on compute node reboot. It should"},{"line_number":14,"context_line":"    not be restarted on a minor update without migration off instances."},{"line_number":15,"context_line":"    This introduces a nova_virtlogd_wrapper container and virtlogd wrapper"},{"line_number":16,"context_line":"    script, to only restart virtlogd on either manual or compute node restart."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"37e4d1a4_c4d786de","line":14,"range":{"start_line":14,"start_character":39,"end_line":14,"end_character":71},"in_reply_to":"292741a3_2ada6049","updated":"2021-05-04 11:46:13.000000000","message":"Ack, maybe could be made clearer if this is added to update docs","commit_id":"f09aa48d95bc0fada01b1a011bc00e8c9b1e87b0"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"54ce0d531f22c2b40f767da848a185999bec4327","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    by doing an RPM update."},{"line_number":12,"context_line":"    To reduce the likelihood in a containerized environment virtlogd should"},{"line_number":13,"context_line":"    only be restarted on manual request, or on compute node reboot. It should"},{"line_number":14,"context_line":"    not be restarted on a minor update without migration off instances."},{"line_number":15,"context_line":"    This introduces a nova_virtlogd_wrapper container and virtlogd wrapper"},{"line_number":16,"context_line":"    script, to only restart virtlogd on either manual or compute node restart."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"292741a3_2ada6049","line":14,"range":{"start_line":14,"start_character":39,"end_line":14,"end_character":71},"in_reply_to":"308bcd09_a7658446","updated":"2021-05-04 11:37:53.000000000","message":"It is for manual restart and for updates where no reboot is done or maybe deferred to some later maintenance window depending on the size of the env.","commit_id":"f09aa48d95bc0fada01b1a011bc00e8c9b1e87b0"}],"templates/nova/virtlogd.epp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"edcc9bebdf91f829757099927a89b9db3ac812fb","unresolved":false,"context_lines":[{"line_number":53,"context_line":"             --privileged \\"},{"line_number":54,"context_line":"             -u root \\"},{"line_number":55,"context_line":"             --name $NAME \\"},{"line_number":56,"context_line":"            undercloud-0.ctlplane.redhat.local:8787/rh-osbs/rhosp16-openstack-nova-libvirt:16.2_20210215.1 \\"},{"line_number":57,"context_line":"            $CMD $ARGS"},{"line_number":58,"context_line":"        ;;"},{"line_number":59,"context_line":""}],"source_content_type":"application/x-epp","patch_set":2,"id":"921380ee_0995acac","line":56,"updated":"2021-04-26 19:54:19.000000000","message":"we shouldn\u0027t hard code this?","commit_id":"962730e919b071bf16b37f7cb976b5ccc6e0abd9"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"f68f7a38d196367df2a4bb85b89dcff3c7ed370f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"             --privileged \\"},{"line_number":54,"context_line":"             -u root \\"},{"line_number":55,"context_line":"             --name $NAME \\"},{"line_number":56,"context_line":"            undercloud-0.ctlplane.redhat.local:8787/rh-osbs/rhosp16-openstack-nova-libvirt:16.2_20210215.1 \\"},{"line_number":57,"context_line":"            $CMD $ARGS"},{"line_number":58,"context_line":"        ;;"},{"line_number":59,"context_line":""}],"source_content_type":"application/x-epp","patch_set":2,"id":"caba5780_8de3e2e2","line":56,"in_reply_to":"921380ee_0995acac","updated":"2021-04-27 05:50:49.000000000","message":"yes, sure this patch is not complete. I\u0027ll set -w for now","commit_id":"962730e919b071bf16b37f7cb976b5ccc6e0abd9"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bb6a98c044775dcc48a4d37a327a0f599d921cf9","unresolved":true,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"esac"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"sleep infinity"}],"source_content_type":"application/x-epp","patch_set":4,"id":"846ec29e_64406cba","line":61,"updated":"2021-04-28 09:09:05.000000000","message":"why do we need this? other wrappers only end with starting a new child container...","commit_id":"62066b0ce21d0e26ac158516ee59fe3077b85984"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"9d3e3b1fb90586ca5661b12949ed0885128dc4b2","unresolved":true,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"esac"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"sleep infinity"}],"source_content_type":"application/x-epp","patch_set":4,"id":"db830676_94919d5b","line":61,"in_reply_to":"846ec29e_64406cba","updated":"2021-04-29 06:42:11.000000000","message":"afik all the other wrappers are used by daemons which and control start/stop if  multiple instances in different namespaces, like neutron dnsmasq/haproxy. In this case we run a single virtlogd instances using --rm that the container gets removed when it is stopped for automatic cleanup. We keep the wrapper running to have the virtlogd health checks running there.","commit_id":"62066b0ce21d0e26ac158516ee59fe3077b85984"}]}