)]}'
{"manifests/profile/base/manila/share.pp":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"02eb2a1301f363d5b5311784685e69b67df47355","unresolved":true,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"      $keyring_path \u003d \"/etc/ceph/ceph.client.${cephfs_auth_id}.keyring\""},{"line_number":144,"context_line":"      ceph_config {"},{"line_number":145,"context_line":"        \"client.${cephfs_auth_id}/keyring\": value \u003d\u003e $keyring_path;"},{"line_number":146,"context_line":"        \"client.${cephfs_auth_id}/client mount uid\": value \u003d\u003e 0;"},{"line_number":147,"context_line":"        \"client.${cephfs_auth_id}/client mount gid\": value \u003d\u003e 0;"},{"line_number":148,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ea8abdaf_3b6646ec","side":"PARENT","line":145,"range":{"start_line":145,"start_character":8,"end_line":145,"end_character":67},"updated":"2021-06-15 06:52:29.000000000","message":"what about setting the keyring elsewhere? the dependency patch only covers uid/gid configuration","commit_id":"3a038e605b5b5300660279da97d6e7aadd69e477"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"8a380aa9f5ee7161c9b250c21d2af5a9a5f8637e","unresolved":true,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"      $keyring_path \u003d \"/etc/ceph/ceph.client.${cephfs_auth_id}.keyring\""},{"line_number":144,"context_line":"      ceph_config {"},{"line_number":145,"context_line":"        \"client.${cephfs_auth_id}/keyring\": value \u003d\u003e $keyring_path;"},{"line_number":146,"context_line":"        \"client.${cephfs_auth_id}/client mount uid\": value \u003d\u003e 0;"},{"line_number":147,"context_line":"        \"client.${cephfs_auth_id}/client mount gid\": value \u003d\u003e 0;"},{"line_number":148,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bb005cdb_431be229","side":"PARENT","line":145,"range":{"start_line":145,"start_character":8,"end_line":145,"end_character":67},"in_reply_to":"ea8abdaf_3b6646ec","updated":"2021-06-15 07:42:45.000000000","message":"hi thanks for the review; the keyring path in the \"new\" version isn\u0027t set because it defaults to this same value [1]\n\nwe have a WIP change too migrating scenario004 to cephadm showing this to work [2]\n\n1. https://docs.ceph.com/en/latest/rados/configuration/auth-config-ref/\n2. https://review.opendev.org/c/openstack/tripleo-heat-templates/+/773355","commit_id":"3a038e605b5b5300660279da97d6e7aadd69e477"}]}