)]}'
{"id":"openstack%2Fpuppet-tripleo~822425","triplet_id":"openstack%2Fpuppet-tripleo~stable%2Fwallaby~I5ca68bcc2cfe34f2e95758628155e4f5b872305a","project":"openstack/puppet-tripleo","branch":"stable/wallaby","attention_set":{},"removed_from_attention_set":{"30126":{"account":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"last_update":"2021-12-21 20:51:08.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I5ca68bcc2cfe34f2e95758628155e4f5b872305a","subject":"Enforce stonith for ComputeInstanceHA nodes","status":"MERGED","created":"2021-12-21 10:56:38.000000000","updated":"2021-12-21 20:51:08.000000000","submitted":"2021-12-21 20:51:08.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"822425","cherry_pick_of_change":820177,"cherry_pick_of_patch_set":3,"meta_rev_id":"0e609a6c687171a49940dfd72093b2a95fb455ed","_number":822425,"virtual_id_number":822425,"owner":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-12-21 20:51:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-12-21 14:12:28.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2021-12-21 14:33:29.000000000","_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2021-12-21 14:33:29.000000000","_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-12-21 14:12:28.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-12-21 14:24:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-12-21 14:33:29.000000000","updated_by":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"reviewer":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"state":"REVIEWER"}],"messages":[{"id":"6a3e105a6322b6262ce2d5a520dc487dad8cb9f9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"date":"2021-12-21 10:56:38.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"31fd037835d1ca2fa68832680e21d6b98ce3f741","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2021-12-21 14:12:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/3611a609bfa748c2a2e6d38b3686140e : SUCCESS in 2h 33m 49s\n- tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset035 https://review.rdoproject.org/zuul/build/d4817e2340b14fa492810238ac7b89af : SUCCESS in 2h 53m 33s","accounts_in_message":[],"_revision_number":1},{"id":"69deb4e895eea71e1ca1d1f8e63dca354a5086cc","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-21 14:24:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/c7bd7d2fb24540b0b2f8be449e06abb8 : SUCCESS in 4m 21s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/68036fb011ab4201803f13ebc5abe8a9 : SUCCESS in 4m 29s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/d274ed66a20f4f8d8a2a882e4fd2f2db : SUCCESS in 21m 02s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/7bd819d50b664d62adcffed34e5086d9 : SUCCESS in 22m 46s\n- puppet-openstack-unit-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/42c5a0814a874bed907e495add1593c4 : SUCCESS in 18m 17s (non-voting)\n- tripleo-ci-centos-8-content-provider https://zuul.opendev.org/t/openstack/build/38dc8ccaab5d408b9dc50735162609c3 : SUCCESS in 3h 21m 34s\n- tripleo-ci-centos-8-undercloud-containers https://zuul.opendev.org/t/openstack/build/6dae3cecc09d461396c7cfbaaa214256 : SUCCESS in 1h 09m 13s\n- tripleo-ci-centos-8-containers-multinode https://zuul.opendev.org/t/openstack/build/9d746c957cb34408aafb1ce5f5748ab4 : SUCCESS in 1h 46m 40s\n- tripleo-ci-centos-8-standalone https://zuul.opendev.org/t/openstack/build/dc86ff8696dd462389c0e9d604d3ee57 : SUCCESS in 1h 35m 58s\n- tripleo-ci-centos-8-content-provider-victoria https://zuul.opendev.org/t/openstack/build/f0220103735c4914a206fb10e75f654d : SUCCESS in 2h 58m 41s\n- tripleo-ci-centos-8-scenario000-multinode-oooq-container-updates-wallaby https://zuul.opendev.org/t/openstack/build/29ad3e57c73b47619572e1ec303372f2 : SUCCESS in 1h 26m 35s\n- tripleo-ci-centos-8-undercloud-upgrade-wallaby https://zuul.opendev.org/t/openstack/build/3cbd75f65cc04447b1ee05e2a76dd771 : SUCCESS in 1h 25m 00s","accounts_in_message":[],"_revision_number":1},{"id":"94f5fb7ccedda606bd25abaffaba92b7dcccf67e","author":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"},"date":"2021-12-21 14:33:29.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"bcacf2fc5ed67399a5ceedaa4bef0f1a7c6f778c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-21 14:35:04.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"826f802f2e3edc8e3af1be9c6e45cb3b89c47b10","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-21 20:51:07.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/a6bd4e115ee74d3da8293c6d5ea1649e : SUCCESS in 4m 34s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/3cc07f3dd1d44f48af1ef25b3082a5db : SUCCESS in 4m 31s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/af9774a9ce134d07a370aa9ddcba4ec3 : SUCCESS in 22m 03s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/7fb957ca6574412c83e9ca3d3cbfa28d : SUCCESS in 23m 00s\n- tripleo-ci-centos-8-content-provider https://zuul.opendev.org/t/openstack/build/aa05fb965a7648b189c892d5be737bcc : SUCCESS in 3h 05m 25s\n- tripleo-ci-centos-8-undercloud-containers https://zuul.opendev.org/t/openstack/build/1529172932414fa9914087345c3a5932 : SUCCESS in 1h 02m 22s\n- tripleo-ci-centos-8-containers-multinode https://zuul.opendev.org/t/openstack/build/6dc474c596654e45a6ad061e694658b4 : SUCCESS in 1h 43m 46s\n- tripleo-ci-centos-8-standalone https://zuul.opendev.org/t/openstack/build/bc36751840b9460ba8f2d63f8e9d8d43 : SUCCESS in 1h 20m 38s\n- tripleo-ci-centos-8-content-provider-victoria https://zuul.opendev.org/t/openstack/build/eb086957414545408a94b918a5bf14a3 : SUCCESS in 3h 26m 30s\n- tripleo-ci-centos-8-scenario000-multinode-oooq-container-updates-wallaby https://zuul.opendev.org/t/openstack/build/f3d2b986218540a3bb848dd83599881a : SUCCESS in 1h 20m 12s\n- tripleo-ci-centos-8-undercloud-upgrade-wallaby https://zuul.opendev.org/t/openstack/build/00fb8c4c90074143bf8cd2a478c1c3c5 : SUCCESS in 1h 27m 32s","accounts_in_message":[],"_revision_number":1},{"id":"0e609a6c687171a49940dfd72093b2a95fb455ed","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-12-21 20:51:08.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fcfebe419c2b4b7c948ca00727912f23a08a9638","revisions":{"fcfebe419c2b4b7c948ca00727912f23a08a9638":{"kind":"REWORK","_number":1,"created":"2021-12-21 10:56:38.000000000","uploader":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"ref":"refs/changes/25/822425/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-tripleo","ref":"refs/changes/25/822425/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/25/822425/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/25/822425/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-tripleo refs/changes/25/822425/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-tripleo refs/changes/25/822425/1"}}},"commit":{"parents":[{"commit":"cb1f97caabdd0ba88002228cbdc35ce0b6d1f8a6","subject":"Merge \"Remove the unused parameter\" into stable/wallaby","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/cb1f97caabdd0ba88002228cbdc35ce0b6d1f8a6"}]}],"author":{"name":"Luca Miccini","email":"lmiccini@redhat.com","date":"2021-12-02 14:20:09.000000000","tz":60},"committer":{"name":"Luca Miccini","email":"lmiccini@redhat.com","date":"2021-12-21 10:56:38.000000000","tz":0},"subject":"Enforce stonith for ComputeInstanceHA nodes","message":"Enforce stonith for ComputeInstanceHA nodes\n\nWith the implementation of stonith levels support via bacfec8647 we\naccidentally lifted the requirement for ComputeInstanceHA nodes to\nhave at least one valid stonith device.\n\nThis commit re-introduces a check to make sure there is at least\none valid fencing agent configured, computing the total number of\nstonith resources belonging to each node and making sure to raise\nan exception if this value is zero.\n\nThis check is performed only for the first level so to allow\ndifferent stonith topologies per node (eg controller nodes can\nhave two levels, while computes only one) and still account for\nthe missing devices.\n\nCloses Bug: #1953042\n\nChange-Id: I5ca68bcc2cfe34f2e95758628155e4f5b872305a\n(cherry picked from commit a4fa4fbb76acdb8363bcedb14ec9cf6a11626b36)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/fcfebe419c2b4b7c948ca00727912f23a08a9638"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-tripleo/commit/fcfebe419c2b4b7c948ca00727912f23a08a9638"}]},"branch":"refs/heads/stable/wallaby"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":20778,"name":"Damien Ciabrini","email":"dciabrin@redhat.com","username":"dciabrin"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}