)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0301c9070a5a350be8c9358723c38540f750a667","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ce6ae69f_6ed8e5b9","updated":"2022-06-23 23:18:48.000000000","message":"Looks like still WIP according to the comment ?","commit_id":"844c6e582aa2d1636650eb3172f15fdcd5c9ab7f"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"829ede1b5f6422415bd5edaff1661f352385a10e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fd2fe154_abbc2bfc","in_reply_to":"ce6ae69f_6ed8e5b9","updated":"2022-06-24 16:50:51.000000000","message":"Eeep. Thanks Takashi!","commit_id":"844c6e582aa2d1636650eb3172f15fdcd5c9ab7f"}],"manifests/haproxy.pp":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"77b3431261e03745cbee336fe3b8b2b587308f46","unresolved":true,"context_lines":[{"line_number":1422,"context_line":"        }"},{"line_number":1423,"context_line":""},{"line_number":1424,"context_line":"        haproxy::backend { \"designate_mdns_${index}_be\":"},{"line_number":1425,"context_line":"          mode      \u003d\u003e \u0027tcp\u0027,"},{"line_number":1426,"context_line":"          options   \u003d\u003e {"},{"line_number":1427,"context_line":"            \u0027option\u0027           \u003d\u003e [ \u0027tcplog\u0027 ],"},{"line_number":1428,"context_line":"            },"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5822cec2_8876d933","line":1425,"updated":"2022-02-15 12:26:18.000000000","message":"2022-02-07 16:16:52.947754 | ubuntu-focal | manifests/haproxy.pp:1425:WARNING: indentation of \u003d\u003e is not properly aligned (expected in column 19, but found it in column 21)\n2022-02-07 16:16:52.947850 | ubuntu-focal | manifests/haproxy.pp:1426:WARNING: indentation of \u003d\u003e is not properly aligned (expected in column 19, but found it in column 21)\n2022-02-07 16:16:52.947865 | ubuntu-focal | manifests/haproxy.pp:1432:WARNING: indentation of \u003d\u003e is not properly aligned (expected in column 29, but found it in column 31)\n2022-02-07 16:16:52.947877 | ubuntu-focal | manifests/haproxy.pp:1433:WARNING: indentation of \u003d\u003e is not properly aligned (expected in column 29, but found it in column 31)\n2022-02-07 16:16:52.947889 | ubuntu-focal | manifests/haproxy.pp:1434:WARNING: indentation of \u003d\u003e is not properly aligned (expected in column 29, but found it in column 31)\n2022-02-07 16:16:52.947901 | ubuntu-focal | manifests/haproxy.pp:1435:WARNING: indentation of \u003d\u003e is not properly aligned (expected in column 29, but found it in column 31)\n2022-02-07 16:16:52.947912 | ubuntu-focal | manifests/haproxy.pp:1436:WARNING: indentation of \u003d\u003e is not properly aligned (expected in column 29, but found it in column 31)","commit_id":"118d519060f2038eaf8252765aa502f8f9fcb721"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"77627619ae5c19444d278f8975802dfbf7d59df0","unresolved":false,"context_lines":[{"line_number":1422,"context_line":"        }"},{"line_number":1423,"context_line":""},{"line_number":1424,"context_line":"        haproxy::backend { \"designate_mdns_${index}_be\":"},{"line_number":1425,"context_line":"          mode      \u003d\u003e \u0027tcp\u0027,"},{"line_number":1426,"context_line":"          options   \u003d\u003e {"},{"line_number":1427,"context_line":"            \u0027option\u0027           \u003d\u003e [ \u0027tcplog\u0027 ],"},{"line_number":1428,"context_line":"            },"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"db285ebf_b8790edd","line":1425,"in_reply_to":"5822cec2_8876d933","updated":"2022-05-17 17:20:38.000000000","message":"Ack","commit_id":"118d519060f2038eaf8252765aa502f8f9fcb721"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"060d07a9b04ab502356e4664757f273863f7c222","unresolved":true,"context_lines":[{"line_number":459,"context_line":"#  Defaults to hiera(\u0027swift_proxy_network\u0027, undef)"},{"line_number":460,"context_line":"#"},{"line_number":461,"context_line":"# [*designate_mdns_proxy_baseport*]"},{"line_number":462,"context_line":"# (optional) Specify the base port value for the external-\u003einternal"},{"line_number":463,"context_line":"# proxies used for external DNS integration with designate workers."},{"line_number":464,"context_line":"# Defaults to hiera(\u0027designate_mdns_public_port_start\u0027, undef)"},{"line_number":465,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ec8c962b_7f50af5c","line":462,"updated":"2022-07-01 11:42:03.000000000","message":"better to add one more space to get this aligned with the other comments.","commit_id":"6cd8d85608788e0c4bb4360d37a91deed359895a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3a2e6379663733499e762749f91b3fd2399a7cbb","unresolved":false,"context_lines":[{"line_number":459,"context_line":"#  Defaults to hiera(\u0027swift_proxy_network\u0027, undef)"},{"line_number":460,"context_line":"#"},{"line_number":461,"context_line":"# [*designate_mdns_proxy_baseport*]"},{"line_number":462,"context_line":"# (optional) Specify the base port value for the external-\u003einternal"},{"line_number":463,"context_line":"# proxies used for external DNS integration with designate workers."},{"line_number":464,"context_line":"# Defaults to hiera(\u0027designate_mdns_public_port_start\u0027, undef)"},{"line_number":465,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bd882994_7a7780d4","line":462,"in_reply_to":"ec8c962b_7f50af5c","updated":"2022-07-01 15:16:16.000000000","message":"Done","commit_id":"6cd8d85608788e0c4bb4360d37a91deed359895a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f7c92e9e1fc8373c66671512ccc4fbbac8b57a3b","unresolved":true,"context_lines":[{"line_number":1399,"context_line":"                        hiera(\u0027designate_mdns_node_names\u0027, $controller_hosts_names_real))"},{"line_number":1400,"context_line":""},{"line_number":1401,"context_line":"      $mdns_nodes.each |$index, $mdns_node| {"},{"line_number":1402,"context_line":"        haproxy::frontend { \"designate_mdns_${index}\":"},{"line_number":1403,"context_line":"          ipaddress \u003d\u003e $public_virtual_ip,"},{"line_number":1404,"context_line":"          ports     \u003d\u003e String($designate_mdns_proxy_baseport + $index),"},{"line_number":1405,"context_line":"          mode      \u003d\u003e \u0027tcp\u0027,"},{"line_number":1406,"context_line":"          options   \u003d\u003e {"},{"line_number":1407,"context_line":"            \u0027default_backend \u0027 \u003d\u003e \"designate_mdns_${index}_be\","},{"line_number":1408,"context_line":"            \u0027option\u0027           \u003d\u003e [ \u0027tcplog\u0027 ],"},{"line_number":1409,"context_line":"            },"},{"line_number":1410,"context_line":"        }"},{"line_number":1411,"context_line":""},{"line_number":1412,"context_line":"        haproxy::backend { \"designate_mdns_${index}_be\":"},{"line_number":1413,"context_line":"          mode    \u003d\u003e \u0027tcp\u0027,"},{"line_number":1414,"context_line":"          options \u003d\u003e {"},{"line_number":1415,"context_line":"            \u0027option\u0027 \u003d\u003e [ \u0027tcplog\u0027 ],"},{"line_number":1416,"context_line":"            },"},{"line_number":1417,"context_line":"        }"},{"line_number":1418,"context_line":""},{"line_number":1419,"context_line":"        haproxy::balancermember { \"designate_mdns_${index}\":"},{"line_number":1420,"context_line":"          listening_service \u003d\u003e \"designate_mdns_${index}_be\","}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ea6f81d6_679382c8","line":1417,"range":{"start_line":1402,"start_character":8,"end_line":1417,"end_character":9},"updated":"2022-07-01 11:44:00.000000000","message":"also, IMO this should honor the use_backend_syntax parameter. We might be able to skip implementing non-backend syntax but better to make it fail when the parameter is false.","commit_id":"6cd8d85608788e0c4bb4360d37a91deed359895a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3a2e6379663733499e762749f91b3fd2399a7cbb","unresolved":false,"context_lines":[{"line_number":1399,"context_line":"                        hiera(\u0027designate_mdns_node_names\u0027, $controller_hosts_names_real))"},{"line_number":1400,"context_line":""},{"line_number":1401,"context_line":"      $mdns_nodes.each |$index, $mdns_node| {"},{"line_number":1402,"context_line":"        haproxy::frontend { \"designate_mdns_${index}\":"},{"line_number":1403,"context_line":"          ipaddress \u003d\u003e $public_virtual_ip,"},{"line_number":1404,"context_line":"          ports     \u003d\u003e String($designate_mdns_proxy_baseport + $index),"},{"line_number":1405,"context_line":"          mode      \u003d\u003e \u0027tcp\u0027,"},{"line_number":1406,"context_line":"          options   \u003d\u003e {"},{"line_number":1407,"context_line":"            \u0027default_backend \u0027 \u003d\u003e \"designate_mdns_${index}_be\","},{"line_number":1408,"context_line":"            \u0027option\u0027           \u003d\u003e [ \u0027tcplog\u0027 ],"},{"line_number":1409,"context_line":"            },"},{"line_number":1410,"context_line":"        }"},{"line_number":1411,"context_line":""},{"line_number":1412,"context_line":"        haproxy::backend { \"designate_mdns_${index}_be\":"},{"line_number":1413,"context_line":"          mode    \u003d\u003e \u0027tcp\u0027,"},{"line_number":1414,"context_line":"          options \u003d\u003e {"},{"line_number":1415,"context_line":"            \u0027option\u0027 \u003d\u003e [ \u0027tcplog\u0027 ],"},{"line_number":1416,"context_line":"            },"},{"line_number":1417,"context_line":"        }"},{"line_number":1418,"context_line":""},{"line_number":1419,"context_line":"        haproxy::balancermember { \"designate_mdns_${index}\":"},{"line_number":1420,"context_line":"          listening_service \u003d\u003e \"designate_mdns_${index}_be\","}],"source_content_type":"text/x-puppet","patch_set":6,"id":"8c29f4d3_94e894c1","line":1417,"range":{"start_line":1402,"start_character":8,"end_line":1417,"end_character":9},"in_reply_to":"ea6f81d6_679382c8","updated":"2022-07-01 15:16:16.000000000","message":"Done","commit_id":"6cd8d85608788e0c4bb4360d37a91deed359895a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"060d07a9b04ab502356e4664757f273863f7c222","unresolved":true,"context_lines":[{"line_number":1424,"context_line":"          verifyhost        \u003d\u003e false,"},{"line_number":1425,"context_line":"        }"},{"line_number":1426,"context_line":""},{"line_number":1427,"context_line":"        # ::tripleo::haproxy::endpoint { \"designate_mdns_${index}\":"},{"line_number":1428,"context_line":"        #   public_virtual_ip \u003d\u003e $public_virtual_ip,"},{"line_number":1429,"context_line":"        #   internal_ip       \u003d\u003e $mdns_node[0],"},{"line_number":1430,"context_line":"        #   # NOTE(beagles): Might be a bit odd to hardcode this value here but we absolutely"},{"line_number":1431,"context_line":"        #   # don\u0027t support configuring the internal miniDNS port at this time."},{"line_number":1432,"context_line":"        #   service_port      \u003d\u003e \u0027535\u00274,"},{"line_number":1433,"context_line":"        #   haproxy_port      \u003d\u003e String($designate_mdns_proxy_baseport + $index),"},{"line_number":1434,"context_line":"        #   ip_addresses      \u003d\u003e $mdns_node[0],"},{"line_number":1435,"context_line":"        #   server_names      \u003d\u003e $mdns_node[1],"},{"line_number":1436,"context_line":"        #   mode              \u003d\u003e \u0027tcp\u0027,"},{"line_number":1437,"context_line":"        #   listen_options    \u003d\u003e {},"},{"line_number":1438,"context_line":"        #   frontend_options  \u003d\u003e {},"},{"line_number":1439,"context_line":"        #   backend_options   \u003d\u003e {},"},{"line_number":1440,"context_line":"        #   service_network   \u003d\u003e $designate_network,"},{"line_number":1441,"context_line":"        # }"},{"line_number":1442,"context_line":"      }"},{"line_number":1443,"context_line":"    }"},{"line_number":1444,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"b8ec3712_b4073b2b","line":1441,"range":{"start_line":1427,"start_character":8,"end_line":1441,"end_character":11},"updated":"2022-07-01 11:42:03.000000000","message":"do you care to leave any TODO note to describe what this is ?","commit_id":"6cd8d85608788e0c4bb4360d37a91deed359895a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3a2e6379663733499e762749f91b3fd2399a7cbb","unresolved":false,"context_lines":[{"line_number":1424,"context_line":"          verifyhost        \u003d\u003e false,"},{"line_number":1425,"context_line":"        }"},{"line_number":1426,"context_line":""},{"line_number":1427,"context_line":"        # ::tripleo::haproxy::endpoint { \"designate_mdns_${index}\":"},{"line_number":1428,"context_line":"        #   public_virtual_ip \u003d\u003e $public_virtual_ip,"},{"line_number":1429,"context_line":"        #   internal_ip       \u003d\u003e $mdns_node[0],"},{"line_number":1430,"context_line":"        #   # NOTE(beagles): Might be a bit odd to hardcode this value here but we absolutely"},{"line_number":1431,"context_line":"        #   # don\u0027t support configuring the internal miniDNS port at this time."},{"line_number":1432,"context_line":"        #   service_port      \u003d\u003e \u0027535\u00274,"},{"line_number":1433,"context_line":"        #   haproxy_port      \u003d\u003e String($designate_mdns_proxy_baseport + $index),"},{"line_number":1434,"context_line":"        #   ip_addresses      \u003d\u003e $mdns_node[0],"},{"line_number":1435,"context_line":"        #   server_names      \u003d\u003e $mdns_node[1],"},{"line_number":1436,"context_line":"        #   mode              \u003d\u003e \u0027tcp\u0027,"},{"line_number":1437,"context_line":"        #   listen_options    \u003d\u003e {},"},{"line_number":1438,"context_line":"        #   frontend_options  \u003d\u003e {},"},{"line_number":1439,"context_line":"        #   backend_options   \u003d\u003e {},"},{"line_number":1440,"context_line":"        #   service_network   \u003d\u003e $designate_network,"},{"line_number":1441,"context_line":"        # }"},{"line_number":1442,"context_line":"      }"},{"line_number":1443,"context_line":"    }"},{"line_number":1444,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1934d1ac_8278c268","line":1441,"range":{"start_line":1427,"start_character":8,"end_line":1441,"end_character":11},"in_reply_to":"b8ec3712_b4073b2b","updated":"2022-07-01 15:16:16.000000000","message":"Done","commit_id":"6cd8d85608788e0c4bb4360d37a91deed359895a"}]}