)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"23ff22347c2771fea53e3846f34c155bae524907","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Provide an upgrade path defferent to refular deployments, with properly"},{"line_number":10,"context_line":"pinned HW machine types."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"For Queens-\u003eTrain FFU, t-h-t NovaHWMachineType defaults to \u0027\u0027 in the"},{"line_number":13,"context_line":"beginning. After upgrade the default changes to x86_64\u003dq35."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Custom NovaHWMachineType value provided by a user takes the highest"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"201670df_751d9cfc","line":12,"range":{"start_line":12,"start_character":29,"end_line":12,"end_character":61},"updated":"2022-03-17 13:51:38.000000000","message":"I could not find this in either queens-eol or stable/train","commit_id":"b9ff22042c6ec3e2df876678a376d6b0805869e1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"23ff22347c2771fea53e3846f34c155bae524907","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Provide an upgrade path defferent to refular deployments, with properly"},{"line_number":10,"context_line":"pinned HW machine types."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"For Queens-\u003eTrain FFU, t-h-t NovaHWMachineType defaults to \u0027\u0027 in the"},{"line_number":13,"context_line":"beginning. After upgrade the default changes to x86_64\u003dq35."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Custom NovaHWMachineType value provided by a user takes the highest"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"d6b5a164_55cec3c3","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":17},"updated":"2022-03-17 13:51:38.000000000","message":"Train -\u003e Wallaby ?","commit_id":"b9ff22042c6ec3e2df876678a376d6b0805869e1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e81c25c263f3faacc1ba159963ead0504f4401d0","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Provide an upgrade path defferent to refular deployments, with properly"},{"line_number":10,"context_line":"pinned HW machine types."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"For Queens-\u003eTrain FFU, t-h-t NovaHWMachineType defaults to \u0027\u0027 in the"},{"line_number":13,"context_line":"beginning. After upgrade the default changes to x86_64\u003dq35."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Custom NovaHWMachineType value provided by a user takes the highest"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"875dd992_ce02e4e9","line":12,"range":{"start_line":12,"start_character":29,"end_line":12,"end_character":61},"in_reply_to":"201670df_751d9cfc","updated":"2022-03-18 10:42:21.000000000","message":"indeed, now I cannot recall from there I\u0027ve got that empty string default...","commit_id":"b9ff22042c6ec3e2df876678a376d6b0805869e1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"23ff22347c2771fea53e3846f34c155bae524907","unresolved":true,"context_lines":[{"line_number":10,"context_line":"pinned HW machine types."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"For Queens-\u003eTrain FFU, t-h-t NovaHWMachineType defaults to \u0027\u0027 in the"},{"line_number":13,"context_line":"beginning. After upgrade the default changes to x86_64\u003dq35."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Custom NovaHWMachineType value provided by a user takes the highest"},{"line_number":16,"context_line":"precedence."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"dc2d1766_1ea6f783","line":13,"range":{"start_line":13,"start_character":11,"end_line":13,"end_character":59},"updated":"2022-03-17 13:51:38.000000000","message":"I have not yet fully understood this.\n\nBefore FFU(Here I assume Train to Wallaby one), the all nodes have configuration files generated by train hieradata. After a node is upgraded, its configuration files are re-generated by wallaby hieradata.\n\nThe description sounds like we want to change the value during converge step but there is no mechanism to update hieradata at that time. Or do you intend running wallaby puppet modules with train hieradata ? I don\u0027t think that works.","commit_id":"b9ff22042c6ec3e2df876678a376d6b0805869e1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"9092394c13f40b449a66dbe3bd32085ee2f9b8ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"77ae9294_9f7f435f","updated":"2022-03-08 16:54:29.000000000","message":"note: this SHOULD be backported down to Train","commit_id":"030fdd3bf52bbb7621a65826b96abe0b795803d7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"47fae6c800e0e169de52190f73a41998e0ff2b70","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"973d3fcc_cc6e7904","updated":"2022-03-09 14:36:57.000000000","message":"Leaving some initial questions and quick feedback.\n\nAt my first glance, this is a kind of \"overkilling\" for automation and I tend to not implement this and guide users to set the tht parameter properly during upgrade.","commit_id":"466e77a6842951b92d1d30c39093a525b399438f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3f408da9fc4c74cb890e13d5e130aa2f3d75eea4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7bf137a5_6a5037d0","in_reply_to":"973d3fcc_cc6e7904","updated":"2022-03-11 07:44:34.000000000","message":"I\u0027m not sure that just a docs update would be sufficient for this case","commit_id":"466e77a6842951b92d1d30c39093a525b399438f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a522b97d7fd8386dee6cd95024115c47b6f66f74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"87189941_5568a091","updated":"2022-03-17 09:34:04.000000000","message":"PTAL","commit_id":"b9ff22042c6ec3e2df876678a376d6b0805869e1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"33262b57225383b7b2f91fc2cbe131c25d227f20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"97310618_89ea7973","updated":"2022-03-15 12:48:07.000000000","message":"for the current default it worked fine https://c6bc260fb8a50c93c7b6-115c1089095738e3e088969e8724f0ca.ssl.cf2.rackcdn.com/828894/3/check/tripleo-ci-centos-9-standalone/2ad7f74/logs/undercloud/var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf","commit_id":"b9ff22042c6ec3e2df876678a376d6b0805869e1"}],"manifests/profile/base/nova/compute_libvirt_shared.pp":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e5e9afcaef0ce6e978b073395acd3fea798cc310","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        hw_machine_type \u003d\u003e $hw_machine_type,"},{"line_number":69,"context_line":"      }"},{"line_number":70,"context_line":"    } else {"},{"line_number":71,"context_line":"      class ( \u0027nova::compute::libvirt\u0027:"},{"line_number":72,"context_line":"        hw_machine_type \u003d\u003e $hw_machine_type,"},{"line_number":73,"context_line":"      }"},{"line_number":74,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"6779d15f_aee9d336","line":71,"range":{"start_line":71,"start_character":12,"end_line":71,"end_character":13},"updated":"2022-03-14 14:36:04.000000000","message":"ouch","commit_id":"b75bff12104c181348e830a7674a75bd120db68a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a517dc48548add6bcc121a6fb153ce02611a31d2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        hw_machine_type \u003d\u003e $hw_machine_type,"},{"line_number":69,"context_line":"      }"},{"line_number":70,"context_line":"    } else {"},{"line_number":71,"context_line":"      class ( \u0027nova::compute::libvirt\u0027:"},{"line_number":72,"context_line":"        hw_machine_type \u003d\u003e $hw_machine_type,"},{"line_number":73,"context_line":"      }"},{"line_number":74,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"cd40b76b_66d8a46c","line":71,"range":{"start_line":71,"start_character":12,"end_line":71,"end_character":13},"in_reply_to":"6779d15f_aee9d336","updated":"2022-03-14 14:36:42.000000000","message":"Done","commit_id":"b75bff12104c181348e830a7674a75bd120db68a"}],"manifests/profile/base/nova/libvirt.pp":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"452cd46983de787028a684c7fa37ae6536ddf0bc","unresolved":true,"context_lines":[{"line_number":87,"context_line":"  $hw_machine_type_pre_ffu \u003d pick($::nova::compute::libvirt::hw_machine_type, $hw_machine_type)"},{"line_number":88,"context_line":"  if $hw_machine_type_pre_ffu \u003d\u003d \u0027\u0027  {"},{"line_number":89,"context_line":"    # For FFU run, use this intermediate value"},{"line_number":90,"context_line":"    $hw_machine_type_real \u003d \u0027x86_64\u003dpc-i440fx-rhel7.6.0,aarch64\u003dvirt-rhel7.6.0,ppc64\u003dpseries-rhel7.6.0,ppc64le\u003dpseries-rhel7.6.0\u0027"},{"line_number":91,"context_line":"  } elsif $hw_machine_type !\u003d undef {"},{"line_number":92,"context_line":"    # otherwise use that user has specified in t-h-t"},{"line_number":93,"context_line":"    $hw_machine_type_real \u003d $hw_machine_type"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"6c0e9525_fb47b4e5","line":90,"updated":"2022-03-08 16:59:50.000000000","message":"for the t-h-t master branch, there is no more such a default in use.\nSo this code path is only for backports to use it","commit_id":"030fdd3bf52bbb7621a65826b96abe0b795803d7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2ebed994edf395b50ca168516540ca91602ae2d7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  $hw_machine_type_pre_ffu \u003d pick($::nova::compute::libvirt::hw_machine_type, $hw_machine_type)"},{"line_number":88,"context_line":"  if $hw_machine_type_pre_ffu \u003d\u003d \u0027\u0027  {"},{"line_number":89,"context_line":"    # For FFU run, use this intermediate value"},{"line_number":90,"context_line":"    $hw_machine_type_real \u003d \u0027x86_64\u003dpc-i440fx-rhel7.6.0,aarch64\u003dvirt-rhel7.6.0,ppc64\u003dpseries-rhel7.6.0,ppc64le\u003dpseries-rhel7.6.0\u0027"},{"line_number":91,"context_line":"  } elsif $hw_machine_type !\u003d undef {"},{"line_number":92,"context_line":"    # otherwise use that user has specified in t-h-t"},{"line_number":93,"context_line":"    $hw_machine_type_real \u003d $hw_machine_type"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7325a150_cc1f8434","line":90,"in_reply_to":"6c0e9525_fb47b4e5","updated":"2022-03-11 08:12:51.000000000","message":"Done","commit_id":"030fdd3bf52bbb7621a65826b96abe0b795803d7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"47fae6c800e0e169de52190f73a41998e0ff2b70","unresolved":true,"context_lines":[{"line_number":85,"context_line":"  # and after upgrade the default changes to x86_64\u003dq35."},{"line_number":86,"context_line":"  # But we also take into account custom values provided via t-h-t NovaHWMachineType."},{"line_number":87,"context_line":"  $hw_machine_type_pre_ffu \u003d hiera(\u0027nova::compute::libvirt::hw_machine_type\u0027, \u0027\u0027)"},{"line_number":88,"context_line":"  if $hw_machine_type_pre_ffu \u003d\u003d \u0027\u0027  {"},{"line_number":89,"context_line":"    # For Queens-\u003eTrain FFU run, use this intermediate value"},{"line_number":90,"context_line":"    $hw_machine_type_real \u003d \u0027x86_64\u003dpc-i440fx-rhel7.6.0,aarch64\u003dvirt-rhel7.6.0,ppc64\u003dpseries-rhel7.6.0,ppc64le\u003dpseries-rhel7.6.0\u0027"},{"line_number":91,"context_line":"  } elsif $hw_machine_type !\u003d undef {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7f5805eb_974410a2","line":88,"range":{"start_line":88,"start_character":6,"end_line":88,"end_character":29},"updated":"2022-03-09 14:36:57.000000000","message":"So with https://review.opendev.org/c/openstack/tripleo-heat-templates/+/828894 nova::compute::libvirt::hw_machine_type is no longer set and this logic is already invoked and the rhel 7 values are always used. Is this really expected behavior of am I missing something ?","commit_id":"466e77a6842951b92d1d30c39093a525b399438f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f4c4c0a7ace43481b9294cd58e62ad197df97f68","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  # and after upgrade the default changes to x86_64\u003dq35."},{"line_number":86,"context_line":"  # But we also take into account custom values provided via t-h-t NovaHWMachineType."},{"line_number":87,"context_line":"  $hw_machine_type_pre_ffu \u003d hiera(\u0027nova::compute::libvirt::hw_machine_type\u0027, \u0027\u0027)"},{"line_number":88,"context_line":"  if $hw_machine_type_pre_ffu \u003d\u003d \u0027\u0027  {"},{"line_number":89,"context_line":"    # For Queens-\u003eTrain FFU run, use this intermediate value"},{"line_number":90,"context_line":"    $hw_machine_type_real \u003d \u0027x86_64\u003dpc-i440fx-rhel7.6.0,aarch64\u003dvirt-rhel7.6.0,ppc64\u003dpseries-rhel7.6.0,ppc64le\u003dpseries-rhel7.6.0\u0027"},{"line_number":91,"context_line":"  } elsif $hw_machine_type !\u003d undef {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"8abe2212_136a0195","line":88,"range":{"start_line":88,"start_character":6,"end_line":88,"end_character":29},"in_reply_to":"3a9d3705_2dbf4c13","updated":"2022-03-11 08:12:24.000000000","message":"Done","commit_id":"466e77a6842951b92d1d30c39093a525b399438f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3f408da9fc4c74cb890e13d5e130aa2f3d75eea4","unresolved":true,"context_lines":[{"line_number":85,"context_line":"  # and after upgrade the default changes to x86_64\u003dq35."},{"line_number":86,"context_line":"  # But we also take into account custom values provided via t-h-t NovaHWMachineType."},{"line_number":87,"context_line":"  $hw_machine_type_pre_ffu \u003d hiera(\u0027nova::compute::libvirt::hw_machine_type\u0027, \u0027\u0027)"},{"line_number":88,"context_line":"  if $hw_machine_type_pre_ffu \u003d\u003d \u0027\u0027  {"},{"line_number":89,"context_line":"    # For Queens-\u003eTrain FFU run, use this intermediate value"},{"line_number":90,"context_line":"    $hw_machine_type_real \u003d \u0027x86_64\u003dpc-i440fx-rhel7.6.0,aarch64\u003dvirt-rhel7.6.0,ppc64\u003dpseries-rhel7.6.0,ppc64le\u003dpseries-rhel7.6.0\u0027"},{"line_number":91,"context_line":"  } elsif $hw_machine_type !\u003d undef {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a9d3705_2dbf4c13","line":88,"range":{"start_line":88,"start_character":6,"end_line":88,"end_character":29},"in_reply_to":"7f5805eb_974410a2","updated":"2022-03-11 07:44:34.000000000","message":"good catch! no, that path was only suggested for FFU.","commit_id":"466e77a6842951b92d1d30c39093a525b399438f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"47fae6c800e0e169de52190f73a41998e0ff2b70","unresolved":true,"context_lines":[{"line_number":95,"context_line":"    $hw_machine_type_real \u003d undef"},{"line_number":96,"context_line":"  }"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"  if $hw_machine_type_real !\u003d undef {"},{"line_number":99,"context_line":"    Nova_config \u003c| title \u003d\u003d \u0027libvirt/hw_machine_type\u0027 |\u003e {"},{"line_number":100,"context_line":"      value \u003d\u003e $hw_machine_type_real,"},{"line_number":101,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"68fa0060_629c48bf","line":98,"range":{"start_line":98,"start_character":6,"end_line":98,"end_character":26},"updated":"2022-03-09 14:36:57.000000000","message":"if you pass undef then puppet would ignore the parameter and use the default value instead.","commit_id":"466e77a6842951b92d1d30c39093a525b399438f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f4c4c0a7ace43481b9294cd58e62ad197df97f68","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    $hw_machine_type_real \u003d undef"},{"line_number":96,"context_line":"  }"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"  if $hw_machine_type_real !\u003d undef {"},{"line_number":99,"context_line":"    Nova_config \u003c| title \u003d\u003d \u0027libvirt/hw_machine_type\u0027 |\u003e {"},{"line_number":100,"context_line":"      value \u003d\u003e $hw_machine_type_real,"},{"line_number":101,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"640ba6a5_1b50b6d1","line":98,"range":{"start_line":98,"start_character":6,"end_line":98,"end_character":26},"in_reply_to":"68fa0060_629c48bf","updated":"2022-03-11 08:12:24.000000000","message":"Done","commit_id":"466e77a6842951b92d1d30c39093a525b399438f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"47fae6c800e0e169de52190f73a41998e0ff2b70","unresolved":true,"context_lines":[{"line_number":96,"context_line":"  }"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"  if $hw_machine_type_real !\u003d undef {"},{"line_number":99,"context_line":"    Nova_config \u003c| title \u003d\u003d \u0027libvirt/hw_machine_type\u0027 |\u003e {"},{"line_number":100,"context_line":"      value \u003d\u003e $hw_machine_type_real,"},{"line_number":101,"context_line":"    }"},{"line_number":102,"context_line":"  }"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"e8a75416_0f2e2949","line":101,"range":{"start_line":99,"start_character":4,"end_line":101,"end_character":5},"updated":"2022-03-09 14:36:57.000000000","message":"Please use native class parmaeters instead of overriding existing implementations by this.","commit_id":"466e77a6842951b92d1d30c39093a525b399438f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7368519f078810627da82f3293d7f194cc7a0389","unresolved":false,"context_lines":[{"line_number":96,"context_line":"  }"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"  if $hw_machine_type_real !\u003d undef {"},{"line_number":99,"context_line":"    Nova_config \u003c| title \u003d\u003d \u0027libvirt/hw_machine_type\u0027 |\u003e {"},{"line_number":100,"context_line":"      value \u003d\u003e $hw_machine_type_real,"},{"line_number":101,"context_line":"    }"},{"line_number":102,"context_line":"  }"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"64a5aeeb_0da3c3e6","line":101,"range":{"start_line":99,"start_character":4,"end_line":101,"end_character":5},"in_reply_to":"40b632eb_5954da63","updated":"2022-03-15 08:02:23.000000000","message":"native class params doesn\u0027t work well here, see \"duplicate declaration\" errors in rspes. Also it leaks abstraction into unrelated compute_libvirt_shared class params. I would rather overrid it via spaceships.","commit_id":"466e77a6842951b92d1d30c39093a525b399438f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"23ff22347c2771fea53e3846f34c155bae524907","unresolved":true,"context_lines":[{"line_number":96,"context_line":"  }"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"  if $hw_machine_type_real !\u003d undef {"},{"line_number":99,"context_line":"    Nova_config \u003c| title \u003d\u003d \u0027libvirt/hw_machine_type\u0027 |\u003e {"},{"line_number":100,"context_line":"      value \u003d\u003e $hw_machine_type_real,"},{"line_number":101,"context_line":"    }"},{"line_number":102,"context_line":"  }"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"e1737db4_d7e6c198","line":101,"range":{"start_line":99,"start_character":4,"end_line":101,"end_character":5},"in_reply_to":"64a5aeeb_0da3c3e6","updated":"2022-03-17 13:51:38.000000000","message":"I mean, you should pass the value using the class interface.\n\nclass{ \u0027nova::compute::libvirt\u0027:\n  hw_machine_type \u003d\u003e $value\n}\n\nThis class is included in ripleo::profile::base::nova::compute_libvirt_shared so you are likely to need to implement the logic in that class instead of this class.","commit_id":"466e77a6842951b92d1d30c39093a525b399438f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f4c4c0a7ace43481b9294cd58e62ad197df97f68","unresolved":false,"context_lines":[{"line_number":96,"context_line":"  }"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"  if $hw_machine_type_real !\u003d undef {"},{"line_number":99,"context_line":"    Nova_config \u003c| title \u003d\u003d \u0027libvirt/hw_machine_type\u0027 |\u003e {"},{"line_number":100,"context_line":"      value \u003d\u003e $hw_machine_type_real,"},{"line_number":101,"context_line":"    }"},{"line_number":102,"context_line":"  }"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"40b632eb_5954da63","line":101,"range":{"start_line":99,"start_character":4,"end_line":101,"end_character":5},"in_reply_to":"e82560d2_524c32aa","updated":"2022-03-11 08:12:24.000000000","message":"Done","commit_id":"466e77a6842951b92d1d30c39093a525b399438f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3f408da9fc4c74cb890e13d5e130aa2f3d75eea4","unresolved":true,"context_lines":[{"line_number":96,"context_line":"  }"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"  if $hw_machine_type_real !\u003d undef {"},{"line_number":99,"context_line":"    Nova_config \u003c| title \u003d\u003d \u0027libvirt/hw_machine_type\u0027 |\u003e {"},{"line_number":100,"context_line":"      value \u003d\u003e $hw_machine_type_real,"},{"line_number":101,"context_line":"    }"},{"line_number":102,"context_line":"  }"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  if $step \u003e\u003d 4 {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"e82560d2_524c32aa","line":101,"range":{"start_line":99,"start_character":4,"end_line":101,"end_character":5},"in_reply_to":"e8a75416_0f2e2949","updated":"2022-03-11 07:44:34.000000000","message":"The issue is that I cannot redeclare nova_config with that. It is declared in the called class above. I could move that param there as well, but I fell that would not belong to it...","commit_id":"466e77a6842951b92d1d30c39093a525b399438f"}]}