)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"14405253771cbc0c2f9317cbe8a8cfcc852edb30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d2e98eb6_9d681263","updated":"2022-04-06 11:59:19.000000000","message":"Had a thought on how to make this whole thing cleaner.","commit_id":"f557136fdff69e3763c7b443cb1c03d5b01c0111"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6e952310e5613469c3e828240b5e4cdb5072c49a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0d5a0fc7_a7dcca38","updated":"2022-05-24 13:02:30.000000000","message":"also, it\u0027d be nice if you update unit tests. I can help you if needed.","commit_id":"f8023a7e1794d627c785835d299df90d609af013"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"31d501b056b82bac4929094a5f833547b1e59358","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"32e9a360_d7e478f5","in_reply_to":"0d5a0fc7_a7dcca38","updated":"2022-06-03 12:32:26.000000000","message":"Updated.","commit_id":"f8023a7e1794d627c785835d299df90d609af013"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6b38107bb7ded458f3cd956a5454852e457c89e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"3b6e6c07_8b30c6f4","updated":"2022-06-06 13:28:10.000000000","message":"The implementation looks almost perfect. -1 because of one question I\u0027ve left in dhcp_spec.rb .","commit_id":"ae1aa2de29a21343376c035e7bfbe1b88031d993"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"95c8cd45dce084fab43778263824b68c9b4d10fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"6c6eedf5_6c0bc140","updated":"2022-06-20 19:44:39.000000000","message":"recheck","commit_id":"f736d081bfcaccb1d249f0f1a519131b79a2deac"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"914762f941dcff1a4177406156135160c02c29c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"b9d68f11_843fda6e","updated":"2022-06-16 17:01:39.000000000","message":"recheck","commit_id":"f736d081bfcaccb1d249f0f1a519131b79a2deac"}],"manifests/profile/base/neutron/dhcp.pp":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"f05b6df4fc4c1e14adfe55de48f27e555f27b8b6","unresolved":true,"context_lines":[{"line_number":34,"context_line":"class tripleo::profile::base::neutron::dhcp ("},{"line_number":35,"context_line":"  $step                     \u003d Integer(hiera(\u0027step\u0027)),"},{"line_number":36,"context_line":"  $neutron_dns_integration  \u003d false,"},{"line_number":37,"context_line":"  $unbound_resolvers        \u003d hiera(\u0027unbound_node_ips\u0027, undef),"},{"line_number":38,"context_line":") {"},{"line_number":39,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":40,"context_line":"    include tripleo::profile::base::neutron"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"c83748f9_fde84203","line":37,"updated":"2022-05-10 18:53:11.000000000","message":"can you go ahead and use lookup instead of hiera?","commit_id":"31ed21ca2b117ea31b84ea8e84bf03eb3707d394"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"916e5bf92b20311f377ff081d00a032f11c91cf1","unresolved":true,"context_lines":[{"line_number":34,"context_line":"class tripleo::profile::base::neutron::dhcp ("},{"line_number":35,"context_line":"  $step                     \u003d Integer(hiera(\u0027step\u0027)),"},{"line_number":36,"context_line":"  $neutron_dns_integration  \u003d false,"},{"line_number":37,"context_line":"  $unbound_resolvers        \u003d hiera(\u0027unbound_node_ips\u0027, undef),"},{"line_number":38,"context_line":") {"},{"line_number":39,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":40,"context_line":"    include tripleo::profile::base::neutron"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"49278900_b1fc09de","line":37,"in_reply_to":"1b3a9a09_6ea6ccff","updated":"2022-05-17 04:29:40.000000000","message":"IMO we should not use hiera in this patch if there is any plan to backport this. Usage of hiera is consistent in older branches and helps the backport.\n\nWe can cover that migration separately.","commit_id":"31ed21ca2b117ea31b84ea8e84bf03eb3707d394"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"b9ac2d87ec64860406554af82f679a4df4cbbe1a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"class tripleo::profile::base::neutron::dhcp ("},{"line_number":35,"context_line":"  $step                     \u003d Integer(hiera(\u0027step\u0027)),"},{"line_number":36,"context_line":"  $neutron_dns_integration  \u003d false,"},{"line_number":37,"context_line":"  $unbound_resolvers        \u003d hiera(\u0027unbound_node_ips\u0027, undef),"},{"line_number":38,"context_line":") {"},{"line_number":39,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":40,"context_line":"    include tripleo::profile::base::neutron"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3930f555_75960be1","line":37,"in_reply_to":"49278900_b1fc09de","updated":"2022-05-18 13:53:43.000000000","message":"Ack","commit_id":"31ed21ca2b117ea31b84ea8e84bf03eb3707d394"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"df07e94351697f2fa44098348babde7b361024e0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"class tripleo::profile::base::neutron::dhcp ("},{"line_number":35,"context_line":"  $step                     \u003d Integer(hiera(\u0027step\u0027)),"},{"line_number":36,"context_line":"  $neutron_dns_integration  \u003d false,"},{"line_number":37,"context_line":"  $unbound_resolvers        \u003d hiera(\u0027unbound_node_ips\u0027, undef),"},{"line_number":38,"context_line":") {"},{"line_number":39,"context_line":"  if $step \u003e\u003d 4 {"},{"line_number":40,"context_line":"    include tripleo::profile::base::neutron"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1b3a9a09_6ea6ccff","line":37,"in_reply_to":"c83748f9_fde84203","updated":"2022-05-13 11:50:31.000000000","message":"Ack","commit_id":"31ed21ca2b117ea31b84ea8e84bf03eb3707d394"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"300446ab9b20a85dcba91702e1d75ac3c6aeaa12","unresolved":true,"context_lines":[{"line_number":21,"context_line":"# [*step*]"},{"line_number":22,"context_line":"#   (Optional) The current step in deployment. See tripleo-heat-templates"},{"line_number":23,"context_line":"#   for more details."},{"line_number":24,"context_line":"#   Defaults to lookup(\u0027step\u0027)"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*neutron_dns_integration*]"},{"line_number":27,"context_line":"#   (Optional) Configure neutron to use the supplied unbound resolver nodes."}],"source_content_type":"text/x-puppet","patch_set":10,"id":"845162cc_c8b6b0b6","line":24,"range":{"start_line":24,"start_character":16,"end_line":24,"end_character":30},"updated":"2022-05-17 04:31:34.000000000","message":"If you replace hiera by lookup then this should be Integer(lookup(\u0027step\u0027))\n\n(I mean, inconsistent default should be fixed as part of replacement, because the line is updated)","commit_id":"f7247ac8e4df08abb404a5bac4564910745307a1"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"b9ac2d87ec64860406554af82f679a4df4cbbe1a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# [*step*]"},{"line_number":22,"context_line":"#   (Optional) The current step in deployment. See tripleo-heat-templates"},{"line_number":23,"context_line":"#   for more details."},{"line_number":24,"context_line":"#   Defaults to lookup(\u0027step\u0027)"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*neutron_dns_integration*]"},{"line_number":27,"context_line":"#   (Optional) Configure neutron to use the supplied unbound resolver nodes."}],"source_content_type":"text/x-puppet","patch_set":10,"id":"2c83764b_b72ce79b","line":24,"range":{"start_line":24,"start_character":16,"end_line":24,"end_character":30},"in_reply_to":"845162cc_c8b6b0b6","updated":"2022-05-18 13:53:43.000000000","message":"Ack","commit_id":"f7247ac8e4df08abb404a5bac4564910745307a1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"300446ab9b20a85dcba91702e1d75ac3c6aeaa12","unresolved":true,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*unbound_resolvers*]"},{"line_number":31,"context_line":"#   (Optional) Unbound resolvers if configured."},{"line_number":32,"context_line":"#   Defaults to lookup(\u0027unbound_node_ips\u0027, undef, undef, undef)"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"class tripleo::profile::base::neutron::dhcp ("},{"line_number":35,"context_line":"  $step                     \u003d Integer(lookup(\u0027step\u0027)),"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"5085e936_af09c352","line":32,"range":{"start_line":32,"start_character":57,"end_line":32,"end_character":62},"updated":"2022-05-17 04:31:34.000000000","message":"should this default to [] ?","commit_id":"f7247ac8e4df08abb404a5bac4564910745307a1"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"b9ac2d87ec64860406554af82f679a4df4cbbe1a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*unbound_resolvers*]"},{"line_number":31,"context_line":"#   (Optional) Unbound resolvers if configured."},{"line_number":32,"context_line":"#   Defaults to lookup(\u0027unbound_node_ips\u0027, undef, undef, undef)"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"class tripleo::profile::base::neutron::dhcp ("},{"line_number":35,"context_line":"  $step                     \u003d Integer(lookup(\u0027step\u0027)),"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7d72d1a9_daf64ca3","line":32,"range":{"start_line":32,"start_character":57,"end_line":32,"end_character":62},"in_reply_to":"5085e936_af09c352","updated":"2022-05-18 13:53:43.000000000","message":"Ack","commit_id":"f7247ac8e4df08abb404a5bac4564910745307a1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"916e5bf92b20311f377ff081d00a032f11c91cf1","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    include tripleo::profile::base::neutron"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    if $neutron_dns_integration {"},{"line_number":43,"context_line":"        class{ \u0027neutron::agents::dhcp\u0027:"},{"line_number":44,"context_line":"            dnsmasq_dns_servers \u003d\u003e $unbound_resolvers"},{"line_number":45,"context_line":"        }"},{"line_number":46,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"05596e3f_34b9e673","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":8},"updated":"2022-05-17 04:29:40.000000000","message":"Use 2 spaces instead of 4 spaces.","commit_id":"f7247ac8e4df08abb404a5bac4564910745307a1"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"b9ac2d87ec64860406554af82f679a4df4cbbe1a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    include tripleo::profile::base::neutron"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    if $neutron_dns_integration {"},{"line_number":43,"context_line":"        class{ \u0027neutron::agents::dhcp\u0027:"},{"line_number":44,"context_line":"            dnsmasq_dns_servers \u003d\u003e $unbound_resolvers"},{"line_number":45,"context_line":"        }"},{"line_number":46,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"0e206256_77e9ce7d","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":8},"in_reply_to":"05596e3f_34b9e673","updated":"2022-05-18 13:53:43.000000000","message":"Ack","commit_id":"f7247ac8e4df08abb404a5bac4564910745307a1"}],"manifests/profile/base/neutron/plugins/ml2/ovn.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"916e5bf92b20311f377ff081d00a032f11c91cf1","unresolved":true,"context_lines":[{"line_number":110,"context_line":"    $nb_conn \u003d $db_hosts.map |$h| { join([$protocol, normalize_ip_for_uri($h), \"${ovn_nb_port}\"], \u0027:\u0027) }"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    if $neutron_dns_integration {"},{"line_number":113,"context_line":"        $unbound_resolvers_real \u003d $unbound_resolvers"},{"line_number":114,"context_line":"    }"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    class { \u0027neutron::plugins::ml2::ovn\u0027:"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3a649864_e800f745","line":113,"range":{"start_line":113,"start_character":4,"end_line":113,"end_character":8},"updated":"2022-05-17 04:29:40.000000000","message":"two spaces","commit_id":"f7247ac8e4df08abb404a5bac4564910745307a1"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"b9ac2d87ec64860406554af82f679a4df4cbbe1a","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    $nb_conn \u003d $db_hosts.map |$h| { join([$protocol, normalize_ip_for_uri($h), \"${ovn_nb_port}\"], \u0027:\u0027) }"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    if $neutron_dns_integration {"},{"line_number":113,"context_line":"        $unbound_resolvers_real \u003d $unbound_resolvers"},{"line_number":114,"context_line":"    }"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    class { \u0027neutron::plugins::ml2::ovn\u0027:"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"e4db27cf_717aa8f4","line":113,"range":{"start_line":113,"start_character":4,"end_line":113,"end_character":8},"in_reply_to":"3a649864_e800f745","updated":"2022-05-18 13:53:43.000000000","message":"Ack","commit_id":"f7247ac8e4df08abb404a5bac4564910745307a1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"916e5bf92b20311f377ff081d00a032f11c91cf1","unresolved":true,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    if $neutron_dns_integration {"},{"line_number":113,"context_line":"        $unbound_resolvers_real \u003d $unbound_resolvers"},{"line_number":114,"context_line":"    }"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    class { \u0027neutron::plugins::ml2::ovn\u0027:"},{"line_number":117,"context_line":"      ovn_nb_connection  \u003d\u003e join(any2array($nb_conn), \u0027,\u0027),"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"1a5d793a_04065e91","line":114,"range":{"start_line":114,"start_character":4,"end_line":114,"end_character":5},"updated":"2022-05-17 04:29:40.000000000","message":"unbound_resouvers_real is not defined unless neutron_dns_integration is true, and that would cause warning about the undefined value.\n\nIMO we should define the variable always or should not refer to it when undefined.","commit_id":"f7247ac8e4df08abb404a5bac4564910745307a1"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"b9ac2d87ec64860406554af82f679a4df4cbbe1a","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    if $neutron_dns_integration {"},{"line_number":113,"context_line":"        $unbound_resolvers_real \u003d $unbound_resolvers"},{"line_number":114,"context_line":"    }"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    class { \u0027neutron::plugins::ml2::ovn\u0027:"},{"line_number":117,"context_line":"      ovn_nb_connection  \u003d\u003e join(any2array($nb_conn), \u0027,\u0027),"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"275ce087_69188788","line":114,"range":{"start_line":114,"start_character":4,"end_line":114,"end_character":5},"in_reply_to":"1a5d793a_04065e91","updated":"2022-05-18 13:53:43.000000000","message":"Ack","commit_id":"f7247ac8e4df08abb404a5bac4564910745307a1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"69588a0d9d7446d77a61b9d8fdd8a6382e24f4ea","unresolved":true,"context_lines":[{"line_number":80,"context_line":"#"},{"line_number":81,"context_line":"# [*unbound_resolvers*]"},{"line_number":82,"context_line":"#   (Optional) Unbound resolvers if configured."},{"line_number":83,"context_line":"#   Defaults to hiera(\u0027unbound_node_ips\u0027, $::os_service_default)"},{"line_number":84,"context_line":"#"},{"line_number":85,"context_line":"class tripleo::profile::base::neutron::plugins::ml2::ovn ("},{"line_number":86,"context_line":"  $ovn_db_host              \u003d hiera(\u0027ovn_dbs_vip\u0027, undef),"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3ac61e0f_ae9dc276","line":83,"range":{"start_line":83,"start_character":42,"end_line":83,"end_character":63},"updated":"2022-05-24 13:01:34.000000000","message":"[] ?","commit_id":"f8023a7e1794d627c785835d299df90d609af013"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"31d501b056b82bac4929094a5f833547b1e59358","unresolved":true,"context_lines":[{"line_number":80,"context_line":"#"},{"line_number":81,"context_line":"# [*unbound_resolvers*]"},{"line_number":82,"context_line":"#   (Optional) Unbound resolvers if configured."},{"line_number":83,"context_line":"#   Defaults to hiera(\u0027unbound_node_ips\u0027, $::os_service_default)"},{"line_number":84,"context_line":"#"},{"line_number":85,"context_line":"class tripleo::profile::base::neutron::plugins::ml2::ovn ("},{"line_number":86,"context_line":"  $ovn_db_host              \u003d hiera(\u0027ovn_dbs_vip\u0027, undef),"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"bb9eab5d_3877f38c","line":83,"range":{"start_line":83,"start_character":42,"end_line":83,"end_character":63},"in_reply_to":"3ac61e0f_ae9dc276","updated":"2022-06-03 12:32:26.000000000","message":"I\u0027ve switched this to undef to fit with the code flow logic","commit_id":"f8023a7e1794d627c785835d299df90d609af013"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6b38107bb7ded458f3cd956a5454852e457c89e2","unresolved":false,"context_lines":[{"line_number":80,"context_line":"#"},{"line_number":81,"context_line":"# [*unbound_resolvers*]"},{"line_number":82,"context_line":"#   (Optional) Unbound resolvers if configured."},{"line_number":83,"context_line":"#   Defaults to hiera(\u0027unbound_node_ips\u0027, $::os_service_default)"},{"line_number":84,"context_line":"#"},{"line_number":85,"context_line":"class tripleo::profile::base::neutron::plugins::ml2::ovn ("},{"line_number":86,"context_line":"  $ovn_db_host              \u003d hiera(\u0027ovn_dbs_vip\u0027, undef),"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"833c7d04_a9fb12fe","line":83,"range":{"start_line":83,"start_character":42,"end_line":83,"end_character":63},"in_reply_to":"bb9eab5d_3877f38c","updated":"2022-06-06 13:28:10.000000000","message":"OK. That makes sense.","commit_id":"f8023a7e1794d627c785835d299df90d609af013"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"69588a0d9d7446d77a61b9d8fdd8a6382e24f4ea","unresolved":true,"context_lines":[{"line_number":112,"context_line":"    if $neutron_dns_integration and $unbound_resolvers {"},{"line_number":113,"context_line":"      $unbound_resolvers_real \u003d $unbound_resolvers"},{"line_number":114,"context_line":"    } else {"},{"line_number":115,"context_line":"      $unbound_resolvers_real \u003d $::os_service_default"},{"line_number":116,"context_line":"    }"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    class { \u0027neutron::plugins::ml2::ovn\u0027:"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"f4037165_61cc394a","line":115,"range":{"start_line":115,"start_character":32,"end_line":115,"end_character":53},"updated":"2022-05-24 13:01:34.000000000","message":"one disadvantage of this is that the neutron::plugins::ml2::ovn::dns_servers hiera key no longer works with this change and users needs to use the unbound_resolvers parameter, which is confusing I\u0027m afraid.\n\nAlternatively we can add a new dns_servers option, which defaults to hiera(\u0027neutron::plugins::ml2::ovn\u0027, undef, undef, $::os_service_default) and use that parameter value. This would allow usage of the previous hieradata key.","commit_id":"f8023a7e1794d627c785835d299df90d609af013"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"31d501b056b82bac4929094a5f833547b1e59358","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    if $neutron_dns_integration and $unbound_resolvers {"},{"line_number":113,"context_line":"      $unbound_resolvers_real \u003d $unbound_resolvers"},{"line_number":114,"context_line":"    } else {"},{"line_number":115,"context_line":"      $unbound_resolvers_real \u003d $::os_service_default"},{"line_number":116,"context_line":"    }"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    class { \u0027neutron::plugins::ml2::ovn\u0027:"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"84fae283_3920bbec","line":115,"range":{"start_line":115,"start_character":32,"end_line":115,"end_character":53},"in_reply_to":"3adb21aa_622b4ce5","updated":"2022-06-03 12:32:26.000000000","message":"Done","commit_id":"f8023a7e1794d627c785835d299df90d609af013"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"b07b446f42f7592bba14de58f595a90ec0d91071","unresolved":true,"context_lines":[{"line_number":112,"context_line":"    if $neutron_dns_integration and $unbound_resolvers {"},{"line_number":113,"context_line":"      $unbound_resolvers_real \u003d $unbound_resolvers"},{"line_number":114,"context_line":"    } else {"},{"line_number":115,"context_line":"      $unbound_resolvers_real \u003d $::os_service_default"},{"line_number":116,"context_line":"    }"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    class { \u0027neutron::plugins::ml2::ovn\u0027:"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3adb21aa_622b4ce5","line":115,"range":{"start_line":115,"start_character":32,"end_line":115,"end_character":53},"in_reply_to":"f4037165_61cc394a","updated":"2022-05-24 18:26:19.000000000","message":"Good point - and precisely what I\u0027m trying to avoid with the $neutron_dns_integration flag. I\u0027ll take the approach you suggest here.","commit_id":"f8023a7e1794d627c785835d299df90d609af013"}],"spec/classes/tripleo_profile_base_neutron_dhcp_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6b38107bb7ded458f3cd956a5454852e457c89e2","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  end"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  shared_examples_for \u0027tripleo::profile::base::neutron::dhcp\u0027 do"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    before :each do"},{"line_number":41,"context_line":"      facts.merge!({ :step \u003d\u003e params[:step] })"},{"line_number":42,"context_line":"    end"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    let(:pre_condition) do"},{"line_number":45,"context_line":"      \u003c\u003c-eos"},{"line_number":46,"context_line":"      class { \u0027tripleo::profile::base::neutron\u0027 :"},{"line_number":47,"context_line":"        oslomsg_rpc_hosts       \u003d\u003e [ \u0027localhost\u0027 ],"},{"line_number":48,"context_line":"        oslomsg_rpc_username    \u003d\u003e \u0027neutron\u0027,"},{"line_number":49,"context_line":"        oslomsg_rpc_password    \u003d\u003e \u0027foo\u0027,"},{"line_number":50,"context_line":"        dhcp_agents_per_network \u003d\u003e 3,"},{"line_number":51,"context_line":"      }"},{"line_number":52,"context_line":"eos"},{"line_number":53,"context_line":"    end"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    context \u0027with step 4 and later\u0027 do"},{"line_number":56,"context_line":"      let(:params) { { :step \u003d\u003e 4 } }"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"5ab64a40_31652fe0","line":53,"range":{"start_line":38,"start_character":1,"end_line":53,"end_character":7},"updated":"2022-06-06 13:28:10.000000000","message":"The test case for step 4 was passing without this previously. Do we really need this ?","commit_id":"ae1aa2de29a21343376c035e7bfbe1b88031d993"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"891eafbd259e689b885fee84561e1ce3a77c6b65","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  end"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  shared_examples_for \u0027tripleo::profile::base::neutron::dhcp\u0027 do"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    before :each do"},{"line_number":41,"context_line":"      facts.merge!({ :step \u003d\u003e params[:step] })"},{"line_number":42,"context_line":"    end"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    let(:pre_condition) do"},{"line_number":45,"context_line":"      \u003c\u003c-eos"},{"line_number":46,"context_line":"      class { \u0027tripleo::profile::base::neutron\u0027 :"},{"line_number":47,"context_line":"        oslomsg_rpc_hosts       \u003d\u003e [ \u0027localhost\u0027 ],"},{"line_number":48,"context_line":"        oslomsg_rpc_username    \u003d\u003e \u0027neutron\u0027,"},{"line_number":49,"context_line":"        oslomsg_rpc_password    \u003d\u003e \u0027foo\u0027,"},{"line_number":50,"context_line":"        dhcp_agents_per_network \u003d\u003e 3,"},{"line_number":51,"context_line":"      }"},{"line_number":52,"context_line":"eos"},{"line_number":53,"context_line":"    end"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    context \u0027with step 4 and later\u0027 do"},{"line_number":56,"context_line":"      let(:params) { { :step \u003d\u003e 4 } }"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"fbbd9357_e0eed255","line":53,"range":{"start_line":38,"start_character":1,"end_line":53,"end_character":7},"in_reply_to":"3ee8fa04_be170ee5","updated":"2022-06-07 02:18:15.000000000","message":"Hmm, it is passing now. https://review.opendev.org/c/openstack/puppet-tripleo/+/844896\n\nI\u0027d squash that change into this but please feel free to revert if you have any concern.","commit_id":"ae1aa2de29a21343376c035e7bfbe1b88031d993"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"421dbc5f1f8335ae97c05e4a135f201a605559c8","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  end"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  shared_examples_for \u0027tripleo::profile::base::neutron::dhcp\u0027 do"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    before :each do"},{"line_number":41,"context_line":"      facts.merge!({ :step \u003d\u003e params[:step] })"},{"line_number":42,"context_line":"    end"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    let(:pre_condition) do"},{"line_number":45,"context_line":"      \u003c\u003c-eos"},{"line_number":46,"context_line":"      class { \u0027tripleo::profile::base::neutron\u0027 :"},{"line_number":47,"context_line":"        oslomsg_rpc_hosts       \u003d\u003e [ \u0027localhost\u0027 ],"},{"line_number":48,"context_line":"        oslomsg_rpc_username    \u003d\u003e \u0027neutron\u0027,"},{"line_number":49,"context_line":"        oslomsg_rpc_password    \u003d\u003e \u0027foo\u0027,"},{"line_number":50,"context_line":"        dhcp_agents_per_network \u003d\u003e 3,"},{"line_number":51,"context_line":"      }"},{"line_number":52,"context_line":"eos"},{"line_number":53,"context_line":"    end"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    context \u0027with step 4 and later\u0027 do"},{"line_number":56,"context_line":"      let(:params) { { :step \u003d\u003e 4 } }"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"3ee8fa04_be170ee5","line":53,"range":{"start_line":38,"start_character":1,"end_line":53,"end_character":7},"in_reply_to":"5ab64a40_31652fe0","updated":"2022-06-06 16:07:21.000000000","message":"I was surprised to run into this too - and I\u0027m not sure how the unit tests were passing previously. In tripleo::profile::base::neutron, if $dhcp_nodes \u003d\u003d [] and $dhcp_agent_per_network is undef, then $dhcp_agents_per_net will not be defined anywhere and it gets referenced later on. Maybe it\u0027s something in my puppet environment that\u0027s doing something weird.","commit_id":"ae1aa2de29a21343376c035e7bfbe1b88031d993"}],"spec/classes/tripleo_profile_base_neutron_plugins_ml2_ovn_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6b38107bb7ded458f3cd956a5454852e457c89e2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (C) 2017 Red Hat, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"f9f0a89d_d15cea3f","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2022-06-06 13:28:10.000000000","message":"good addition !","commit_id":"ae1aa2de29a21343376c035e7bfbe1b88031d993"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6b38107bb7ded458f3cd956a5454852e457c89e2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (C) 2017 Red Hat, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"5b84fed8_41163282","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":20},"updated":"2022-06-06 13:28:10.000000000","message":"(nit) 2022","commit_id":"ae1aa2de29a21343376c035e7bfbe1b88031d993"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"421dbc5f1f8335ae97c05e4a135f201a605559c8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (C) 2017 Red Hat, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"f98402e1_02d1fde7","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":20},"in_reply_to":"5b84fed8_41163282","updated":"2022-06-06 16:07:21.000000000","message":"Done","commit_id":"ae1aa2de29a21343376c035e7bfbe1b88031d993"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6b38107bb7ded458f3cd956a5454852e457c89e2","unresolved":true,"context_lines":[{"line_number":24,"context_line":"      facts.merge!({ :step \u003d\u003e params[:step] })"},{"line_number":25,"context_line":"    end"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    context \u0027with step less than 4 do\u0027 do"},{"line_number":28,"context_line":"      let(:params) { {"},{"line_number":29,"context_line":"        :step             \u003d\u003e 3,"},{"line_number":30,"context_line":"        :ovn_db_node_ips  \u003d\u003e [\u0027192.168.111.10\u0027, \u0027192.168.111.11\u0027],"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"f590054e_73b11659","line":27,"range":{"start_line":27,"start_character":34,"end_line":27,"end_character":37},"updated":"2022-06-06 13:28:10.000000000","message":"(nit) this can be removed.","commit_id":"ae1aa2de29a21343376c035e7bfbe1b88031d993"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"421dbc5f1f8335ae97c05e4a135f201a605559c8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"      facts.merge!({ :step \u003d\u003e params[:step] })"},{"line_number":25,"context_line":"    end"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    context \u0027with step less than 4 do\u0027 do"},{"line_number":28,"context_line":"      let(:params) { {"},{"line_number":29,"context_line":"        :step             \u003d\u003e 3,"},{"line_number":30,"context_line":"        :ovn_db_node_ips  \u003d\u003e [\u0027192.168.111.10\u0027, \u0027192.168.111.11\u0027],"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"52987d42_50a5d659","line":27,"range":{"start_line":27,"start_character":34,"end_line":27,"end_character":37},"in_reply_to":"f590054e_73b11659","updated":"2022-06-06 16:07:21.000000000","message":"Done","commit_id":"ae1aa2de29a21343376c035e7bfbe1b88031d993"}]}