)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f55603c163aa374171cb16baf82c3901f9cf23c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b7d6059e_799c4099","updated":"2022-04-19 11:25:26.000000000","message":"Found one point which requires fix. The other part looks good as long as I\u0027ve gone through but I\u0027d defer to CI.","commit_id":"28cf0f037827c45d5d04330286396861233416cf"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"6efeb8c58a09dcea70a55e3f63b4116a8033880b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cf269b6c_06a7f4d1","in_reply_to":"b7d6059e_799c4099","updated":"2022-04-19 12:09:35.000000000","message":"Done.","commit_id":"28cf0f037827c45d5d04330286396861233416cf"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"741a93dd4d95e8faf2a66f2c3c4fe2d7bed0eef2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cb4ccfd2_c5148959","updated":"2022-04-20 14:47:29.000000000","message":"Lint also identified some lines that are now too long (\u003e140).","commit_id":"64dcc1ca060fd5fc8724f49650864038eb8e1be1"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"5a80104cc3be2a521162ce8a66c35acd2a664e4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e5e438f7_b64f4ef2","in_reply_to":"cb4ccfd2_c5148959","updated":"2022-04-21 05:58:07.000000000","message":"Fixed Lint warnings.","commit_id":"64dcc1ca060fd5fc8724f49650864038eb8e1be1"}],"manifests/profile/base/cinder/api.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f55603c163aa374171cb16baf82c3901f9cf23c7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#         service_certificate: \u003cservice certificate path\u003e"},{"line_number":33,"context_line":"#         service_key: \u003cservice key path\u003e"},{"line_number":34,"context_line":"#         principal: \"haproxy/\u003covercloud controller fqdn\u003e\""},{"line_number":35,"context_line":"#   Defaults to lookup(\u0027apache_certificate_specs\u0027, undef, undef, {})."},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"# [*cinder_api_network*]"},{"line_number":38,"context_line":"#   (Optional) The network name where the cinder API endpoint is listening on."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"807215b3_e525f7c0","line":35,"range":{"start_line":35,"start_character":24,"end_line":35,"end_character":48},"updated":"2022-04-19 11:25:26.000000000","message":"note to self: this should be apache_certificate\"s\"_specs. Because we see the same type in all service manifests, it\u0027d be better to fix this typo once we complete replacement of the hiera function.","commit_id":"28cf0f037827c45d5d04330286396861233416cf"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"5a80104cc3be2a521162ce8a66c35acd2a664e4c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#         service_certificate: \u003cservice certificate path\u003e"},{"line_number":33,"context_line":"#         service_key: \u003cservice key path\u003e"},{"line_number":34,"context_line":"#         principal: \"haproxy/\u003covercloud controller fqdn\u003e\""},{"line_number":35,"context_line":"#   Defaults to lookup(\u0027apache_certificate_specs\u0027, undef, undef, {})."},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"# [*cinder_api_network*]"},{"line_number":38,"context_line":"#   (Optional) The network name where the cinder API endpoint is listening on."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fda63c47_80122832","line":35,"range":{"start_line":35,"start_character":24,"end_line":35,"end_character":48},"in_reply_to":"478a3605_c6b9b261","updated":"2022-04-21 05:58:07.000000000","message":"Done","commit_id":"28cf0f037827c45d5d04330286396861233416cf"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"741a93dd4d95e8faf2a66f2c3c4fe2d7bed0eef2","unresolved":true,"context_lines":[{"line_number":32,"context_line":"#         service_certificate: \u003cservice certificate path\u003e"},{"line_number":33,"context_line":"#         service_key: \u003cservice key path\u003e"},{"line_number":34,"context_line":"#         principal: \"haproxy/\u003covercloud controller fqdn\u003e\""},{"line_number":35,"context_line":"#   Defaults to lookup(\u0027apache_certificate_specs\u0027, undef, undef, {})."},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"# [*cinder_api_network*]"},{"line_number":38,"context_line":"#   (Optional) The network name where the cinder API endpoint is listening on."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"478a3605_c6b9b261","line":35,"range":{"start_line":35,"start_character":24,"end_line":35,"end_character":48},"in_reply_to":"807215b3_e525f7c0","updated":"2022-04-20 14:47:29.000000000","message":"The actual code at L53 looks correct, so this is just a typo in a comment. And since this patch is already touching this line, I\u0027d prefer to fix it now instead of in another patch. Other services can/should do the same in their patches.","commit_id":"28cf0f037827c45d5d04330286396861233416cf"}],"manifests/profile/base/cinder/volume/rbd.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f55603c163aa374171cb16baf82c3901f9cf23c7","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  $backend_name                            \u003d lookup(\u0027cinder::backend::rbd::volume_backend_name\u0027, undef, undef, [\u0027tripleo_ceph\u0027]),"},{"line_number":75,"context_line":"  $backend_availability_zone               \u003d lookup(\u0027cinder::backend::rbd::backend_availability_zone\u0027, undef, undef, undef),"},{"line_number":76,"context_line":"  # lint:ignore:parameter_documentation"},{"line_number":77,"context_line":"  $cinder_rbd_backend_host                 \u003d lookup(\u0027cinder::backend_host\u0027, lookup(\u0027cinder::host\u0027, undef, undef, $::hostname)),"},{"line_number":78,"context_line":"  # lint:endignore"},{"line_number":79,"context_line":"  $cinder_rbd_ceph_conf                    \u003d lookup(\u0027cinder::backend::rbd::rbd_ceph_conf\u0027, undef, undef, \u0027/etc/ceph/ceph.conf\u0027),"},{"line_number":80,"context_line":"  $cinder_rbd_pool_name                    \u003d \u0027volumes\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5f65f81a_072c5de1","line":77,"range":{"start_line":77,"start_character":45,"end_line":77,"end_character":127},"updated":"2022-04-19 11:25:26.000000000","message":"(Leave this now for a separate follow-up)\nCurrently tht defines cinder::backend_host so this reference to the cinder::host parameter is redundant and can be removed later.","commit_id":"28cf0f037827c45d5d04330286396861233416cf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f55603c163aa374171cb16baf82c3901f9cf23c7","unresolved":true,"context_lines":[{"line_number":74,"context_line":"  $backend_name                            \u003d lookup(\u0027cinder::backend::rbd::volume_backend_name\u0027, undef, undef, [\u0027tripleo_ceph\u0027]),"},{"line_number":75,"context_line":"  $backend_availability_zone               \u003d lookup(\u0027cinder::backend::rbd::backend_availability_zone\u0027, undef, undef, undef),"},{"line_number":76,"context_line":"  # lint:ignore:parameter_documentation"},{"line_number":77,"context_line":"  $cinder_rbd_backend_host                 \u003d lookup(\u0027cinder::backend_host\u0027, lookup(\u0027cinder::host\u0027, undef, undef, $::hostname)),"},{"line_number":78,"context_line":"  # lint:endignore"},{"line_number":79,"context_line":"  $cinder_rbd_ceph_conf                    \u003d lookup(\u0027cinder::backend::rbd::rbd_ceph_conf\u0027, undef, undef, \u0027/etc/ceph/ceph.conf\u0027),"},{"line_number":80,"context_line":"  $cinder_rbd_pool_name                    \u003d \u0027volumes\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bbed4b2d_7fe24eef","line":77,"updated":"2022-04-19 11:25:26.000000000","message":"you need  undef, undef  in front of the 2nd lookup","commit_id":"28cf0f037827c45d5d04330286396861233416cf"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"741a93dd4d95e8faf2a66f2c3c4fe2d7bed0eef2","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  $backend_name                            \u003d lookup(\u0027cinder::backend::rbd::volume_backend_name\u0027, undef, undef, [\u0027tripleo_ceph\u0027]),"},{"line_number":75,"context_line":"  $backend_availability_zone               \u003d lookup(\u0027cinder::backend::rbd::backend_availability_zone\u0027, undef, undef, undef),"},{"line_number":76,"context_line":"  # lint:ignore:parameter_documentation"},{"line_number":77,"context_line":"  $cinder_rbd_backend_host                 \u003d lookup(\u0027cinder::backend_host\u0027, lookup(\u0027cinder::host\u0027, undef, undef, $::hostname)),"},{"line_number":78,"context_line":"  # lint:endignore"},{"line_number":79,"context_line":"  $cinder_rbd_ceph_conf                    \u003d lookup(\u0027cinder::backend::rbd::rbd_ceph_conf\u0027, undef, undef, \u0027/etc/ceph/ceph.conf\u0027),"},{"line_number":80,"context_line":"  $cinder_rbd_pool_name                    \u003d \u0027volumes\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5ec4534b_62405239","line":77,"range":{"start_line":77,"start_character":45,"end_line":77,"end_character":127},"in_reply_to":"2d00654f_1de89ea5","updated":"2022-04-20 14:47:29.000000000","message":"Yeah, I made a note to revisit this (but in a follow-up).","commit_id":"28cf0f037827c45d5d04330286396861233416cf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"65d88f1dee067910d928c07d6c2d709ad5ae4a32","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  $backend_name                            \u003d lookup(\u0027cinder::backend::rbd::volume_backend_name\u0027, undef, undef, [\u0027tripleo_ceph\u0027]),"},{"line_number":75,"context_line":"  $backend_availability_zone               \u003d lookup(\u0027cinder::backend::rbd::backend_availability_zone\u0027, undef, undef, undef),"},{"line_number":76,"context_line":"  # lint:ignore:parameter_documentation"},{"line_number":77,"context_line":"  $cinder_rbd_backend_host                 \u003d lookup(\u0027cinder::backend_host\u0027, lookup(\u0027cinder::host\u0027, undef, undef, $::hostname)),"},{"line_number":78,"context_line":"  # lint:endignore"},{"line_number":79,"context_line":"  $cinder_rbd_ceph_conf                    \u003d lookup(\u0027cinder::backend::rbd::rbd_ceph_conf\u0027, undef, undef, \u0027/etc/ceph/ceph.conf\u0027),"},{"line_number":80,"context_line":"  $cinder_rbd_pool_name                    \u003d \u0027volumes\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"2d00654f_1de89ea5","line":77,"range":{"start_line":77,"start_character":45,"end_line":77,"end_character":127},"in_reply_to":"5f65f81a_072c5de1","updated":"2022-04-19 12:39:00.000000000","message":"Oops I noticed I misunderstood what is used by tht (cinder::backends::backend_host).\n\nI guess this should be cinder::backend_host but let\u0027s leave it now to limit scope of this change to simple replacement.","commit_id":"28cf0f037827c45d5d04330286396861233416cf"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"6efeb8c58a09dcea70a55e3f63b4116a8033880b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  $backend_name                            \u003d lookup(\u0027cinder::backend::rbd::volume_backend_name\u0027, undef, undef, [\u0027tripleo_ceph\u0027]),"},{"line_number":75,"context_line":"  $backend_availability_zone               \u003d lookup(\u0027cinder::backend::rbd::backend_availability_zone\u0027, undef, undef, undef),"},{"line_number":76,"context_line":"  # lint:ignore:parameter_documentation"},{"line_number":77,"context_line":"  $cinder_rbd_backend_host                 \u003d lookup(\u0027cinder::backend_host\u0027, lookup(\u0027cinder::host\u0027, undef, undef, $::hostname)),"},{"line_number":78,"context_line":"  # lint:endignore"},{"line_number":79,"context_line":"  $cinder_rbd_ceph_conf                    \u003d lookup(\u0027cinder::backend::rbd::rbd_ceph_conf\u0027, undef, undef, \u0027/etc/ceph/ceph.conf\u0027),"},{"line_number":80,"context_line":"  $cinder_rbd_pool_name                    \u003d \u0027volumes\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"48b6c8a0_cdfac526","line":77,"in_reply_to":"bbed4b2d_7fe24eef","updated":"2022-04-19 12:09:35.000000000","message":"Thanks for identifying this. It is fixed now.","commit_id":"28cf0f037827c45d5d04330286396861233416cf"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"741a93dd4d95e8faf2a66f2c3c4fe2d7bed0eef2","unresolved":true,"context_lines":[{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"# [*cinder_rbd_backend_host*]"},{"line_number":30,"context_line":"#   (Optional) String to use as backend_host in the backend stanza"},{"line_number":31,"context_line":"#   Defaults to lookup(\u0027cinder::backend_host\u0027, lookup(\u0027cinder::host\u0027, undef, undef, $::hostname))"},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"# [*cinder_rbd_ceph_conf*]"},{"line_number":34,"context_line":"#   (Optional) The path to the Ceph cluster config file"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"78713cfd_41cd913e","line":31,"updated":"2022-04-20 14:47:29.000000000","message":"This comment needs to be fixed (2 undef\u0027s missing in the first lookup)","commit_id":"64dcc1ca060fd5fc8724f49650864038eb8e1be1"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"5a80104cc3be2a521162ce8a66c35acd2a664e4c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"# [*cinder_rbd_backend_host*]"},{"line_number":30,"context_line":"#   (Optional) String to use as backend_host in the backend stanza"},{"line_number":31,"context_line":"#   Defaults to lookup(\u0027cinder::backend_host\u0027, lookup(\u0027cinder::host\u0027, undef, undef, $::hostname))"},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"# [*cinder_rbd_ceph_conf*]"},{"line_number":34,"context_line":"#   (Optional) The path to the Ceph cluster config file"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dc35d2fa_c72171fa","line":31,"in_reply_to":"78713cfd_41cd913e","updated":"2022-04-21 05:58:07.000000000","message":"Done","commit_id":"64dcc1ca060fd5fc8724f49650864038eb8e1be1"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"741a93dd4d95e8faf2a66f2c3c4fe2d7bed0eef2","unresolved":true,"context_lines":[{"line_number":74,"context_line":"  $backend_name                            \u003d lookup(\u0027cinder::backend::rbd::volume_backend_name\u0027, undef, undef, [\u0027tripleo_ceph\u0027]),"},{"line_number":75,"context_line":"  $backend_availability_zone               \u003d lookup(\u0027cinder::backend::rbd::backend_availability_zone\u0027, undef, undef, undef),"},{"line_number":76,"context_line":"  # lint:ignore:parameter_documentation"},{"line_number":77,"context_line":"  $cinder_rbd_backend_host                 \u003d lookup(\u0027cinder::backend_host\u0027, undef, undef, lookup(\u0027cinder::host\u0027, undef, undef, $::hostname)),"},{"line_number":78,"context_line":"  # lint:endignore"},{"line_number":79,"context_line":"  $cinder_rbd_ceph_conf                    \u003d lookup(\u0027cinder::backend::rbd::rbd_ceph_conf\u0027, undef, undef, \u0027/etc/ceph/ceph.conf\u0027),"},{"line_number":80,"context_line":"  $cinder_rbd_pool_name                    \u003d \u0027volumes\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"b43c4ec4_4ef61fc7","line":77,"updated":"2022-04-20 14:47:29.000000000","message":"Note to self and mkatari: there is some legacy cruft in this expression that needs to be cleaned up (as Takashi noted, leave for a follow-up).","commit_id":"64dcc1ca060fd5fc8724f49650864038eb8e1be1"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"5a80104cc3be2a521162ce8a66c35acd2a664e4c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  $backend_name                            \u003d lookup(\u0027cinder::backend::rbd::volume_backend_name\u0027, undef, undef, [\u0027tripleo_ceph\u0027]),"},{"line_number":75,"context_line":"  $backend_availability_zone               \u003d lookup(\u0027cinder::backend::rbd::backend_availability_zone\u0027, undef, undef, undef),"},{"line_number":76,"context_line":"  # lint:ignore:parameter_documentation"},{"line_number":77,"context_line":"  $cinder_rbd_backend_host                 \u003d lookup(\u0027cinder::backend_host\u0027, undef, undef, lookup(\u0027cinder::host\u0027, undef, undef, $::hostname)),"},{"line_number":78,"context_line":"  # lint:endignore"},{"line_number":79,"context_line":"  $cinder_rbd_ceph_conf                    \u003d lookup(\u0027cinder::backend::rbd::rbd_ceph_conf\u0027, undef, undef, \u0027/etc/ceph/ceph.conf\u0027),"},{"line_number":80,"context_line":"  $cinder_rbd_pool_name                    \u003d \u0027volumes\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"22fa6ccf_1bc2e49c","line":77,"in_reply_to":"b43c4ec4_4ef61fc7","updated":"2022-04-21 05:58:07.000000000","message":"Ack","commit_id":"64dcc1ca060fd5fc8724f49650864038eb8e1be1"}]}