)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"533108e50297159d26f847c5cce1a1f6c3fb4c10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8d4be3e1_ce154b8e","updated":"2022-05-25 16:00:46.000000000","message":"recheck","commit_id":"10d86c8d1534384126591e1256c4561838bc2df5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f28f275bddc0a2efb50ba3894d79722960b90435","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1c276aee_1da8bb9e","updated":"2022-06-07 00:38:58.000000000","message":"We might want to apply https://review.opendev.org/c/openstack/puppet-tripleo/+/843579 to NFS backend but that can be done as a follow-up.","commit_id":"0b6d00bc4ac5eee9609a8582c2d24b27f249476c"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"47309fae1a03f314397f8e616c3e62067908fb0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0b26fdb6_73fdb51e","updated":"2022-06-07 06:39:18.000000000","message":"recheck","commit_id":"0b6d00bc4ac5eee9609a8582c2d24b27f249476c"}],"manifests/profile/base/cinder/volume.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6e6d7a84cf02bc873fd4394bfb5deb8a180a0c26","unresolved":true,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if $cinder_enable_nfs_backend {"},{"line_number":266,"context_line":"      include tripleo::profile::base::cinder::volume::nfs"},{"line_number":267,"context_line":"      $cinder_nfs_backend_name \u003d lookup(\u0027tripleo::profile::base::cinder::volume::nfs::backend_name\u0027,"},{"line_number":268,"context_line":"                                        undef, undef, lookup(\u0027cinder::backend::nfs::volume_backend_name\u0027,"},{"line_number":269,"context_line":"                                        undef, undef, \u0027tripleo_nfs\u0027))"},{"line_number":270,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"020be3df_36b09800","line":267,"range":{"start_line":267,"start_character":41,"end_line":267,"end_character":98},"updated":"2022-05-24 12:54:26.000000000","message":"I tend to skip this change because\n\n - to make this logic compatible with the other backends (except for ceph)\n\n - tripleo::profile:: ... hiera key has never worked properly and we can assume\n   users would be using cinder::backend::nfs::volume_backend_name in existing\n   deployments","commit_id":"720520fdc14cbd53a61fb42a7cd941c66dc648d5"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2d19851c42f821be8597dd5d79eab24030ae5e0a","unresolved":true,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if $cinder_enable_nfs_backend {"},{"line_number":266,"context_line":"      include tripleo::profile::base::cinder::volume::nfs"},{"line_number":267,"context_line":"      $cinder_nfs_backend_name \u003d lookup(\u0027tripleo::profile::base::cinder::volume::nfs::backend_name\u0027,"},{"line_number":268,"context_line":"                                        undef, undef, lookup(\u0027cinder::backend::nfs::volume_backend_name\u0027,"},{"line_number":269,"context_line":"                                        undef, undef, \u0027tripleo_nfs\u0027))"},{"line_number":270,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"4a317b3b_91907b6f","line":267,"range":{"start_line":267,"start_character":41,"end_line":267,"end_character":98},"in_reply_to":"020be3df_36b09800","updated":"2022-05-24 16:24:32.000000000","message":"The problem we\u0027re faced with is a historical inconsistency in whether THT and puppet-tripleo use hiera data in puppet-tripleo\u0027s or puppet-cinder\u0027s namespace. Many of the original cinder backends seem to have chose to use puppet-cinder hiera variables, but IMHO that was misguided because the puppet-cinder backends are all defined resources, where hiera bindings don\u0027t work. The whole design relies on puppet-tripleo to create the resources, so there should have been an incentive to use puppet-tripleo variables. I cringe each time I see a puppet-tripleo cinder backend (which is a puppet class) having to do a lookup() of another puppet-cinder variable.\n\nIn this situation, the THT patch [1] wants to emit puppet-tripleo hiera data, which works perfectly fine by overriding parameters in the tripleo::profile::base::cinder::volume::nfs puppet class.\n\n[1] https://review.opendev.org/c/openstack/tripleo-heat-templates/+/842370/3/deployment/cinder/cinder-volume-container-puppet.yaml#271\n\nBut that means *this* file needs to look up the puppet-tripleo variable. The double lookup, which falls back on looking up the legacy puppet-cinder variable, is added in order to avoid any possibility of a regression (something that\u0027s highly unlikely due to the tight coupling of THT and puppet-tripleo, but better safe than sorry).","commit_id":"720520fdc14cbd53a61fb42a7cd941c66dc648d5"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"a89fea0cbf217a65377a90217f9c6e91ef972cf4","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if $cinder_enable_nfs_backend {"},{"line_number":266,"context_line":"      include tripleo::profile::base::cinder::volume::nfs"},{"line_number":267,"context_line":"      $cinder_nfs_backend_name \u003d lookup(\u0027tripleo::profile::base::cinder::volume::nfs::backend_name\u0027,"},{"line_number":268,"context_line":"                                        undef, undef, lookup(\u0027cinder::backend::nfs::volume_backend_name\u0027,"},{"line_number":269,"context_line":"                                        undef, undef, \u0027tripleo_nfs\u0027))"},{"line_number":270,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"c619371e_bca32a12","line":267,"range":{"start_line":267,"start_character":41,"end_line":267,"end_character":98},"in_reply_to":"4a317b3b_91907b6f","updated":"2022-05-25 10:49:28.000000000","message":"Ack","commit_id":"720520fdc14cbd53a61fb42a7cd941c66dc648d5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dc3883f3ebff5530c0dff8e47d37ab939a80d86f","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if $cinder_enable_nfs_backend {"},{"line_number":266,"context_line":"      include tripleo::profile::base::cinder::volume::nfs"},{"line_number":267,"context_line":"      $cinder_nfs_backend_name \u003d lookup(\u0027tripleo::profile::base::cinder::volume::nfs::backend_name\u0027,"},{"line_number":268,"context_line":"                                        undef, undef, lookup(\u0027cinder::backend::nfs::volume_backend_name\u0027,"},{"line_number":269,"context_line":"                                        undef, undef, \u0027tripleo_nfs\u0027))"},{"line_number":270,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"8c56c1ab_b71f46a6","line":267,"range":{"start_line":267,"start_character":41,"end_line":267,"end_character":98},"in_reply_to":"c619371e_bca32a12","updated":"2022-05-27 08:34:24.000000000","message":"Alan,\n\nThank you for your clarification and now I understand your point. I initially thought we\u0027d use cinder::backend:: ... hieradata mainly but if we\u0027d use tripleo::profile:: consistently in nfs backend then this makes sense.","commit_id":"720520fdc14cbd53a61fb42a7cd941c66dc648d5"}],"manifests/profile/base/cinder/volume/nfs.pp":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"82a77aa28b9b027009fbcbc947b843e6d21048ea","unresolved":true,"context_lines":[{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"class tripleo::profile::base::cinder::volume::nfs ("},{"line_number":70,"context_line":"  $cinder_nfs_servers,"},{"line_number":71,"context_line":"  $cinder_nfs_shares_config,"},{"line_number":72,"context_line":"  $backend_name                       \u003d lookup(\u0027cinder::backend::nfs::volume_backend_name\u0027, undef, undef, [\u0027tripleo_nfs\u0027]),"},{"line_number":73,"context_line":"  $backend_availability_zone          \u003d lookup(\u0027cinder::backend::nfs::backend_availability_zone\u0027, undef, undef, undef),"},{"line_number":74,"context_line":"  $cinder_nfs_mount_options           \u003d \u0027\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9990c197_5f6b7c62","line":71,"updated":"2022-05-19 16:22:38.000000000","message":"Several points regarding $cinder_nfs_shares_config:\n- It should have a default value\n- The previous code had it hard-coded to \u0027/etc/cinder/shares-nfs.conf\u0027\n- But that\u0027s also cinder\u0027s own default value, so a better puppet default is $::os_service_default\n\nSo, I suggest changing this to \"$cinder_nfs_shares_config \u003d $::os_service_default\" and moving it down between L74 and L75.","commit_id":"9e49a709cab62b68ea32c1d76c5e753dc6152734"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"6b35e9e0edc81ea1da0529e1352037fe31d356a1","unresolved":false,"context_lines":[{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"class tripleo::profile::base::cinder::volume::nfs ("},{"line_number":70,"context_line":"  $cinder_nfs_servers,"},{"line_number":71,"context_line":"  $cinder_nfs_shares_config,"},{"line_number":72,"context_line":"  $backend_name                       \u003d lookup(\u0027cinder::backend::nfs::volume_backend_name\u0027, undef, undef, [\u0027tripleo_nfs\u0027]),"},{"line_number":73,"context_line":"  $backend_availability_zone          \u003d lookup(\u0027cinder::backend::nfs::backend_availability_zone\u0027, undef, undef, undef),"},{"line_number":74,"context_line":"  $cinder_nfs_mount_options           \u003d \u0027\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"a4131018_80312bfc","line":71,"in_reply_to":"9990c197_5f6b7c62","updated":"2022-05-19 17:56:26.000000000","message":"Done","commit_id":"9e49a709cab62b68ea32c1d76c5e753dc6152734"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6e6d7a84cf02bc873fd4394bfb5deb8a180a0c26","unresolved":true,"context_lines":[{"line_number":21,"context_line":"# [*cinder_nfs_servers*]"},{"line_number":22,"context_line":"#   List of NFS shares to mount"},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*cinder_nfs_shares_config*]"},{"line_number":25,"context_line":"#   NFS shares configuration file"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*backend_name*]"},{"line_number":28,"context_line":"#   (Optional) List of names given to the Cinder backend stanza."},{"line_number":29,"context_line":"#   Defaults to lookup(\u0027cinder::backend::nfs::volume_backend_name\u0027, undef, undef, \u0027tripleo_nfs\u0027)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"f30d0b67_202caa69","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":1},"updated":"2022-05-24 12:54:26.000000000","message":"Please insert this to the consistent position (after cinder_nfs_mount_options). Also description of default value is missing.","commit_id":"720520fdc14cbd53a61fb42a7cd941c66dc648d5"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"a89fea0cbf217a65377a90217f9c6e91ef972cf4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# [*cinder_nfs_servers*]"},{"line_number":22,"context_line":"#   List of NFS shares to mount"},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# [*cinder_nfs_shares_config*]"},{"line_number":25,"context_line":"#   NFS shares configuration file"},{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*backend_name*]"},{"line_number":28,"context_line":"#   (Optional) List of names given to the Cinder backend stanza."},{"line_number":29,"context_line":"#   Defaults to lookup(\u0027cinder::backend::nfs::volume_backend_name\u0027, undef, undef, \u0027tripleo_nfs\u0027)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"46dd678c_eeaeb000","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":1},"in_reply_to":"f30d0b67_202caa69","updated":"2022-05-25 10:49:28.000000000","message":"Done","commit_id":"720520fdc14cbd53a61fb42a7cd941c66dc648d5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6e6d7a84cf02bc873fd4394bfb5deb8a180a0c26","unresolved":true,"context_lines":[{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*backend_name*]"},{"line_number":28,"context_line":"#   (Optional) List of names given to the Cinder backend stanza."},{"line_number":29,"context_line":"#   Defaults to lookup(\u0027cinder::backend::nfs::volume_backend_name\u0027, undef, undef, \u0027tripleo_nfs\u0027)"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*backend_availability_zone*]"},{"line_number":32,"context_line":"#   (Optional) Availability zone for this volume backend"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9917c7d4_cc476377","line":29,"range":{"start_line":29,"start_character":82,"end_line":29,"end_character":95},"updated":"2022-05-24 12:54:26.000000000","message":"this needs update","commit_id":"720520fdc14cbd53a61fb42a7cd941c66dc648d5"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"a89fea0cbf217a65377a90217f9c6e91ef972cf4","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*backend_name*]"},{"line_number":28,"context_line":"#   (Optional) List of names given to the Cinder backend stanza."},{"line_number":29,"context_line":"#   Defaults to lookup(\u0027cinder::backend::nfs::volume_backend_name\u0027, undef, undef, \u0027tripleo_nfs\u0027)"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*backend_availability_zone*]"},{"line_number":32,"context_line":"#   (Optional) Availability zone for this volume backend"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"a82ee4ec_62d744d8","line":29,"range":{"start_line":29,"start_character":82,"end_line":29,"end_character":95},"in_reply_to":"2a95ee98_28a35d81","updated":"2022-05-25 10:49:28.000000000","message":"Done","commit_id":"720520fdc14cbd53a61fb42a7cd941c66dc648d5"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2d19851c42f821be8597dd5d79eab24030ae5e0a","unresolved":true,"context_lines":[{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*backend_name*]"},{"line_number":28,"context_line":"#   (Optional) List of names given to the Cinder backend stanza."},{"line_number":29,"context_line":"#   Defaults to lookup(\u0027cinder::backend::nfs::volume_backend_name\u0027, undef, undef, \u0027tripleo_nfs\u0027)"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*backend_availability_zone*]"},{"line_number":32,"context_line":"#   (Optional) Availability zone for this volume backend"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"2a95ee98_28a35d81","line":29,"range":{"start_line":29,"start_character":82,"end_line":29,"end_character":95},"in_reply_to":"9917c7d4_cc476377","updated":"2022-05-24 16:24:32.000000000","message":"Yes, the [] brackets are missing.","commit_id":"720520fdc14cbd53a61fb42a7cd941c66dc648d5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6e6d7a84cf02bc873fd4394bfb5deb8a180a0c26","unresolved":true,"context_lines":[{"line_number":71,"context_line":"  $backend_name                       \u003d lookup(\u0027cinder::backend::nfs::volume_backend_name\u0027, undef, undef, [\u0027tripleo_nfs\u0027]),"},{"line_number":72,"context_line":"  $backend_availability_zone          \u003d lookup(\u0027cinder::backend::nfs::backend_availability_zone\u0027, undef, undef, undef),"},{"line_number":73,"context_line":"  $cinder_nfs_mount_options           \u003d \u0027\u0027,"},{"line_number":74,"context_line":"  $cinder_nfs_shares_config           \u003d $::os_service_default,"},{"line_number":75,"context_line":"  $cinder_nfs_snapshot_support        \u003d $::os_service_default,"},{"line_number":76,"context_line":"  $cinder_nas_secure_file_operations  \u003d $::os_service_default,"},{"line_number":77,"context_line":"  $cinder_nas_secure_file_permissions \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"0d24de79_60c53a23","line":74,"range":{"start_line":74,"start_character":40,"end_line":74,"end_character":61},"updated":"2022-05-24 12:54:26.000000000","message":"In puppet-cinder, we intentionally hard-code this because this path is used to define the file resource.\n\nhttps://github.com/openstack/puppet-cinder/blob/master/manifests/backend/nfs.pp#L127\n\nSo we should define the same default value, or alternatively use \"undef\" as default which eventually results in using the default defined in the underlying defined type.","commit_id":"720520fdc14cbd53a61fb42a7cd941c66dc648d5"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2d19851c42f821be8597dd5d79eab24030ae5e0a","unresolved":true,"context_lines":[{"line_number":71,"context_line":"  $backend_name                       \u003d lookup(\u0027cinder::backend::nfs::volume_backend_name\u0027, undef, undef, [\u0027tripleo_nfs\u0027]),"},{"line_number":72,"context_line":"  $backend_availability_zone          \u003d lookup(\u0027cinder::backend::nfs::backend_availability_zone\u0027, undef, undef, undef),"},{"line_number":73,"context_line":"  $cinder_nfs_mount_options           \u003d \u0027\u0027,"},{"line_number":74,"context_line":"  $cinder_nfs_shares_config           \u003d $::os_service_default,"},{"line_number":75,"context_line":"  $cinder_nfs_snapshot_support        \u003d $::os_service_default,"},{"line_number":76,"context_line":"  $cinder_nas_secure_file_operations  \u003d $::os_service_default,"},{"line_number":77,"context_line":"  $cinder_nas_secure_file_permissions \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"17677455_787e0e75","line":74,"range":{"start_line":74,"start_character":40,"end_line":74,"end_character":61},"in_reply_to":"0d24de79_60c53a23","updated":"2022-05-24 16:24:32.000000000","message":"I was the one who urged the use of $::os_service_default, but I agree with your comment. While it\u0027s fine to use $::os_service_default to let cinder choose a default value, I neglected the fact that puppet-cinder needs an actual value in order to create the File resource. Let\u0027s go back to using the original default value. I think it\u0027s better for puppet-tripleo to be explicit.","commit_id":"720520fdc14cbd53a61fb42a7cd941c66dc648d5"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"a89fea0cbf217a65377a90217f9c6e91ef972cf4","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  $backend_name                       \u003d lookup(\u0027cinder::backend::nfs::volume_backend_name\u0027, undef, undef, [\u0027tripleo_nfs\u0027]),"},{"line_number":72,"context_line":"  $backend_availability_zone          \u003d lookup(\u0027cinder::backend::nfs::backend_availability_zone\u0027, undef, undef, undef),"},{"line_number":73,"context_line":"  $cinder_nfs_mount_options           \u003d \u0027\u0027,"},{"line_number":74,"context_line":"  $cinder_nfs_shares_config           \u003d $::os_service_default,"},{"line_number":75,"context_line":"  $cinder_nfs_snapshot_support        \u003d $::os_service_default,"},{"line_number":76,"context_line":"  $cinder_nas_secure_file_operations  \u003d $::os_service_default,"},{"line_number":77,"context_line":"  $cinder_nas_secure_file_permissions \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"0e020ceb_468c94dc","line":74,"range":{"start_line":74,"start_character":40,"end_line":74,"end_character":61},"in_reply_to":"17677455_787e0e75","updated":"2022-05-25 10:49:28.000000000","message":"Thanks Takashi and Alan for the details.\nI have used the same default value as in puppet-cinder.","commit_id":"720520fdc14cbd53a61fb42a7cd941c66dc648d5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6e6d7a84cf02bc873fd4394bfb5deb8a180a0c26","unresolved":true,"context_lines":[{"line_number":101,"context_line":"        \u0027nfs_snapshot_support\u0027        \u003d\u003e $backend_config[\u0027CinderNfsSnapshotSupport\u0027],"},{"line_number":102,"context_line":"        \u0027nas_secure_file_operations\u0027  \u003d\u003e $backend_config[\u0027CinderNasSecureFileOperations\u0027],"},{"line_number":103,"context_line":"        \u0027nas_secure_file_permissions\u0027 \u003d\u003e $backend_config[\u0027CinderNasSecureFilePermissions\u0027],"},{"line_number":104,"context_line":"    })})"},{"line_number":105,"context_line":"      Package[\u0027nfs-utils\u0027] -\u003e Cinder::Backend::Nfs[$backend]"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":"    if str2bool($::selinux) {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"f8aaa864_2d6c09ca","line":104,"range":{"start_line":104,"start_character":4,"end_line":104,"end_character":8},"updated":"2022-05-24 12:54:26.000000000","message":"this needs one more indent, to be placed in the consistent indent with L96","commit_id":"720520fdc14cbd53a61fb42a7cd941c66dc648d5"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"a89fea0cbf217a65377a90217f9c6e91ef972cf4","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        \u0027nfs_snapshot_support\u0027        \u003d\u003e $backend_config[\u0027CinderNfsSnapshotSupport\u0027],"},{"line_number":102,"context_line":"        \u0027nas_secure_file_operations\u0027  \u003d\u003e $backend_config[\u0027CinderNasSecureFileOperations\u0027],"},{"line_number":103,"context_line":"        \u0027nas_secure_file_permissions\u0027 \u003d\u003e $backend_config[\u0027CinderNasSecureFilePermissions\u0027],"},{"line_number":104,"context_line":"    })})"},{"line_number":105,"context_line":"      Package[\u0027nfs-utils\u0027] -\u003e Cinder::Backend::Nfs[$backend]"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":"    if str2bool($::selinux) {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"76079dd2_fb7336a2","line":104,"range":{"start_line":104,"start_character":4,"end_line":104,"end_character":8},"in_reply_to":"f8aaa864_2d6c09ca","updated":"2022-05-25 10:49:28.000000000","message":"Done","commit_id":"720520fdc14cbd53a61fb42a7cd941c66dc648d5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6e6d7a84cf02bc873fd4394bfb5deb8a180a0c26","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        \u0027nas_secure_file_operations\u0027  \u003d\u003e $backend_config[\u0027CinderNasSecureFileOperations\u0027],"},{"line_number":103,"context_line":"        \u0027nas_secure_file_permissions\u0027 \u003d\u003e $backend_config[\u0027CinderNasSecureFilePermissions\u0027],"},{"line_number":104,"context_line":"    })})"},{"line_number":105,"context_line":"      Package[\u0027nfs-utils\u0027] -\u003e Cinder::Backend::Nfs[$backend]"},{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":"    if str2bool($::selinux) {"},{"line_number":108,"context_line":"      selboolean { \u0027virt_use_nfs\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9bc97b6b_1d1c89bf","line":105,"range":{"start_line":105,"start_character":6,"end_line":105,"end_character":60},"updated":"2022-05-24 12:54:26.000000000","message":"We can keep this now but we might just want to remove this because this has no effect in containerized deployment.","commit_id":"720520fdc14cbd53a61fb42a7cd941c66dc648d5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3c710f2388cc94eab353c7a5b164b864fe074157","unresolved":true,"context_lines":[{"line_number":72,"context_line":"  $backend_name                       \u003d lookup(\u0027cinder::backend::nfs::volume_backend_name\u0027, undef, undef, [\u0027tripleo_nfs\u0027]),"},{"line_number":73,"context_line":"  $backend_availability_zone          \u003d lookup(\u0027cinder::backend::nfs::backend_availability_zone\u0027, undef, undef, undef),"},{"line_number":74,"context_line":"  $cinder_nfs_mount_options           \u003d \u0027\u0027,"},{"line_number":75,"context_line":"  $cinder_nfs_shares_config           \u003d \u0027/etc/cinder/shares.conf\u0027,"},{"line_number":76,"context_line":"  $cinder_nfs_snapshot_support        \u003d $::os_service_default,"},{"line_number":77,"context_line":"  $cinder_nas_secure_file_operations  \u003d $::os_service_default,"},{"line_number":78,"context_line":"  $cinder_nas_secure_file_permissions \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7580ddd9_4ea12de3","line":75,"range":{"start_line":75,"start_character":40,"end_line":75,"end_character":66},"updated":"2022-05-27 08:38:57.000000000","message":"I discussed this with Manoj locally but this might need a few more consideration.\n\nSo if we have multiple nfs backend enabled, each backend tries to use this same file unless user gives CinderNfsSharesConfig. Also, the current file name is conflicting with what is used by netapp backend so users would face the same situation if they have both NetApp backend and Nfs backend enabled.\n\nIdeally we should not use the common file name by default but the one unique per driver and backend, like /etc/cinder/shares-nfs-${backend}.conf . See what I proposed in https://review.opendev.org/c/openstack/puppet-tripleo/+/843579\n\nMy suggestion for your patch is\n\n1. Use \"undef\" as the default value\n2. If the value is not undef then use the given value (which is likely cause the problem when multiple backends are enabled)\n3. If the value is undef then use \u0027/etc/cinder/shares-nfs-${backend}.conf\u0027 (and let it overridden by CinderNfsSharesConfig.)","commit_id":"10d86c8d1534384126591e1256c4561838bc2df5"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"81498e001e1e880e904928ff33c949d68b7993df","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  $backend_name                       \u003d lookup(\u0027cinder::backend::nfs::volume_backend_name\u0027, undef, undef, [\u0027tripleo_nfs\u0027]),"},{"line_number":73,"context_line":"  $backend_availability_zone          \u003d lookup(\u0027cinder::backend::nfs::backend_availability_zone\u0027, undef, undef, undef),"},{"line_number":74,"context_line":"  $cinder_nfs_mount_options           \u003d \u0027\u0027,"},{"line_number":75,"context_line":"  $cinder_nfs_shares_config           \u003d \u0027/etc/cinder/shares.conf\u0027,"},{"line_number":76,"context_line":"  $cinder_nfs_snapshot_support        \u003d $::os_service_default,"},{"line_number":77,"context_line":"  $cinder_nas_secure_file_operations  \u003d $::os_service_default,"},{"line_number":78,"context_line":"  $cinder_nas_secure_file_permissions \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"247b3810_d9c0a559","line":75,"range":{"start_line":75,"start_character":40,"end_line":75,"end_character":66},"in_reply_to":"00279a87_339898ca","updated":"2022-05-30 07:15:18.000000000","message":"Done","commit_id":"10d86c8d1534384126591e1256c4561838bc2df5"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bc7256dbf49d479910145659abd0b56a19e1c5c7","unresolved":true,"context_lines":[{"line_number":72,"context_line":"  $backend_name                       \u003d lookup(\u0027cinder::backend::nfs::volume_backend_name\u0027, undef, undef, [\u0027tripleo_nfs\u0027]),"},{"line_number":73,"context_line":"  $backend_availability_zone          \u003d lookup(\u0027cinder::backend::nfs::backend_availability_zone\u0027, undef, undef, undef),"},{"line_number":74,"context_line":"  $cinder_nfs_mount_options           \u003d \u0027\u0027,"},{"line_number":75,"context_line":"  $cinder_nfs_shares_config           \u003d \u0027/etc/cinder/shares.conf\u0027,"},{"line_number":76,"context_line":"  $cinder_nfs_snapshot_support        \u003d $::os_service_default,"},{"line_number":77,"context_line":"  $cinder_nas_secure_file_operations  \u003d $::os_service_default,"},{"line_number":78,"context_line":"  $cinder_nas_secure_file_permissions \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9d58b566_fbff43cc","line":75,"range":{"start_line":75,"start_character":40,"end_line":75,"end_character":66},"in_reply_to":"7580ddd9_4ea12de3","updated":"2022-05-27 13:48:18.000000000","message":"See my comment in the other patch https://review.opendev.org/c/openstack/puppet-tripleo/+/843579\n\nI would avoid worrying whether the user is deploying both NFS and NetApp backends. As I mentioned in that patch, this is simply not done in real world usage.\n\nI also mentioned I OK with the code providing a fallback (default value) for the shares config file. But, the default file name doesn\u0027t need to include \u0027nfs\u0027, because the backend names for all cinder backends are already unique, and \u0027nfs\u0027 probably already appears in the backend name.","commit_id":"10d86c8d1534384126591e1256c4561838bc2df5"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"e15f3dd5433d29f9175d969823c898a2af18a0e1","unresolved":true,"context_lines":[{"line_number":72,"context_line":"  $backend_name                       \u003d lookup(\u0027cinder::backend::nfs::volume_backend_name\u0027, undef, undef, [\u0027tripleo_nfs\u0027]),"},{"line_number":73,"context_line":"  $backend_availability_zone          \u003d lookup(\u0027cinder::backend::nfs::backend_availability_zone\u0027, undef, undef, undef),"},{"line_number":74,"context_line":"  $cinder_nfs_mount_options           \u003d \u0027\u0027,"},{"line_number":75,"context_line":"  $cinder_nfs_shares_config           \u003d \u0027/etc/cinder/shares.conf\u0027,"},{"line_number":76,"context_line":"  $cinder_nfs_snapshot_support        \u003d $::os_service_default,"},{"line_number":77,"context_line":"  $cinder_nas_secure_file_operations  \u003d $::os_service_default,"},{"line_number":78,"context_line":"  $cinder_nas_secure_file_permissions \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"00279a87_339898ca","line":75,"range":{"start_line":75,"start_character":40,"end_line":75,"end_character":66},"in_reply_to":"9d58b566_fbff43cc","updated":"2022-05-27 18:46:54.000000000","message":"I dug back over the history of the NFS and Netapp backends. I think the problem here is the default value needs to match the old hard-coded value \u0027/etc/cinder/shares-nfs.conf\u0027 (see L81 of the base file).","commit_id":"10d86c8d1534384126591e1256c4561838bc2df5"}],"spec/classes/tripleo_profile_base_cinder_volume_nfs_spec.rb":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"82a77aa28b9b027009fbcbc947b843e6d21048ea","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    context \u0027with step less than 4\u0027 do"},{"line_number":26,"context_line":"      let(:params) { {"},{"line_number":27,"context_line":"        :cinder_nfs_servers \u003d\u003e [\u0027127.0.0.1\u0027],"},{"line_number":28,"context_line":"        :cinder_nfs_shares_config \u003d\u003e  \u0027/etc/cinder/shares-nfs.conf\u0027,"},{"line_number":29,"context_line":"        :step \u003d\u003e 3"},{"line_number":30,"context_line":"      } }"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"d57d7d82_96c94113","line":28,"updated":"2022-05-19 16:22:38.000000000","message":"This won\u0027t be necessary if you adopt my other suggestion of assigning a default value.","commit_id":"9e49a709cab62b68ea32c1d76c5e753dc6152734"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"6b35e9e0edc81ea1da0529e1352037fe31d356a1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    context \u0027with step less than 4\u0027 do"},{"line_number":26,"context_line":"      let(:params) { {"},{"line_number":27,"context_line":"        :cinder_nfs_servers \u003d\u003e [\u0027127.0.0.1\u0027],"},{"line_number":28,"context_line":"        :cinder_nfs_shares_config \u003d\u003e  \u0027/etc/cinder/shares-nfs.conf\u0027,"},{"line_number":29,"context_line":"        :step \u003d\u003e 3"},{"line_number":30,"context_line":"      } }"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"2e4998c3_bd3a9647","line":28,"in_reply_to":"d57d7d82_96c94113","updated":"2022-05-19 17:56:26.000000000","message":"Done","commit_id":"9e49a709cab62b68ea32c1d76c5e753dc6152734"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"82a77aa28b9b027009fbcbc947b843e6d21048ea","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    context \u0027with step 4\u0027 do"},{"line_number":41,"context_line":"      let(:params) { {"},{"line_number":42,"context_line":"        :cinder_nfs_servers \u003d\u003e [\u0027127.0.0.1\u0027],"},{"line_number":43,"context_line":"        :cinder_nfs_shares_config \u003d\u003e  \u0027/etc/cinder/shares-nfs.conf\u0027,"},{"line_number":44,"context_line":"        :step \u003d\u003e 4,"},{"line_number":45,"context_line":"      } }"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fbf253a9_23f3cf28","line":43,"updated":"2022-05-19 16:22:38.000000000","message":"ditto","commit_id":"9e49a709cab62b68ea32c1d76c5e753dc6152734"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"6b35e9e0edc81ea1da0529e1352037fe31d356a1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    context \u0027with step 4\u0027 do"},{"line_number":41,"context_line":"      let(:params) { {"},{"line_number":42,"context_line":"        :cinder_nfs_servers \u003d\u003e [\u0027127.0.0.1\u0027],"},{"line_number":43,"context_line":"        :cinder_nfs_shares_config \u003d\u003e  \u0027/etc/cinder/shares-nfs.conf\u0027,"},{"line_number":44,"context_line":"        :step \u003d\u003e 4,"},{"line_number":45,"context_line":"      } }"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"5e7128e6_e35cb3a3","line":43,"in_reply_to":"fbf253a9_23f3cf28","updated":"2022-05-19 17:56:26.000000000","message":"Done","commit_id":"9e49a709cab62b68ea32c1d76c5e753dc6152734"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"82a77aa28b9b027009fbcbc947b843e6d21048ea","unresolved":true,"context_lines":[{"line_number":79,"context_line":"      context \u0027with multiple backends\u0027 do"},{"line_number":80,"context_line":"        let(:params) { {"},{"line_number":81,"context_line":"          :backend_name \u003d\u003e [\u0027tripleo_nfs_1\u0027, \u0027tripleo_nfs_2\u0027],"},{"line_number":82,"context_line":"          :cinder_nfs_shares_config \u003d\u003e  \u0027/etc/cinder/shares-nfs.conf\u0027,"},{"line_number":83,"context_line":"          :multi_config \u003d\u003e { \u0027tripleo_nfs_1\u0027 \u003d\u003e {"},{"line_number":84,"context_line":"                              \u0027CinderNfsSnapshotSupport\u0027 \u003d\u003e \u0027true\u0027,"},{"line_number":85,"context_line":"                             },"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"2a72daa0_eb756e7e","line":82,"updated":"2022-05-19 16:22:38.000000000","message":"ditto","commit_id":"9e49a709cab62b68ea32c1d76c5e753dc6152734"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"6b35e9e0edc81ea1da0529e1352037fe31d356a1","unresolved":false,"context_lines":[{"line_number":79,"context_line":"      context \u0027with multiple backends\u0027 do"},{"line_number":80,"context_line":"        let(:params) { {"},{"line_number":81,"context_line":"          :backend_name \u003d\u003e [\u0027tripleo_nfs_1\u0027, \u0027tripleo_nfs_2\u0027],"},{"line_number":82,"context_line":"          :cinder_nfs_shares_config \u003d\u003e  \u0027/etc/cinder/shares-nfs.conf\u0027,"},{"line_number":83,"context_line":"          :multi_config \u003d\u003e { \u0027tripleo_nfs_1\u0027 \u003d\u003e {"},{"line_number":84,"context_line":"                              \u0027CinderNfsSnapshotSupport\u0027 \u003d\u003e \u0027true\u0027,"},{"line_number":85,"context_line":"                             },"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"efcdd8d7_be18b389","line":82,"in_reply_to":"2a72daa0_eb756e7e","updated":"2022-05-19 17:56:26.000000000","message":"Done","commit_id":"9e49a709cab62b68ea32c1d76c5e753dc6152734"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"82a77aa28b9b027009fbcbc947b843e6d21048ea","unresolved":true,"context_lines":[{"line_number":84,"context_line":"                              \u0027CinderNfsSnapshotSupport\u0027 \u003d\u003e \u0027true\u0027,"},{"line_number":85,"context_line":"                             },"},{"line_number":86,"context_line":"                             \u0027tripleo_nfs_2\u0027 \u003d\u003e {"},{"line_number":87,"context_line":"                              \u0027CinderNfsSharesConfig\u0027 \u003d\u003e \u0027/etc/cinder/shares-nfs_2.conf\u0027,"},{"line_number":88,"context_line":"                             },"},{"line_number":89,"context_line":"                           },"},{"line_number":90,"context_line":"          :step         \u003d\u003e 4,"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"6731e9f3_900ab398","line":87,"updated":"2022-05-19 16:22:38.000000000","message":"Good! You should only need to override the shares-config for additional backends.","commit_id":"9e49a709cab62b68ea32c1d76c5e753dc6152734"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"6b35e9e0edc81ea1da0529e1352037fe31d356a1","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                              \u0027CinderNfsSnapshotSupport\u0027 \u003d\u003e \u0027true\u0027,"},{"line_number":85,"context_line":"                             },"},{"line_number":86,"context_line":"                             \u0027tripleo_nfs_2\u0027 \u003d\u003e {"},{"line_number":87,"context_line":"                              \u0027CinderNfsSharesConfig\u0027 \u003d\u003e \u0027/etc/cinder/shares-nfs_2.conf\u0027,"},{"line_number":88,"context_line":"                             },"},{"line_number":89,"context_line":"                           },"},{"line_number":90,"context_line":"          :step         \u003d\u003e 4,"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"b05bd8c0_a0a81520","line":87,"in_reply_to":"6731e9f3_900ab398","updated":"2022-05-19 17:56:26.000000000","message":"Ack","commit_id":"9e49a709cab62b68ea32c1d76c5e753dc6152734"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"af2fee246b22bff7c72347596247bdfa608de591","unresolved":true,"context_lines":[{"line_number":47,"context_line":"          is_expected.to contain_cinder__backend__nfs(\u0027tripleo_nfs\u0027).with("},{"line_number":48,"context_line":"            :nfs_servers                 \u003d\u003e [\u0027127.0.0.1\u0027],"},{"line_number":49,"context_line":"            :nfs_mount_options           \u003d\u003e \u0027\u0027,"},{"line_number":50,"context_line":"            :nfs_shares_config           \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":51,"context_line":"            :nfs_snapshot_support        \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":52,"context_line":"            :nas_secure_file_operations  \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":53,"context_line":"            :nas_secure_file_permissions \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9aa250c5_42f9fe68","line":50,"updated":"2022-05-26 16:49:21.000000000","message":"This change needs to be reverted.","commit_id":"10d86c8d1534384126591e1256c4561838bc2df5"}],"spec/fixtures/hieradata/step4.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"82a77aa28b9b027009fbcbc947b843e6d21048ea","unresolved":true,"context_lines":[{"line_number":5,"context_line":"tripleo::profile::base::cinder::volume::iscsi::cinder_iscsi_address: \u0027127.0.0.1\u0027"},{"line_number":6,"context_line":"tripleo::profile::base::cinder::volume::nfs::cinder_nfs_servers:"},{"line_number":7,"context_line":" - \u0027127.0.0.1\u0027"},{"line_number":8,"context_line":"tripleo::profile::base::cinder::volume::nfs::cinder_nfs_shares_config:"},{"line_number":9,"context_line":" - \u0027/etc/cinder/shares-nfs.conf\u0027"},{"line_number":10,"context_line":"cinder::backend::dellsc_iscsi::iscsi_ip_address: \u0027127.0.0.1\u0027"},{"line_number":11,"context_line":"cinder::backend::emc_vnx::storage_vnx_pool_names: \u0027emc-storage-pool\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"79a5db1c_0245b119","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":32},"updated":"2022-05-19 16:22:38.000000000","message":"Per my previous comments, this won\u0027t be necessary if there\u0027s a default value.","commit_id":"9e49a709cab62b68ea32c1d76c5e753dc6152734"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"6b35e9e0edc81ea1da0529e1352037fe31d356a1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"tripleo::profile::base::cinder::volume::iscsi::cinder_iscsi_address: \u0027127.0.0.1\u0027"},{"line_number":6,"context_line":"tripleo::profile::base::cinder::volume::nfs::cinder_nfs_servers:"},{"line_number":7,"context_line":" - \u0027127.0.0.1\u0027"},{"line_number":8,"context_line":"tripleo::profile::base::cinder::volume::nfs::cinder_nfs_shares_config:"},{"line_number":9,"context_line":" - \u0027/etc/cinder/shares-nfs.conf\u0027"},{"line_number":10,"context_line":"cinder::backend::dellsc_iscsi::iscsi_ip_address: \u0027127.0.0.1\u0027"},{"line_number":11,"context_line":"cinder::backend::emc_vnx::storage_vnx_pool_names: \u0027emc-storage-pool\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"56edc6da_5d36490e","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":32},"in_reply_to":"79a5db1c_0245b119","updated":"2022-05-19 17:56:26.000000000","message":"Done","commit_id":"9e49a709cab62b68ea32c1d76c5e753dc6152734"}],"spec/fixtures/hieradata/step5.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"82a77aa28b9b027009fbcbc947b843e6d21048ea","unresolved":true,"context_lines":[{"line_number":36,"context_line":"  - \u0027tripleo_nfs_2\u0027"},{"line_number":37,"context_line":"tripleo::profile::base::cinder::volume::nfs::cinder_nfs_servers:"},{"line_number":38,"context_line":"  - \u0027127.0.0.1\u0027"},{"line_number":39,"context_line":"tripleo::profile::base::cinder::volume::nfs::cinder_nfs_shares_config:"},{"line_number":40,"context_line":"  - \u0027/etc/cinder/shares-nfs.conf\u0027"},{"line_number":41,"context_line":"tripleo::profile::base::cinder::volume::nfs::multi_config:"},{"line_number":42,"context_line":"  tripleo_nfs_2:"},{"line_number":43,"context_line":"    CinderNfsSharesConfig: \u0027/etc/cinder/shares-nfs_2.conf\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"34955d9a_b74b4dcf","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":33},"updated":"2022-05-19 16:22:38.000000000","message":"This shouldn\u0027t be necessary if there\u0027s a default value.","commit_id":"9e49a709cab62b68ea32c1d76c5e753dc6152734"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"6b35e9e0edc81ea1da0529e1352037fe31d356a1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  - \u0027tripleo_nfs_2\u0027"},{"line_number":37,"context_line":"tripleo::profile::base::cinder::volume::nfs::cinder_nfs_servers:"},{"line_number":38,"context_line":"  - \u0027127.0.0.1\u0027"},{"line_number":39,"context_line":"tripleo::profile::base::cinder::volume::nfs::cinder_nfs_shares_config:"},{"line_number":40,"context_line":"  - \u0027/etc/cinder/shares-nfs.conf\u0027"},{"line_number":41,"context_line":"tripleo::profile::base::cinder::volume::nfs::multi_config:"},{"line_number":42,"context_line":"  tripleo_nfs_2:"},{"line_number":43,"context_line":"    CinderNfsSharesConfig: \u0027/etc/cinder/shares-nfs_2.conf\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e81f204a_7ac226d8","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":33},"in_reply_to":"34955d9a_b74b4dcf","updated":"2022-05-19 17:56:26.000000000","message":"Done","commit_id":"9e49a709cab62b68ea32c1d76c5e753dc6152734"}]}