)]}'
{"manifests/profile/base/glance/api.pp":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"c69ed5d1053781c795136eae51dd70c90e248a44","unresolved":true,"context_lines":[{"line_number":141,"context_line":"#"},{"line_number":142,"context_line":"# [*glance_endpoint_id*]"},{"line_number":143,"context_line":"#   (Required) The glance service\u0027s endpoint id which is registered in Keystone."},{"line_number":144,"context_line":"#   defaults to None"},{"line_number":145,"context_line":"#"},{"line_number":146,"context_line":"# [*glance_user_password*]"},{"line_number":147,"context_line":"#   (Required) Password to create for the service user required in oslo/limits"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"2d202dba_9abd90e6","line":144,"updated":"2022-10-05 18:04:39.000000000","message":"the defaults are actually lookup calls. Although, those don\u0027t look quite right to me either.","commit_id":"85b7b6e5886ed53c46d00d62d6f009351296db69"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"c69ed5d1053781c795136eae51dd70c90e248a44","unresolved":true,"context_lines":[{"line_number":176,"context_line":"  $oslomsg_notify_username      \u003d lookup(\u0027oslo_messaging_notify_user_name\u0027, undef, undef, \u0027guest\u0027),"},{"line_number":177,"context_line":"  $oslomsg_notify_use_ssl       \u003d lookup(\u0027oslo_messaging_notify_use_ssl\u0027, undef, undef, \u00270\u0027),"},{"line_number":178,"context_line":"  $glance_endpoint_id           \u003d lookup(\u0027endpoint_id\u0027, undef, undef, \u0027None\u0027),"},{"line_number":179,"context_line":"  $glance_user_password         \u003d lookup(\u0027password\u0027, undef, undef, \u0027None\u0027),"},{"line_number":180,"context_line":"  $tls_proxy_bind_ip            \u003d undef,"},{"line_number":181,"context_line":"  $tls_proxy_fqdn               \u003d undef,"},{"line_number":182,"context_line":"  $tls_proxy_port               \u003d 9292,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3b687dce_78af3244","line":179,"updated":"2022-10-05 18:04:39.000000000","message":"I don\u0027t think we have top level hiera keys for endpoint_id and password that are specific to glance.","commit_id":"85b7b6e5886ed53c46d00d62d6f009351296db69"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a6fb6fbbe38d1cb5c291322befe9542a43923a60","unresolved":true,"context_lines":[{"line_number":176,"context_line":"  $oslomsg_notify_username      \u003d lookup(\u0027oslo_messaging_notify_user_name\u0027, undef, undef, \u0027guest\u0027),"},{"line_number":177,"context_line":"  $oslomsg_notify_use_ssl       \u003d lookup(\u0027oslo_messaging_notify_use_ssl\u0027, undef, undef, \u00270\u0027),"},{"line_number":178,"context_line":"  $glance_endpoint_id           \u003d lookup(\u0027endpoint_id\u0027, undef, undef, \u0027None\u0027),"},{"line_number":179,"context_line":"  $glance_user_password         \u003d lookup(\u0027password\u0027, undef, undef, \u0027None\u0027),"},{"line_number":180,"context_line":"  $tls_proxy_bind_ip            \u003d undef,"},{"line_number":181,"context_line":"  $tls_proxy_fqdn               \u003d undef,"},{"line_number":182,"context_line":"  $tls_proxy_port               \u003d 9292,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"4621f97e_3a3acbf1","line":179,"in_reply_to":"3b687dce_78af3244","updated":"2022-10-06 01:46:22.000000000","message":"I agree with James. We don\u0027t need these lookup and can just use the puppet parameters directly. I also suggest removing the \u0027glance_\u0027 prefix because it\u0027s clear this class is for glance.\n\nAlso, the password parameter is not required at puppet-tripleo layer and you can directly set it by tht.","commit_id":"85b7b6e5886ed53c46d00d62d6f009351296db69"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a6fb6fbbe38d1cb5c291322befe9542a43923a60","unresolved":true,"context_lines":[{"line_number":183,"context_line":"  $glance_enable_db_purge       \u003d true,"},{"line_number":184,"context_line":"  $glance_enable_cache          \u003d false,"},{"line_number":185,"context_line":"  $configure_apache             \u003d lookup(\u0027configure_apache\u0027, undef, undef, true),"},{"line_number":186,"context_line":"  $glance_enable_unified_quotas \u003d false,"},{"line_number":187,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":188,"context_line":"  $glance_rbd_client_name  \u003d undef,"},{"line_number":189,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"579fc85f_b74f1a18","line":186,"range":{"start_line":186,"start_character":3,"end_line":186,"end_character":31},"updated":"2022-10-06 01:46:22.000000000","message":"the glance_ prefix is redundant and can be removed.","commit_id":"85b7b6e5886ed53c46d00d62d6f009351296db69"}],"spec/classes/tripleo_profile_base_glance_api_spec.rb":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f203dc892c20d0baaa4403046d5360467bf049c0","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        is_expected.to contain_class(\u0027glance::api\u0027)"},{"line_number":72,"context_line":"        is_expected.to contain_class(\u0027glance::key_manager\u0027)"},{"line_number":73,"context_line":"        is_expected.to contain_class(\u0027glance::key_manager::barbican\u0027)"},{"line_number":74,"context_line":"        is_expected.to contain_class(\u0027glance::limit\u0027)"},{"line_number":75,"context_line":"        is_expected.to contain_class(\u0027glance::notify::rabbitmq\u0027).with("},{"line_number":76,"context_line":"          :default_transport_url      \u003d\u003e \u0027rabbit://glance1:foo@192.168.0.1:1234/?ssl\u003d0\u0027,"},{"line_number":77,"context_line":"          :notification_transport_url \u003d\u003e \u0027rabbit://glance2:baa@192.168.0.2:5678/?ssl\u003d0\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1e006fc2_b78bf1b4","line":74,"range":{"start_line":74,"start_character":38,"end_line":74,"end_character":51},"updated":"2022-07-12 12:13:41.000000000","message":"the glance::limit class requires a few parameters like endpoint_id. You need to add these to hieradata otherwise this fails because the required parameters are not given.","commit_id":"079af9f9be65d318f66820c04dd11573db1b0b52"}]}