)]}'
{"manifests/api.pp":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"2724734720be7de0e28952a35f5e85b1cd1ec1f6","unresolved":false,"context_lines":[{"line_number":327,"context_line":"    \u0027DEFAULT/heat_service_type\u0027:         value \u003d\u003e $::trove::heat_service_type;"},{"line_number":328,"context_line":"  }"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"  # notification_driver"},{"line_number":331,"context_line":"  $notification_driver_real \u003d is_string($::trove::notification_driver) ? {"},{"line_number":332,"context_line":"    true    \u003d\u003e $::trove::notification_driver,"},{"line_number":333,"context_line":"    default \u003d\u003e join($::trove::notification_driver, \u0027,\u0027)"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba15a1d1_cb02600b","line":330,"updated":"2015-09-16 08:18:39.000000000","message":"Could we rather rely on a any2array() call here to avoid this.\n\nFinal result would be \n\ntrove_config {\n\n  \u0027DEFAULT/notifications_driver\u0027: value \u003d\u003e join(any2array($::trove::notification_driver, \u0027,\u0027))\n\n ...\n\n}\n\nExamples :\n\n* https://review.openstack.org/#/c/220090/8/manifests/init.pp,cm\n\n* https://review.openstack.org/#/c/221318/1/manifests/plugins/ml2.pp,cm","commit_id":"5c02a5a00dcefbabc64f840298b195a300777d2b"}],"manifests/guestagent.pp":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"2724734720be7de0e28952a35f5e85b1cd1ec1f6","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    trove_guestagent_config {\u0027DEFAULT/os_region_name\u0027: ensure \u003d\u003e absent }"},{"line_number":104,"context_line":"  }"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  # notification_driver"},{"line_number":107,"context_line":"  $notification_driver_real \u003d is_string($::trove::notification_driver) ? {"},{"line_number":108,"context_line":"    true    \u003d\u003e $::trove::notification_driver,"},{"line_number":109,"context_line":"    default \u003d\u003e join($::trove::notification_driver, \u0027,\u0027)"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba15a1d1_2e0a0a22","line":106,"updated":"2015-09-16 08:18:39.000000000","message":"ditto","commit_id":"5c02a5a00dcefbabc64f840298b195a300777d2b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"024b0bb79d5e27b0f0c0e019d5051ab09da8e6bf","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    trove_guestagent_config {\u0027DEFAULT/os_region_name\u0027: ensure \u003d\u003e absent }"},{"line_number":104,"context_line":"  }"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  trove_guestagent_config {"},{"line_number":107,"context_line":"    \u0027DEFAULT/notification_driver\u0027: value \u003d\u003e join(any2array($::trove::notification_driver, \u0027,\u0027));"},{"line_number":108,"context_line":"    \u0027DEFAULT/notification_topics\u0027: value \u003d\u003e $::trove::notification_topics;"},{"line_number":109,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"9a68dd71_e7426c0e","line":106,"updated":"2016-01-25 22:50:32.000000000","message":"would we ever want to configure these with different values other than what is provided via the main trove class? Would it be better to add this as a configuration option to these classes but inherit trove as to allow for this to be the default value?","commit_id":"ffee17b8830c79ce6aa7645e5fdbc781859d5d09"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a6402b0f3df2f9ad350ad94d07494fc71a4b9dba","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    trove_guestagent_config {\u0027DEFAULT/os_region_name\u0027: ensure \u003d\u003e absent }"},{"line_number":104,"context_line":"  }"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  trove_guestagent_config {"},{"line_number":107,"context_line":"    \u0027DEFAULT/notification_driver\u0027: value \u003d\u003e join(any2array($::trove::notification_driver, \u0027,\u0027));"},{"line_number":108,"context_line":"    \u0027DEFAULT/notification_topics\u0027: value \u003d\u003e $::trove::notification_topics;"},{"line_number":109,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"9a68dd71_e5ac8337","line":106,"in_reply_to":"9a68dd71_70ab86d7","updated":"2016-01-26 14:51:26.000000000","message":"I don\u0027t know, which is why I was asking because it seems like adding a lack of configurability might cause problems down the road if an end user does need to make them different","commit_id":"ffee17b8830c79ce6aa7645e5fdbc781859d5d09"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7adc7f0a4a8b6200bbe14567a2f367aacc999fce","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    trove_guestagent_config {\u0027DEFAULT/os_region_name\u0027: ensure \u003d\u003e absent }"},{"line_number":104,"context_line":"  }"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  trove_guestagent_config {"},{"line_number":107,"context_line":"    \u0027DEFAULT/notification_driver\u0027: value \u003d\u003e join(any2array($::trove::notification_driver, \u0027,\u0027));"},{"line_number":108,"context_line":"    \u0027DEFAULT/notification_topics\u0027: value \u003d\u003e $::trove::notification_topics;"},{"line_number":109,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"9a68dd71_2c3600b5","line":106,"in_reply_to":"9a68dd71_d169fd26","updated":"2016-01-26 15:51:04.000000000","message":"Ok thanks.  Seems like it would be better to define it in a single config and read it all from there but that\u0027s for another discussion","commit_id":"ffee17b8830c79ce6aa7645e5fdbc781859d5d09"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"c33fe0dba94e1af1a0f021af5615002f71d772b6","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    trove_guestagent_config {\u0027DEFAULT/os_region_name\u0027: ensure \u003d\u003e absent }"},{"line_number":104,"context_line":"  }"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  trove_guestagent_config {"},{"line_number":107,"context_line":"    \u0027DEFAULT/notification_driver\u0027: value \u003d\u003e join(any2array($::trove::notification_driver, \u0027,\u0027));"},{"line_number":108,"context_line":"    \u0027DEFAULT/notification_topics\u0027: value \u003d\u003e $::trove::notification_topics;"},{"line_number":109,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"9a68dd71_d169fd26","line":106,"in_reply_to":"9a68dd71_e5ac8337","updated":"2016-01-26 15:43:46.000000000","message":"@Alex \nI have asked this question with trove developer, it seems notification_driver and notification_topics should be consistent among all the trove services，otherwise it will lead to other trove services can\u0027t receive messages.","commit_id":"ffee17b8830c79ce6aa7645e5fdbc781859d5d09"},{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"eaaf3e7ad61909873cfd27144f937d01b16ec83b","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    trove_guestagent_config {\u0027DEFAULT/os_region_name\u0027: ensure \u003d\u003e absent }"},{"line_number":104,"context_line":"  }"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  trove_guestagent_config {"},{"line_number":107,"context_line":"    \u0027DEFAULT/notification_driver\u0027: value \u003d\u003e join(any2array($::trove::notification_driver, \u0027,\u0027));"},{"line_number":108,"context_line":"    \u0027DEFAULT/notification_topics\u0027: value \u003d\u003e $::trove::notification_topics;"},{"line_number":109,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"9a68dd71_70ab86d7","line":106,"in_reply_to":"9a68dd71_e7426c0e","updated":"2016-01-26 07:49:47.000000000","message":"I think these params should be the same, do we have  the scenario need to configure different values?","commit_id":"ffee17b8830c79ce6aa7645e5fdbc781859d5d09"}],"manifests/taskmanager.pp":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"2724734720be7de0e28952a35f5e85b1cd1ec1f6","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    \u0027DEFAULT/heat_service_type\u0027:         value \u003d\u003e $::trove::heat_service_type;"},{"line_number":157,"context_line":"  }"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"  $notification_driver_real \u003d is_string($::trove::notification_driver) ? {"},{"line_number":160,"context_line":"    true    \u003d\u003e $::trove::notification_driver,"},{"line_number":161,"context_line":"    default \u003d\u003e join($::trove::notification_driver, \u0027,\u0027)"},{"line_number":162,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba15a1d1_2e21aa9f","line":159,"updated":"2015-09-16 08:18:39.000000000","message":"ditto","commit_id":"5c02a5a00dcefbabc64f840298b195a300777d2b"}]}