)]}'
{"manifests/api.pp":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"85e3c53a5901b6f630b827b5d43f5d0e8e1a116d","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"  Trove_config\u003c||\u003e ~\u003e Exec[\u0027post-trove_config\u0027]"},{"line_number":178,"context_line":"  Trove_config\u003c||\u003e ~\u003e Service[\u0027trove-api\u0027]"},{"line_number":179,"context_line":"  Package[\u0027trove-api\u0027] -\u003e Trove_config\u003c||\u003e"},{"line_number":180,"context_line":"  Package[\u0027trove-api\u0027] -\u003e Trove_api_paste_ini\u003c||\u003e"},{"line_number":181,"context_line":"  Trove_api_paste_ini\u003c||\u003e ~\u003e Service[\u0027trove-api\u0027]"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba15a1d1_6eea4211","line":179,"updated":"2015-09-16 08:11:06.000000000","message":"This module wasn\u0027t part of the autorequire batch because of the hack this reviews aims to fix.\n\nCould you please remove those constraints at this level and add them directly in the Trove_config type as an autorequire, here is the cinder example[1]\n\n[1]https://github.com/openstack/puppet-cinder/commit/69bfb7cb815d95cffebfeb7f46384e04548ba64d","commit_id":"b983f26cc85228c076327006c8a29490d6ed86ab"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"85e3c53a5901b6f630b827b5d43f5d0e8e1a116d","unresolved":false,"context_lines":[{"line_number":177,"context_line":"  Trove_config\u003c||\u003e ~\u003e Exec[\u0027post-trove_config\u0027]"},{"line_number":178,"context_line":"  Trove_config\u003c||\u003e ~\u003e Service[\u0027trove-api\u0027]"},{"line_number":179,"context_line":"  Package[\u0027trove-api\u0027] -\u003e Trove_config\u003c||\u003e"},{"line_number":180,"context_line":"  Package[\u0027trove-api\u0027] -\u003e Trove_api_paste_ini\u003c||\u003e"},{"line_number":181,"context_line":"  Trove_api_paste_ini\u003c||\u003e ~\u003e Service[\u0027trove-api\u0027]"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"  if $::trove::database_connection {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba15a1d1_4ef73ef5","line":180,"updated":"2015-09-16 08:11:06.000000000","message":"ditto","commit_id":"b983f26cc85228c076327006c8a29490d6ed86ab"}],"manifests/conductor.pp":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"85e3c53a5901b6f630b827b5d43f5d0e8e1a116d","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  include ::trove::params"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  Package[$::trove::params::conductor_package_name] -\u003e Trove_conductor_config\u003c||\u003e"},{"line_number":70,"context_line":"  Trove_conductor_config\u003c||\u003e ~\u003e Exec[\u0027post-trove_config\u0027]"},{"line_number":71,"context_line":"  Trove_conductor_config\u003c||\u003e ~\u003e Service[\u0027trove-conductor\u0027]"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba15a1d1_aee85a11","line":69,"updated":"2015-09-16 08:11:06.000000000","message":"ditto","commit_id":"b983f26cc85228c076327006c8a29490d6ed86ab"}],"manifests/guestagent.pp":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"85e3c53a5901b6f630b827b5d43f5d0e8e1a116d","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  include ::trove::params"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  Package[$::trove::params::guestagent_package_name] -\u003e Trove_guestagent_config\u003c||\u003e"},{"line_number":75,"context_line":"  Trove_guestagent_config\u003c||\u003e ~\u003e Exec[\u0027post-trove_config\u0027]"},{"line_number":76,"context_line":"  Trove_guestagent_config\u003c||\u003e ~\u003e Service[\u0027trove-guestagent\u0027]"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba15a1d1_8ed47647","line":74,"updated":"2015-09-16 08:11:06.000000000","message":"ditto","commit_id":"b983f26cc85228c076327006c8a29490d6ed86ab"}],"spec/unit/type/trove_conductor_config_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0b8d1cd9b22653ef247f66b7ced35fe2826ab904","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027puppet\u0027"},{"line_number":2,"context_line":"require \u0027puppet/type/trove_conductor_config\u0027"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"describe \u0027Puppet::Type.type(:trove_conductor_config)\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9a8ffd7b_ae0d24e9","line":1,"updated":"2015-11-30 10:51:03.000000000","message":"this is out of context of the patch.","commit_id":"aaf6a8e0ab2415e87104595979151c51a93c5def"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"54e533d6a4f044aa18ddf052e04aee36bb8bb315","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    @trove_conductor_config \u003d Puppet::Type.type(:trove_conductor_config).new(:name \u003d\u003e \u0027DEFAULT/foo\u0027, :value \u003d\u003e \u0027bar\u0027)"},{"line_number":6,"context_line":"  end"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  it \u0027sould autorequire the package that installs the file\u0027 do"},{"line_number":9,"context_line":"    catalog \u003d Puppet::Resource::Catalog.new"},{"line_number":10,"context_line":"    package \u003d Puppet::Type.type(:package).new(:name \u003d\u003e \u0027trove-conductor\u0027)"},{"line_number":11,"context_line":"    catalog.add_resource package, @trove_conductor_config"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"9a8ffd7b_36c77997","line":8,"updated":"2015-12-03 12:04:39.000000000","message":"should","commit_id":"2cc93502bc5841073f52cceda620cc81b00d2be0"}],"spec/unit/type/trove_conductor_guestagent_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0b8d1cd9b22653ef247f66b7ced35fe2826ab904","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027puppet\u0027"},{"line_number":2,"context_line":"require \u0027puppet/type/trove_guestagent_config\u0027"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"describe \u0027Puppet::Type.type(:trove_guestagent_config)\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9a8ffd7b_ce10a802","line":1,"updated":"2015-11-30 10:51:03.000000000","message":"this is out of context of the patch.","commit_id":"aaf6a8e0ab2415e87104595979151c51a93c5def"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"54e533d6a4f044aa18ddf052e04aee36bb8bb315","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    @trove_guestagent_config \u003d Puppet::Type.type(:trove_guestagent_config).new(:name \u003d\u003e \u0027DEFAULT/foo\u0027, :value \u003d\u003e \u0027bar\u0027)"},{"line_number":6,"context_line":"  end"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  it \u0027sould autorequire the package that installs the file\u0027 do"},{"line_number":9,"context_line":"    catalog \u003d Puppet::Resource::Catalog.new"},{"line_number":10,"context_line":"    package \u003d Puppet::Type.type(:package).new(:name \u003d\u003e \u0027trove-guestagent\u0027)"},{"line_number":11,"context_line":"    catalog.add_resource package, @trove_guestagent_config"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"9a8ffd7b_16b83510","line":8,"updated":"2015-12-03 12:04:39.000000000","message":"should","commit_id":"2cc93502bc5841073f52cceda620cc81b00d2be0"}],"spec/unit/type/trove_config_spec.rb":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"54e533d6a4f044aa18ddf052e04aee36bb8bb315","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    }.to raise_error(Puppet::Error, /Invalid value/)"},{"line_number":51,"context_line":"  end"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  it \u0027sould autorequire the package that installs the file\u0027 do"},{"line_number":54,"context_line":"    catalog \u003d Puppet::Resource::Catalog.new"},{"line_number":55,"context_line":"    package \u003d Puppet::Type.type(:package).new(:name \u003d\u003e \u0027trove-api\u0027)"},{"line_number":56,"context_line":"    catalog.add_resource package, @trove_config"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"9a8ffd7b_763f4187","line":53,"updated":"2015-12-03 12:04:39.000000000","message":"should","commit_id":"2cc93502bc5841073f52cceda620cc81b00d2be0"}]}