)]}'
{"manifests/api.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5e3a278651c81d26c9fb4d11eb6ddcadacd256c4","unresolved":false,"context_lines":[{"line_number":184,"context_line":"  $ensure_package               \u003d \u0027present\u0027,"},{"line_number":185,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":186,"context_line":"  $auth_host                    \u003d undef,"},{"line_number":187,"context_line":"  $auth_url                     \u003d false,"},{"line_number":188,"context_line":"  $auth_port                    \u003d undef,"},{"line_number":189,"context_line":"  $auth_protocol                \u003d undef,"},{"line_number":190,"context_line":") inherits trove {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a29b11f_69bc3f06","line":187,"updated":"2015-10-21 19:52:55.000000000","message":"why it false? should be undef, i guess","commit_id":"e3a43cee0029cdcf33e0945338d62951fdcf6f77"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"8c8f5db2d7c7df8ad1ed508728a641cf9461f335","unresolved":false,"context_lines":[{"line_number":245,"context_line":"  }"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"  # auth config"},{"line_number":248,"context_line":"  if $auth_host or $auth_port or $auth_protocol {"},{"line_number":249,"context_line":"    if $auth_host {"},{"line_number":250,"context_line":"      warning(\u0027The auth_host parameter is deprecated. Use identity_uri parameter instead\u0027)"},{"line_number":251,"context_line":"      $auth_host_real \u003d $auth_host"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_ba7060dd","line":248,"updated":"2015-11-06 12:54:45.000000000","message":"In the other modules, this test tends to be of the form:\n    if !$auth_uri or !$identity_uri {\n\nWhy is this module different?","commit_id":"beecafd16e2109a2bb2ddf54dc147eb2dc68f6c6"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"dd4fbdf73472c0622e16cdb2ec36f93f25840d15","unresolved":false,"context_lines":[{"line_number":245,"context_line":"  }"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"  # auth config"},{"line_number":248,"context_line":"  if $auth_host or $auth_port or $auth_protocol {"},{"line_number":249,"context_line":"    if $auth_host {"},{"line_number":250,"context_line":"      warning(\u0027The auth_host parameter is deprecated. Use identity_uri parameter instead\u0027)"},{"line_number":251,"context_line":"      $auth_host_real \u003d $auth_host"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da85f559_34909eec","line":248,"in_reply_to":"da85f559_14f23a9b","updated":"2015-11-06 21:39:50.000000000","message":"The topic of problem is in if structure.\n\nSo, i really don\u0027t understand, why we need to test deprecated values, if BOTH new parameters passed.\n\nWhat we have in your case: if passed some deprecated parameter (with both new), it will be pass into config - hence can be raised warning although we pass new parameters - that\u0027s strange for me.","commit_id":"beecafd16e2109a2bb2ddf54dc147eb2dc68f6c6"},{"author":{"_account_id":13953,"name":"Elise Gafford","email":"egafford@redhat.com","username":"egafford"},"change_message_id":"0feeea641b93185be5f82f342d9f5710b2fc9fe8","unresolved":false,"context_lines":[{"line_number":245,"context_line":"  }"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"  # auth config"},{"line_number":248,"context_line":"  if $auth_host or $auth_port or $auth_protocol {"},{"line_number":249,"context_line":"    if $auth_host {"},{"line_number":250,"context_line":"      warning(\u0027The auth_host parameter is deprecated. Use identity_uri parameter instead\u0027)"},{"line_number":251,"context_line":"      $auth_host_real \u003d $auth_host"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da85f559_39321860","line":248,"in_reply_to":"da85f559_34909eec","updated":"2015-11-11 20:43:01.000000000","message":"So, I agree with you if parameters that default to, say, \u0027http://127.0.0.1:5000/v2.0/\u0027 equate to boolean false. In that case, yes, we should switch on the new params. If default values equate to boolean true, then I believe that switching on ($auth_uri and $identity_uri ) would always be true (in the case of a tool using the old params, the new params would be unset, would default, and the expression would be true, meaning that the construction from URL parts would be skipped, breaking backward compatibility.)\n\nIf parameters that default equate to boolean false when tested in puppet, then you are right, and I will gladly change this. If they equate to boolean true (which would be more normal for non-empty string values), then I believe that my patch is the right path to preserve backward compatibility.","commit_id":"beecafd16e2109a2bb2ddf54dc147eb2dc68f6c6"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7e92adb358dd2aa4fd21c9a4ab3c29c8c0148a40","unresolved":false,"context_lines":[{"line_number":245,"context_line":"  }"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"  # auth config"},{"line_number":248,"context_line":"  if $auth_host or $auth_port or $auth_protocol {"},{"line_number":249,"context_line":"    if $auth_host {"},{"line_number":250,"context_line":"      warning(\u0027The auth_host parameter is deprecated. Use identity_uri parameter instead\u0027)"},{"line_number":251,"context_line":"      $auth_host_real \u003d $auth_host"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da85f559_788f1975","line":248,"in_reply_to":"da85f559_39321860","updated":"2015-11-12 11:25:27.000000000","message":"Take a look on another modules (as mentioned Clayton), for example: heat.\n\nhttps://github.com/openstack/puppet-heat/blob/master/manifests/init.pp#L445-L446\n\nThis is (in my opinion) how should to work deprecation policy and raising warnings.\n\nWe should use as start point existence/lack of both $identity_uri AND $auth_url.","commit_id":"beecafd16e2109a2bb2ddf54dc147eb2dc68f6c6"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"78e08c4bc0282fbf833d4e8b3a7de4ff6f0a29c0","unresolved":false,"context_lines":[{"line_number":245,"context_line":"  }"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"  # auth config"},{"line_number":248,"context_line":"  if $auth_host or $auth_port or $auth_protocol {"},{"line_number":249,"context_line":"    if $auth_host {"},{"line_number":250,"context_line":"      warning(\u0027The auth_host parameter is deprecated. Use identity_uri parameter instead\u0027)"},{"line_number":251,"context_line":"      $auth_host_real \u003d $auth_host"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da85f559_4c75a52f","line":248,"in_reply_to":"da85f559_69173b45","updated":"2015-11-12 15:42:10.000000000","message":"Actually, i probably were wrong. We have same as your solution for keystone/auth.\n\nhttps://github.com/openstack/puppet-heat/blob/master/manifests/keystone/auth.pp#L207","commit_id":"beecafd16e2109a2bb2ddf54dc147eb2dc68f6c6"},{"author":{"_account_id":13953,"name":"Elise Gafford","email":"egafford@redhat.com","username":"egafford"},"change_message_id":"74161e10056cf7f04c8b81a1bac87c22cd16ad44","unresolved":false,"context_lines":[{"line_number":245,"context_line":"  }"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"  # auth config"},{"line_number":248,"context_line":"  if $auth_host or $auth_port or $auth_protocol {"},{"line_number":249,"context_line":"    if $auth_host {"},{"line_number":250,"context_line":"      warning(\u0027The auth_host parameter is deprecated. Use identity_uri parameter instead\u0027)"},{"line_number":251,"context_line":"      $auth_host_real \u003d $auth_host"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da85f559_14f23a9b","line":248,"in_reply_to":"da85f559_7492a659","updated":"2015-11-06 21:30:59.000000000","message":"Some installers may be depending on any subset of these variables being set, and the rest defaulting to their previous values. Future products don\u0027t care about these variables, but previous ones do; I am attempting to be fully backward compatible with any existing product.\n\nThe reason to test all of the parameters in one set is that if any of the deprecated params are set, the others need to default to their previous defaults so that they can be concatenated and generate the same URL.\n\nIf this is actively undesirable for some reason and we think it\u0027s more important to achieve code clarity than to keep existing installers working, then we should change it, but that seems strange to me.","commit_id":"beecafd16e2109a2bb2ddf54dc147eb2dc68f6c6"},{"author":{"_account_id":13953,"name":"Elise Gafford","email":"egafford@redhat.com","username":"egafford"},"change_message_id":"e9c82b3fffd1a7cf49ba65d42315661e20b2cc2f","unresolved":false,"context_lines":[{"line_number":245,"context_line":"  }"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"  # auth config"},{"line_number":248,"context_line":"  if $auth_host or $auth_port or $auth_protocol {"},{"line_number":249,"context_line":"    if $auth_host {"},{"line_number":250,"context_line":"      warning(\u0027The auth_host parameter is deprecated. Use identity_uri parameter instead\u0027)"},{"line_number":251,"context_line":"      $auth_host_real \u003d $auth_host"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da85f559_69173b45","line":248,"in_reply_to":"da85f559_788f1975","updated":"2015-11-12 15:20:47.000000000","message":"Okay, so you don\u0027t want default values for auth_uri and identity_uri. I think those defaults are a bit useful to have, but your way works, and I don\u0027t care much. I\u0027ll change it.","commit_id":"beecafd16e2109a2bb2ddf54dc147eb2dc68f6c6"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"9cac459eefe8f65338cce8b63ed472258d89d6de","unresolved":false,"context_lines":[{"line_number":245,"context_line":"  }"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"  # auth config"},{"line_number":248,"context_line":"  if $auth_host or $auth_port or $auth_protocol {"},{"line_number":249,"context_line":"    if $auth_host {"},{"line_number":250,"context_line":"      warning(\u0027The auth_host parameter is deprecated. Use identity_uri parameter instead\u0027)"},{"line_number":251,"context_line":"      $auth_host_real \u003d $auth_host"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da85f559_7492a659","line":248,"in_reply_to":"fa80f949_9e6789e8","updated":"2015-11-06 21:25:53.000000000","message":"I disagree with you Ethan and partially agree with Clayton. If you specified both new parameters, you don\u0027t care about deprecated parameters. Any reasons to test all of parameters in one set?","commit_id":"beecafd16e2109a2bb2ddf54dc147eb2dc68f6c6"},{"author":{"_account_id":13953,"name":"Elise Gafford","email":"egafford@redhat.com","username":"egafford"},"change_message_id":"4927c8169f47c88ef62b334b83651e1bb9cb2b18","unresolved":false,"context_lines":[{"line_number":245,"context_line":"  }"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"  # auth config"},{"line_number":248,"context_line":"  if $auth_host or $auth_port or $auth_protocol {"},{"line_number":249,"context_line":"    if $auth_host {"},{"line_number":250,"context_line":"      warning(\u0027The auth_host parameter is deprecated. Use identity_uri parameter instead\u0027)"},{"line_number":251,"context_line":"      $auth_host_real \u003d $auth_host"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da85f559_149eba63","line":248,"in_reply_to":"fa80f949_ba7060dd","updated":"2015-11-12 19:49:32.000000000","message":"Hi Clayton,\n\nDenis and I discussed this, but the reason is effectively that this logical path allows us to have default values for the non-deprecated parameters, and to avoid warnings in the case in which no arguments (deprecated or new) are provided. Thoughts?","commit_id":"beecafd16e2109a2bb2ddf54dc147eb2dc68f6c6"},{"author":{"_account_id":13953,"name":"Elise Gafford","email":"egafford@redhat.com","username":"egafford"},"change_message_id":"c6f6a12108512ff74a8549256a8a23c73ecdd390","unresolved":false,"context_lines":[{"line_number":245,"context_line":"  }"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"  # auth config"},{"line_number":248,"context_line":"  if $auth_host or $auth_port or $auth_protocol {"},{"line_number":249,"context_line":"    if $auth_host {"},{"line_number":250,"context_line":"      warning(\u0027The auth_host parameter is deprecated. Use identity_uri parameter instead\u0027)"},{"line_number":251,"context_line":"      $auth_host_real \u003d $auth_host"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa80f949_9e6789e8","line":248,"in_reply_to":"fa80f949_ba7060dd","updated":"2015-11-06 14:48:52.000000000","message":"The deprecated parameters, if set, need to take precedence for backward compatibility, yes?","commit_id":"beecafd16e2109a2bb2ddf54dc147eb2dc68f6c6"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"78e08c4bc0282fbf833d4e8b3a7de4ff6f0a29c0","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    $identity_uri_real \u003d $identity_uri"},{"line_number":270,"context_line":"  }"},{"line_number":271,"context_line":"  trove_config {"},{"line_number":272,"context_line":"    \u0027DEFAULT/trove_auth_url\u0027:               value \u003d\u003e $auth_uri_real;"},{"line_number":273,"context_line":"    \u0027keystone_authtoken/auth_uri\u0027:          value \u003d\u003e $auth_uri_real;"},{"line_number":274,"context_line":"    \u0027keystone_authtoken/identity_uri\u0027:      value \u003d\u003e $identity_uri_real;"},{"line_number":275,"context_line":"    \u0027keystone_authtoken/admin_tenant_name\u0027: value \u003d\u003e $keystone_tenant;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da85f559_aca1b195","line":272,"updated":"2015-11-12 15:42:10.000000000","message":"trove_auth_url - bad copy-past?","commit_id":"beecafd16e2109a2bb2ddf54dc147eb2dc68f6c6"},{"author":{"_account_id":13953,"name":"Elise Gafford","email":"egafford@redhat.com","username":"egafford"},"change_message_id":"75f844c53ed1c6f69d7ad94e6408b91645c19814","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    $identity_uri_real \u003d $identity_uri"},{"line_number":270,"context_line":"  }"},{"line_number":271,"context_line":"  trove_config {"},{"line_number":272,"context_line":"    \u0027DEFAULT/trove_auth_url\u0027:               value \u003d\u003e $auth_uri_real;"},{"line_number":273,"context_line":"    \u0027keystone_authtoken/auth_uri\u0027:          value \u003d\u003e $auth_uri_real;"},{"line_number":274,"context_line":"    \u0027keystone_authtoken/identity_uri\u0027:      value \u003d\u003e $identity_uri_real;"},{"line_number":275,"context_line":"    \u0027keystone_authtoken/admin_tenant_name\u0027: value \u003d\u003e $keystone_tenant;"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da85f559_d7de023d","line":272,"in_reply_to":"da85f559_aca1b195","updated":"2015-11-12 15:51:57.000000000","message":"I think this is right; per https://github.com/openstack/trove/blob/master/etc/trove/trove.conf.sample, this is the name and section in which that\u0027s configured.","commit_id":"beecafd16e2109a2bb2ddf54dc147eb2dc68f6c6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f76520d797c803e8b41c62048e8b47d2ba7dcbf0","unresolved":false,"context_lines":[{"line_number":224,"context_line":"  }"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"  # auth config"},{"line_number":227,"context_line":"  if $auth_host or $auth_port or $auth_protocol {"},{"line_number":228,"context_line":"    if $auth_host {"},{"line_number":229,"context_line":"      warning(\u0027The auth_host parameter is deprecated. Use identity_uri parameter instead\u0027)"},{"line_number":230,"context_line":"      $auth_host_real \u003d $auth_host"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3a7e1126_c06d7905","line":227,"updated":"2015-12-17 19:22:20.000000000","message":"the way you deprecated it is not consistent with how Dan Prince did in puppet-neutron.","commit_id":"51ec054a1f9339e771b3e308d151add8358f3df0"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f76520d797c803e8b41c62048e8b47d2ba7dcbf0","unresolved":false,"context_lines":[{"line_number":227,"context_line":"  if $auth_host or $auth_port or $auth_protocol {"},{"line_number":228,"context_line":"    if $auth_host {"},{"line_number":229,"context_line":"      warning(\u0027The auth_host parameter is deprecated. Use identity_uri parameter instead\u0027)"},{"line_number":230,"context_line":"      $auth_host_real \u003d $auth_host"},{"line_number":231,"context_line":"    } else {"},{"line_number":232,"context_line":"      $auth_host_real \u003d \u0027127.0.0.1\u0027"},{"line_number":233,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3a7e1126_e070b5de","line":230,"updated":"2015-12-17 19:22:20.000000000","message":"I think this is useless, you can directly construct the url by using auth_ parameters defined by the user.","commit_id":"51ec054a1f9339e771b3e308d151add8358f3df0"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f76520d797c803e8b41c62048e8b47d2ba7dcbf0","unresolved":false,"context_lines":[{"line_number":229,"context_line":"      warning(\u0027The auth_host parameter is deprecated. Use identity_uri parameter instead\u0027)"},{"line_number":230,"context_line":"      $auth_host_real \u003d $auth_host"},{"line_number":231,"context_line":"    } else {"},{"line_number":232,"context_line":"      $auth_host_real \u003d \u0027127.0.0.1\u0027"},{"line_number":233,"context_line":"    }"},{"line_number":234,"context_line":"    if $auth_port {"},{"line_number":235,"context_line":"      warning(\u0027The auth_port parameter is deprecated. Use identity_uri parameter instead\u0027)"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3a7e1126_8078d1c5","line":232,"updated":"2015-12-17 19:22:20.000000000","message":"how come you default it to 127.0.0.1?","commit_id":"51ec054a1f9339e771b3e308d151add8358f3df0"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f76520d797c803e8b41c62048e8b47d2ba7dcbf0","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    } else {"},{"line_number":244,"context_line":"      $auth_protocol_real \u003d \u0027http\u0027"},{"line_number":245,"context_line":"    }"},{"line_number":246,"context_line":"    $identity_uri_real \u003d \"${auth_protocol_real}://${auth_host_real}:${auth_port_real}/\""},{"line_number":247,"context_line":"  } else {"},{"line_number":248,"context_line":"    $identity_uri_real \u003d $identity_uri"},{"line_number":249,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3a7e1126_a0738de6","line":246,"updated":"2015-12-17 19:22:20.000000000","message":"I\u0027m not sure you need the _real thing for auth_ params.\n\nPlease look how dprince did, which is the way we did in some modules.","commit_id":"51ec054a1f9339e771b3e308d151add8358f3df0"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"cfc5ece5e7cbd5ac48b6ec76f5ba93a6596b2816","unresolved":false,"context_lines":[{"line_number":189,"context_line":"  $ensure_package               \u003d \u0027present\u0027,"},{"line_number":190,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":191,"context_line":"  $auth_host                    \u003d \u0027127.0.0.1\u0027,"},{"line_number":192,"context_line":"  $auth_url                     \u003d \u0027http://localhost:5000/v2.0\u0027,"},{"line_number":193,"context_line":"  $auth_port                    \u003d \u002735357\u0027,"},{"line_number":194,"context_line":"  $auth_protocol                \u003d \u0027http\u0027,"},{"line_number":195,"context_line":") inherits trove {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fa69d971_add753be","line":192,"updated":"2016-01-07 18:29:02.000000000","message":"This is completely unused in this version. Shouldn\u0027t this be used in some form if auth_uri is not provided?  Should the priority of these vars be $auth_uri then $auth_url then construct url with $auth_* params?","commit_id":"0c9f54f5af7b4df94c3957572bd353269650e506"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7d505b9ffdc8dad0a10974fa140126e50be546f8","unresolved":false,"context_lines":[{"line_number":153,"context_line":"#   Protocol to use for auth."},{"line_number":154,"context_line":"#   Defaults to \u0027http\u0027."},{"line_number":155,"context_line":"#"},{"line_number":156,"context_line":"# [*auth_url*]"},{"line_number":157,"context_line":"#   (optional) DEPRECATED: Use auth_uri instead."},{"line_number":158,"context_line":"#   Authentication URL."},{"line_number":159,"context_line":"#   Defaults to \u0027http://localhost:5000/v2.0\u0027."}],"source_content_type":"text/x-puppet","patch_set":7,"id":"da6ed579_881cca14","line":156,"updated":"2016-01-16 00:17:30.000000000","message":"where do you use it? I see no deprecation message for it...","commit_id":"314a234d24a14934afa3884993fdde4421721b06"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7d505b9ffdc8dad0a10974fa140126e50be546f8","unresolved":false,"context_lines":[{"line_number":171,"context_line":"  $bind_port                    \u003d \u00278779\u0027,"},{"line_number":172,"context_line":"  $backlog                      \u003d \u00274096\u0027,"},{"line_number":173,"context_line":"  $workers                      \u003d $::processorcount,"},{"line_number":174,"context_line":"  $auth_uri                     \u003d false,"},{"line_number":175,"context_line":"  $identity_uri                 \u003d false,"},{"line_number":176,"context_line":"  $keystone_tenant              \u003d \u0027services\u0027,"},{"line_number":177,"context_line":"  $keystone_user                \u003d \u0027trove\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"da6ed579_68cdd685","line":174,"updated":"2016-01-16 00:17:30.000000000","message":"no, you should set the right values by default:\nhttp://127.0.0.1:5000/\n\nLike we do in other modules...","commit_id":"314a234d24a14934afa3884993fdde4421721b06"},{"author":{"_account_id":13953,"name":"Elise Gafford","email":"egafford@redhat.com","username":"egafford"},"change_message_id":"da3ab1bc9e70a66af00be54fbd7814fe742d75e2","unresolved":false,"context_lines":[{"line_number":171,"context_line":"  $bind_port                    \u003d \u00278779\u0027,"},{"line_number":172,"context_line":"  $backlog                      \u003d \u00274096\u0027,"},{"line_number":173,"context_line":"  $workers                      \u003d $::processorcount,"},{"line_number":174,"context_line":"  $auth_uri                     \u003d false,"},{"line_number":175,"context_line":"  $identity_uri                 \u003d false,"},{"line_number":176,"context_line":"  $keystone_tenant              \u003d \u0027services\u0027,"},{"line_number":177,"context_line":"  $keystone_user                \u003d \u0027trove\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9a68dd71_46eec7ed","line":174,"in_reply_to":"da6ed579_68cdd685","updated":"2016-01-20 14:51:20.000000000","message":"I think this would be a problem, actually; if we set defaults for the new params, older installers that don\u0027t set them will be overridden when they try to set auth_url or any of (auth_host, auth_port, and auth_protocol).","commit_id":"314a234d24a14934afa3884993fdde4421721b06"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7d505b9ffdc8dad0a10974fa140126e50be546f8","unresolved":false,"context_lines":[{"line_number":172,"context_line":"  $backlog                      \u003d \u00274096\u0027,"},{"line_number":173,"context_line":"  $workers                      \u003d $::processorcount,"},{"line_number":174,"context_line":"  $auth_uri                     \u003d false,"},{"line_number":175,"context_line":"  $identity_uri                 \u003d false,"},{"line_number":176,"context_line":"  $keystone_tenant              \u003d \u0027services\u0027,"},{"line_number":177,"context_line":"  $keystone_user                \u003d \u0027trove\u0027,"},{"line_number":178,"context_line":"  $enabled                      \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"da6ed579_88ca8a6d","line":175,"updated":"2016-01-16 00:17:30.000000000","message":"no, you should set the right values by default:\nhttp://127.0.0.1:35357/\n\nLike we do in other modules...","commit_id":"314a234d24a14934afa3884993fdde4421721b06"},{"author":{"_account_id":13953,"name":"Elise Gafford","email":"egafford@redhat.com","username":"egafford"},"change_message_id":"da3ab1bc9e70a66af00be54fbd7814fe742d75e2","unresolved":false,"context_lines":[{"line_number":172,"context_line":"  $backlog                      \u003d \u00274096\u0027,"},{"line_number":173,"context_line":"  $workers                      \u003d $::processorcount,"},{"line_number":174,"context_line":"  $auth_uri                     \u003d false,"},{"line_number":175,"context_line":"  $identity_uri                 \u003d false,"},{"line_number":176,"context_line":"  $keystone_tenant              \u003d \u0027services\u0027,"},{"line_number":177,"context_line":"  $keystone_user                \u003d \u0027trove\u0027,"},{"line_number":178,"context_line":"  $enabled                      \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9a68dd71_663f4b26","line":175,"in_reply_to":"da6ed579_88ca8a6d","updated":"2016-01-20 14:51:20.000000000","message":"I think this would be a problem, actually; if we set defaults for the new params, older installers that don\u0027t set them will be overridden when they try to set auth_url or any of (auth_host, auth_port, and auth_protocol).","commit_id":"314a234d24a14934afa3884993fdde4421721b06"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7d505b9ffdc8dad0a10974fa140126e50be546f8","unresolved":false,"context_lines":[{"line_number":189,"context_line":"  $ensure_package               \u003d \u0027present\u0027,"},{"line_number":190,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":191,"context_line":"  $auth_host                    \u003d \u0027127.0.0.1\u0027,"},{"line_number":192,"context_line":"  $auth_url                     \u003d \u0027http://localhost:5000/v2.0\u0027,"},{"line_number":193,"context_line":"  $auth_port                    \u003d \u002735357\u0027,"},{"line_number":194,"context_line":"  $auth_protocol                \u003d \u0027http\u0027,"},{"line_number":195,"context_line":") inherits trove {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"da6ed579_e886a615","line":192,"updated":"2016-01-16 00:17:30.000000000","message":"where do you use it?","commit_id":"314a234d24a14934afa3884993fdde4421721b06"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7d505b9ffdc8dad0a10974fa140126e50be546f8","unresolved":false,"context_lines":[{"line_number":228,"context_line":"      \u0027keystone_authtoken/auth_uri\u0027 : value \u003d\u003e $auth_uri;"},{"line_number":229,"context_line":"    }"},{"line_number":230,"context_line":"  } else {"},{"line_number":231,"context_line":"    $auth_uri_real \u003d \"${auth_protocol}://${auth_host}:5000/v2.0\""},{"line_number":232,"context_line":"    trove_config {"},{"line_number":233,"context_line":"      \u0027DEFAULT/trove_auth_url\u0027      : value \u003d\u003e $auth_uri_real;"},{"line_number":234,"context_line":"      \u0027keystone_authtoken/auth_uri\u0027 : value \u003d\u003e $auth_uri_real;"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"da6ed579_68e63618","line":231,"updated":"2016-01-16 00:17:30.000000000","message":"without v2.0 would be consistent with other modules.","commit_id":"314a234d24a14934afa3884993fdde4421721b06"}],"spec/acceptance/basic_trove_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5e3a278651c81d26c9fb4d11eb6ddcadacd256c4","unresolved":false,"context_lines":[{"line_number":111,"context_line":"      }"},{"line_number":112,"context_line":"      class { \u0027::trove::api\u0027:"},{"line_number":113,"context_line":"        keystone_password \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":114,"context_line":"        identity_uri      \u003d\u003e \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":115,"context_line":"        debug             \u003d\u003e true,"},{"line_number":116,"context_line":"        verbose           \u003d\u003e true,"},{"line_number":117,"context_line":"      }"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3a29b11f_6953dfe2","line":114,"updated":"2015-10-21 19:52:55.000000000","message":"it is similar to default value. I think we can drop this.","commit_id":"e3a43cee0029cdcf33e0945338d62951fdcf6f77"}],"spec/classes/trove_api_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4747571de69a9dd2132927ab2858464462df8114","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        is_expected.to contain_trove_config(\u0027DEFAULT/nova_proxy_admin_pass\u0027).with_value(\u0027verysecrete\u0027)"},{"line_number":72,"context_line":"        is_expected.to contain_trove_config(\u0027DEFAULT/nova_proxy_admin_tenant_name\u0027).with_value(\u0027admin\u0027)"},{"line_number":73,"context_line":"        is_expected.to contain_trove_config(\u0027keystone_authtoken/auth_uri\u0027).with_value(\u0027http://10.0.0.10:5000/v2.0/\u0027)"},{"line_number":74,"context_line":"        is_expected.to contain_trove_config(\u0027keystone_authtoken/identity_uri\u0027).with_value(\u0027http://10.0.0.10:35357/\u0027)"},{"line_number":75,"context_line":"        is_expected.to contain_trove_config(\u0027keystone_authtoken/admin_tenant_name\u0027).with_value(\u0027_services_\u0027)"},{"line_number":76,"context_line":"        is_expected.to contain_trove_config(\u0027keystone_authtoken/admin_user\u0027).with_value(\u0027trove\u0027)"},{"line_number":77,"context_line":"        is_expected.to contain_trove_config(\u0027keystone_authtoken/admin_password\u0027).with_value(\u0027passw0rd\u0027)"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3a29b11f_2e8acd1b","line":74,"updated":"2015-10-21 19:30:19.000000000","message":"instead of editing current tests, you should rather add new context to test the new parameters, like it\u0027s done in other modules.","commit_id":"e3a43cee0029cdcf33e0945338d62951fdcf6f77"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5e3a278651c81d26c9fb4d11eb6ddcadacd256c4","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        is_expected.to contain_trove_config(\u0027DEFAULT/nova_proxy_admin_pass\u0027).with_value(\u0027verysecrete\u0027)"},{"line_number":72,"context_line":"        is_expected.to contain_trove_config(\u0027DEFAULT/nova_proxy_admin_tenant_name\u0027).with_value(\u0027admin\u0027)"},{"line_number":73,"context_line":"        is_expected.to contain_trove_config(\u0027keystone_authtoken/auth_uri\u0027).with_value(\u0027http://10.0.0.10:5000/v2.0/\u0027)"},{"line_number":74,"context_line":"        is_expected.to contain_trove_config(\u0027keystone_authtoken/identity_uri\u0027).with_value(\u0027http://10.0.0.10:35357/\u0027)"},{"line_number":75,"context_line":"        is_expected.to contain_trove_config(\u0027keystone_authtoken/admin_tenant_name\u0027).with_value(\u0027_services_\u0027)"},{"line_number":76,"context_line":"        is_expected.to contain_trove_config(\u0027keystone_authtoken/admin_user\u0027).with_value(\u0027trove\u0027)"},{"line_number":77,"context_line":"        is_expected.to contain_trove_config(\u0027keystone_authtoken/admin_password\u0027).with_value(\u0027passw0rd\u0027)"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3a29b11f_4965c3b2","line":74,"in_reply_to":"3a29b11f_2e8acd1b","updated":"2015-10-21 19:52:55.000000000","message":"Agreed with Emilien. You should keep testing of deprecated params.","commit_id":"e3a43cee0029cdcf33e0945338d62951fdcf6f77"}]}