)]}'
{"manifests/api.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9be66efd02279942b93f3af510acd57b3c45d288","unresolved":false,"context_lines":[{"line_number":146,"context_line":"#"},{"line_number":147,"context_line":"class trove::api("},{"line_number":148,"context_line":"  $keystone_password,"},{"line_number":149,"context_line":"  $verbose                      \u003d undef,"},{"line_number":150,"context_line":"  $debug                        \u003d undef,"},{"line_number":151,"context_line":"  $use_syslog                   \u003d undef,"},{"line_number":152,"context_line":"  $use_stderr                   \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9a8ffd7b_4cd64050","line":149,"updated":"2015-12-03 06:50:34.000000000","message":"In all the other modules, these get added to init.pp not the api.","commit_id":"438a9db08593fb10ea9cae24da09584126ee30d4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"de39c49b30ce77c8081d189a7242e49fd692ceae","unresolved":false,"context_lines":[{"line_number":146,"context_line":"#"},{"line_number":147,"context_line":"class trove::api("},{"line_number":148,"context_line":"  $keystone_password,"},{"line_number":149,"context_line":"  $verbose                      \u003d undef,"},{"line_number":150,"context_line":"  $debug                        \u003d undef,"},{"line_number":151,"context_line":"  $use_syslog                   \u003d undef,"},{"line_number":152,"context_line":"  $use_stderr                   \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a740942_4f24225f","line":149,"in_reply_to":"7a740942_a9739fb0","updated":"2015-12-07 15:40:36.000000000","message":"Ah so it\u0027s different. Should we perhaps add them to init and use pick to pick($trove::verbose, $trove::api::verbose, $trove::logging::verbose) to bring them inline with the other modules?","commit_id":"438a9db08593fb10ea9cae24da09584126ee30d4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"07575d645550c09d7d26a0dfc6206113025599d6","unresolved":false,"context_lines":[{"line_number":146,"context_line":"#"},{"line_number":147,"context_line":"class trove::api("},{"line_number":148,"context_line":"  $keystone_password,"},{"line_number":149,"context_line":"  $verbose                      \u003d undef,"},{"line_number":150,"context_line":"  $debug                        \u003d undef,"},{"line_number":151,"context_line":"  $use_syslog                   \u003d undef,"},{"line_number":152,"context_line":"  $use_stderr                   \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a740942_a9739fb0","line":149,"in_reply_to":"9a8ffd7b_4cd64050","updated":"2015-12-04 10:54:25.000000000","message":"I\u0027m not agree with you, because some parameters already implemented in this class.","commit_id":"438a9db08593fb10ea9cae24da09584126ee30d4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9be66efd02279942b93f3af510acd57b3c45d288","unresolved":false,"context_lines":[{"line_number":152,"context_line":"  $use_stderr                   \u003d undef,"},{"line_number":153,"context_line":"  $log_facility                 \u003d undef,"},{"line_number":154,"context_line":"  $log_file                     \u003d undef,"},{"line_number":155,"context_line":"  $log_dir                      \u003d \u0027/var/log/trove\u0027,"},{"line_number":156,"context_line":"  $bind_host                    \u003d \u00270.0.0.0\u0027,"},{"line_number":157,"context_line":"  $bind_port                    \u003d \u00278779\u0027,"},{"line_number":158,"context_line":"  $backlog                      \u003d \u00274096\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9a8ffd7b_ecc6149b","line":155,"updated":"2015-12-03 06:50:34.000000000","message":"This should only be specified in the logging class, should be undef here","commit_id":"438a9db08593fb10ea9cae24da09584126ee30d4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"07575d645550c09d7d26a0dfc6206113025599d6","unresolved":false,"context_lines":[{"line_number":152,"context_line":"  $use_stderr                   \u003d undef,"},{"line_number":153,"context_line":"  $log_facility                 \u003d undef,"},{"line_number":154,"context_line":"  $log_file                     \u003d undef,"},{"line_number":155,"context_line":"  $log_dir                      \u003d \u0027/var/log/trove\u0027,"},{"line_number":156,"context_line":"  $bind_host                    \u003d \u00270.0.0.0\u0027,"},{"line_number":157,"context_line":"  $bind_port                    \u003d \u00278779\u0027,"},{"line_number":158,"context_line":"  $backlog                      \u003d \u00274096\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a740942_4969dbbd","line":155,"in_reply_to":"9a8ffd7b_ecc6149b","updated":"2015-12-04 10:54:25.000000000","message":"Agree.","commit_id":"438a9db08593fb10ea9cae24da09584126ee30d4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ed774839adb9cc53ef32bf202a917ef4fbb7963e","unresolved":false,"context_lines":[{"line_number":142,"context_line":"class trove::api("},{"line_number":143,"context_line":"  $keystone_password,"},{"line_number":144,"context_line":"  $verbose                      \u003d false,"},{"line_number":145,"context_line":"  $debug                        \u003d false,"},{"line_number":146,"context_line":"  $bind_host                    \u003d \u00270.0.0.0\u0027,"},{"line_number":147,"context_line":"  $bind_port                    \u003d \u00278779\u0027,"},{"line_number":148,"context_line":"  $backlog                      \u003d \u00274096\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a740942_1da5bc45","side":"PARENT","line":145,"updated":"2015-12-08 14:07:15.000000000","message":"So removing these breaks backwards compatibility. We need to properly deprecate these. You can use pick in the logging class like:\n\npick($trove::verbose, $trove::api::verbose, $trove::logging::verbose)\n\nSame goes for all the other variables here. Deprecate them and move the setting to trove::logging","commit_id":"05cbdefa6b239d8ad515481ca5776cdeb4ba4561"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"39c832a565a85b471ae775cad968ffa4b9ff98a8","unresolved":false,"context_lines":[{"line_number":142,"context_line":"class trove::api("},{"line_number":143,"context_line":"  $keystone_password,"},{"line_number":144,"context_line":"  $verbose                      \u003d undef,"},{"line_number":145,"context_line":"  $debug                        \u003d undef,"},{"line_number":146,"context_line":"  $bind_host                    \u003d \u00270.0.0.0\u0027,"},{"line_number":147,"context_line":"  $bind_port                    \u003d \u00278779\u0027,"},{"line_number":148,"context_line":"  $backlog                      \u003d \u00274096\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_0685e705","line":145,"updated":"2015-12-10 14:04:56.000000000","message":"can you please group these parameters in one logical block?","commit_id":"43ef5868e113b460c1ace802480edf11ce826afd"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6fe3ab8a1c6fec9bfc5c0b7136bd9d48ecf17227","unresolved":false,"context_lines":[{"line_number":148,"context_line":"  $verbose                      \u003d undef,"},{"line_number":149,"context_line":"  $debug                        \u003d undef,"},{"line_number":150,"context_line":"  $log_file                     \u003d undef,"},{"line_number":151,"context_line":"  $log_dir                      \u003d undef,"},{"line_number":152,"context_line":"  $use_syslog                   \u003d undef,"},{"line_number":153,"context_line":"  $use_stderr                   \u003d undef,"},{"line_number":154,"context_line":"  $log_facility                 \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a7e1126_c0b019e0","line":151,"updated":"2015-12-17 19:16:25.000000000","message":"Not sure this change is backward compatible, look at SERVICE_DEFAULT feature [1], where we kept the log_dir otherwise we loose the logs by default.\nShould we switch os this feature now or in a future patch?\n\n[1] https://wiki.openstack.org/wiki/Puppet/Coding_style#Config_file_defaults_and_parameters","commit_id":"2bc8689341fe8dbd8b8e0ef8880126ec11616660"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5fd033e5009cc5d7973f5efa97ad8655e0b768b3","unresolved":false,"context_lines":[{"line_number":148,"context_line":"  $verbose                      \u003d undef,"},{"line_number":149,"context_line":"  $debug                        \u003d undef,"},{"line_number":150,"context_line":"  $log_file                     \u003d undef,"},{"line_number":151,"context_line":"  $log_dir                      \u003d undef,"},{"line_number":152,"context_line":"  $use_syslog                   \u003d undef,"},{"line_number":153,"context_line":"  $use_stderr                   \u003d undef,"},{"line_number":154,"context_line":"  $log_facility                 \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a7e1126_b320c59c","line":151,"in_reply_to":"3a7e1126_c0b019e0","updated":"2015-12-17 19:26:51.000000000","message":"this is backwards compatible as the value will get picked up in the logging class. We always have it undef in the old spot with the value being moved to the logging class and a pick(...) used.  If you check the logging class, you\u0027ll see it is defined there now with the value that used to be here.","commit_id":"2bc8689341fe8dbd8b8e0ef8880126ec11616660"}],"manifests/init.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"39c832a565a85b471ae775cad968ffa4b9ff98a8","unresolved":false,"context_lines":[{"line_number":290,"context_line":"  $use_neutron                  \u003d true,"},{"line_number":291,"context_line":"  $package_ensure               \u003d \u0027present\u0027,"},{"line_number":292,"context_line":"  $verbose                      \u003d undef,"},{"line_number":293,"context_line":"  $debug                        \u003d undef,"},{"line_number":294,"context_line":"  $use_syslog                   \u003d undef,"},{"line_number":295,"context_line":"  $use_stderr                   \u003d undef,"},{"line_number":296,"context_line":"  $log_facility                 \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_c6903f51","line":293,"updated":"2015-12-10 14:04:56.000000000","message":"i\u0027m not sure, that it should be added here. It was implemented in api class, let\u0027s not duplicate here these parameters.","commit_id":"43ef5868e113b460c1ace802480edf11ce826afd"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9db3789d34f803b4bc37a9c7f9ee4d8e5f427f21","unresolved":false,"context_lines":[{"line_number":290,"context_line":"  $use_neutron                  \u003d true,"},{"line_number":291,"context_line":"  $package_ensure               \u003d \u0027present\u0027,"},{"line_number":292,"context_line":"  $verbose                      \u003d undef,"},{"line_number":293,"context_line":"  $debug                        \u003d undef,"},{"line_number":294,"context_line":"  $use_syslog                   \u003d undef,"},{"line_number":295,"context_line":"  $use_stderr                   \u003d undef,"},{"line_number":296,"context_line":"  $log_facility                 \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_f76c070a","line":293,"in_reply_to":"7a740942_57ecfb28","updated":"2015-12-10 14:48:07.000000000","message":"A good example of what? Is that what we\u0027re shooting for? The reason it was mentioned to put these in here is because puppet-cinder, puppet-nova, puppet-keystone, puppet-neutron, puppet-murano, etc all have these parameters in init.pp.","commit_id":"43ef5868e113b460c1ace802480edf11ce826afd"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"a38c05f583e1704a2f2b323b29d937bb4126ef23","unresolved":false,"context_lines":[{"line_number":290,"context_line":"  $use_neutron                  \u003d true,"},{"line_number":291,"context_line":"  $package_ensure               \u003d \u0027present\u0027,"},{"line_number":292,"context_line":"  $verbose                      \u003d undef,"},{"line_number":293,"context_line":"  $debug                        \u003d undef,"},{"line_number":294,"context_line":"  $use_syslog                   \u003d undef,"},{"line_number":295,"context_line":"  $use_stderr                   \u003d undef,"},{"line_number":296,"context_line":"  $log_facility                 \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_57ecfb28","line":293,"in_reply_to":"7a740942_7c49decf","updated":"2015-12-10 14:39:18.000000000","message":"Alex, please take a look at glance module. It is a good example.","commit_id":"43ef5868e113b460c1ace802480edf11ce826afd"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"fc215a36f74260e7bcdc6bd5aa12a02ec49191b9","unresolved":false,"context_lines":[{"line_number":290,"context_line":"  $use_neutron                  \u003d true,"},{"line_number":291,"context_line":"  $package_ensure               \u003d \u0027present\u0027,"},{"line_number":292,"context_line":"  $verbose                      \u003d undef,"},{"line_number":293,"context_line":"  $debug                        \u003d undef,"},{"line_number":294,"context_line":"  $use_syslog                   \u003d undef,"},{"line_number":295,"context_line":"  $use_stderr                   \u003d undef,"},{"line_number":296,"context_line":"  $log_facility                 \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_7c49decf","line":293,"in_reply_to":"7a740942_c6903f51","updated":"2015-12-10 14:32:17.000000000","message":"Denis, in all the other modules these variables are here and not in the api class. I\u0027m not sure we\u0027ve properly set the expectations around this on if these settings should continue to live in the init class or if they should only be in the logging class. I think we need to decide so we can be more clear around this change.  This was an attempt to bring this module more in line with the other modules.","commit_id":"43ef5868e113b460c1ace802480edf11ce826afd"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e8143695f38f8e37157f2060e0565e7e2b6a53f6","unresolved":false,"context_lines":[{"line_number":290,"context_line":"  $use_neutron                  \u003d true,"},{"line_number":291,"context_line":"  $package_ensure               \u003d \u0027present\u0027,"},{"line_number":292,"context_line":"  $verbose                      \u003d undef,"},{"line_number":293,"context_line":"  $debug                        \u003d undef,"},{"line_number":294,"context_line":"  $use_syslog                   \u003d undef,"},{"line_number":295,"context_line":"  $use_stderr                   \u003d undef,"},{"line_number":296,"context_line":"  $log_facility                 \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_529e49b9","line":293,"in_reply_to":"7a740942_f76c070a","updated":"2015-12-10 14:52:41.000000000","message":"Yes, because they always were in init.pp. But as i said, for example for glance, we have these parameters in api/ragistry class. And we don\u0027t use init.pp class.\n\nOk, if you want use these parametes here, you should mark then api logging parameters as deprecated then.","commit_id":"43ef5868e113b460c1ace802480edf11ce826afd"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"39c832a565a85b471ae775cad968ffa4b9ff98a8","unresolved":false,"context_lines":[{"line_number":308,"context_line":"  $qpid_tcp_nodelay             \u003d undef,"},{"line_number":309,"context_line":") {"},{"line_number":310,"context_line":"  include ::trove::params"},{"line_number":311,"context_line":"  include ::trove::logging"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"  if $mysql_module {"},{"line_number":314,"context_line":"    warning(\u0027The mysql_module parameter is deprecated. The latest 2.x mysql module will be used.\u0027)"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_268fc324","line":311,"updated":"2015-12-10 14:04:56.000000000","message":"unneeded","commit_id":"43ef5868e113b460c1ace802480edf11ce826afd"}],"manifests/logging.pp":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"9334040ca5298c6df8369d5d059b448a16bd76b4","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  }"},{"line_number":157,"context_line":"  else {"},{"line_number":158,"context_line":"    trove_config {"},{"line_number":159,"context_line":"      \u0027DEFAULT/logging_default_format_string\u0027 : ensure \u003d\u003e absent;"},{"line_number":160,"context_line":"    }"},{"line_number":161,"context_line":"  }"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba8a016a_0849ad8b","line":159,"updated":"2015-11-16 15:05:36.000000000","message":"Probably it\u0027s worth to switch to ::os_service_default?","commit_id":"ebd071a637c1080b7a59b4a34fbbacd852c7755a"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"8f3d69dbbb3f9fd8dd2927845489b47926e11749","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  }"},{"line_number":157,"context_line":"  else {"},{"line_number":158,"context_line":"    trove_config {"},{"line_number":159,"context_line":"      \u0027DEFAULT/logging_default_format_string\u0027 : ensure \u003d\u003e absent;"},{"line_number":160,"context_line":"    }"},{"line_number":161,"context_line":"  }"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba8a016a_7c9cb769","line":159,"in_reply_to":"ba8a016a_0849ad8b","updated":"2015-11-16 15:58:23.000000000","message":"Not yet, I am sorry. It will be part of a new patch.","commit_id":"ebd071a637c1080b7a59b4a34fbbacd852c7755a"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"67ff360ce487221bd6bf9cef0c64c62c97e89f30","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  }"},{"line_number":157,"context_line":"  else {"},{"line_number":158,"context_line":"    trove_config {"},{"line_number":159,"context_line":"      \u0027DEFAULT/logging_default_format_string\u0027 : ensure \u003d\u003e absent;"},{"line_number":160,"context_line":"    }"},{"line_number":161,"context_line":"  }"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba8a016a_8a9b9517","line":159,"in_reply_to":"ba8a016a_7c9cb769","updated":"2015-11-19 15:03:34.000000000","message":"Now all new patches that adds new values should use $::os_service_default.\n\nhttp://eavesdrop.openstack.org/meetings/puppet_openstack/2015/puppet_openstack.2015-11-17-15.00.log.html","commit_id":"ebd071a637c1080b7a59b4a34fbbacd852c7755a"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e182d70abcc64e6f13b0991d6828c46df1ec71b4","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  }"},{"line_number":157,"context_line":"  else {"},{"line_number":158,"context_line":"    trove_config {"},{"line_number":159,"context_line":"      \u0027DEFAULT/logging_default_format_string\u0027 : ensure \u003d\u003e absent;"},{"line_number":160,"context_line":"    }"},{"line_number":161,"context_line":"  }"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba8a016a_0a2485c2","line":159,"in_reply_to":"ba8a016a_8a9b9517","updated":"2015-11-19 15:05:30.000000000","message":"Oops, sorry :)\n\nWe can accept your patch with old style. But please upload patch for changing it.","commit_id":"ebd071a637c1080b7a59b4a34fbbacd852c7755a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9be66efd02279942b93f3af510acd57b3c45d288","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"  # NOTE(spredzy): In order to keep backward compatibility we rely on the pick function"},{"line_number":120,"context_line":"  # to use trove::\u003cmyparam\u003e first then trove::logging::\u003cmyparam\u003e."},{"line_number":121,"context_line":"  $use_syslog_real   \u003d pick($::trove::api::use_syslog,$use_syslog)"},{"line_number":122,"context_line":"  $use_stderr_real   \u003d pick($::trove::api::use_stderr,$use_stderr)"},{"line_number":123,"context_line":"  $log_facility_real \u003d pick($::trove::api::log_facility,$log_facility)"},{"line_number":124,"context_line":"  $log_dir_real      \u003d pick($::trove::api::log_dir,$log_dir)"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9a8ffd7b_2cd17c57","line":121,"updated":"2015-12-03 06:50:34.000000000","message":"As I mentioned in the other file, I\u0027m not sure this should picking the trove::api::\u003cvar\u003e, the other modules use the init.pp for these","commit_id":"438a9db08593fb10ea9cae24da09584126ee30d4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"39c832a565a85b471ae775cad968ffa4b9ff98a8","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"  # NOTE(spredzy): In order to keep backward compatibility we rely on the pick function"},{"line_number":120,"context_line":"  # to use trove::\u003cmyparam\u003e first then trove::logging::\u003cmyparam\u003e."},{"line_number":121,"context_line":"  $use_syslog_real   \u003d pick($::trove::use_syslog,$::trove::api::use_syslog,$use_syslog)"},{"line_number":122,"context_line":"  $use_stderr_real   \u003d pick($::trove::use_stderr,$use_stderr)"},{"line_number":123,"context_line":"  $log_facility_real \u003d pick($::trove::log_facility,$::trove::api::log_facility,$log_facility)"},{"line_number":124,"context_line":"  $log_dir_real      \u003d pick($::trove::log_dir,$::trove::api::log_dir,$log_dir)"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_26b6e3dc","line":121,"updated":"2015-12-10 14:04:56.000000000","message":"again, we should not spawn everywhere these parameters. Please use api class.","commit_id":"43ef5868e113b460c1ace802480edf11ce826afd"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"fc215a36f74260e7bcdc6bd5aa12a02ec49191b9","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"  # NOTE(spredzy): In order to keep backward compatibility we rely on the pick function"},{"line_number":120,"context_line":"  # to use trove::\u003cmyparam\u003e first then trove::logging::\u003cmyparam\u003e."},{"line_number":121,"context_line":"  $use_syslog_real   \u003d pick($::trove::use_syslog,$::trove::api::use_syslog,$use_syslog)"},{"line_number":122,"context_line":"  $use_stderr_real   \u003d pick($::trove::use_stderr,$use_stderr)"},{"line_number":123,"context_line":"  $log_facility_real \u003d pick($::trove::log_facility,$::trove::api::log_facility,$log_facility)"},{"line_number":124,"context_line":"  $log_dir_real      \u003d pick($::trove::log_dir,$::trove::api::log_dir,$log_dir)"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_7c4ebec2","line":121,"in_reply_to":"7a740942_26b6e3dc","updated":"2015-12-10 14:32:17.000000000","message":"This goes back to previous comments around this trying to bring it in line with the other modules. Personally i think we support (or completely remove them) in the init.pp class and we need the api ones here so we could properly deprecate it from the api class.","commit_id":"43ef5868e113b460c1ace802480edf11ce826afd"}]}