)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"d5c2ff1b87d4d438bc451f232062ada1ea40e1ae","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Move all dependency tracking to an external class which simplifies the"},{"line_number":10,"context_line":"relationships and allows managing Trove without necessarily using"},{"line_number":11,"context_line":"packages. This change also cleans up how the client is handled to make"},{"line_number":12,"context_line":"it more configurable and match other modules."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I943685fbeb114dead80b7465b8f5c564a0bc9fe0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa0719c6_8d2b4382","line":12,"updated":"2016-03-21 18:38:40.000000000","message":"I won\u0027t block this patch because of it, but it would be great to have a release note about it.","commit_id":"8a4d6f9736350e4f2fd158f1210a4d312cdaae58"}],"manifests/api.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"d5c2ff1b87d4d438bc451f232062ada1ea40e1ae","unresolved":false,"context_lines":[{"line_number":194,"context_line":"  $auth_protocol                \u003d \u0027http\u0027,"},{"line_number":195,"context_line":") inherits trove {"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"  require ::keystone::python"},{"line_number":198,"context_line":"  include ::trove::db"},{"line_number":199,"context_line":"  include ::trove::logging"},{"line_number":200,"context_line":"  include ::trove::params"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"fa0719c6_ed20ff9d","side":"PARENT","line":197,"updated":"2016-03-21 18:38:40.000000000","message":"This is not in the commit message.","commit_id":"77c50a16f1b083ef7a1f70568407e6c59891ad7d"}],"manifests/db.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"1bc23236de9c880ffeadc20b1d6930c35402a134","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  include ::trove::deps"},{"line_number":47,"context_line":"  include ::trove::params"},{"line_number":48,"context_line":"  include ::trove::db::sync"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  # NOTE(spredzy): In order to keep backward compatibility we rely on the pick function"},{"line_number":51,"context_line":"  # to use trove::\u003cmyparam\u003e if trove::db::\u003cmyparam\u003e isn\u0027t specified."}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1af94dfe_3b8ba520","line":48,"range":{"start_line":48,"start_character":2,"end_line":48,"end_character":27},"updated":"2016-03-18 16:46:01.000000000","message":"not sure, that we need call this from this class. This class is only configures db parameters for config.\n\nMay be better to place it to main init.pp class?","commit_id":"8c4ef3be5c1d07a8d53ea1b8d8e8706636181c15"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"aad6d6d49630c3caaf0f60750474b9db64df3afd","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  include ::trove::deps"},{"line_number":47,"context_line":"  include ::trove::params"},{"line_number":48,"context_line":"  include ::trove::db::sync"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  # NOTE(spredzy): In order to keep backward compatibility we rely on the pick function"},{"line_number":51,"context_line":"  # to use trove::\u003cmyparam\u003e if trove::db::\u003cmyparam\u003e isn\u0027t specified."}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1af94dfe_ea4a0554","line":48,"range":{"start_line":48,"start_character":2,"end_line":48,"end_character":27},"in_reply_to":"1af94dfe_3b8ba520","updated":"2016-03-18 18:11:14.000000000","message":"API is what includes trove::db now. The modules seem split on this. In neutron its in server.pp in keystone its in db.pp. I\u0027m kind of ambivalent on this but I think either here or in api.pp makes the most sense.","commit_id":"8c4ef3be5c1d07a8d53ea1b8d8e8706636181c15"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d1b63d3d05cbe8fad57aa1599f89431e41fe066f","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  include ::trove::deps"},{"line_number":47,"context_line":"  include ::trove::params"},{"line_number":48,"context_line":"  include ::trove::db::sync"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  # NOTE(spredzy): In order to keep backward compatibility we rely on the pick function"},{"line_number":51,"context_line":"  # to use trove::\u003cmyparam\u003e if trove::db::\u003cmyparam\u003e isn\u0027t specified."}],"source_content_type":"text/x-puppet","patch_set":8,"id":"fa0719c6_b15204dc","line":48,"range":{"start_line":48,"start_character":2,"end_line":48,"end_character":27},"in_reply_to":"1af94dfe_ea4a0554","updated":"2016-03-21 09:36:26.000000000","message":"Well, api.pp make sense for me too.","commit_id":"8c4ef3be5c1d07a8d53ea1b8d8e8706636181c15"}]}