)]}'
{"manifests/guestagent.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"531490e66653da485e4020543cfab659842f4e02","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    trove_guestagent_config { \u0027DEFAULT/swift_url\u0027: value  \u003d\u003e $swift_url; }"},{"line_number":114,"context_line":"  }"},{"line_number":115,"context_line":"  else {"},{"line_number":116,"context_line":"    trove_guestagent_config { \u0027DEFAULT/swift_url\u0027: ensure \u003d\u003e absent; }"},{"line_number":117,"context_line":"  }"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"  # region name"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dab17558_8296ed3c","line":116,"updated":"2016-05-10 14:00:06.000000000","message":"can we use os_service_default instead?","commit_id":"401c962d2889e5961d3b4454ef1a1289d9a62952"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"06ccb2f56bf7654d801bfd94c250d925a530918a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  $use_syslog                \u003d false,"},{"line_number":88,"context_line":"  $log_facility              \u003d \u0027LOG_USER\u0027,"},{"line_number":89,"context_line":"  $auth_url                  \u003d \u0027http://localhost:5000/v2.0\u0027,"},{"line_number":90,"context_line":"  $swift_url                 \u003d $::os_service_default,"},{"line_number":91,"context_line":"  $control_exchange          \u003d \u0027trove\u0027,"},{"line_number":92,"context_line":"  $rabbit_hosts              \u003d $::trove::rabbit_hosts,"},{"line_number":93,"context_line":"  $rabbit_host               \u003d $::trove::rabbit_host,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dab17558_acd3f65e","line":90,"updated":"2016-05-11 10:41:55.000000000","message":"I am sorry, but it looks like os_service_default can\u0027t be use here right now, because swift_url is used in trove-guestagent.conf template - https://github.com/openstack/puppet-trove/blob/master/templates/trove-guestagent.conf.erb#L39. This template is deprecated actually - https://github.com/openstack/puppet-trove/blob/master/manifests/taskmanager.pp#L255 but still can be used. We don\u0027t want to see swift_url set to \u003cSERVICE DEFAULT\u003e, so I\u0027d prefer to keep previous version of your patch. Sorry for confusing.","commit_id":"fef403dc873855ab73dad60a6b45ef806a2c43dd"}],"releasenotes/notes/allow_removing_swift_url-70e1d0eb72236908.yaml":[{"author":{"_account_id":18225,"name":"Shaik Apsar","email":"sa709c@intl.att.com","username":"sa709c"},"change_message_id":"28af9812ec9ea24049b742bfed8fdf82d829f78c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - If swift_url is unset, Trove will set it using the "},{"line_number":4,"context_line":"    Keystone catalog. This change allows setting swift_url"},{"line_number":5,"context_line":"    to false to remove the setting. So that Trove loads the"},{"line_number":6,"context_line":"    swift URL from the Keystone catalog."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dab17558_24bdacb7","line":3,"range":{"start_line":3,"start_character":54,"end_line":3,"end_character":55},"updated":"2016-05-10 06:30:54.000000000","message":"Please remove the extra space","commit_id":"8332b6cefa7fcea7c570c85cda70eac17869cf06"}]}