)]}'
{"manifests/logging.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"a60c6f0c228aaacd17dcd7a24fa19aaae879c77a","unresolved":false,"context_lines":[{"line_number":135,"context_line":"  oslo::log { \u0027trove_config\u0027:"},{"line_number":136,"context_line":"    debug                         \u003d\u003e $debug_real,"},{"line_number":137,"context_line":"    use_stderr                    \u003d\u003e $use_stderr_real,"},{"line_number":138,"context_line":"    use_syslog                    \u003d\u003e $use_syslog,"},{"line_number":139,"context_line":"    log_dir                       \u003d\u003e $log_dir_real,"},{"line_number":140,"context_line":"    log_file                      \u003d\u003e $log_file_real,"},{"line_number":141,"context_line":"    syslog_log_facility           \u003d\u003e $log_facility_real,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_31af437e","line":138,"updated":"2016-05-23 13:15:45.000000000","message":"please remove this line and add the deprecation stuff as in api class","commit_id":"585bec025ab090dd3c71a842d733f1496f771bd7"}],"manifests/quota.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"a60c6f0c228aaacd17dcd7a24fa19aaae879c77a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*max_instances_per_user*]"},{"line_number":31,"context_line":"#   (optional) DEPRECATED. Default maximum number of instances per tenant."},{"line_number":32,"context_line":"#   Defaults to 5."},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# [*max_volumes_per_user*]"},{"line_number":35,"context_line":"#   (optional) DEPRECATED. Default maximum volume capacity (in GB) spanning across"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_71e0ab29","line":32,"updated":"2016-05-23 13:15:45.000000000","message":"undef","commit_id":"585bec025ab090dd3c71a842d733f1496f771bd7"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"a60c6f0c228aaacd17dcd7a24fa19aaae879c77a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# [*max_volumes_per_user*]"},{"line_number":35,"context_line":"#   (optional) DEPRECATED. Default maximum volume capacity (in GB) spanning across"},{"line_number":36,"context_line":"#   all Trove volumes per tenant."},{"line_number":37,"context_line":"#   Defaults to 20."},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"# [*max_backups_per_user*]"},{"line_number":40,"context_line":"#   (optional) DEPRECATED. Default maximum number of backups created by a tenant."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_31c903ad","line":37,"updated":"2016-05-23 13:15:45.000000000","message":"undef","commit_id":"585bec025ab090dd3c71a842d733f1496f771bd7"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"a60c6f0c228aaacd17dcd7a24fa19aaae879c77a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"# [*max_backups_per_user*]"},{"line_number":40,"context_line":"#   (optional) DEPRECATED. Default maximum number of backups created by a tenant."},{"line_number":41,"context_line":"#   Defaults to 50."},{"line_number":42,"context_line":"#"},{"line_number":43,"context_line":"class trove::quota ("},{"line_number":44,"context_line":"  $max_instances_per_tenant     \u003d 5,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_b1e69341","line":41,"updated":"2016-05-23 13:15:45.000000000","message":"undef","commit_id":"585bec025ab090dd3c71a842d733f1496f771bd7"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"a60c6f0c228aaacd17dcd7a24fa19aaae879c77a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"#   Defaults to 50."},{"line_number":42,"context_line":"#"},{"line_number":43,"context_line":"class trove::quota ("},{"line_number":44,"context_line":"  $max_instances_per_tenant     \u003d 5,"},{"line_number":45,"context_line":"  $max_accepted_volume_size     \u003d 5,"},{"line_number":46,"context_line":"  $max_volumes_per_tenant       \u003d 20,"},{"line_number":47,"context_line":"  $max_backups_per_tenant       \u003d 50,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_11431f14","line":44,"updated":"2016-05-23 13:15:45.000000000","message":"please remove extra spaces","commit_id":"585bec025ab090dd3c71a842d733f1496f771bd7"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"a60c6f0c228aaacd17dcd7a24fa19aaae879c77a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  include ::trove::deps"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  if $max_instances_per_user {"},{"line_number":58,"context_line":"    warning(\u0027max_instances_per_user deprecated, has no effect and will be removed after Newton cycle.\u0027)"},{"line_number":59,"context_line":"  }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  if $max_volumes_per_user {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_f1d5bb1b","line":58,"updated":"2016-05-23 13:15:45.000000000","message":"I think it would be great to add \u0027use max_instances_per_tenant instead.\u0027","commit_id":"585bec025ab090dd3c71a842d733f1496f771bd7"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"a60c6f0c228aaacd17dcd7a24fa19aaae879c77a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  if $max_volumes_per_user {"},{"line_number":62,"context_line":"    warning(\u0027max_volumes_per_user deprecated, has no effect and will be removed after Newton cycle.\u0027)"},{"line_number":63,"context_line":"  }"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  if $max_backups_per_user {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_31dc6345","line":62,"updated":"2016-05-23 13:15:45.000000000","message":"same here","commit_id":"585bec025ab090dd3c71a842d733f1496f771bd7"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"a60c6f0c228aaacd17dcd7a24fa19aaae879c77a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  }"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  if $max_backups_per_user {"},{"line_number":66,"context_line":"    warning(\u0027max_backups_per_user deprecated, has no effect and will be removed after Newton cycle.\u0027)"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  trove_config {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_71ea6bdc","line":66,"updated":"2016-05-23 13:15:45.000000000","message":"same here","commit_id":"585bec025ab090dd3c71a842d733f1496f771bd7"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"aa367f8dd0dec390ea30ba50c207ca02f3f91ea6","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  if $max_instances_per_user {"},{"line_number":58,"context_line":"    warning(\u0027max_instances_per_user deprecated, has no effect and will be removed after Newton cycle. Please use max_instances_per_tenant instead.\u0027)"},{"line_number":59,"context_line":"  }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  if $max_volumes_per_user {"},{"line_number":62,"context_line":"    warning(\u0027max_volumes_per_user deprecated, has no effect and will be removed after Newton cycle. Please use max_volumes_per_tenant instead.\u0027)"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_59eee98b","line":59,"updated":"2016-05-25 14:54:39.000000000","message":"please use here suffix _real, in case of using old parameters","commit_id":"333c51639a67f1c99f0558fff7e6ffc6670c86f5"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"fab8ab4feba4e3e12d6102f7cb287d8220b6d00a","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  if $max_instances_per_user {"},{"line_number":58,"context_line":"    warning(\u0027max_instances_per_user deprecated, has no effect and will be removed after Newton cycle. Please use max_instances_per_tenant instead.\u0027)"},{"line_number":59,"context_line":"  }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  if $max_volumes_per_user {"},{"line_number":62,"context_line":"    warning(\u0027max_volumes_per_user deprecated, has no effect and will be removed after Newton cycle. Please use max_volumes_per_tenant instead.\u0027)"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bab6814e_5427bcb5","line":59,"in_reply_to":"bab6814e_59eee98b","updated":"2016-05-25 21:03:51.000000000","message":"ok will do \u003d)","commit_id":"333c51639a67f1c99f0558fff7e6ffc6670c86f5"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"87304661dc068cee464e20d9ae445edf3b57b56a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  }"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  trove_config {"},{"line_number":79,"context_line":"    \u0027DEFAULT/max_instances_per_tenant\u0027: value \u003d\u003e"},{"line_number":80,"context_line":"$max_instances_per_tenant_real;"},{"line_number":81,"context_line":"    \u0027DEFAULT/max_accepted_volume_size\u0027: value \u003d\u003e $max_accepted_volume_size;"},{"line_number":82,"context_line":"    \u0027DEFAULT/max_volumes_per_tenant\u0027:   value \u003d\u003e $max_volumes_per_tenant_real;"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9abb7d3a_8cc5165d","line":79,"updated":"2016-05-27 10:41:06.000000000","message":"alignment :) no need use a new line","commit_id":"a3b3d1b9fedec668b158aebe727222805d32657e"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"ff59f4c2b74706a4fa3e9d21be8a4f3467b593fb","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  }"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  trove_config {"},{"line_number":79,"context_line":"    \u0027DEFAULT/max_instances_per_tenant\u0027: value \u003d\u003e"},{"line_number":80,"context_line":"$max_instances_per_tenant_real;"},{"line_number":81,"context_line":"    \u0027DEFAULT/max_accepted_volume_size\u0027: value \u003d\u003e $max_accepted_volume_size;"},{"line_number":82,"context_line":"    \u0027DEFAULT/max_volumes_per_tenant\u0027:   value \u003d\u003e $max_volumes_per_tenant_real;"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9abb7d3a_7ecb2673","line":79,"in_reply_to":"9abb7d3a_8cc5165d","updated":"2016-05-27 15:32:42.000000000","message":"my vim it\u0027s trolling, sorry","commit_id":"a3b3d1b9fedec668b158aebe727222805d32657e"}]}
