)]}'
{"manifests/guestagent.pp":[{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"ae414e53e31681d577b10a5d003f1ea06f789ca5","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  $manage_service            \u003d true,"},{"line_number":85,"context_line":"  $ensure_package            \u003d \u0027present\u0027,"},{"line_number":86,"context_line":"  $debug                     \u003d $::os_service_default,"},{"line_number":87,"context_line":"  $log_file                  \u003d \u0027/var/log/trove/trove-guestagent.log\u0027,"},{"line_number":88,"context_line":"  $log_dir                   \u003d \u0027/var/log/trove\u0027,"},{"line_number":89,"context_line":"  $use_syslog                \u003d $::os_service_default,"},{"line_number":90,"context_line":"  $log_facility              \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_ed5a854f","line":87,"range":{"start_line":87,"start_character":32,"end_line":87,"end_character":67},"updated":"2016-06-07 08:09:52.000000000","message":"I don\u0027t know that it isn\u0027t right , but you should update related spec tests after modify the option value.","commit_id":"df684c6fc650fa793be5beca3e1d56ff26f00f38"}],"manifests/taskmanager.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"cc0b6dd46834227ffd51cb99743c45d26cbb2c5b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"# [*use_syslog*]"},{"line_number":51,"context_line":"#   (optional) Use syslog for logging."},{"line_number":52,"context_line":"#   Defaults to $::os_service_default"},{"line_number":53,"context_line":"# [*guest_log_file*]"},{"line_number":54,"context_line":"#   (optional) The path of file used for logging."},{"line_number":55,"context_line":"#   If set to boolean false, it will not log to any file."},{"line_number":56,"context_line":"#   Defaults to \u0027/var/log/trove/trove-guestagent.log\u0027"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9abb7d3a_47545753","line":53,"updated":"2016-06-03 14:37:31.000000000","message":"Can you put a blank line above here?","commit_id":"aaf068cbc71e6a64a54d54870f8d310273345de4"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0e4c22ede2a278d5909b4303cb1677f45a2b4805","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  $log_file                 \u003d \u0027/var/log/trove/trove-taskmanager.log\u0027,"},{"line_number":98,"context_line":"  $log_dir                  \u003d \u0027/var/log/trove\u0027,"},{"line_number":99,"context_line":"  $use_syslog               \u003d $::os_service_default,"},{"line_number":100,"context_line":"  $guest_log_file           \u003d \u0027/var/log/trove/trove-guestagent.log\u0027,"},{"line_number":101,"context_line":"  $log_facility             \u003d $::os_service_default,"},{"line_number":102,"context_line":"  $auth_url                 \u003d \u0027http://localhost:5000/v2.0\u0027,"},{"line_number":103,"context_line":"  $heat_url                 \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7aa08908_544f12bd","line":100,"updated":"2016-06-06 13:42:54.000000000","message":"the default value is not consistent with what we have in manifests/guestagent.pp for log_file parameter.","commit_id":"a4e5898b4f76a157dfe3194f5c81f7bff0c9f33e"},{"author":{"_account_id":18225,"name":"Shaik Apsar","email":"sa709c@intl.att.com","username":"sa709c"},"change_message_id":"a70e805f2b4ed1308f4ee4ba3a0893aa5bb4a770","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  $log_file                 \u003d \u0027/var/log/trove/trove-taskmanager.log\u0027,"},{"line_number":98,"context_line":"  $log_dir                  \u003d \u0027/var/log/trove\u0027,"},{"line_number":99,"context_line":"  $use_syslog               \u003d $::os_service_default,"},{"line_number":100,"context_line":"  $guest_log_file           \u003d \u0027/var/log/trove/trove-guestagent.log\u0027,"},{"line_number":101,"context_line":"  $log_facility             \u003d $::os_service_default,"},{"line_number":102,"context_line":"  $auth_url                 \u003d \u0027http://localhost:5000/v2.0\u0027,"},{"line_number":103,"context_line":"  $heat_url                 \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7aa08908_adb87de6","line":100,"in_reply_to":"7aa08908_544f12bd","updated":"2016-06-07 07:57:07.000000000","message":"All the trove services using trove- prefix for the log files. I think we should update the manifests/guestagent.pp for log_file parameter values as /var/log/trove/trove-guestagent.log. I\u0027m updating the value in manifests/guestagent.pp","commit_id":"a4e5898b4f76a157dfe3194f5c81f7bff0c9f33e"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"ae414e53e31681d577b10a5d003f1ea06f789ca5","unresolved":false,"context_lines":[{"line_number":97,"context_line":"  $log_file                 \u003d \u0027/var/log/trove/trove-taskmanager.log\u0027,"},{"line_number":98,"context_line":"  $log_dir                  \u003d \u0027/var/log/trove\u0027,"},{"line_number":99,"context_line":"  $use_syslog               \u003d $::os_service_default,"},{"line_number":100,"context_line":"  $guest_log_file           \u003d \u0027/var/log/trove/trove-guestagent.log\u0027,"},{"line_number":101,"context_line":"  $log_facility             \u003d $::os_service_default,"},{"line_number":102,"context_line":"  $auth_url                 \u003d \u0027http://localhost:5000/v2.0\u0027,"},{"line_number":103,"context_line":"  $heat_url                 \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7aa08908_f036dce5","line":100,"range":{"start_line":100,"start_character":2,"end_line":100,"end_character":68},"updated":"2016-06-07 08:09:52.000000000","message":"you should update releated spec tests after add the option.","commit_id":"df684c6fc650fa793be5beca3e1d56ff26f00f38"}]}
