)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"a2091fbe3bcb6664a8f429ff2ad4040e76acedca","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Venkata Mahesh Jonnalagadda \u003cVenkata.Jonnalagadda@intl.att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-01 10:43:06 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Currently disabling configure_user and configure_user_role parameters doesn\u0027t take care to ensure keystone service to present. This needs to be corrected."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For Example, If we are using Keystone User entries from LDAP, We can\u0027t create/update the user."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_deb89713","line":7,"updated":"2016-06-01 14:49:41.000000000","message":"Please update this and give more details in the message body not in the title","commit_id":"9677f656e9d2c712c8b34fc661894e234c0bdf0e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"485a84a16fd696d60a602536ee43f565ae20457d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Venkata Mahesh Jonnalagadda \u003cVenkata.Jonnalagadda@intl.att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-01 10:43:06 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Currently disabling configure_user and configure_user_role parameters doesn\u0027t take care to ensure keystone service to present. This needs to be corrected."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For Example, If we are using Keystone User entries from LDAP, We can\u0027t create/update the user."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_5e114703","line":7,"in_reply_to":"9abb7d3a_deb89713","updated":"2016-06-01 14:50:48.000000000","message":"Commit title should not be so longest, please move this to commit message body and propose shorter title.","commit_id":"9677f656e9d2c712c8b34fc661894e234c0bdf0e"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"daa0432235f6766bdb06a7bcefeb28321d29ee9d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Venkata Mahesh Jonnalagadda \u003cVenkata.Jonnalagadda@intl.att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-01 10:47:35 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Currently disabling configure_user and configure_user_role parameters"},{"line_number":8,"context_line":"doesn\u0027t take care to ensure keystone service to present."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This needs to be corrected."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9abb7d3a_fe759b31","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":56},"updated":"2016-06-01 14:53:14.000000000","message":"still huge...","commit_id":"0cf9b14efe45d41e653d8cf7d5fe264556f3e8ed"}],"spec/classes/trove_keystone_auth_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"60f11d60f24e22e19a9728439ffa357df3ddc58e","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    it { is_expected.to contain_keystone_service(\u0027trove::database\u0027).with("},{"line_number":149,"context_line":"      :ensure      \u003d\u003e \u0027present\u0027,"},{"line_number":150,"context_line":"      :description \u003d\u003e \u0027Trove Database Service\u0027"},{"line_number":151,"context_line":"    ) }"},{"line_number":152,"context_line":"  end"},{"line_number":153,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9abb7d3a_c8757ccb","line":151,"updated":"2016-06-01 15:42:46.000000000","message":"not sure that this case is useful in this test: we can also pass configure_service \u003d\u003e false\n\nin this current test, we are checking that configuring of user and user role is really disabled.","commit_id":"0466483d0139f2d6a7b61d7f658f3cb4dc0f527b"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"a726140a95903356a381767cb9c8708bcfffbf0c","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    it { is_expected.to contain_keystone_service(\u0027trove::database\u0027).with("},{"line_number":149,"context_line":"      :ensure      \u003d\u003e \u0027present\u0027,"},{"line_number":150,"context_line":"      :description \u003d\u003e \u0027Trove Database Service\u0027"},{"line_number":151,"context_line":"    ) }"},{"line_number":152,"context_line":"  end"},{"line_number":153,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"7aa08908_a074349c","line":151,"in_reply_to":"7aa08908_4f030674","updated":"2016-06-06 12:42:04.000000000","message":"I agree with Denis this test is useless here. We already have it at 45, 114 and 127 lines and it tested with parameters which actually affect this resource.","commit_id":"0466483d0139f2d6a7b61d7f658f3cb4dc0f527b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"54858b64b5f289661ba2bdd98a4fc335ab0d8cfc","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    it { is_expected.to contain_keystone_service(\u0027trove::database\u0027).with("},{"line_number":149,"context_line":"      :ensure      \u003d\u003e \u0027present\u0027,"},{"line_number":150,"context_line":"      :description \u003d\u003e \u0027Trove Database Service\u0027"},{"line_number":151,"context_line":"    ) }"},{"line_number":152,"context_line":"  end"},{"line_number":153,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"7aa08908_4f030674","line":151,"in_reply_to":"9abb7d3a_18b3240c","updated":"2016-06-06 11:03:12.000000000","message":"Why do we need to test everything in each test? Passed parameters are not affect this.","commit_id":"0466483d0139f2d6a7b61d7f658f3cb4dc0f527b"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2696372297cd84804445275de100c80a2d0a4928","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    it { is_expected.to contain_keystone_service(\u0027trove::database\u0027).with("},{"line_number":149,"context_line":"      :ensure      \u003d\u003e \u0027present\u0027,"},{"line_number":150,"context_line":"      :description \u003d\u003e \u0027Trove Database Service\u0027"},{"line_number":151,"context_line":"    ) }"},{"line_number":152,"context_line":"  end"},{"line_number":153,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9abb7d3a_64c0d02b","line":151,"in_reply_to":"9abb7d3a_31c29585","updated":"2016-06-02 09:49:26.000000000","message":"Nope, these parameters are not affect keystone service:\n\nhttps://github.com/openstack/puppet-keystone/blob/master/manifests/resource/service_identity.pp#L143-L181","commit_id":"0466483d0139f2d6a7b61d7f658f3cb4dc0f527b"},{"author":{"_account_id":18324,"name":"Venkata Mahesh Jonnalagadda","email":"Venkata.Jonnalagadda@intl.att.com","username":"vj884x"},"change_message_id":"6951b7ba7f146819d4dc6791f5c7bfac7fcb9117","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    it { is_expected.to contain_keystone_service(\u0027trove::database\u0027).with("},{"line_number":149,"context_line":"      :ensure      \u003d\u003e \u0027present\u0027,"},{"line_number":150,"context_line":"      :description \u003d\u003e \u0027Trove Database Service\u0027"},{"line_number":151,"context_line":"    ) }"},{"line_number":152,"context_line":"  end"},{"line_number":153,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9abb7d3a_18b3240c","line":151,"in_reply_to":"9abb7d3a_64c0d02b","updated":"2016-06-04 05:50:59.000000000","message":"Denis, these parameters are just to ensure keystone service for trove when disabling user \u0026 user_role configuration.\n\nIts always better to ensure keystone service, keystone endpoint during enable or disable configuration changes.\n\nIt was followed even in zaqar, even in keystone also -\n\nhttps://github.com/openstack/puppet-keystone/blob/master/spec/defines/keystone_resource_service_identity_spec.rb\n\nhttps://github.com/openstack/puppet-zaqar/blob/master/spec/classes/zaqar_keystone_auth_spec.rb\n\nWith this change, everything looks good.","commit_id":"0466483d0139f2d6a7b61d7f658f3cb4dc0f527b"},{"author":{"_account_id":18324,"name":"Venkata Mahesh Jonnalagadda","email":"Venkata.Jonnalagadda@intl.att.com","username":"vj884x"},"change_message_id":"82bedae61a15270853efc8c31cbe13fc813f843f","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    it { is_expected.to contain_keystone_service(\u0027trove::database\u0027).with("},{"line_number":149,"context_line":"      :ensure      \u003d\u003e \u0027present\u0027,"},{"line_number":150,"context_line":"      :description \u003d\u003e \u0027Trove Database Service\u0027"},{"line_number":151,"context_line":"    ) }"},{"line_number":152,"context_line":"  end"},{"line_number":153,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9abb7d3a_31c29585","line":151,"in_reply_to":"9abb7d3a_c8757ccb","updated":"2016-06-02 07:25:43.000000000","message":"Denis, when disabling user and user_role configuration, it is always better to ensure keystone service test. Here, we are touching keystone user \u0026 user_role. Hence, Its better to ensure the service too.","commit_id":"0466483d0139f2d6a7b61d7f658f3cb4dc0f527b"}]}