)]}'
{"manifests/guestagent.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"f233cfab07164ed53e4d5dd8fed86a52e5feae9b","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  oslo::messaging::default { \u0027trove_guestagent_config\u0027:"},{"line_number":115,"context_line":"    transport_url    \u003d\u003e $::trove::default_transport_url,"},{"line_number":116,"context_line":"    control_exchange \u003d\u003e $control_exchange"},{"line_number":117,"context_line":"  }"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"  # region name"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a9d85d2_b51db268","line":116,"updated":"2016-06-20 09:39:24.000000000","message":"I think it should be:\n\ncontrol_exchange \u003d\u003e $::trove::control_exchange\n\nto be consistent with other classes. Also you can deprecate control_exchange parameter in this class. Does it make sense?","commit_id":"8c655c861977851dca63bd3fcb2f29e3ca89c8f2"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"1b01b47bf0b73474c57d396fe4cf85fc0c096c3f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"#"},{"line_number":50,"context_line":"# [*control_exchange*]"},{"line_number":51,"context_line":"#   (optional) Control exchange."},{"line_number":52,"context_line":"#   Defaults to \u0027trove\u0027."},{"line_number":53,"context_line":"#"},{"line_number":54,"context_line":"# [*rabbit_hosts*]"},{"line_number":55,"context_line":"#   (optional) List of clustered rabbit servers."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a9d85d2_83be2ed2","line":52,"updated":"2016-06-21 15:24:16.000000000","message":"please deprecate it, it\u0027s not used anymore.","commit_id":"e0037c8b01a609943d75b500aafccc74fd2834dd"}],"manifests/taskmanager.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"f233cfab07164ed53e4d5dd8fed86a52e5feae9b","unresolved":false,"context_lines":[{"line_number":158,"context_line":"  }"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"  oslo::messaging::default { \u0027trove_taskmanager_config\u0027:"},{"line_number":161,"context_line":"    transport_url \u003d\u003e $::trove::default_transport_url,"},{"line_number":162,"context_line":"  }"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"  oslo::messaging::notifications { \u0027trove_taskmanager_config\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a9d85d2_2a44bd72","line":161,"updated":"2016-06-20 09:39:24.000000000","message":"what about control exchange parameter for taskmanager?\nhttps://github.com/openstack/trove/blob/master/etc/trove/trove-taskmanager.conf.sample#L24","commit_id":"8c655c861977851dca63bd3fcb2f29e3ca89c8f2"}]}