)]}'
{"manifests/init.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c7bf6db878cdb89625201e8673afadf4c173869f","unresolved":false,"context_lines":[{"line_number":347,"context_line":"  $heat_service_type            \u003d \u0027orchestration\u0027,"},{"line_number":348,"context_line":"  $neutron_service_type         \u003d \u0027network\u0027,"},{"line_number":349,"context_line":"  $use_neutron                  \u003d true,"},{"line_number":350,"context_line":"  $default_neutron_networks     \u003d undef,"},{"line_number":351,"context_line":"  $package_ensure               \u003d \u0027present\u0027,"},{"line_number":352,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":353,"context_line":"  $rabbit_host                  \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bff0334d_1da53d47","line":350,"updated":"2017-04-11 21:26:31.000000000","message":"The tests fail because pick needs a value. So you can work around that by setting this one to $::os_service_default and leaving the one in trove::taskmanager as undef. But if the default_neutron_networks need to have a value we might need to figure something else out","commit_id":"88fe751263c06f3e6ab8a8829af566ffea127d5f"},{"author":{"_account_id":18418,"name":"Andy Botting","email":"andy@andybotting.com","username":"andybotting"},"change_message_id":"65c05ed9923188f2e1e1f3eb1b547d6b6cc2bc97","unresolved":false,"context_lines":[{"line_number":347,"context_line":"  $heat_service_type            \u003d \u0027orchestration\u0027,"},{"line_number":348,"context_line":"  $neutron_service_type         \u003d \u0027network\u0027,"},{"line_number":349,"context_line":"  $use_neutron                  \u003d true,"},{"line_number":350,"context_line":"  $default_neutron_networks     \u003d undef,"},{"line_number":351,"context_line":"  $package_ensure               \u003d \u0027present\u0027,"},{"line_number":352,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":353,"context_line":"  $rabbit_host                  \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bff0334d_29e323a6","line":350,"in_reply_to":"bff0334d_1da53d47","updated":"2017-04-12 00:55:20.000000000","message":"Just tested the service, and it looks like if the setting is commented out, we still get an empty list - so all good. Updated the commit with your suggestions and test look good","commit_id":"88fe751263c06f3e6ab8a8829af566ffea127d5f"}],"manifests/taskmanager.pp":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"99fa454dbc7b7889c51ca8ebc2dac9badcd8fb2d","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  if $default_neutron_networks {"},{"line_number":130,"context_line":"    warning(\"trove::taskmanager::default_neutron_networks is deprecated and will be removed in \\"},{"line_number":131,"context_line":"the future release. Please use trove::default_neutron_networks instead.\")"},{"line_number":132,"context_line":"    $default_neutron_networks_real \u003d $default_neutron_networks"},{"line_number":133,"context_line":"  } else {"},{"line_number":134,"context_line":"    $default_neutron_networks_real \u003d $::trove::default_neutron_networks"},{"line_number":135,"context_line":"  }"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  if $taskmanager_queue {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bff0334d_eb9c5a0f","line":134,"range":{"start_line":132,"start_character":0,"end_line":134,"end_character":71},"updated":"2017-04-10 07:52:05.000000000","message":"instead of this better to use pick() function for example here https://github.com/openstack/puppet-glance/blob/master/manifests/api/logging.pp#L117","commit_id":"b2b2894e5fd19618f5e6c8c4382c8703a584b06a"},{"author":{"_account_id":18418,"name":"Andy Botting","email":"andy@andybotting.com","username":"andybotting"},"change_message_id":"9364e86de41544f3c84d92677610b0bb36ca0174","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  if $default_neutron_networks {"},{"line_number":130,"context_line":"    warning(\"trove::taskmanager::default_neutron_networks is deprecated and will be removed in \\"},{"line_number":131,"context_line":"the future release. Please use trove::default_neutron_networks instead.\")"},{"line_number":132,"context_line":"    $default_neutron_networks_real \u003d $default_neutron_networks"},{"line_number":133,"context_line":"  } else {"},{"line_number":134,"context_line":"    $default_neutron_networks_real \u003d $::trove::default_neutron_networks"},{"line_number":135,"context_line":"  }"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  if $taskmanager_queue {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bff0334d_a75d4516","line":134,"range":{"start_line":132,"start_character":0,"end_line":134,"end_character":71},"in_reply_to":"bff0334d_eb9c5a0f","updated":"2017-04-10 23:43:22.000000000","message":"I\u0027d use pick if I wasn\u0027t also including the deprecation notice. Should the notice stay?","commit_id":"b2b2894e5fd19618f5e6c8c4382c8703a584b06a"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"99fa454dbc7b7889c51ca8ebc2dac9badcd8fb2d","unresolved":false,"context_lines":[{"line_number":137,"context_line":"  if $taskmanager_queue {"},{"line_number":138,"context_line":"    warning(\"trove::taskmanager::taskmanager_queue is deprecated and will be removed in \\"},{"line_number":139,"context_line":"the future release. Please use trove::taskmanager_queue instead.\")"},{"line_number":140,"context_line":"    trove_config {"},{"line_number":141,"context_line":"      \u0027DEFAULT/taskmanager_queue\u0027: value \u003d\u003e $::trove::taskmanager_queue;"},{"line_number":142,"context_line":"    }"},{"line_number":143,"context_line":"  }"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  if $::trove::database_connection {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bff0334d_abb3f297","line":142,"range":{"start_line":140,"start_character":0,"end_line":142,"end_character":5},"updated":"2017-04-10 07:52:05.000000000","message":"maybe pick() function should be used here too, in order to fallback to new parameter","commit_id":"b2b2894e5fd19618f5e6c8c4382c8703a584b06a"},{"author":{"_account_id":18418,"name":"Andy Botting","email":"andy@andybotting.com","username":"andybotting"},"change_message_id":"9364e86de41544f3c84d92677610b0bb36ca0174","unresolved":false,"context_lines":[{"line_number":137,"context_line":"  if $taskmanager_queue {"},{"line_number":138,"context_line":"    warning(\"trove::taskmanager::taskmanager_queue is deprecated and will be removed in \\"},{"line_number":139,"context_line":"the future release. Please use trove::taskmanager_queue instead.\")"},{"line_number":140,"context_line":"    trove_config {"},{"line_number":141,"context_line":"      \u0027DEFAULT/taskmanager_queue\u0027: value \u003d\u003e $::trove::taskmanager_queue;"},{"line_number":142,"context_line":"    }"},{"line_number":143,"context_line":"  }"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  if $::trove::database_connection {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bff0334d_62a16bf8","line":142,"range":{"start_line":140,"start_character":0,"end_line":142,"end_character":5},"in_reply_to":"bff0334d_abb3f297","updated":"2017-04-10 23:43:22.000000000","message":"Actually, I\u0027ve modified this in a new patchset. This shouldn\u0027t be here as it generates a duplicate resource if the api and taskmanager are on the same host.","commit_id":"b2b2894e5fd19618f5e6c8c4382c8703a584b06a"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"1a1b79d0898155a157f1f07f3ad96ae59f94974c","unresolved":false,"context_lines":[{"line_number":135,"context_line":"  }"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  if $taskmanager_queue {"},{"line_number":138,"context_line":"    fail(\"Please use trove::api::taskmanager_queue instead to configure taskmanager_queue\")"},{"line_number":139,"context_line":"  }"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  if $::trove::database_connection {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bff0334d_fd7e3c17","line":138,"range":{"start_line":138,"start_character":9,"end_line":138,"end_character":91},"updated":"2017-04-11 01:00:23.000000000","message":"single quoted, like that:\nfail(\u0027Please use trove::api::taskmanager_queue instead to configure taskmanager_queue\u0027)","commit_id":"543ca43d9a5cbcc7e3382bd201f31854b1d736cd"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"03ec6ea18d33609a5df1196c58d6599db98ca055","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  if $default_neutron_networks {"},{"line_number":130,"context_line":"    warning(\"trove::taskmanager::default_neutron_networks is deprecated and will be removed in \\"},{"line_number":131,"context_line":"the future release. Please use trove::default_neutron_networks instead.\")"},{"line_number":132,"context_line":"    $default_neutron_networks_real \u003d $default_neutron_networks"},{"line_number":133,"context_line":"  } else {"},{"line_number":134,"context_line":"    $default_neutron_networks_real \u003d $::trove::default_neutron_networks"},{"line_number":135,"context_line":"  }"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"  if $taskmanager_queue {"},{"line_number":138,"context_line":"    fail(\u0027Please use trove::api::taskmanager_queue instead to configure taskmanager_queue\u0027)"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bff0334d_0d19ab20","line":135,"range":{"start_line":132,"start_character":0,"end_line":135,"end_character":3},"updated":"2017-04-11 07:22:41.000000000","message":"Yeah, you could leave warning and add pick under the warning like this:\n\nif $default_neutron_networks {\n    warning(\"trove::taskmanager::default_neutron_networks is deprecated and will be removed in \\\nthe future release. Please use trove::default_neutron_networks instead.\")\n}\n\n$default_neutron_networks_real \u003d pick($default_neutron_networks,$::trove::default_neutron_networks)","commit_id":"399cf21a1332001b6de5e7f23a07d586b1c15422"}],"spec/classes/trove_api_spec.rb":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"99fa454dbc7b7889c51ca8ebc2dac9badcd8fb2d","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        let :pre_condition do"},{"line_number":207,"context_line":"          \"class { \u0027trove\u0027:"},{"line_number":208,"context_line":"             nova_proxy_admin_pass    \u003d\u003e \u0027verysecrete\u0027,"},{"line_number":209,"context_line":"             use_neutron              \u003d\u003e true}"},{"line_number":210,"context_line":"           class { \u0027::trove::keystone::authtoken\u0027:"},{"line_number":211,"context_line":"             password \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":212,"context_line":"           }\""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"bff0334d_ebe7baab","line":209,"range":{"start_line":209,"start_character":45,"end_line":209,"end_character":46},"updated":"2017-04-10 07:52:05.000000000","message":"please move this brace on next line, for better readability, thanks","commit_id":"b2b2894e5fd19618f5e6c8c4382c8703a584b06a"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"99fa454dbc7b7889c51ca8ebc2dac9badcd8fb2d","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        let :pre_condition do"},{"line_number":222,"context_line":"          \"class { \u0027trove\u0027:"},{"line_number":223,"context_line":"             nova_proxy_admin_pass \u003d\u003e \u0027verysecrete\u0027,"},{"line_number":224,"context_line":"             use_neutron           \u003d\u003e false}"},{"line_number":225,"context_line":"           class { \u0027::trove::keystone::authtoken\u0027:"},{"line_number":226,"context_line":"             password \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":227,"context_line":"           }\""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"bff0334d_ab053248","line":224,"range":{"start_line":224,"start_character":43,"end_line":224,"end_character":44},"updated":"2017-04-10 07:52:05.000000000","message":"this too","commit_id":"b2b2894e5fd19618f5e6c8c4382c8703a584b06a"}]}