)]}'
{"manifests/auth.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"da2d3609d634749245c2d12d6b7c742ed678ef36","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"class vitrage::auth ("},{"line_number":37,"context_line":"  $auth_password,"},{"line_number":38,"context_line":"  $auth_url           \u003d \u0027http://localhost:5000/v2.0\u0027,"},{"line_number":39,"context_line":"  $auth_region        \u003d \u0027RegionOne\u0027,"},{"line_number":40,"context_line":"  $auth_user          \u003d \u0027vitrage\u0027,"},{"line_number":41,"context_line":"  $auth_tenant_name   \u003d \u0027services\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9abb7d3a_d33e52d9","line":38,"updated":"2016-05-30 12:03:05.000000000","message":"do we need endpoint version?","commit_id":"513693fa975863a15abef51ecf82b72fce761755"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"5449d9826e2c824125976418b4c899b1b36ae42b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"class vitrage::auth ("},{"line_number":37,"context_line":"  $auth_password,"},{"line_number":38,"context_line":"  $auth_url           \u003d \u0027http://localhost:5000/v2.0\u0027,"},{"line_number":39,"context_line":"  $auth_region        \u003d \u0027RegionOne\u0027,"},{"line_number":40,"context_line":"  $auth_user          \u003d \u0027vitrage\u0027,"},{"line_number":41,"context_line":"  $auth_tenant_name   \u003d \u0027services\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9abb7d3a_02a9a5df","line":38,"in_reply_to":"9abb7d3a_d33e52d9","updated":"2016-05-30 12:30:10.000000000","message":"ok","commit_id":"513693fa975863a15abef51ecf82b72fce761755"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"da2d3609d634749245c2d12d6b7c742ed678ef36","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  $auth_user          \u003d \u0027vitrage\u0027,"},{"line_number":41,"context_line":"  $auth_tenant_name   \u003d \u0027services\u0027,"},{"line_number":42,"context_line":"  $auth_tenant_id     \u003d undef,"},{"line_number":43,"context_line":"  $auth_cacert        \u003d undef,"},{"line_number":44,"context_line":"  $auth_endpoint_type \u003d undef,"},{"line_number":45,"context_line":") {"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9abb7d3a_3326bece","line":43,"updated":"2016-05-30 12:03:05.000000000","message":"why not using os_service_default for all undef parameters?","commit_id":"513693fa975863a15abef51ecf82b72fce761755"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"5449d9826e2c824125976418b4c899b1b36ae42b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  $auth_user          \u003d \u0027vitrage\u0027,"},{"line_number":41,"context_line":"  $auth_tenant_name   \u003d \u0027services\u0027,"},{"line_number":42,"context_line":"  $auth_tenant_id     \u003d undef,"},{"line_number":43,"context_line":"  $auth_cacert        \u003d undef,"},{"line_number":44,"context_line":"  $auth_endpoint_type \u003d undef,"},{"line_number":45,"context_line":") {"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9abb7d3a_e282a151","line":43,"in_reply_to":"9abb7d3a_3326bece","updated":"2016-05-30 12:30:10.000000000","message":"ok","commit_id":"513693fa975863a15abef51ecf82b72fce761755"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"21cc0ee993de8d5601ec54e62ab4d09107826e32","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    \u0027service_credentials/os_tenant_name\u0027 : value \u003d\u003e $auth_tenant_name;"},{"line_number":60,"context_line":"  }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"  if $auth_tenant_id {"},{"line_number":63,"context_line":"    vitrage_config {"},{"line_number":64,"context_line":"      \u0027service_credentials/os_tenant_id\u0027 : value \u003d\u003e $auth_tenant_id;"},{"line_number":65,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9abb7d3a_ec9c505f","line":62,"updated":"2016-05-30 14:35:17.000000000","message":"there is no need of that. Because we use os_service_default, a value will be set only if param is set. Please add the 3 params after L59.","commit_id":"c4a02f72051460bf6edc12d183a680689ba8a5d5"}]}