)]}'
{"lib/puppet/provider/vs_bridge/ovs.rb":[{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"b0aa962c9681180c38ab7b45470495249d3cc10c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  commands :vsctl     \u003d\u003e \u0027ovs-vsctl\u0027"},{"line_number":5,"context_line":"  if Facter.value(:operatingsystem) \u003d\u003d \u0027FreeBSD\u0027"},{"line_number":6,"context_line":"    Puppet.debug(\u0027FreeBSD detected\u0027)"},{"line_number":7,"context_line":"    commands :ifconfig  \u003d\u003e \u0027ifconfig\u0027 "},{"line_number":8,"context_line":"  else "},{"line_number":9,"context_line":"    commands :ip          \u003d\u003e \u0027ip\u0027"},{"line_number":10,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa32b979_05141ef3","line":7,"updated":"2015-06-14 16:55:00.000000000","message":"please delete the trailing whitespace","commit_id":"fb2374b06016027aee509825e32d43fb9aa93d9a"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"b0aa962c9681180c38ab7b45470495249d3cc10c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  if Facter.value(:operatingsystem) \u003d\u003d \u0027FreeBSD\u0027"},{"line_number":6,"context_line":"    Puppet.debug(\u0027FreeBSD detected\u0027)"},{"line_number":7,"context_line":"    commands :ifconfig  \u003d\u003e \u0027ifconfig\u0027 "},{"line_number":8,"context_line":"  else "},{"line_number":9,"context_line":"    commands :ip          \u003d\u003e \u0027ip\u0027"},{"line_number":10,"context_line":"  end"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa32b979_a5f9b2ca","line":8,"updated":"2015-06-14 16:55:00.000000000","message":"same","commit_id":"fb2374b06016027aee509825e32d43fb9aa93d9a"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"b0aa962c9681180c38ab7b45470495249d3cc10c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    if Facter.value(:operatingsystem) \u003d\u003d \u0027FreeBSD\u0027"},{"line_number":21,"context_line":"      vsctl(\u0027set\u0027,\u0027bridge\u0027,@resource[:name],\u0027datapath_type\u003dnetdev\u0027)"},{"line_number":22,"context_line":"      ifconfig(@resource[:name],\u0027up\u0027)"},{"line_number":23,"context_line":"    else "},{"line_number":24,"context_line":"      ip(\u0027link\u0027, \u0027set\u0027, @resource[:name], \u0027up\u0027)"},{"line_number":25,"context_line":"    end"},{"line_number":26,"context_line":"    external_ids \u003d @resource[:external_ids] if @resource[:external_ids]"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa32b979_6503aab9","line":23,"updated":"2015-06-14 16:55:00.000000000","message":"same","commit_id":"fb2374b06016027aee509825e32d43fb9aa93d9a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5b0de042eac219f21e61fac8406328be18e777e8","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  def destroy"},{"line_number":30,"context_line":"    if Facter.value(:operatingsystem) \u003d\u003d \u0027FreeBSD\u0027"},{"line_number":31,"context_line":"      ifconfig(@resource[:name],\u0027up\u0027)"},{"line_number":32,"context_line":"    else"},{"line_number":33,"context_line":"      ip(\u0027link\u0027, \u0027set\u0027, @resource[:name], \u0027down\u0027)"},{"line_number":34,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"3a50d1a3_e4bd9968","line":31,"updated":"2015-07-29 20:12:56.000000000","message":"The up seems a typo, down is needed?","commit_id":"3fc5c46cf7c19f053b7e2e557e945781d819d2da"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"260ef8f2f854823c89a2101e4d11232038ade09f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Puppet::Type.type(:vs_bridge).provide(:ovs) do"},{"line_number":4,"context_line":"  commands :vsctl     \u003d\u003e \u0027ovs-vsctl\u0027"},{"line_number":5,"context_line":"  if Facter.value(:operatingsystem) \u003d\u003d \u0027FreeBSD\u0027"},{"line_number":6,"context_line":"    Puppet.debug(\u0027FreeBSD detected\u0027)"},{"line_number":7,"context_line":"    commands :ifconfig  \u003d\u003e \u0027ifconfig\u0027"},{"line_number":8,"context_line":"  else"},{"line_number":9,"context_line":"    commands :ip  \u003d\u003e \u0027ip\u0027"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"ba15a1d1_134366b3","line":6,"updated":"2015-09-17 14:12:43.000000000","message":"Do we really need debug message here?","commit_id":"c0875b3bed0fe7c69a8c1646d61cb040fe5e1c28"}],"spec/classes/vswitch_ovs_spec.rb":[{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"9699c9bde0e125222e3b4688c72bfcf728dfe9a1","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    it_configures \u0027vswitch ovs\u0027"},{"line_number":199,"context_line":"    #"},{"line_number":200,"context_line":"    #it_configures \u0027install dkms\u0027"},{"line_number":201,"context_line":"    #"},{"line_number":202,"context_line":"    it \u0027configures ovsdb service\u0027 do"},{"line_number":203,"context_line":"        is_expected.to contain_service(\u0027ovsdb-server\u0027).with("}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa32b979_809d950b","line":200,"updated":"2015-06-19 07:39:49.000000000","message":"RedHat also doesn\u0027t use DKMS, so I suggest you copy the RedHat example and actually test that DKMS is not installed.","commit_id":"f8c91e70a739656fe5d2e8c2477eaa1f50996c5e"},{"author":{"_account_id":16850,"name":"Athanasios Douitsis","email":"aduitsis@gmail.com","username":"athanasios"},"change_message_id":"4f5e55a783b46722ab1c942ab60ee24382b42f3d","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    it_configures \u0027vswitch ovs\u0027"},{"line_number":199,"context_line":"    #"},{"line_number":200,"context_line":"    #it_configures \u0027install dkms\u0027"},{"line_number":201,"context_line":"    #"},{"line_number":202,"context_line":"    it \u0027configures ovsdb service\u0027 do"},{"line_number":203,"context_line":"        is_expected.to contain_service(\u0027ovsdb-server\u0027).with("}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa32b979_685dd747","line":200,"in_reply_to":"fa32b979_809d950b","updated":"2015-06-19 09:07:26.000000000","message":"Done","commit_id":"f8c91e70a739656fe5d2e8c2477eaa1f50996c5e"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"9699c9bde0e125222e3b4688c72bfcf728dfe9a1","unresolved":false,"context_lines":[{"line_number":213,"context_line":"  context \u0027on FreeBSD with parameters\u0027 do"},{"line_number":214,"context_line":"    let :params do {"},{"line_number":215,"context_line":"      :package_ensure \u003d\u003e \u0027latest\u0027,"},{"line_number":216,"context_line":"      :dkms_ensure    \u003d\u003e false,"},{"line_number":217,"context_line":"    }"},{"line_number":218,"context_line":"    end"},{"line_number":219,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa32b979_80b4b581","line":216,"updated":"2015-06-19 07:39:49.000000000","message":"Remove this line. This is a pointless param since by default you don\u0027t have DKMS, you are not actually overriding anything. RedHat\u0027s test also has the same problem, but I suggest you fix it in yours regardless.","commit_id":"f8c91e70a739656fe5d2e8c2477eaa1f50996c5e"},{"author":{"_account_id":16850,"name":"Athanasios Douitsis","email":"aduitsis@gmail.com","username":"athanasios"},"change_message_id":"4f5e55a783b46722ab1c942ab60ee24382b42f3d","unresolved":false,"context_lines":[{"line_number":213,"context_line":"  context \u0027on FreeBSD with parameters\u0027 do"},{"line_number":214,"context_line":"    let :params do {"},{"line_number":215,"context_line":"      :package_ensure \u003d\u003e \u0027latest\u0027,"},{"line_number":216,"context_line":"      :dkms_ensure    \u003d\u003e false,"},{"line_number":217,"context_line":"    }"},{"line_number":218,"context_line":"    end"},{"line_number":219,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa32b979_a842ff66","line":216,"in_reply_to":"fa32b979_80b4b581","updated":"2015-06-19 09:07:26.000000000","message":"Done","commit_id":"f8c91e70a739656fe5d2e8c2477eaa1f50996c5e"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"9699c9bde0e125222e3b4688c72bfcf728dfe9a1","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    let :platform_params do freebsd_platform_params end"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    it_configures \u0027vswitch ovs\u0027"},{"line_number":228,"context_line":"    # it_configures \u0027do not install dkms\u0027"},{"line_number":229,"context_line":"    it \u0027configures ovsdb service\u0027 do"},{"line_number":230,"context_line":"        is_expected.to contain_service(platform_params[:ovsdb_service_name]).with("},{"line_number":231,"context_line":"          :ensure    \u003d\u003e true,"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa32b979_20a4c948","line":228,"updated":"2015-06-19 07:39:49.000000000","message":"RedHat also doesn\u0027t use DKMS, so I suggest you copy the RedHat example and actually test that DKMS is not installed.","commit_id":"f8c91e70a739656fe5d2e8c2477eaa1f50996c5e"},{"author":{"_account_id":16850,"name":"Athanasios Douitsis","email":"aduitsis@gmail.com","username":"athanasios"},"change_message_id":"4f5e55a783b46722ab1c942ab60ee24382b42f3d","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    let :platform_params do freebsd_platform_params end"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    it_configures \u0027vswitch ovs\u0027"},{"line_number":228,"context_line":"    # it_configures \u0027do not install dkms\u0027"},{"line_number":229,"context_line":"    it \u0027configures ovsdb service\u0027 do"},{"line_number":230,"context_line":"        is_expected.to contain_service(platform_params[:ovsdb_service_name]).with("},{"line_number":231,"context_line":"          :ensure    \u003d\u003e true,"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"fa32b979_e848078d","line":228,"in_reply_to":"fa32b979_20a4c948","updated":"2015-06-19 09:07:26.000000000","message":"Done","commit_id":"f8c91e70a739656fe5d2e8c2477eaa1f50996c5e"}]}