)]}'
{"manifests/dpdk.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4bda72e8485307cafc2585989b89468bbcd2b818","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Configure OVS to use DPDK"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# \u003d\u003d\u003d Parameters"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_3f0821d9","line":1,"updated":"2016-07-11 13:32:47.000000000","message":"Could we have unit tests?","commit_id":"47a710aa155d87b9c169458f45cf6aa5e83df1a4"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"1a2f5fcc1cb79fe87562956eeca21160c68a18fe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Configure OVS to use DPDK"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# \u003d\u003d\u003d Parameters"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_9371200f","line":1,"in_reply_to":"1aa78d24_3f0821d9","updated":"2016-07-12 13:04:51.000000000","message":"Done","commit_id":"47a710aa155d87b9c169458f45cf6aa5e83df1a4"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4bda72e8485307cafc2585989b89468bbcd2b818","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"class vswitch::dpdk ("},{"line_number":20,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":21,"context_line":"  $core_list,"},{"line_number":22,"context_line":"  $memory_channels,"},{"line_number":23,"context_line":"  $socket_mem,"},{"line_number":24,"context_line":") {"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  include ::vswitch::params"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_bff411cf","line":23,"range":{"start_line":21,"start_character":0,"end_line":23,"end_character":14},"updated":"2016-07-11 13:32:47.000000000","message":"no default values?","commit_id":"47a710aa155d87b9c169458f45cf6aa5e83df1a4"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"1a2f5fcc1cb79fe87562956eeca21160c68a18fe","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"class vswitch::dpdk ("},{"line_number":20,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":21,"context_line":"  $core_list,"},{"line_number":22,"context_line":"  $memory_channels,"},{"line_number":23,"context_line":"  $socket_mem,"},{"line_number":24,"context_line":") {"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  include ::vswitch::params"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_93df60d5","line":23,"range":{"start_line":21,"start_character":0,"end_line":23,"end_character":14},"in_reply_to":"1aa78d24_bff411cf","updated":"2016-07-12 13:04:51.000000000","message":"core_list and memory_channels are mandatory parameters, cannot assume default. I have assigned socket_mem with undef as default.","commit_id":"47a710aa155d87b9c169458f45cf6aa5e83df1a4"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4bda72e8485307cafc2585989b89468bbcd2b818","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      }"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":"    default: {"},{"line_number":54,"context_line":"      fail( \"${::osfamily} not yet supported by puppet-vswitch\")"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":"  }"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_ff15f9e4","line":54,"updated":"2016-07-11 13:32:47.000000000","message":"the message is wrong, puppet-vswitch can be deployed on Ubuntu/Debian. But it looks like this class is not the case. Please make it explicit.","commit_id":"47a710aa155d87b9c169458f45cf6aa5e83df1a4"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"1a2f5fcc1cb79fe87562956eeca21160c68a18fe","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      }"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":"    default: {"},{"line_number":54,"context_line":"      fail( \"${::osfamily} not yet supported by puppet-vswitch\")"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":"  }"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_284d8999","line":54,"in_reply_to":"1aa78d24_ff15f9e4","updated":"2016-07-12 13:04:51.000000000","message":"Done","commit_id":"47a710aa155d87b9c169458f45cf6aa5e83df1a4"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"1005f8d2d08b69997efbe1c063a693aa0a5f6476","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class vswitch::dpdk ("},{"line_number":21,"context_line":"  $package_ensure     \u003d \u0027present\u0027,"},{"line_number":22,"context_line":"  $core_list,"},{"line_number":23,"context_line":"  $memory_channels,"},{"line_number":24,"context_line":"  $socket_mem         \u003d undef,"},{"line_number":25,"context_line":") {"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1aa78d24_545af4f2","line":23,"updated":"2016-07-12 13:21:51.000000000","message":"nitpick but usually the required parameters go on top, like:\n\n  class test (\n    param1,\n    param2,\n    param3 \u003d undef,\n  ) {\n  ...\n  }","commit_id":"27cfcc5f2783e299f53aafff27dc76663c510851"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"e7fdb219bde23f975c524698771ee54976ef1322","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class vswitch::dpdk ("},{"line_number":21,"context_line":"  $package_ensure     \u003d \u0027present\u0027,"},{"line_number":22,"context_line":"  $core_list,"},{"line_number":23,"context_line":"  $memory_channels,"},{"line_number":24,"context_line":"  $socket_mem         \u003d undef,"},{"line_number":25,"context_line":") {"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1aa78d24_f88c86d8","line":23,"in_reply_to":"1aa78d24_545af4f2","updated":"2016-07-13 08:20:21.000000000","message":"Done","commit_id":"27cfcc5f2783e299f53aafff27dc76663c510851"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"bf4d6f9cc51456fb77c89be2e754fa1d73a6184c","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#   Defaults to \u0027present\u0027."},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# [*core_list*]"},{"line_number":11,"context_line":"#   (required) The list of cores to be used by the DPDK Poll Mode Driver"},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"# [*memory_channels*]"},{"line_number":14,"context_line":"#   (required) The number of memory channels to use"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1aa78d24_17ad7c9b","line":11,"updated":"2016-07-14 20:41:21.000000000","message":"Can we have an example of what format this list should be? It appears to be a comma seperated list of integers from the tests but we should document what is expected here. Additionally if it\u0027s a comma seperated list, perhaps we should also support the input being an array and use join(any2array($core_list), \u0027,\u0027)","commit_id":"b948916cd7965d3ec40f65fd635a17e01d4e2258"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"26e0d9937eb9cdeff4b6271974979e9e5df4094d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#   Defaults to \u0027present\u0027."},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# [*core_list*]"},{"line_number":11,"context_line":"#   (required) The list of cores to be used by the DPDK Poll Mode Driver"},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"# [*memory_channels*]"},{"line_number":14,"context_line":"#   (required) The number of memory channels to use"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1aa78d24_41672f51","line":11,"in_reply_to":"1aa78d24_17ad7c9b","updated":"2016-07-15 08:28:28.000000000","message":"Done","commit_id":"b948916cd7965d3ec40f65fd635a17e01d4e2258"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"bf4d6f9cc51456fb77c89be2e754fa1d73a6184c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#   (required) The list of cores to be used by the DPDK Poll Mode Driver"},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"# [*memory_channels*]"},{"line_number":14,"context_line":"#   (required) The number of memory channels to use"},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# [*socket_mem*]"},{"line_number":17,"context_line":"#   (Optional) Set the memory to be allocated on each socket"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1aa78d24_7794c043","line":14,"updated":"2016-07-14 20:41:21.000000000","message":"Same here, I assume it\u0027s just an integer but it would be good to document it","commit_id":"b948916cd7965d3ec40f65fd635a17e01d4e2258"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"26e0d9937eb9cdeff4b6271974979e9e5df4094d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#   (required) The list of cores to be used by the DPDK Poll Mode Driver"},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"# [*memory_channels*]"},{"line_number":14,"context_line":"#   (required) The number of memory channels to use"},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# [*socket_mem*]"},{"line_number":17,"context_line":"#   (Optional) Set the memory to be allocated on each socket"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1aa78d24_a176d303","line":14,"in_reply_to":"1aa78d24_7794c043","updated":"2016-07-15 08:28:28.000000000","message":"Done","commit_id":"b948916cd7965d3ec40f65fd635a17e01d4e2258"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"e1185c1ea035c99a4bfb25728367cc8ef9460960","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  package { $::vswitch::params::ovs_dpdk_package_name:"},{"line_number":34,"context_line":"    ensure        \u003d\u003e $package_ensure,"},{"line_number":35,"context_line":"    allow_virtual \u003d\u003e true,"},{"line_number":36,"context_line":"    before        \u003d\u003e Service[\u0027openvswitch\u0027],"},{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1aa78d24_b07e1268","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":26},"updated":"2016-07-15 11:42:26.000000000","message":"the same w/ puppet version","commit_id":"a2ad2138d0e25f1b44781a51908e6903ac50ab5c"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"6f9f69d0273da5a08e349838f02b51916d41ab89","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  package { $::vswitch::params::ovs_dpdk_package_name:"},{"line_number":34,"context_line":"    ensure        \u003d\u003e $package_ensure,"},{"line_number":35,"context_line":"    allow_virtual \u003d\u003e true,"},{"line_number":36,"context_line":"    before        \u003d\u003e Service[\u0027openvswitch\u0027],"},{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1aa78d24_166d5e32","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":26},"in_reply_to":"1aa78d24_b07e1268","updated":"2016-07-15 12:36:20.000000000","message":"Done","commit_id":"a2ad2138d0e25f1b44781a51908e6903ac50ab5c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d9a0b5f6e1883947485de403c21a8ec3fa5333f3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  include ::vswitch::params"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  package { $::vswitch::params::ovs_dpdk_package_name:"},{"line_number":34,"context_line":"    ensure  \u003d\u003e $package_ensure,"},{"line_number":35,"context_line":"    before  \u003d\u003e Service[\u0027openvswitch\u0027],"},{"line_number":36,"context_line":"    tag     \u003d\u003e \u0027openvswitch\u0027,"},{"line_number":37,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1aa78d24_46ebb312","line":34,"updated":"2016-07-15 13:56:50.000000000","message":"Lint is complaining because there are too many spaces here","commit_id":"d8d7d38168d593b7b07fb6e6fc10bae3b5625588"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"7bf2e6ea8aeb7d0ddb47c5fca21881f2858dd955","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  include ::vswitch::params"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  package { $::vswitch::params::ovs_dpdk_package_name:"},{"line_number":34,"context_line":"    ensure  \u003d\u003e $package_ensure,"},{"line_number":35,"context_line":"    before  \u003d\u003e Service[\u0027openvswitch\u0027],"},{"line_number":36,"context_line":"    tag     \u003d\u003e \u0027openvswitch\u0027,"},{"line_number":37,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1aa78d24_26e5c7a7","line":34,"in_reply_to":"1aa78d24_46ebb312","updated":"2016-07-15 14:27:46.000000000","message":"Done","commit_id":"d8d7d38168d593b7b07fb6e6fc10bae3b5625588"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6a2f936cc40c99ec145cab7e283a4901a78b37b3","unresolved":false,"context_lines":[{"line_number":60,"context_line":"      }"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":"    default: {"},{"line_number":63,"context_line":"      fail( \"${::osfamily} not yet supported for dpdk installation by puppet-vswitch\")"},{"line_number":64,"context_line":"    }"},{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"fad55976_518903ca","line":63,"updated":"2016-07-15 16:39:39.000000000","message":"you are specified package for Debian OS, so, is dpdk supported only on redhat?","commit_id":"f1c5e34409e34a66284340b4f61ec77f01f5436f"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"f97fbcba32b0c9b84935cbfb10deec01fa8a2195","unresolved":false,"context_lines":[{"line_number":60,"context_line":"      }"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":"    default: {"},{"line_number":63,"context_line":"      fail( \"${::osfamily} not yet supported for dpdk installation by puppet-vswitch\")"},{"line_number":64,"context_line":"    }"},{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"fad55976_3987d8d8","line":63,"in_reply_to":"fad55976_1144ab72","updated":"2016-07-16 07:15:30.000000000","message":"The plan is to support for Debian also. But we have other changes planned on top this class. Importantly, PCI white listing options for DPDK_OPTIONS. As a first step, this review is targeted with Red Hat family with only basic options. We will be working on PCI white listing \u0026 Debian.","commit_id":"f1c5e34409e34a66284340b4f61ec77f01f5436f"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"e3d7c17115ad7bb42af6e8d3671f2dcbccfbc84a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"      }"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":"    default: {"},{"line_number":63,"context_line":"      fail( \"${::osfamily} not yet supported for dpdk installation by puppet-vswitch\")"},{"line_number":64,"context_line":"    }"},{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"fad55976_1144ab72","line":63,"in_reply_to":"fad55976_518903ca","updated":"2016-07-15 16:41:59.000000000","message":"Yes, AFAIK openvswitch-dpdk packages exist for Ubuntu Xenial","commit_id":"f1c5e34409e34a66284340b4f61ec77f01f5436f"}],"manifests/ovs.pp":[{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"edbeebd66e29205b3eaf035961908ea199de1379","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  package { $::vswitch::params::ovs_package_name:"},{"line_number":129,"context_line":"    ensure        \u003d\u003e $package_ensure,"},{"line_number":130,"context_line":"    allow_virtual \u003d\u003e true,"},{"line_number":131,"context_line":"    before        \u003d\u003e Service[\u0027openvswitch\u0027],"},{"line_number":132,"context_line":"  }"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1aa78d24_b783b154","line":130,"range":{"start_line":130,"start_character":4,"end_line":130,"end_character":26},"updated":"2016-07-15 08:58:50.000000000","message":"#minor: valid for puppet \u003c 4 and \u003e\u003d 3.6.1","commit_id":"284f515e5c980de1d57dc2faae1a10ff7e21e57d"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"28c6b380abae6e803180639686a39f39207bc0cd","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  package { $::vswitch::params::ovs_package_name:"},{"line_number":129,"context_line":"    ensure        \u003d\u003e $package_ensure,"},{"line_number":130,"context_line":"    allow_virtual \u003d\u003e true,"},{"line_number":131,"context_line":"    before        \u003d\u003e Service[\u0027openvswitch\u0027],"},{"line_number":132,"context_line":"  }"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1aa78d24_edaa8519","line":130,"range":{"start_line":130,"start_character":4,"end_line":130,"end_character":26},"in_reply_to":"1aa78d24_b783b154","updated":"2016-07-15 11:34:49.000000000","message":"Done","commit_id":"284f515e5c980de1d57dc2faae1a10ff7e21e57d"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"e1185c1ea035c99a4bfb25728367cc8ef9460960","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    }"},{"line_number":126,"context_line":"  }"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  if versioncmp($::puppetversion, \u00274.0.0\u0027) \u003c 0 and versioncmp($::puppetversion, \u00273.6.1\u0027) \u003e\u003d 0 {"},{"line_number":129,"context_line":"    Package\u003c| tag \u003d\u003d \u0027openvswitch\u0027 |\u003e {"},{"line_number":130,"context_line":"      allow_virtual \u003d\u003e true,"},{"line_number":131,"context_line":"    }"},{"line_number":132,"context_line":"  }"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"  package { $::vswitch::params::ovs_package_name:"},{"line_number":135,"context_line":"    ensure        \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1aa78d24_70d2ea5c","line":132,"range":{"start_line":128,"start_character":3,"end_line":132,"end_character":3},"updated":"2016-07-15 11:42:26.000000000","message":"this could be placed into params.pp","commit_id":"a2ad2138d0e25f1b44781a51908e6903ac50ab5c"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"6f9f69d0273da5a08e349838f02b51916d41ab89","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    }"},{"line_number":126,"context_line":"  }"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  if versioncmp($::puppetversion, \u00274.0.0\u0027) \u003c 0 and versioncmp($::puppetversion, \u00273.6.1\u0027) \u003e\u003d 0 {"},{"line_number":129,"context_line":"    Package\u003c| tag \u003d\u003d \u0027openvswitch\u0027 |\u003e {"},{"line_number":130,"context_line":"      allow_virtual \u003d\u003e true,"},{"line_number":131,"context_line":"    }"},{"line_number":132,"context_line":"  }"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"  package { $::vswitch::params::ovs_package_name:"},{"line_number":135,"context_line":"    ensure        \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1aa78d24_767b02f5","line":132,"range":{"start_line":128,"start_character":3,"end_line":132,"end_character":3},"in_reply_to":"1aa78d24_70d2ea5c","updated":"2016-07-15 12:36:20.000000000","message":"Done","commit_id":"a2ad2138d0e25f1b44781a51908e6903ac50ab5c"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"e1185c1ea035c99a4bfb25728367cc8ef9460960","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    }"},{"line_number":132,"context_line":"  }"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"  package { $::vswitch::params::ovs_package_name:"},{"line_number":135,"context_line":"    ensure        \u003d\u003e $package_ensure,"},{"line_number":136,"context_line":"    before        \u003d\u003e Service[\u0027openvswitch\u0027],"},{"line_number":137,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1aa78d24_d06d9ecd","line":134,"range":{"start_line":134,"start_character":2,"end_line":134,"end_character":9},"updated":"2016-07-15 11:42:26.000000000","message":"tag \u003d\u003e \u0027openvswitch\u0027\nshould be added to catch by above expression.","commit_id":"a2ad2138d0e25f1b44781a51908e6903ac50ab5c"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"6f9f69d0273da5a08e349838f02b51916d41ab89","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    }"},{"line_number":132,"context_line":"  }"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"  package { $::vswitch::params::ovs_package_name:"},{"line_number":135,"context_line":"    ensure        \u003d\u003e $package_ensure,"},{"line_number":136,"context_line":"    before        \u003d\u003e Service[\u0027openvswitch\u0027],"},{"line_number":137,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1aa78d24_d682b6c7","line":134,"range":{"start_line":134,"start_character":2,"end_line":134,"end_character":9},"in_reply_to":"1aa78d24_d06d9ecd","updated":"2016-07-15 12:36:20.000000000","message":"Done","commit_id":"a2ad2138d0e25f1b44781a51908e6903ac50ab5c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d9a0b5f6e1883947485de403c21a8ec3fa5333f3","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  }"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  package { $::vswitch::params::ovs_package_name:"},{"line_number":129,"context_line":"    ensure  \u003d\u003e $package_ensure,"},{"line_number":130,"context_line":"    before  \u003d\u003e Service[\u0027openvswitch\u0027],"},{"line_number":131,"context_line":"    tag     \u003d\u003e \u0027openvswitch\u0027,"},{"line_number":132,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1aa78d24_46bc53db","line":129,"updated":"2016-07-15 13:56:50.000000000","message":"Lint is complaining because there are too many spaces here","commit_id":"d8d7d38168d593b7b07fb6e6fc10bae3b5625588"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"7bf2e6ea8aeb7d0ddb47c5fca21881f2858dd955","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  }"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"  package { $::vswitch::params::ovs_package_name:"},{"line_number":129,"context_line":"    ensure  \u003d\u003e $package_ensure,"},{"line_number":130,"context_line":"    before  \u003d\u003e Service[\u0027openvswitch\u0027],"},{"line_number":131,"context_line":"    tag     \u003d\u003e \u0027openvswitch\u0027,"},{"line_number":132,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1aa78d24_490744c9","line":129,"in_reply_to":"1aa78d24_46bc53db","updated":"2016-07-15 14:27:46.000000000","message":"Done","commit_id":"d8d7d38168d593b7b07fb6e6fc10bae3b5625588"}],"manifests/params.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4bda72e8485307cafc2585989b89468bbcd2b818","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  case $::osfamily {"},{"line_number":5,"context_line":"    \u0027Redhat\u0027: {"},{"line_number":6,"context_line":"      $ovs_package_name      \u003d \u0027openvswitch\u0027"},{"line_number":7,"context_line":"      $ovs_dpdk_package_name \u003d \u0027openvswitch-dpdk\u0027"},{"line_number":8,"context_line":"      $ovs_dkms_package_name \u003d undef"},{"line_number":9,"context_line":"      $ovs_service_name      \u003d \u0027openvswitch\u0027"},{"line_number":10,"context_line":"      $provider              \u003d \u0027ovs_redhat\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_ff67b9b4","line":7,"updated":"2016-07-11 13:32:47.000000000","message":"what about Debian/Ubuntu?","commit_id":"47a710aa155d87b9c169458f45cf6aa5e83df1a4"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"1a2f5fcc1cb79fe87562956eeca21160c68a18fe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  case $::osfamily {"},{"line_number":5,"context_line":"    \u0027Redhat\u0027: {"},{"line_number":6,"context_line":"      $ovs_package_name      \u003d \u0027openvswitch\u0027"},{"line_number":7,"context_line":"      $ovs_dpdk_package_name \u003d \u0027openvswitch-dpdk\u0027"},{"line_number":8,"context_line":"      $ovs_dkms_package_name \u003d undef"},{"line_number":9,"context_line":"      $ovs_service_name      \u003d \u0027openvswitch\u0027"},{"line_number":10,"context_line":"      $provider              \u003d \u0027ovs_redhat\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_4831f50a","line":7,"in_reply_to":"1aa78d24_ff67b9b4","updated":"2016-07-12 13:04:51.000000000","message":"Done","commit_id":"47a710aa155d87b9c169458f45cf6aa5e83df1a4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d9a0b5f6e1883947485de403c21a8ec3fa5333f3","unresolved":false,"context_lines":[{"line_number":3,"context_line":"class vswitch::params {"},{"line_number":4,"context_line":"  include ::openstacklib::defaults"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  if versioncmp($::puppetversion, \u00274.0.0\u0027) \u003c 0 and versioncmp($::puppetversion, \u00273.6.1\u0027) \u003e\u003d 0 {"},{"line_number":7,"context_line":"    Package\u003c| tag \u003d\u003d \u0027openvswitch\u0027 |\u003e {"},{"line_number":8,"context_line":"      allow_virtual \u003d\u003e true,"},{"line_number":9,"context_line":"    }"},{"line_number":10,"context_line":"  }"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  case $::osfamily {"},{"line_number":13,"context_line":"    \u0027Redhat\u0027: {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1aa78d24_e6e61f15","line":10,"range":{"start_line":6,"start_character":0,"end_line":10,"end_character":3},"updated":"2016-07-15 13:56:50.000000000","message":"If you just take the packages with openstack, this is already handled via ::openstacklib::defaults. Not sure if there would any side effect to switching to also include the openstack tag, but I\u0027d thought i\u0027d mention it","commit_id":"d8d7d38168d593b7b07fb6e6fc10bae3b5625588"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"7bf2e6ea8aeb7d0ddb47c5fca21881f2858dd955","unresolved":false,"context_lines":[{"line_number":3,"context_line":"class vswitch::params {"},{"line_number":4,"context_line":"  include ::openstacklib::defaults"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  if versioncmp($::puppetversion, \u00274.0.0\u0027) \u003c 0 and versioncmp($::puppetversion, \u00273.6.1\u0027) \u003e\u003d 0 {"},{"line_number":7,"context_line":"    Package\u003c| tag \u003d\u003d \u0027openvswitch\u0027 |\u003e {"},{"line_number":8,"context_line":"      allow_virtual \u003d\u003e true,"},{"line_number":9,"context_line":"    }"},{"line_number":10,"context_line":"  }"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  case $::osfamily {"},{"line_number":13,"context_line":"    \u0027Redhat\u0027: {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"fad55976_6a4ed7c2","line":10,"range":{"start_line":6,"start_character":0,"end_line":10,"end_character":3},"in_reply_to":"1aa78d24_e6e61f15","updated":"2016-07-15 14:27:46.000000000","message":"I validated with a simple test case and it is working. Let me know if i miss any case.\n\n----------------------------------------------\nif versioncmp($::puppetversion, \u00274.0.0\u0027) \u003c 0 and versioncmp($::puppetversion, \u00273.6.1\u0027) \u003e\u003d 0 {\n  Package\u003c| tag \u003d\u003d \u0027openvswitch1\u0027 |\u003e {\n    allow_virtual \u003d\u003e true,\n  }\n}\n \nif versioncmp($::puppetversion, \u00274.0.0\u0027) \u003c 0 and versioncmp($::puppetversion, \u00273.6.1\u0027) \u003e\u003d 0 {\n  Package\u003c| tag \u003d\u003d \u0027openvswitch2\u0027 |\u003e {\n    allow_virtual \u003d\u003e true,\n  }\n}\n \npackage { \u0027openvswitch\u0027:\n  ensure \u003d\u003e \u0027present\u0027,\n  tag    \u003d\u003e \u0027openvswitch2\u0027\n}\n \npackage { \u0027openvswitch-dpdk\u0027:\n  ensure \u003d\u003e \u0027present\u0027,\n  tag    \u003d\u003e \u0027openvswitch1\u0027\n}","commit_id":"d8d7d38168d593b7b07fb6e6fc10bae3b5625588"}]}