)]}'
{"manifests/dpdk.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"66c885629fa5aaa2bb63119a09ab0a1dff2569de","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        name   \u003d\u003e $::vswitch::params::ovs_service_name,"},{"line_number":72,"context_line":"      }"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"      file { \u0027dpdk-driver-module-loader\u0027:"},{"line_number":75,"context_line":"        ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":76,"context_line":"        path    \u003d\u003e \u0027/etc/sysconfig/modules/dpdk-driver.modules\u0027,"},{"line_number":77,"context_line":"        mode    \u003d\u003e \u00270700\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bacf61ea_37af22e5","line":74,"updated":"2016-07-27 15:11:07.000000000","message":"This is not the cleanest way to do it. I would rather use puppet-kmod for that.\nYou\u0027ll need to look https://github.com/camptocamp/puppet-kmod\nAdd it in openstack/puppet-openstack-integration Puppetfile and external_modules.txt files.\nAnd use it here, like:   kmod::load { \u0027vfio-pci\u0027: }.\nYou can also add a boolean to whether or not - True by default - activate this module.","commit_id":"f2cc1ded400d602942623aa03652a148d5822976"}],"metadata.json":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b2b31e9ccb1565323b8dcd4a71a20ca02fb8f657","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    { \"name\": \"puppet\",\"version_requirement\": \"3.x\" }"},{"line_number":43,"context_line":"  ],"},{"line_number":44,"context_line":"  \"dependencies\": ["},{"line_number":45,"context_line":"    { \"name\": \"camptocamp/puppet-kmod\", \"version_requirement\": \"\u003e 2.1.0 \u003c\u003d 2.1.1\" }"},{"line_number":46,"context_line":"  ]"},{"line_number":47,"context_line":"}"}],"source_content_type":"application/json","patch_set":6,"id":"bacf61ea_de8ab7be","line":45,"range":{"start_line":45,"start_character":64,"end_line":45,"end_character":80},"updated":"2016-07-29 10:28:25.000000000","message":"it\u0027s better to use\n\n\u003e \"\u003e 2.1.0 \u003c\u003d 2.2.0\"\n\nbut let\u0027s wait for other reviews","commit_id":"da3803aca530c910dcbbc699c473b6a412f49361"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"568892eae05e3bea112f0ca46f9a6daddfad683a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    { \"name\": \"puppet\",\"version_requirement\": \"3.x\" }"},{"line_number":43,"context_line":"  ],"},{"line_number":44,"context_line":"  \"dependencies\": ["},{"line_number":45,"context_line":"    { \"name\": \"camptocamp/puppet-kmod\", \"version_requirement\": \"\u003e 2.1.0 \u003c\u003d 2.1.1\" }"},{"line_number":46,"context_line":"  ]"},{"line_number":47,"context_line":"}"}],"source_content_type":"application/json","patch_set":6,"id":"bacf61ea_ea77ea37","line":45,"updated":"2016-07-29 15:05:50.000000000","message":"or no version_requirement... I\u0027m not aware of any constraint here.","commit_id":"da3803aca530c910dcbbc699c473b6a412f49361"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"1d2e42dd1556826f09df94a7776d82fa860f403b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    { \"name\": \"puppet\",\"version_requirement\": \"3.x\" }"},{"line_number":43,"context_line":"  ],"},{"line_number":44,"context_line":"  \"dependencies\": ["},{"line_number":45,"context_line":"    { \"name\": \"camptocamp/puppet-kmod\", \"version_requirement\": \"\u003e 2.1.0 \u003c\u003d 2.1.1\" }"},{"line_number":46,"context_line":"  ]"},{"line_number":47,"context_line":"}"}],"source_content_type":"application/json","patch_set":6,"id":"bacf61ea_1472477b","line":45,"in_reply_to":"bacf61ea_ea77ea37","updated":"2016-07-30 05:19:34.000000000","message":"Done","commit_id":"da3803aca530c910dcbbc699c473b6a412f49361"}],"spec/classes/vswitch_dpdk_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"021cf7699770619860c890f06df683fff758db67","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  shared_examples_for \u0027vswitch dpdk for modprobe\u0027 do"},{"line_number":86,"context_line":"    it \u0027should have dpdk driver modules file\u0027 do"},{"line_number":87,"context_line":"      is_expected.to contain_file(\u0027dpdk-driver-module-loader\u0027).with("},{"line_number":88,"context_line":"        :ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":89,"context_line":"        :mode    \u003d\u003e \u00270700\u0027,"},{"line_number":90,"context_line":"        :path    \u003d\u003e \u0027/etc/sysconfig/modules/dpdk-driver.modules\u0027,"},{"line_number":91,"context_line":"      )"},{"line_number":92,"context_line":"    end"},{"line_number":93,"context_line":"  end"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"bacf61ea_ecb1dc90","line":91,"range":{"start_line":87,"start_character":0,"end_line":91,"end_character":7},"updated":"2016-07-29 08:43:19.000000000","message":"is_expected.to contain_kmod__load(\u0027vfio-pci\u0027)","commit_id":"f70be99d653ec4eb1dedcaed1349f60b2be54015"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"3692eb6e08156cb311da22af451863fd451057f9","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  shared_examples_for \u0027vswitch dpdk for modprobe\u0027 do"},{"line_number":86,"context_line":"    it \u0027should have dpdk driver modules file\u0027 do"},{"line_number":87,"context_line":"      is_expected.to contain_file(\u0027dpdk-driver-module-loader\u0027).with("},{"line_number":88,"context_line":"        :ensure  \u003d\u003e \u0027present\u0027,"},{"line_number":89,"context_line":"        :mode    \u003d\u003e \u00270700\u0027,"},{"line_number":90,"context_line":"        :path    \u003d\u003e \u0027/etc/sysconfig/modules/dpdk-driver.modules\u0027,"},{"line_number":91,"context_line":"      )"},{"line_number":92,"context_line":"    end"},{"line_number":93,"context_line":"  end"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"bacf61ea_0756c95b","line":91,"range":{"start_line":87,"start_character":0,"end_line":91,"end_character":7},"in_reply_to":"bacf61ea_ecb1dc90","updated":"2016-07-29 09:02:54.000000000","message":"Done","commit_id":"f70be99d653ec4eb1dedcaed1349f60b2be54015"}],"templates/dpdk-driver.modules.erb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"021cf7699770619860c890f06df683fff758db67","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":"modprobe vfio-pci \u003e/dev/null 2\u003e\u00261"},{"line_number":3,"context_line":"exit 0"}],"source_content_type":"application/x-erb","patch_set":4,"id":"bacf61ea_2c50145d","line":1,"updated":"2016-07-29 08:43:19.000000000","message":"do we still need this file?","commit_id":"f70be99d653ec4eb1dedcaed1349f60b2be54015"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"3692eb6e08156cb311da22af451863fd451057f9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":"modprobe vfio-pci \u003e/dev/null 2\u003e\u00261"},{"line_number":3,"context_line":"exit 0"}],"source_content_type":"application/x-erb","patch_set":4,"id":"bacf61ea_277e6dae","line":1,"in_reply_to":"bacf61ea_2c50145d","updated":"2016-07-29 09:02:54.000000000","message":"Will remove","commit_id":"f70be99d653ec4eb1dedcaed1349f60b2be54015"}]}