)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"de4084b28f52904f86faeaa42fa05164e753fbc8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"2. Shall notify the ovs db with the vhostuser-socket-dir"},{"line_number":12,"context_line":"   ovs-vsctl set Open_vSwitch . other_config:vhost-sock-dir\u003d$vhostdir"},{"line_number":13,"context_line":"   ovs-vsctl set Open_vSwitch . other_config:vhost-sock-perms\u003d0775"},{"line_number":14,"context_line":"   ovs-vsctl set Open_vSwitch . other_config:vhost-sock-owner\u003dqemu"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"   The vhostuser-socket-dir referred here needs to be same value as"},{"line_number":17,"context_line":"   neutron::agents::ml2::ovs::vhostuser_socket_dir"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3ac371cc_9c9e32b7","line":14,"updated":"2016-08-18 02:41:00.000000000","message":"The commit message is admirably detailed, but probably unnecessarily so. It\u0027s probably sufficient to state that it creates and configures the vhost-socket-dir. Other useful details might be things that would be useful when searching git logs. Any other stuff that is basically documentation might belong better in the code or other docs using the appropriate mechanisms. People can read the code if they want this level of detail.\n\nAlso note that avoiding too much detail also prevents your commit message becoming invalid if what your patch does changes :)","commit_id":"0fc5c199100ba84b550be9f9ff183307ab84e430"}],"manifests/dpdk.pp":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"889758a547a826b10052bb595cdedd27d528a458","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    path    \u003d\u003e $vhostuser_socket_dir,"},{"line_number":53,"context_line":"    mode    \u003d\u003e \u00272775\u0027,"},{"line_number":54,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"},{"line_number":55,"context_line":"    group   \u003d\u003e \u0027qemu\u0027,"},{"line_number":56,"context_line":"    require \u003d\u003e Package[$::vswitch::params::ovs_dpdk_package_name],"},{"line_number":57,"context_line":"    before  \u003d\u003e Service[\u0027openvswitch\u0027]"},{"line_number":58,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9ad45d7e_b73866d4","line":55,"updated":"2016-08-11 14:44:32.000000000","message":"This looks like it creates an implicit dependency on qemu being installed and the qemu user created. vswitch with dpdk support doesn\u0027t really require this, so it seems like this should all be configurable.","commit_id":"0fc5c199100ba84b550be9f9ff183307ab84e430"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fe74daf720087ddf947a570b20f1665af2097491","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    }"},{"line_number":105,"context_line":"  }"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  Service[\u0027openvswitch\u0027] -\u003e Vs_config\u003c||\u003e"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bacf61ea_bc7ea0ac","line":107,"updated":"2016-08-05 13:07:12.000000000","message":"What? you want to run ovs before configuring it?","commit_id":"0fc5c199100ba84b550be9f9ff183307ab84e430"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"889758a547a826b10052bb595cdedd27d528a458","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    }"},{"line_number":105,"context_line":"  }"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  Service[\u0027openvswitch\u0027] -\u003e Vs_config\u003c||\u003e"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9ad45d7e_d42998e7","line":107,"in_reply_to":"bacf61ea_750a72d3","updated":"2016-08-11 14:44:32.000000000","message":"Yes. This is configuration via the OVSDB.","commit_id":"0fc5c199100ba84b550be9f9ff183307ab84e430"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"efefdaa47f9683ca9fd4ce8d51f1e185ad370da4","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    }"},{"line_number":105,"context_line":"  }"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"  Service[\u0027openvswitch\u0027] -\u003e Vs_config\u003c||\u003e"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bacf61ea_750a72d3","line":107,"in_reply_to":"bacf61ea_bc7ea0ac","updated":"2016-08-05 15:37:20.000000000","message":"I had to read up on this before commenting. vs_config\u0027s provider runs ovs-vsctl commands which operates on the openvswitch services, so I think Karthik\u0027s ordering is correct here. I *think* the \u0027before\u0027 bits in the file and file_line resources take care of getting those bits in before the service though.","commit_id":"0fc5c199100ba84b550be9f9ff183307ab84e430"}]}