)]}'
{"lib/facter/pci_address.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7eb6e6d40292f82f5d0739573420615f6985ef10","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027facter\u0027"},{"line_number":2,"context_line":"if File.file?(\"cat /proc/bus/pci/devices\")"},{"line_number":3,"context_line":"  drivers_details\u003dFacter::Util::Resolution.exec(\"cat /proc/bus/pci/devices\")"},{"line_number":4,"context_line":"  drivers_lines\u003ddrivers_details.split(\"\\n\")"},{"line_number":5,"context_line":"else"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"df140735_1d59ea33","line":2,"updated":"2017-06-02 20:53:21.000000000","message":"if File.file?(\u0027/etc/buse/pci/devices\u0027)","commit_id":"5acd790ab07e9a0923c52889a37692359b6e6a33"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"87cac1a83bd1388826cb6639f5ff3476dbc47413","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027facter\u0027"},{"line_number":2,"context_line":"if File.file?(\"cat /proc/bus/pci/devices\")"},{"line_number":3,"context_line":"  drivers_details\u003dFacter::Util::Resolution.exec(\"cat /proc/bus/pci/devices\")"},{"line_number":4,"context_line":"  drivers_lines\u003ddrivers_details.split(\"\\n\")"},{"line_number":5,"context_line":"else"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"df140735_e7157ce6","line":2,"in_reply_to":"df140735_1d59ea33","updated":"2017-06-03 06:11:38.000000000","message":"Done","commit_id":"5acd790ab07e9a0923c52889a37692359b6e6a33"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7eb6e6d40292f82f5d0739573420615f6985ef10","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027facter\u0027"},{"line_number":2,"context_line":"if File.file?(\"cat /proc/bus/pci/devices\")"},{"line_number":3,"context_line":"  drivers_details\u003dFacter::Util::Resolution.exec(\"cat /proc/bus/pci/devices\")"},{"line_number":4,"context_line":"  drivers_lines\u003ddrivers_details.split(\"\\n\")"},{"line_number":5,"context_line":"else"},{"line_number":6,"context_line":"  drivers_lines\u003dArray.new"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"df140735_fd41963a","line":3,"updated":"2017-06-02 20:53:21.000000000","message":"Then you can just do File.read(\u0027/etc/bus/pci/devices\u0027) rather than using exec","commit_id":"5acd790ab07e9a0923c52889a37692359b6e6a33"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"87cac1a83bd1388826cb6639f5ff3476dbc47413","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027facter\u0027"},{"line_number":2,"context_line":"if File.file?(\"cat /proc/bus/pci/devices\")"},{"line_number":3,"context_line":"  drivers_details\u003dFacter::Util::Resolution.exec(\"cat /proc/bus/pci/devices\")"},{"line_number":4,"context_line":"  drivers_lines\u003ddrivers_details.split(\"\\n\")"},{"line_number":5,"context_line":"else"},{"line_number":6,"context_line":"  drivers_lines\u003dArray.new"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"df140735_27e5b409","line":3,"in_reply_to":"df140735_fd41963a","updated":"2017-06-03 06:11:38.000000000","message":"I did just copy the existing line !\nI also think, youre solution is better, please someone check if it\u0027s working (I have no system who uses this fact).\nDone","commit_id":"5acd790ab07e9a0923c52889a37692359b6e6a33"},{"author":{"_account_id":22865,"name":"Jaganathan Palanisamy","email":"jpalanis@redhat.com","username":"jaganathancse"},"change_message_id":"d85309bb5a1399b2752cfb42ba5d6d18bc8909cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027facter\u0027"},{"line_number":2,"context_line":"if File.file?(\"/proc/bus/pci/devices\")"},{"line_number":3,"context_line":"  drivers_details\u003dFile.read(\"/proc/bus/pci/devices\")"},{"line_number":4,"context_line":"  drivers_lines\u003ddrivers_details.split(\"\\n\")"},{"line_number":5,"context_line":"else"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"df140735_b0d8c9ee","line":2,"updated":"2017-06-05 08:50:51.000000000","message":"nit: Can we use File.readlines instead of read?\ndrivers_lines \u003d Array.new\nfile_path \u003d \"/proc/bus/pci/devices\"\ndrivers_lines \u003d File.readlines(file_path) if File.file?(file_path)","commit_id":"8a3479db80ae1c4fc0c22c7ff733ad193e63a0fb"},{"author":{"_account_id":22865,"name":"Jaganathan Palanisamy","email":"jpalanis@redhat.com","username":"jaganathancse"},"change_message_id":"d85309bb5a1399b2752cfb42ba5d6d18bc8909cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027facter\u0027"},{"line_number":2,"context_line":"if File.file?(\"/proc/bus/pci/devices\")"},{"line_number":3,"context_line":"  drivers_details\u003dFile.read(\"/proc/bus/pci/devices\")"},{"line_number":4,"context_line":"  drivers_lines\u003ddrivers_details.split(\"\\n\")"},{"line_number":5,"context_line":"else"},{"line_number":6,"context_line":"  drivers_lines\u003dArray.new"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"df140735_30c4b9f4","line":3,"updated":"2017-06-05 08:50:51.000000000","message":"nit: space left and right is missing for \u0027\u003d\u0027\n\nInstead of hard coding file path in 2 places, can we have a variable and uses variable in 2 places?","commit_id":"8a3479db80ae1c4fc0c22c7ff733ad193e63a0fb"},{"author":{"_account_id":22865,"name":"Jaganathan Palanisamy","email":"jpalanis@redhat.com","username":"jaganathancse"},"change_message_id":"d85309bb5a1399b2752cfb42ba5d6d18bc8909cf","unresolved":false,"context_lines":[{"line_number":2,"context_line":"if File.file?(\"/proc/bus/pci/devices\")"},{"line_number":3,"context_line":"  drivers_details\u003dFile.read(\"/proc/bus/pci/devices\")"},{"line_number":4,"context_line":"  drivers_lines\u003ddrivers_details.split(\"\\n\")"},{"line_number":5,"context_line":"else"},{"line_number":6,"context_line":"  drivers_lines\u003dArray.new"},{"line_number":7,"context_line":"end"},{"line_number":8,"context_line":"drivers\u003dHash.new"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"df140735_d08b3dc0","line":5,"updated":"2017-06-05 08:50:51.000000000","message":"nit: else is not needed if we move drivers_lines\u003dArray.new above if statement?","commit_id":"8a3479db80ae1c4fc0c22c7ff733ad193e63a0fb"}]}