)]}'
{"manifests/hw_offload.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"037229f719c58b092b9505f2fc4e708b747c630b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  include ::vswitch::params"},{"line_number":7,"context_line":"  require ::vswitch::ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  if versioncmp($::ovs_version, \u00272.8.0\u0027) \u003c 0 {"},{"line_number":10,"context_line":"    fail(\u0027Hardware Offload is supported from 2.8.0\u0027)"},{"line_number":11,"context_line":"  }"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f2577a7_0b9a5513","line":9,"updated":"2017-09-11 16:28:05.000000000","message":"The problem with trying to do this is that if the package isn\u0027t installed, this will fail.  Let\u0027s skip this and document this requirement in the class rather than being so forceful","commit_id":"71dea7b2aa873872fdcaf3e810d58ad77af9f0dc"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"44376972c43c08c175ffc42d0c95473028de5534","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  include ::vswitch::params"},{"line_number":7,"context_line":"  require ::vswitch::ovs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  if versioncmp($::ovs_version, \u00272.8.0\u0027) \u003c 0 {"},{"line_number":10,"context_line":"    fail(\u0027Hardware Offload is supported from 2.8.0\u0027)"},{"line_number":11,"context_line":"  }"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f2577a7_341fa46d","line":9,"in_reply_to":"5f2577a7_0b9a5513","updated":"2017-09-12 06:40:41.000000000","message":"Done","commit_id":"71dea7b2aa873872fdcaf3e810d58ad77af9f0dc"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"e72195c48cf904b95400847404016ac61834700f","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  vs_config { \u0027other_config:hw-offload\u0027:"},{"line_number":12,"context_line":"    value   \u003d\u003e \u0027true\u0027,"},{"line_number":13,"context_line":"    require \u003d\u003e Service[\u0027openvswitch\u0027],"},{"line_number":14,"context_line":"    wait    \u003d\u003e true,"},{"line_number":15,"context_line":"  }"},{"line_number":16,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5f2577a7_ed34a64c","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":38},"updated":"2017-09-12 14:28:59.000000000","message":"Future note, we should probably add this as an autorequire to the type.","commit_id":"c4ec2ff0a93126f11c1bcdd01a5078ec4caac2c8"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"b8b6e8700e1b04c25b10788ee9a4b15eff52dd1d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    wait   \u003d\u003e true,"},{"line_number":22,"context_line":"  }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  service { \u0027openvswitch\u0027:"},{"line_number":25,"context_line":"    ensure    \u003d\u003e true,"},{"line_number":26,"context_line":"    enable    \u003d\u003e true,"},{"line_number":27,"context_line":"    name      \u003d\u003e $::vswitch::params::ovs_service_name,"},{"line_number":28,"context_line":"    status    \u003d\u003e $::vswitch::params::ovs_status,"},{"line_number":29,"context_line":"    hasstatus \u003d\u003e $::vswitch::params::ovs_service_hasstatus"},{"line_number":30,"context_line":"  }"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  package { $::vswitch::params::ovs_package_name:"},{"line_number":33,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":34,"context_line":"    before \u003d\u003e Vs_config[\u0027other_config:hw-offload\u0027],"},{"line_number":35,"context_line":"    tag    \u003d\u003e \u0027openvswitch\u0027,"},{"line_number":36,"context_line":"  }"},{"line_number":37,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5f2577a7_68376db2","line":36,"range":{"start_line":24,"start_character":0,"end_line":36,"end_character":3},"updated":"2017-09-13 00:39:20.000000000","message":"Is there a reason why you\u0027re not including vswitch::ovs which already has those?","commit_id":"21afa4ff3a72bf7977026f148855b5e22da45b1b"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"6ac2502fa8f0d5cfe8395728d2cff00c67bbba5c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    wait   \u003d\u003e true,"},{"line_number":22,"context_line":"  }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  service { \u0027openvswitch\u0027:"},{"line_number":25,"context_line":"    ensure    \u003d\u003e true,"},{"line_number":26,"context_line":"    enable    \u003d\u003e true,"},{"line_number":27,"context_line":"    name      \u003d\u003e $::vswitch::params::ovs_service_name,"},{"line_number":28,"context_line":"    status    \u003d\u003e $::vswitch::params::ovs_status,"},{"line_number":29,"context_line":"    hasstatus \u003d\u003e $::vswitch::params::ovs_service_hasstatus"},{"line_number":30,"context_line":"  }"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  package { $::vswitch::params::ovs_package_name:"},{"line_number":33,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":34,"context_line":"    before \u003d\u003e Vs_config[\u0027other_config:hw-offload\u0027],"},{"line_number":35,"context_line":"    tag    \u003d\u003e \u0027openvswitch\u0027,"},{"line_number":36,"context_line":"  }"},{"line_number":37,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5f2577a7_8b604ea7","line":36,"range":{"start_line":24,"start_character":0,"end_line":36,"end_character":3},"in_reply_to":"5f2577a7_68376db2","updated":"2017-09-13 07:47:48.000000000","message":"yes, the hw-offload config need openvswitch restart after applying. When I include the vswitch:ovs and add notify \u003d\u003e Service[\u0027openvswtich] to vs_config[\u0027other_config:hw-offload\u0027] I got Circular Dependency Error.\n\nbasicly in hw-offload we need to install package, do the vs_config and then openvswitch restart.","commit_id":"21afa4ff3a72bf7977026f148855b5e22da45b1b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c4e08d70e0a1543f9fd0669c0e60c4b3a35a64af","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    value  \u003d\u003e \u0027true\u0027,"},{"line_number":20,"context_line":"    notify \u003d\u003e Service[\u0027openvswitch\u0027],"},{"line_number":21,"context_line":"    wait   \u003d\u003e true,"},{"line_number":22,"context_line":"  }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  service { \u0027openvswitch\u0027:"},{"line_number":25,"context_line":"    ensure    \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bf57530f_79e3ef06","line":22,"updated":"2017-09-20 20:53:01.000000000","message":"Rather than duplicating the service/package install. It seems like this really should be a param in vswitch::ovs","commit_id":"c298cf0101cb90e298fcda0fceba2d6aeddd5c3f"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"c0944ac4eea3bd17642215484794ca7a593ceb92","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    value  \u003d\u003e \u0027true\u0027,"},{"line_number":20,"context_line":"    notify \u003d\u003e Service[\u0027openvswitch\u0027],"},{"line_number":21,"context_line":"    wait   \u003d\u003e true,"},{"line_number":22,"context_line":"  }"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  service { \u0027openvswitch\u0027:"},{"line_number":25,"context_line":"    ensure    \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7f515b1d_f340050a","line":22,"in_reply_to":"bf57530f_79e3ef06","updated":"2017-09-25 09:38:52.000000000","message":"Done","commit_id":"c298cf0101cb90e298fcda0fceba2d6aeddd5c3f"}],"manifests/ovs.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e1ba7140c3ffdbfca0f0a4e05dcbe83394c113ff","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#   is not available anymore for openvswitch."},{"line_number":18,"context_line":"#   For RedHat this parameter is ignored."},{"line_number":19,"context_line":"#   If you like turn off dkms on Debian/Ubuntu set to"},{"line_number":20,"context_line":"#   false. defaults to false."},{"line_number":21,"context_line":"# [*enable_hw_offload*]"},{"line_number":22,"context_line":"#   (optional) Configure OVS to use"},{"line_number":23,"context_line":"#   Hardware Offload. This feature is"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7f515b1d_dfa48ea8","line":20,"updated":"2017-09-27 18:38:39.000000000","message":"please live a # here for readability","commit_id":"18ecd5e78debc927df2e43459d889253cd2f247d"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"e31dfdbbec37796f9eb34730a77c171f53f8aa97","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#   is not available anymore for openvswitch."},{"line_number":18,"context_line":"#   For RedHat this parameter is ignored."},{"line_number":19,"context_line":"#   If you like turn off dkms on Debian/Ubuntu set to"},{"line_number":20,"context_line":"#   false. defaults to false."},{"line_number":21,"context_line":"# [*enable_hw_offload*]"},{"line_number":22,"context_line":"#   (optional) Configure OVS to use"},{"line_number":23,"context_line":"#   Hardware Offload. This feature is"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7f515b1d_baad60ea","line":20,"in_reply_to":"7f515b1d_dfa48ea8","updated":"2017-09-27 19:19:01.000000000","message":"Done","commit_id":"18ecd5e78debc927df2e43459d889253cd2f247d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e1ba7140c3ffdbfca0f0a4e05dcbe83394c113ff","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# [*enable_hw_offload*]"},{"line_number":22,"context_line":"#   (optional) Configure OVS to use"},{"line_number":23,"context_line":"#   Hardware Offload. This feature is"},{"line_number":24,"context_line":"#   supported from ovs 2.8.0."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class vswitch::ovs("},{"line_number":27,"context_line":"  $package_ensure \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7f515b1d_bfa1d296","line":24,"updated":"2017-09-27 18:38:39.000000000","message":"Defaults to False.","commit_id":"18ecd5e78debc927df2e43459d889253cd2f247d"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"e31dfdbbec37796f9eb34730a77c171f53f8aa97","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# [*enable_hw_offload*]"},{"line_number":22,"context_line":"#   (optional) Configure OVS to use"},{"line_number":23,"context_line":"#   Hardware Offload. This feature is"},{"line_number":24,"context_line":"#   supported from ovs 2.8.0."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class vswitch::ovs("},{"line_number":27,"context_line":"  $package_ensure \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7f515b1d_dafb7c76","line":24,"in_reply_to":"7f515b1d_bfa1d296","updated":"2017-09-27 19:19:01.000000000","message":"Done","commit_id":"18ecd5e78debc927df2e43459d889253cd2f247d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e1ba7140c3ffdbfca0f0a4e05dcbe83394c113ff","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class vswitch::ovs("},{"line_number":27,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":28,"context_line":"  $dkms_ensure    \u003d false,"},{"line_number":29,"context_line":"  $enable_hw_offload \u003d false,"},{"line_number":30,"context_line":") {"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  include ::vswitch::params"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7f515b1d_9faa966e","line":29,"updated":"2017-09-27 18:38:39.000000000","message":"please align the \u003d","commit_id":"18ecd5e78debc927df2e43459d889253cd2f247d"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"e31dfdbbec37796f9eb34730a77c171f53f8aa97","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class vswitch::ovs("},{"line_number":27,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":28,"context_line":"  $dkms_ensure    \u003d false,"},{"line_number":29,"context_line":"  $enable_hw_offload \u003d false,"},{"line_number":30,"context_line":") {"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  include ::vswitch::params"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7f515b1d_7a8c887e","line":29,"in_reply_to":"7f515b1d_9faa966e","updated":"2017-09-27 19:19:01.000000000","message":"Done","commit_id":"18ecd5e78debc927df2e43459d889253cd2f247d"}]}