)]}'
{"manifests/dpdk.pp":[{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"52f33f870bb2183df8d79356beadf4048d57d9e7","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    notify  \u003d\u003e Vs_config[\u0027other_config:dpdk-init\u0027],"},{"line_number":83,"context_line":"  }"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  vs_config { \u0027other_config:dpdk-init\u0027:"},{"line_number":86,"context_line":"    value   \u003d\u003e \u0027true\u0027,"},{"line_number":87,"context_line":"    require \u003d\u003e Service[\u0027openvswitch\u0027],"},{"line_number":88,"context_line":"    wait    \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3fa0c359_1934b1fa","line":85,"updated":"2018-02-20 09:32:55.000000000","message":"I think even the skip_if_version field in provider also shall be removed.","commit_id":"3d91514806a1bb32aa2ac0fed90ced23162ccc32"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"aea4b4df443310fe607e18cf663f678767d13afa","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    notify  \u003d\u003e Vs_config[\u0027other_config:dpdk-init\u0027],"},{"line_number":83,"context_line":"  }"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  vs_config { \u0027other_config:dpdk-init\u0027:"},{"line_number":86,"context_line":"    value   \u003d\u003e \u0027true\u0027,"},{"line_number":87,"context_line":"    require \u003d\u003e Service[\u0027openvswitch\u0027],"},{"line_number":88,"context_line":"    wait    \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3fa0c359_31ac218b","line":85,"in_reply_to":"3fa0c359_1934b1fa","updated":"2018-02-20 11:17:47.000000000","message":"Yes, I thought we could keep it as it is generic option and not specific to ovs2.5, may be if required in future with anyother version specific requirement, then it would be useful.","commit_id":"3d91514806a1bb32aa2ac0fed90ced23162ccc32"}],"spec/classes/vswitch_dpdk_spec.rb":[{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"52f33f870bb2183df8d79356beadf4048d57d9e7","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    let(:params) { default_params }"},{"line_number":23,"context_line":"    context \u0027shall  write DPDK_OPTIONS as well as ovsdb params\u0027 do"},{"line_number":24,"context_line":"      it \u0027include the class\u0027 do"},{"line_number":25,"context_line":"        is_expected.to contain_class(\u0027vswitch::dpdk\u0027)"},{"line_number":26,"context_line":"      end"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"      it \u0027contains params\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3fa0c359_59f8f947","side":"PARENT","line":25,"updated":"2018-02-20 09:32:55.000000000","message":"Some of these test cases are still valid in general","commit_id":"146cdb1e8e7d6d455c23e8b9b0e0f603cd7c5a6f"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"aea4b4df443310fe607e18cf663f678767d13afa","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    let(:params) { default_params }"},{"line_number":23,"context_line":"    context \u0027shall  write DPDK_OPTIONS as well as ovsdb params\u0027 do"},{"line_number":24,"context_line":"      it \u0027include the class\u0027 do"},{"line_number":25,"context_line":"        is_expected.to contain_class(\u0027vswitch::dpdk\u0027)"},{"line_number":26,"context_line":"      end"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"      it \u0027contains params\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3fa0c359_51720d4b","side":"PARENT","line":25,"in_reply_to":"3fa0c359_59f8f947","updated":"2018-02-20 11:17:47.000000000","message":"These are under the DPDK_OPTIONS context, so it is not required.","commit_id":"146cdb1e8e7d6d455c23e8b9b0e0f603cd7c5a6f"}]}