)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"1c59956dc25ea40a136fecc7f7ea04af1bf28a08","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OVS Revalidator and handler threads config via TripleO"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OVS revalidot and hanlder threads are not coherent with lcore list."},{"line_number":10,"context_line":"They can be passed using THT and configed accordingly on compute nodes."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I576b00bb28d0d531eb91a856632a7b5afe552f43"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_b7979545","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":13},"updated":"2019-04-08 08:30:04.000000000","message":"spelling","commit_id":"722c7d1b2db28c6c681473b39c1f982509668b24"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"1c59956dc25ea40a136fecc7f7ea04af1bf28a08","unresolved":false,"context_lines":[{"line_number":7,"context_line":"OVS Revalidator and handler threads config via TripleO"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OVS revalidot and hanlder threads are not coherent with lcore list."},{"line_number":10,"context_line":"They can be passed using THT and configed accordingly on compute nodes."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I576b00bb28d0d531eb91a856632a7b5afe552f43"},{"line_number":13,"context_line":"Closes-Bug: #1822571"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_f77afd21","line":10,"range":{"start_line":10,"start_character":25,"end_line":10,"end_character":28},"updated":"2019-04-08 08:30:04.000000000","message":"puppet code is general, not specific to TripleO, it can be used puppet-openstack projects too. So its better to avoid specifics about the user (unless it is important).","commit_id":"722c7d1b2db28c6c681473b39c1f982509668b24"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7ed675e86cc89534dbdabeffeef51e7324461d76","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     hakhande \u003chakhande@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-04-12 15:49:45 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OVS Revalidator and handler threads config via TripleO"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OVS revalidator and hanlder threads are not coherent with lcore list."},{"line_number":10,"context_line":"This patch will enable them to be configured in puppet vswitch module"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3fce034c_9f3b0337","line":7,"range":{"start_line":7,"start_character":43,"end_line":7,"end_character":54},"updated":"2019-04-12 13:46:26.000000000","message":"no need to mention tripleo here, this is puppet-vswitch","commit_id":"652d1a2e09ffbb1923cf1a22ac15678901ff4e11"}],"lib/puppet/functions/range_to_number.rb":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"4901b5682a80965e3b60785c30dfd3ed1539d7ff","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  end"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  def range_param(range)"},{"line_number":25,"context_line":"    range.to_s.split(\",\").map{|c| c.include?(\"-\")?(c.split(\"-\").map(\u0026:to_i)[0]..c.split(\"-\").map(\u0026:to_i)[1]).to_a.join(\",\"):c}.to_s.gsub(\u0027\"\u0027, \u0027\u0027).to_s.gsub(\u0027 \u0027, \u0027\u0027).split(\",\").map{|c| c.include?(\"-\")?(c.split(\"-\")) :c}.length.to_s"},{"line_number":26,"context_line":"   end"},{"line_number":27,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"5fc1f717_3ebe1a65","line":25,"updated":"2019-04-08 11:49:30.000000000","message":"This one liner could probably be made much easier to read but I guess it does it\u0027s work","commit_id":"56f8c46369d4509c1bb82f7c5aa00d1c75694caf"}],"manifests/dpdk.pp":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"1c59956dc25ea40a136fecc7f7ea04af1bf28a08","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# [*memory_channels*]"},{"line_number":7,"context_line":"#   (optional) The number of memory channels to use as an integer."},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"# [*driver_type*]"},{"line_number":10,"context_line":"#   (Optional) The DPDK Driver type"},{"line_number":11,"context_line":"#   Defaults to \u0027vfio-pci\u0027"},{"line_number":12,"context_line":"#   This parameter is required only for OVS versions \u003c\u003d 2.5."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5fc1f717_379ac561","line":9,"updated":"2019-04-08 08:30:04.000000000","message":"Dont change the locaiton of this parameter, this has been deprecated and it is added under the \"DEPRECATED\" comment","commit_id":"722c7d1b2db28c6c681473b39c1f982509668b24"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"1c59956dc25ea40a136fecc7f7ea04af1bf28a08","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  $package_ensure     \u003d \u0027present\u0027,"},{"line_number":45,"context_line":"  $pmd_core_list      \u003d undef,"},{"line_number":46,"context_line":"  $socket_mem         \u003d undef,"},{"line_number":47,"context_line":"  $revalidator_core_list \u003d undef,"},{"line_number":48,"context_line":"  $handler_core_list \u003d undef,"},{"line_number":49,"context_line":") {"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5fc1f717_97a85978","line":47,"updated":"2019-04-08 08:30:04.000000000","message":"keep the alignment of all parameter to the \u003d sign on this, general puppet coding style.","commit_id":"722c7d1b2db28c6c681473b39c1f982509668b24"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"1c59956dc25ea40a136fecc7f7ea04af1bf28a08","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    tag    \u003d\u003e \u0027openvswitch\u0027,"},{"line_number":62,"context_line":"  }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  # DEPRECATED support for OVS 2.5"},{"line_number":65,"context_line":"  # DPDK_OPTIONS is no longer used in ovs 2.6, since it was a distribution"},{"line_number":66,"context_line":"  # specific hack to the ovs-ctl scripts. Instead dpdk information is"},{"line_number":67,"context_line":"  # pulled from the ovsdb."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5fc1f717_77bdadb5","line":64,"updated":"2019-04-08 08:30:04.000000000","message":"These changes have been removed, look like you are on a old code. Just merge your changes if you are working on a different version of the repo.","commit_id":"722c7d1b2db28c6c681473b39c1f982509668b24"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"4901b5682a80965e3b60785c30dfd3ed1539d7ff","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# [*revalidator_core_list*]"},{"line_number":36,"context_line":"#   (Optional) cores to be used for OVS Revalidator threads."},{"line_number":37,"context_line":"# [*handler_core_list*]"},{"line_number":38,"context_line":"#   (Optional) cores to be used for OVS handler threads."},{"line_number":39,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*driver_type*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5fc1f717_3e95bae4","line":38,"updated":"2019-04-08 11:49:30.000000000","message":"missing a empty \"#\" line after here","commit_id":"56f8c46369d4509c1bb82f7c5aa00d1c75694caf"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"2055a802af5feceec725edb0c1ed33ad898d8996","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  $dpdk_lcore_mask \u003d range_to_mask($host_core_list)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  if \u0027,\u0027 in $revalidator_cores {"},{"line_number":78,"context_line":"    $ovsrevalidator_threads \u003d range_to_number($revalidator_cores)"},{"line_number":79,"context_line":"  }"},{"line_number":80,"context_line":"  else {"},{"line_number":81,"context_line":"    $ovsrevalidator_threads \u003d \"${revalidator_cores}\""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3fce034c_0c214cb5","line":78,"updated":"2019-04-11 10:20:53.000000000","message":"Let us not handle both count and list. As OvS is expecting as count, passing only the count should be enough.","commit_id":"3f8eb6077ad8ea0bf532e3cdf3e2de76f67531f7"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7ed675e86cc89534dbdabeffeef51e7324461d76","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  $pmd_core_mask \u003d range_to_mask($pmd_core_list)"},{"line_number":75,"context_line":"  $dpdk_lcore_mask \u003d range_to_mask($host_core_list)"},{"line_number":76,"context_line":"  $ovsrevalidator_threads \u003d \"${revalidator_cores}\""},{"line_number":77,"context_line":"  $ovshandler_threads \u003d \"${handler_cores}\""},{"line_number":78,"context_line":"  if $memory_channels and !empty($memory_channels) {"},{"line_number":79,"context_line":"    $memory_channels_conf \u003d \"-n ${memory_channels}\""},{"line_number":80,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3fce034c_5ff03b91","line":77,"range":{"start_line":76,"start_character":0,"end_line":77,"end_character":42},"updated":"2019-04-12 13:46:26.000000000","message":"I have no idea how this passed lint because this should hav errored. You\u0027re not supposed to just quote a var.  Anyway are you doing this for a reason? You should be able to just use the params in L90-91.","commit_id":"652d1a2e09ffbb1923cf1a22ac15678901ff4e11"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7536f5fbcbe4659aebe316db9f70e66da8517d52","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  $pmd_core_mask \u003d range_to_mask($pmd_core_list)"},{"line_number":75,"context_line":"  $dpdk_lcore_mask \u003d range_to_mask($host_core_list)"},{"line_number":76,"context_line":"  $ovsrevalidator_threads \u003d \"${revalidator_cores}\""},{"line_number":77,"context_line":"  $ovshandler_threads \u003d \"${handler_cores}\""},{"line_number":78,"context_line":"  if $memory_channels and !empty($memory_channels) {"},{"line_number":79,"context_line":"    $memory_channels_conf \u003d \"-n ${memory_channels}\""},{"line_number":80,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ffb9cba7_203837ec","line":77,"range":{"start_line":76,"start_character":0,"end_line":77,"end_character":42},"updated":"2019-04-30 14:17:09.000000000","message":"We don\u0027t need this. We should just use these param values on L90-91 rather than doing this.","commit_id":"0838cf92e293fedb382e0a47ecd99621306c7f04"}],"releasenotes/notes/ovs-revalidator-handler-threads.yaml-12907a70b68e178c.yaml":[{"author":{"_account_id":22865,"name":"Jaganathan Palanisamy","email":"jpalanis@redhat.com","username":"jaganathancse"},"change_message_id":"428cd0e2d51e8c39b87e83bb35ab28e6a0ddb8a3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Introduced 2 new paramters. OvsRevalidatorCores and OvsHandlerCores. Value passed to these parameters will be set against ovs revalidator and handler threads respectively."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fce034c_0a191a78","line":3,"updated":"2019-04-12 07:58:39.000000000","message":"nit: can we update note like \u0027Introduced two new parameters revalidator cores and handler cores for DPDK configuration to set values for n-revalidator-threads and n-handler-threads.","commit_id":"639fd75d51dfed989772f32df40ad99a59cc9106"},{"author":{"_account_id":22865,"name":"Jaganathan Palanisamy","email":"jpalanis@redhat.com","username":"jaganathancse"},"change_message_id":"f11ca9102176c4d38ad3167db93d9cfa84c2f6e2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Introduced two new paramters OvsRevalidatorCores and OvsHandlerCores to set values of n-revalidator-threads and n-handler-threads on openvswitch."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fce034c_d60df837","line":3,"updated":"2019-04-12 10:17:51.000000000","message":"typo: new parameters","commit_id":"25c99ef20e0e899e3b3d06b08df5e3088bf7ad06"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"83bd5b2f0082d049fced0415bb94d633530cd916","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Introduced two new parameters OvsRevalidatorCores and OvsHandlerCores to set values of n-revalidator-threads and n-handler-threads on openvswitch."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"dfbec78f_23e11c2b","line":3,"range":{"start_line":3,"start_character":34,"end_line":3,"end_character":73},"updated":"2019-05-14 09:55:20.000000000","message":"nit: the release notes specifices the heat parameters, rather it should be puppet parameters.","commit_id":"8b3e1cdb32ffdc769e76ba68be010ff38a1dbe6b"}]}