)]}'
{"id":"openstack%2Fpuppet-vswitch~792321","triplet_id":"openstack%2Fpuppet-vswitch~master~I8594e7faf8213734ac2121836ed39e96037a5456","project":"openstack/puppet-vswitch","branch":"master","topic":"debian-support","hashtags":[],"change_id":"I8594e7faf8213734ac2121836ed39e96037a5456","subject":"Avoid validate_legacy in Debian","status":"ABANDONED","created":"2021-05-20 06:46:04.000000000","updated":"2022-05-22 14:40:44.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6787768ea42e54f9df49fd403eeffcd227bd2498","_number":792321,"virtual_id_number":792321,"owner":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-05-31 13:07:00.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-20 07:04:59.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"},{"updated":"2021-05-20 08:08:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"752dea0b2eadbce322bdc51d59aad38e5200c038","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"date":"2021-05-20 06:46:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b108df00771a87c034e968b083df371be4337e84","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2021-05-20 07:04:59.000000000","message":"Patch Set 1: Code-Review-1\n\nyou should run a stdlib version that includes that function, you can\u0027t patch that away it\u0027s in every single module as of now since parameters is not converted to proper types yet","accounts_in_message":[],"_revision_number":1},{"id":"add86ac083c049c51bdc08bfdf548fbbccbe715c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-20 08:08:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/c4f7c44577184bda881391b64a72522a : SUCCESS in 4m 30s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/7fc4751572c349ceb7dfc10447dd46cd : SUCCESS in 3m 58s\n- puppet-openstack-syntax-7-ubuntu-focal https://zuul.opendev.org/t/openstack/build/77a2afde1a244952840c4d07aa62f649 : SUCCESS in 4m 15s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/988dbe88ae2e4a789f2faf75dbcbeba1 : SUCCESS in 9m 19s\n- puppet-openstack-unit-7.5-centos-8-stream https://zuul.opendev.org/t/openstack/build/216a784b9be64b7b9ac42f065e2639fc : SUCCESS in 12m 45s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/304dc94db0fb4bd194c901a1f87e7409 : SUCCESS in 6m 48s\n- puppet-openstack-unit-7.5-ubuntu-focal https://zuul.opendev.org/t/openstack/build/d4fa8c27e6494b0bbf1881b31dd4b464 : SUCCESS in 10m 35s\n- puppet-openstack-unit-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/84d32174c4fb48e892279c2dc6e9e24f : SUCCESS in 7m 15s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/f0a41c36b57d46e9836f7b244b12c1ba : FAILURE in 41m 06s (non-voting)\n- puppet-openstack-integration-6-scenario002-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/a0de930ddb654949a9ddb9068daa1de4 : FAILURE in 43m 13s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/641c0893d57b4bfa8d5c8d7dcf15b9a3 : FAILURE in 29m 34s (non-voting)\n- puppet-openstack-integration-6-scenario004-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ebcd553b871f4557b3521c489c163516 : FAILURE in 27m 54s (non-voting)\n- puppet-openstack-integration-6-scenario000-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/64cf1e166d614e52b150a003d29bb6a6 : SUCCESS in 19m 47s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/8696ef67e0ac4fa2b6201fb9861d2fcd : SUCCESS in 57m 46s\n- puppet-openstack-integration-6-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/bcf3b48018cc472991af69ad2f0769d7 : SUCCESS in 1h 20m 09s\n- puppet-openstack-integration-6-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/ef65dd3efd87407faf47c33650d0b513 : SUCCESS in 1h 20m 03s\n- puppet-openstack-integration-6-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/1bf611b90d1144c78883b2887f7f2fe8 : SUCCESS in 1h 00m 16s\n- puppet-openstack-integration-7-scenario000-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/cb868ec2af20494fae617ddc89437554 : SUCCESS in 23m 09s (non-voting)\n- puppet-openstack-integration-7-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/94d5e539c1e24ec09675f49ab73c4609 : SUCCESS in 1h 09m 07s\n- puppet-openstack-integration-7-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/a336cd84ca004d6882649b8a96f6dd6d : SUCCESS in 1h 20m 15s\n- puppet-openstack-integration-7-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/ea84befdc09744028bb9ca52bd5d21b3 : SUCCESS in 1h 16m 52s\n- puppet-openstack-integration-7-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/b6334acbf1564149beb1133725427f33 : SUCCESS in 1h 03m 23s\n- puppet-openstack-litmus-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/513a0079c658474080429e8363627865 : SUCCESS in 17m 17s\n- puppet-openstack-litmus-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/640f7bbdb1a54a7cab879fb5d3be4737 : SUCCESS in 10m 40s (non-voting)\n- puppet-openstack-litmus-7.5-centos-8-stream https://zuul.opendev.org/t/openstack/build/dd546c25b7394c5eb4ba62031438e9eb : SUCCESS in 15m 23s\n- puppet-openstack-litmus-7.5-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ab09aeab37ee42ccb18e7af3cc4b8feb : SUCCESS in 10m 17s (non-voting)\n- puppet-openstack-litmus-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/d0caeb4c430246808ae96730a5d3ff0e : SUCCESS in 11m 07s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7cd7702b7a22ec435d475ccbdf341554859b6f47","author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"date":"2021-05-20 14:27:40.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e you should run a stdlib version that includes that function, you can\u0027t patch that away it\u0027s in every single module as of now since parameters is not converted to proper types yet\n\nTobias, I should have marked this patch as WIP, sorry. This was to know what was going on if this was removed, and it\u0027s kind of nice: I\u0027m getting puppet-openstack-integration to actually start installing. Now, I\u0027m still confused and don\u0027t understand what\u0027s going on and why I\u0027m getting such a failure. Hints to fix it would be welcome. As much as I understand validate_legacy *IS* present in my Debian env, so I don\u0027t know what\u0027s going on...","accounts_in_message":[],"_revision_number":1},{"id":"146b3945d6e3ea15c44595354f1a66e846c989eb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"date":"2021-05-31 11:26:12.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f13c6030fa46a2933e092b3e3ac9ef05bf974d8b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-31 13:07:00.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/5ed69046d91b4e6483df37f9ebb477d6 : SUCCESS in 4m 32s\n- puppet-openstack-syntax-6-ubuntu-focal https://zuul.opendev.org/t/openstack/build/02964c5d468b4104b9338db74ee8fb9e : SUCCESS in 4m 13s\n- puppet-openstack-syntax-7-ubuntu-focal https://zuul.opendev.org/t/openstack/build/50338c6c8838485686467620ef053a2a : SUCCESS in 4m 46s\n- puppet-openstack-unit-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/4a1d5d2b2407477ca3b09de727febc4d : FAILURE in 8m 42s\n- puppet-openstack-unit-7.5-centos-8-stream https://zuul.opendev.org/t/openstack/build/cf8cc3c227114ec2b1b1c1ffb225032e : FAILURE in 12m 09s\n- puppet-openstack-unit-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/e6bad4df7f8044cbbc21aba1d4533342 : SUCCESS in 7m 15s\n- puppet-openstack-unit-7.5-ubuntu-focal https://zuul.opendev.org/t/openstack/build/56738f7e12e54843a9f2d5f7c5010c0e : SUCCESS in 8m 59s\n- puppet-openstack-unit-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/c3ec582dbd6b421d81171cced44a90fd : SUCCESS in 6m 54s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/a36889eb887a44928331755b0b4cfe5d : FAILURE in 41m 24s (non-voting)\n- puppet-openstack-integration-6-scenario002-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/f27f2a1ba3134d51aa75395841f0cc71 : FAILURE in 43m 52s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/b9b2459f62cb44958c78759683647fb8 : FAILURE in 31m 06s (non-voting)\n- puppet-openstack-integration-6-scenario004-tempest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/817a924cd4ea4ff8939aa06f85d2a04d : FAILURE in 28m 16s (non-voting)\n- puppet-openstack-integration-6-scenario000-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/9c3f16db313543bdb748864f5c3588a0 : SUCCESS in 23m 31s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/772c630f01034a7a8e762ec4b3730aa1 : SUCCESS in 1h 22m 46s\n- puppet-openstack-integration-6-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/64759ea34b6d40509d7dbc398ee7e9b3 : SUCCESS in 1h 29m 34s\n- puppet-openstack-integration-6-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/0c9ca2913a7141d4af84ed812cff8b8d : SUCCESS in 1h 08m 18s\n- puppet-openstack-integration-6-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/5426bc6ac5604769ba5b36c128c61cf5 : FAILURE in 34m 50s\n- puppet-openstack-integration-7-scenario000-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/c636437d910b4b049c5aac697740a095 : SUCCESS in 23m 22s (non-voting)\n- puppet-openstack-integration-7-scenario001-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/c0c3b524dda54472b300d799b68f5c72 : SUCCESS in 59m 04s\n- puppet-openstack-integration-7-scenario002-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/74122eb78dab439f901bb320138ca29a : SUCCESS in 1h 36m 28s\n- puppet-openstack-integration-7-scenario003-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/8d7c2c7e7035423082d63ab103871fac : FAILURE in 57m 02s\n- puppet-openstack-integration-7-scenario004-tempest-centos-8-stream https://zuul.opendev.org/t/openstack/build/19d8661f16d84d65b5770ae59d9c149c : SUCCESS in 1h 06m 58s\n- puppet-openstack-litmus-6.21-centos-8-stream https://zuul.opendev.org/t/openstack/build/57dcaa857ac94e91ad981a25650f1596 : SUCCESS in 12m 39s\n- puppet-openstack-litmus-6.21-ubuntu-focal https://zuul.opendev.org/t/openstack/build/80e4842b5a74497584748a0dc60ff2fe : SUCCESS in 7m 34s (non-voting)\n- puppet-openstack-litmus-7.5-centos-8-stream https://zuul.opendev.org/t/openstack/build/486793b5915f4a6db56abe4866c292c8 : FAILURE in 16m 37s\n- puppet-openstack-litmus-7.5-ubuntu-focal https://zuul.opendev.org/t/openstack/build/694f6e58f4b64bb49375556cc3fb9187 : SUCCESS in 7m 23s (non-voting)\n- puppet-openstack-litmus-latest-ubuntu-focal https://zuul.opendev.org/t/openstack/build/807e0f143dfe478fbed2f3a65a05077a : SUCCESS in 7m 12s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"416d3cced87bbda6f6e17a600bb620e9e19e65aa","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2021-05-31 13:56:04.000000000","message":"Patch Set 2:\n\nTry this one Thomas https://review.opendev.org/c/openstack/puppet-vswitch/+/793798","accounts_in_message":[],"_revision_number":2},{"id":"6787768ea42e54f9df49fd403eeffcd227bd2498","tag":"autogenerated:gerrit:abandon","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2022-05-22 14:40:44.000000000","message":"Abandoned\n\nThis was fixed by https://review.opendev.org/c/openstack/puppet-vswitch/+/793798 .","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"9e82d2dbdd84a880c82eabb7bf7bf9a0daf53808","revisions":{"8979cb581fefb5bb25dbd66d6db4a70e8197d06c":{"kind":"REWORK","_number":1,"created":"2021-05-20 06:46:04.000000000","uploader":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"ref":"refs/changes/21/792321/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-vswitch","ref":"refs/changes/21/792321/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-vswitch refs/changes/21/792321/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-vswitch refs/changes/21/792321/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-vswitch refs/changes/21/792321/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-vswitch refs/changes/21/792321/1"}}},"commit":{"parents":[{"commit":"e4fc423170f189670f1c5ee025d79d9bfba97875","subject":"setup.cfg: Replace dashes with underscores","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-vswitch/commit/e4fc423170f189670f1c5ee025d79d9bfba97875"}]}],"author":{"name":"Thomas Goirand","email":"zigo@debian.org","date":"2021-05-20 06:45:32.000000000","tz":120},"committer":{"name":"Thomas Goirand","email":"zigo@debian.org","date":"2021-05-20 06:45:32.000000000","tz":120},"subject":"Avoid validate_legacy in Debian","message":"Avoid validate_legacy in Debian\n\nLooks like calling this function fails in Debian, maybe because of\nthe older Puppet version?\n\nChange-Id: I8594e7faf8213734ac2121836ed39e96037a5456\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-vswitch/commit/8979cb581fefb5bb25dbd66d6db4a70e8197d06c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-vswitch/commit/8979cb581fefb5bb25dbd66d6db4a70e8197d06c"}]},"branch":"refs/heads/master"},"9e82d2dbdd84a880c82eabb7bf7bf9a0daf53808":{"kind":"REWORK","_number":2,"created":"2021-05-31 11:26:12.000000000","uploader":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"ref":"refs/changes/21/792321/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-vswitch","ref":"refs/changes/21/792321/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-vswitch refs/changes/21/792321/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-vswitch refs/changes/21/792321/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-vswitch refs/changes/21/792321/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-vswitch refs/changes/21/792321/2"}}},"commit":{"parents":[{"commit":"e4fc423170f189670f1c5ee025d79d9bfba97875","subject":"setup.cfg: Replace dashes with underscores","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-vswitch/commit/e4fc423170f189670f1c5ee025d79d9bfba97875"}]}],"author":{"name":"Thomas Goirand","email":"zigo@debian.org","date":"2021-05-20 06:45:32.000000000","tz":120},"committer":{"name":"Thomas Goirand","email":"zigo@debian.org","date":"2021-05-31 11:25:47.000000000","tz":120},"subject":"Avoid validate_legacy in Debian","message":"Avoid validate_legacy in Debian\n\nLooks like calling this function fails in Debian. Using the older\nvalidate_hash works.\n\nChange-Id: I8594e7faf8213734ac2121836ed39e96037a5456\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-vswitch/commit/9e82d2dbdd84a880c82eabb7bf7bf9a0daf53808"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-vswitch/commit/9e82d2dbdd84a880c82eabb7bf7bf9a0daf53808"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}