)]}'
{"id":"openstack%2Fpuppet-vswitch~793798","triplet_id":"openstack%2Fpuppet-vswitch~master~Ib7591e46058db67869d2b075ad069f1e98bc875d","project":"openstack/puppet-vswitch","branch":"master","hashtags":[],"change_id":"Ib7591e46058db67869d2b075ad069f1e98bc875d","subject":"Add puppetlabs-stdlib to dependencies","status":"MERGED","created":"2021-05-31 13:50:44.000000000","updated":"2021-06-02 16:24:00.000000000","submitted":"2021-06-02 16:24:00.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"793798","meta_rev_id":"125277c4149e7166be06187ef8c4af5293bf19ad","_number":793798,"virtual_id_number":793798,"owner":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-06-02 16:23:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-06-01 07:45:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":2,"date":"2021-06-02 15:53:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":1,"date":"2021-06-02 15:53:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"}],"reviewers":{"REVIEWER":[{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-31 13:53:11.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"state":"REVIEWER"},{"updated":"2021-05-31 13:58:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-05-31 14:34:21.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"REVIEWER"},{"updated":"2021-06-02 15:53:59.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"}],"messages":[{"id":"a953359767ea8dabf9cce3f5bbe0fe1acb31b3ef","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2021-05-31 13:50:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"aebcb903cb5b9cea94d153383e59a7bd7c0bca47","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2021-05-31 13:51:59.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"1379f37efdcb32f5ce6b703083ab20dccc14a22f","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2021-05-31 13:53:11.000000000","message":"Patch Set 2:\n\n@Thomas try this one.","accounts_in_message":[],"_revision_number":2},{"id":"48105c3faca0daf282a724167cbda2b2ebad5ad7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-31 13:58:17.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-puppet-tarball https://zuul.opendev.org/t/openstack/build/619f2bd633234dcca4d09dbdea24dcbb : SUCCESS in 3m 20s\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/0fd7545c02434d02b031807a8090f0d8 : SUCCESS in 5m 01s","accounts_in_message":[],"_revision_number":2},{"id":"eb0170a69e28d2492c85f1463ff6c0e2b37b803a","author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"date":"2021-05-31 14:16:47.000000000","message":"Patch Set 2:\n\nHi. The issue is *not* a missing stdlib module. It\u0027s there in my setup. It feels like the underlying ruby function isn\u0027t there or something...\n\nFYI, Debian has stdlib 5.0.0.","accounts_in_message":[],"_revision_number":2},{"id":"3fb3e2c298bde809cdd979a1776ddbccff3b677f","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2021-05-31 14:27:34.000000000","message":"Patch Set 2:\n\nThomas, you need to explicitly have stdlib defined in modules metadata.json for it to import the functions that module provides. It\u0027s probably a bug in puppet-vswitch, that this patch fixes, but if you could test this change we\u0027d know for sure if it\u0027s that.","accounts_in_message":[],"_revision_number":2},{"id":"6f78b60f4d072daaa47b951ed37fd49c9289a743","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2021-05-31 14:34:21.000000000","message":"Patch Set 2:\n\nWe should prob backport this as well","accounts_in_message":[],"_revision_number":2},{"id":"246228f7f7e511e9634f721dd8c474336c6df4cf","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2021-05-31 14:34:42.000000000","message":"Patch Set 2:\n\nto where we started to depend on stdlib","accounts_in_message":[],"_revision_number":2},{"id":"5a9af01c98b0a4eae71da855dea5e9da1e46ac03","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-05-31 15:06:17.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"979e44bac64884002c5e0cd482b69fb163f9439c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2021-06-01 07:24:13.000000000","message":"Patch Set 3: Published edit on patch set 2.","accounts_in_message":[],"_revision_number":3},{"id":"d24906334e6e7c49014cd8c92fc3dad31c35cf9c","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2021-06-01 07:24:34.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"0e1b68837c161bc1036b4c0f347fb46b667fd385","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-01 07:37:08.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-puppet-tarball https://zuul.opendev.org/t/openstack/build/a49fd9114a484bdd8b63f9695703b2e9 : SUCCESS in 3m 20s\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/1b662394dbb54860832c3d5a6c2843ad : SUCCESS in 3m 57s","accounts_in_message":[],"_revision_number":3},{"id":"c2c7aac7bfba782e18f0102bdfac39d443fbb163","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-06-01 07:45:09.000000000","message":"Patch Set 3: Code-Review+2\n\nThe usage of validate_legacy was added by the following patch which was merged after Wallaby cutoff so I think we don\u0027t need any backport at this moment.\n\nhttps://review.opendev.org/c/openstack/puppet-vswitch/+/780194","accounts_in_message":[],"_revision_number":3},{"id":"f55f15918786c7c8584fd759e107a92e425050a8","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2021-06-02 15:53:59.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"51d98c87837e52ced23ddc569c83df48271dc6fb","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-02 15:54:17.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"a2878e2ed04adb636365a209398a9d0cb98f1c21","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-02 16:23:58.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-puppet-tarball https://zuul.opendev.org/t/openstack/build/ae70bac200a544689a2d3227d8abf1cc : SUCCESS in 3m 48s\n- puppet-openstack-lint-ubuntu-focal https://zuul.opendev.org/t/openstack/build/5e66ad0967314866a1dfa4983f4f4a85 : SUCCESS in 4m 27s","accounts_in_message":[],"_revision_number":3},{"id":"125277c4149e7166be06187ef8c4af5293bf19ad","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-02 16:24:00.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"06719f1ba9498dfbd29dabd9436263c05b02e1f5","revisions":{"cfe5350fdc8816e077187827a5a5fa3cff686df6":{"kind":"REWORK","_number":1,"created":"2021-05-31 13:50:44.000000000","uploader":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"ref":"refs/changes/98/793798/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-vswitch","ref":"refs/changes/98/793798/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-vswitch refs/changes/98/793798/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-vswitch refs/changes/98/793798/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-vswitch refs/changes/98/793798/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-vswitch refs/changes/98/793798/1"}}},"commit":{"parents":[{"commit":"f52b53006d5207f0bdec422e9b826f3da309fe53","subject":"Prepare Xena M1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-vswitch/commit/f52b53006d5207f0bdec422e9b826f3da309fe53"}]}],"author":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2021-05-31 13:50:33.000000000","tz":120},"committer":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2021-05-31 13:50:33.000000000","tz":120},"subject":"Add puppetlabs-stdlib to dependencies","message":"Add puppetlabs-stdlib to dependencies\n\nChange-Id: Ib7591e46058db67869d2b075ad069f1e98bc875d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-vswitch/commit/cfe5350fdc8816e077187827a5a5fa3cff686df6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-vswitch/commit/cfe5350fdc8816e077187827a5a5fa3cff686df6"}]},"branch":"refs/heads/master"},"a26e753890dda1de2a86da008c75ccb87a350ed3":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-05-31 13:51:59.000000000","uploader":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"ref":"refs/changes/98/793798/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-vswitch","ref":"refs/changes/98/793798/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-vswitch refs/changes/98/793798/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-vswitch refs/changes/98/793798/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-vswitch refs/changes/98/793798/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-vswitch refs/changes/98/793798/2"}}},"commit":{"parents":[{"commit":"f52b53006d5207f0bdec422e9b826f3da309fe53","subject":"Prepare Xena M1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-vswitch/commit/f52b53006d5207f0bdec422e9b826f3da309fe53"}]}],"author":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2021-05-31 13:50:33.000000000","tz":120},"committer":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2021-05-31 13:51:32.000000000","tz":120},"subject":"Add puppetlabs-stdlib to dependencies","message":"Add puppetlabs-stdlib to dependencies\n\nNeed this so that Puppet functions is imported\nfrom this module since we are using validate_legacy etc.\n\nChange-Id: Ib7591e46058db67869d2b075ad069f1e98bc875d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-vswitch/commit/a26e753890dda1de2a86da008c75ccb87a350ed3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-vswitch/commit/a26e753890dda1de2a86da008c75ccb87a350ed3"}]},"branch":"refs/heads/master"},"06719f1ba9498dfbd29dabd9436263c05b02e1f5":{"kind":"REWORK","_number":3,"created":"2021-06-01 07:24:13.000000000","uploader":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"ref":"refs/changes/98/793798/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-vswitch","ref":"refs/changes/98/793798/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-vswitch refs/changes/98/793798/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-vswitch refs/changes/98/793798/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-vswitch refs/changes/98/793798/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-vswitch refs/changes/98/793798/3"}}},"commit":{"parents":[{"commit":"f52b53006d5207f0bdec422e9b826f3da309fe53","subject":"Prepare Xena M1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-vswitch/commit/f52b53006d5207f0bdec422e9b826f3da309fe53"}]}],"author":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2021-05-31 13:50:33.000000000","tz":120},"committer":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2021-06-01 07:24:07.000000000","tz":0},"subject":"Add puppetlabs-stdlib to dependencies","message":"Add puppetlabs-stdlib to dependencies\n\nNeed this so that Puppet functions is imported\nfrom this module since we are using validate_legacy etc.\n\nChange-Id: Ib7591e46058db67869d2b075ad069f1e98bc875d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-vswitch/commit/06719f1ba9498dfbd29dabd9436263c05b02e1f5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-vswitch/commit/06719f1ba9498dfbd29dabd9436263c05b02e1f5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}