)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"b7b4fb3a297539caf96d10fe9a44c07b9ec645b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3e80dd73_2b69497c","updated":"2021-10-14 10:57:39.000000000","message":"How about adding a \"restart\" boolean parameter to vs_config and then autonotify service restart if it\u0027s set, seems like a better solution","commit_id":"13de192f306ba36bc21a225b164728dd79dfb24a"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"1dfb3d18f013d10412411037f221c516081f7779","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"94655622_14149aba","in_reply_to":"128cb996_7db543ed","updated":"2021-10-14 13:55:01.000000000","message":"It would still only restart it once after all vs_config resources is already done or am I missing something?","commit_id":"13de192f306ba36bc21a225b164728dd79dfb24a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1b253c2d99e6bcba87b3423be1b8f0086fa804b0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"128cb996_7db543ed","in_reply_to":"3e80dd73_2b69497c","updated":"2021-10-14 12:24:58.000000000","message":"That would make the logic in manifest simpler. However my concern is that it\u0027s not yet clear to me how we can prevent redundant restart if we have two parameters to trigger restart and the current implementation based on notification would be an easier solution.","commit_id":"13de192f306ba36bc21a225b164728dd79dfb24a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a90a7261f92e6766b513ca4e7dc19d8e3ae74f08","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8e9bdbd0_65a514a3","in_reply_to":"94655622_14149aba","updated":"2021-10-14 15:05:16.000000000","message":"I\u0027m afraid I misunderstood your comment and was thinking of implementing the logic to restart service in the provider.\nDoes the current version match with your expectation ?","commit_id":"13de192f306ba36bc21a225b164728dd79dfb24a"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"ce3061dcea51173f1a94c8be8f57f3c79337228a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9ee55048_139ba56a","updated":"2021-10-15 14:37:43.000000000","message":"I really like the idea, just a small typo.","commit_id":"62b1e043ed5a931ef367d16f1ae83efb6f3bad4b"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"714663e45d9cb2b0196c89c8821450ff427cac4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2137abd7_967c8277","updated":"2021-10-15 09:43:53.000000000","message":"Weird that Puppet doesn\u0027t support notify without it being circular, I would understand if it\u0027s a require.","commit_id":"62b1e043ed5a931ef367d16f1ae83efb6f3bad4b"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"d64b04a8bb5f279772539f4c96ba50a5f7db0df7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d7683bd9_fc2abac4","updated":"2021-10-15 07:41:15.000000000","message":"Yes, exactly like that :) But do we really need to use the Exec instead of just notifying the service?","commit_id":"62b1e043ed5a931ef367d16f1ae83efb6f3bad4b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8fe1162e8de14873e8aef0e4c32de4c5d365b708","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ca91c714_51163d63","in_reply_to":"d7683bd9_fc2abac4","updated":"2021-10-15 07:54:46.000000000","message":"Please check the parent patch and the bug[1] associated with it. (I\u0027ll squash this patch into the parent patch later)\n\n[1] https://bugs.launchpad.net/puppet-vswitch/+bug/1946985\n\nThe bug describes the circular dependency detected between vs_config and Service[\u0027openvswitch\u0027] and we avoid notification to Service[\u0027openvswitch\u0027] here.","commit_id":"62b1e043ed5a931ef367d16f1ae83efb6f3bad4b"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"7339298be5677c583549cd75321593b4ec38567f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"42ebdc09_85bf1cc3","updated":"2021-10-15 15:08:46.000000000","message":"Btw is vswitch::ovs and vswitch::dpdk mutually exclusive? Or should we ensure \"restart openvswitch\" exec does not cause a redeclaration issue?","commit_id":"e8e82e8eb27da7cb68aeff0f914fab0174ce4a24"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"c5c8982379e663cbeb5e0f59e2f525a0e2c7cf3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5c970481_c46a1a69","updated":"2021-10-15 14:40:45.000000000","message":"Fixed typo + rebased on master as my change is no longer relevant.","commit_id":"e8e82e8eb27da7cb68aeff0f914fab0174ce4a24"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8f4c5cecc2e241db2bd1f088e03624e36fa4bdcb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0ff23f98_e7e0ac19","in_reply_to":"42ebdc09_85bf1cc3","updated":"2021-10-17 23:40:52.000000000","message":"These two are mutually exclusive. The parameters managed by these two parameters are overlapping. In RHEL/CentOS these two classes install the same openvswtich package which results in duplicated declaration.","commit_id":"e8e82e8eb27da7cb68aeff0f914fab0174ce4a24"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e6a6d22888d3ce823e5fba21df75da0e49ba3988","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"280ce062_6c51236b","in_reply_to":"5c970481_c46a1a69","updated":"2021-10-17 23:46:52.000000000","message":"Thanks !","commit_id":"e8e82e8eb27da7cb68aeff0f914fab0174ce4a24"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2015786afde421d557476df7978c1ebf8b64cd24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"24ab9103_4532f9d3","updated":"2021-10-29 12:43:15.000000000","message":"recheck","commit_id":"1fe71cf5e359c8f83f11b2673620be822423bf47"}],"lib/puppet/type/vs_config.rb":[{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"ce3061dcea51173f1a94c8be8f57f3c79337228a","unresolved":true,"context_lines":[{"line_number":32,"context_line":"  end"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  newparam(:restart) do"},{"line_number":35,"context_line":"    desc \u0027Should the openvswithc service be restarted\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    newvalues(:true, :false)"},{"line_number":38,"context_line":"    defaultto :false"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"d6374c53_c30ee75b","line":35,"range":{"start_line":35,"start_character":21,"end_line":35,"end_character":32},"updated":"2021-10-15 14:37:43.000000000","message":"small typo here","commit_id":"62b1e043ed5a931ef367d16f1ae83efb6f3bad4b"}]}