)]}'
{"manifests/dpdk.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d60b77079d40718d7259ddbde5f0ca1178b1c817","unresolved":false,"context_lines":[{"line_number":178,"context_line":"  }"},{"line_number":179,"context_line":"  exec { \u0027restart openvswitch\u0027:"},{"line_number":180,"context_line":"    path        \u003d\u003e [\u0027/sbin\u0027, \u0027/usr/sbin\u0027, \u0027/bin\u0027, \u0027/usr/bin\u0027],"},{"line_number":181,"context_line":"    command     \u003d\u003e \"systemctl -q restart ${restart_command}.service\","},{"line_number":182,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":183,"context_line":"  }"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"db039dd7_6ceaa18f","line":181,"updated":"2022-01-12 15:44:17.000000000","message":"This doesn\u0027t make sense as currently written.  That being said, should we even update this? Do we support this module on anything that still uses upstart/init scripts?","commit_id":"b45a7590a2abf9ffd94ca540371e2ddb85d9a5b9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7abc3cd818252e3ae7beeee7e34886ca18086f68","unresolved":false,"context_lines":[{"line_number":178,"context_line":"  }"},{"line_number":179,"context_line":"  exec { \u0027restart openvswitch\u0027:"},{"line_number":180,"context_line":"    path        \u003d\u003e [\u0027/sbin\u0027, \u0027/usr/sbin\u0027, \u0027/bin\u0027, \u0027/usr/bin\u0027],"},{"line_number":181,"context_line":"    command     \u003d\u003e \"systemctl -q restart ${restart_command}.service\","},{"line_number":182,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":183,"context_line":"  }"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1bd23092_878b1ec6","line":181,"in_reply_to":"2c467d3c_91136600","updated":"2022-01-12 16:24:14.000000000","message":":facepalm: I\u0027ll add unit tests to assert this so that I won\u0027t break this in the future...","commit_id":"b45a7590a2abf9ffd94ca540371e2ddb85d9a5b9"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"bf68aafd8cef3d0ecfa4a466e87650bb972c222c","unresolved":false,"context_lines":[{"line_number":178,"context_line":"  }"},{"line_number":179,"context_line":"  exec { \u0027restart openvswitch\u0027:"},{"line_number":180,"context_line":"    path        \u003d\u003e [\u0027/sbin\u0027, \u0027/usr/sbin\u0027, \u0027/bin\u0027, \u0027/usr/bin\u0027],"},{"line_number":181,"context_line":"    command     \u003d\u003e \"systemctl -q restart ${restart_command}.service\","},{"line_number":182,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":183,"context_line":"  }"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"2c467d3c_91136600","line":181,"in_reply_to":"3a9a7cd9_1ba3f970","updated":"2022-01-12 16:00:28.000000000","message":"Ok. Btw as currently written the command here ends up being \"systemctl -q restart systemctl restart ${::vswitch::params::ovs_service_name}.service.service\". This should have been command \u003d\u003e $restart_command if we wanted this.","commit_id":"b45a7590a2abf9ffd94ca540371e2ddb85d9a5b9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5a2f0805d70ec81d3339108656d326c5038e6e6d","unresolved":false,"context_lines":[{"line_number":178,"context_line":"  }"},{"line_number":179,"context_line":"  exec { \u0027restart openvswitch\u0027:"},{"line_number":180,"context_line":"    path        \u003d\u003e [\u0027/sbin\u0027, \u0027/usr/sbin\u0027, \u0027/bin\u0027, \u0027/usr/bin\u0027],"},{"line_number":181,"context_line":"    command     \u003d\u003e \"systemctl -q restart ${restart_command}.service\","},{"line_number":182,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":183,"context_line":"  }"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a9a7cd9_1ba3f970","line":181,"in_reply_to":"db039dd7_6ceaa18f","updated":"2022-01-12 15:57:48.000000000","message":"I\u0027ve rechecked the current implementation of providers for the service resource but it seems systemd is the default for all OS version we currently support.\nI\u0027ll abandon this chanage and revisit it when we introduce a new version/distro which uses the different provider by default.","commit_id":"b45a7590a2abf9ffd94ca540371e2ddb85d9a5b9"}]}